62324 2011-06-08 14:17:10 -0700 [Chromium] Crash when closing a tab with accelerated 2d canvas 2011-06-08 23:42:37 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Blocker --- 1 junov junov bsalomon dglazkov jamesr mdelaney7 senorblanco vangelis webkit.review.bot oldest_to_newest 417517 0 junov 2011-06-08 14:17:10 -0700 This is in reference to chromium bug 85309 Repro steps posted here: http://code.google.com/p/chromium/issues/detail?id=85309 This is a Chrome release blocker 417594 1 96493 junov 2011-06-08 15:23:30 -0700 Created attachment 96493 Patch 417600 2 junov 2011-06-08 15:26:50 -0700 No need to worry about cr-* test builds that will fail. This patch depends on a skia change that has not yet rolled in. Dependent change is pending review here: http://codereview.appspot.com/4584048/ 417606 3 senorblanco 2011-06-08 15:29:48 -0700 This looks ok to me, but jamesr and brian should take a look. 417607 4 96493 jamesr 2011-06-08 15:30:39 -0700 Comment on attachment 96493 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96493&action=review You need to explain what's going on here, preferably in the ChangeLog. > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) This will fail an svn presubmit 417628 5 96497 junov 2011-06-08 15:49:48 -0700 Created attachment 96497 Patch 417636 6 96497 bsalomon 2011-06-08 15:52:10 -0700 Comment on attachment 96497 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96497&action=review > Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp:126 > + GrSafeUnref(m_grContext); Minor: GrSafeUnref is now redundant, can be m_grContext->unref(); 417637 7 96497 jamesr 2011-06-08 15:52:23 -0700 Comment on attachment 96497 Patch Are the two fixes for the same thing or not? 417640 8 96497 webkit.review.bot 2011-06-08 15:54:05 -0700 Comment on attachment 96497 Patch Attachment 96497 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8776842 417646 9 junov 2011-06-08 15:57:37 -0700 (In reply to comment #7) > (From update of attachment 96497 [details]) > Are the two fixes for the same thing or not? It fixes the same test case. The callback was the first thing to crash. When I fixed that, there was another crash waiting behind it. 417652 10 junov 2011-06-08 16:00:44 -0700 The skia change that fixes the build failure reported by the review bot is now in ToT skia: http://code.google.com/p/skia/source/detail?r=1551 417657 11 jamesr 2011-06-08 16:07:32 -0700 You need to update the skia rev in Source/WebKit/chromium/DEPS before landing this. You also need to be sure the DEPS file in chromium trunk is updated before landing this. Ping this bug again for review after you've done those two. This can't land before then. 417661 12 96497 jamesr 2011-06-08 16:13:23 -0700 Comment on attachment 96497 Patch R- until DEPS rolls, please flip back to review? once they've rolled in. 417738 13 vangelis 2011-06-08 18:25:15 -0700 (In reply to comment #12) > (From update of attachment 96497 [details]) > R- until DEPS rolls, please flip back to review? once they've rolled in. James, can you r+ this and I'll cq+ once the skia deps roll lands? 417760 14 jamesr 2011-06-08 19:36:12 -0700 Sure, update the bug when the rolls land. Where are the bugs/codereviews/whatever for the rolls? 417800 15 vangelis 2011-06-08 21:41:13 -0700 (In reply to comment #14) > Sure, update the bug when the rolls land. Where are the bugs/codereviews/whatever for the rolls? Skia rolled past 1551 which is what was needed for this CL to land http://src.chromium.org/viewvc/chrome?view=rev&revision=88481 417802 16 jamesr 2011-06-08 21:43:36 -0700 It has to roll here as well or this will break bots: http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/DEPS should just need to increment chromium_rev to 88481 and make sure that already builds. I'll start the process for that if nobody else has started it yet. 417808 17 jamesr 2011-06-08 21:47:26 -0700 Rev at https://bugs.webkit.org/show_bug.cgi?id=62353, seeing how the EWS bots like it. 417827 18 jamesr 2011-06-08 22:25:18 -0700 Roll going through EWS here: https://bugs.webkit.org/show_bug.cgi?id=62353 417838 19 96497 jamesr 2011-06-08 22:53:23 -0700 Comment on attachment 96497 Patch OK, Source/WebKit/chromium/DEPS roll landed (hope it sticks) 417858 20 96497 webkit.review.bot 2011-06-08 23:40:55 -0700 Comment on attachment 96497 Patch Clearing flags on attachment: 96497 Committed r88429: <http://trac.webkit.org/changeset/88429> 417859 21 webkit.review.bot 2011-06-08 23:41:01 -0700 All reviewed patches have been landed. Closing bug. 417861 22 jamesr 2011-06-08 23:42:37 -0700 drovering... 96493 2011-06-08 15:23:30 -0700 2011-06-08 15:49:43 -0700 Patch bug-62324-20110608182329.patch text/plain 2704 junov SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4Mzk1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMDggIEp1c3RpbiBO b3Zvc2FkICA8anVub3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gQ3Jhc2ggd2hlbiBjbG9zaW5nIGEgdGFi IHdpdGggYWNjZWxlcmF0ZWQgMmQgY2FudmFzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02MjMyNAorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMh KQorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1NoYXJlZEdyYXBoaWNzQ29udGV4 dDNELmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNoYXJlZEdyYXBoaWNzQ29udGV4dDNEOjp+U2hh cmVkR3JhcGhpY3NDb250ZXh0M0QpOgorCiAyMDExLTA2LTA2ICBOYXRlIENoYXBpbiAgPGphcGhl dEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9TaGFyZWRHcmFwaGljc0NvbnRl eHQzRC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3B1L1NoYXJlZEdyYXBoaWNzQ29udGV4dDNELmNwcAkocmV2aXNpb24gODgzOTQpCisrKyBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvU2hhcmVkR3JhcGhpY3NDb250ZXh0M0Qu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjEsNyArMTIxLDEwIEBAIFNoYXJlZEdyYXBoaWNzQ29u dGV4dDNEOjp+U2hhcmVkR3JhcGhpY3MKICAgICBtX2NvbnRleHQtPmRlbGV0ZUJ1ZmZlcihtX3F1 YWRWZXJ0aWNlcyk7CiAgICAgYWxsQ29udGV4dHMoKS0+cmVtb3ZlKHRoaXMpOwogI2lmIFVTRShT S0lBKQotICAgIEdyU2FmZVVucmVmKG1fZ3JDb250ZXh0KTsKKyAgICBpZiAobV9nckNvbnRleHQp IHsKKyAgICAgICAgbV9nckNvbnRleHQtPmNvbnRleHREZXN0cm95ZWQoKTsKKyAgICAgICAgR3JT YWZlVW5yZWYobV9nckNvbnRleHQpOworICAgIH0KICNlbmRpZgogfQogCkluZGV4OiBTb3VyY2Uv V2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gODgzOTUpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9t aXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDExLTA2LTA4 ICBKdXN0aW4gTm92b3NhZCAgPGp1bm92QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbQ2hyb21pdW1dIENyYXNoIHdoZW4gY2xv c2luZyBhIHRhYiB3aXRoIGFjY2VsZXJhdGVkIDJkIGNhbnZhcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjIzMjQKKworICAgICAgICAqIHNyYy9HcmFw aGljc0NvbnRleHQzRENocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29u dGV4dExvc3RDYWxsYmFja0FkYXB0ZXI6OmNyZWF0ZSk6CisKIDIwMTEtMDYtMDggIFRvbSBTZXBl eiAgPHRzZXBlekBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0 aC4KSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0dyYXBoaWNzQ29udGV4dDNEQ2hy b21pdW0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0dyYXBo aWNzQ29udGV4dDNEQ2hyb21pdW0uY3BwCShyZXZpc2lvbiA4ODM5NCkKKysrIFNvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL0dyYXBoaWNzQ29udGV4dDNEQ2hyb21pdW0uY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xMTc0LDcgKzExNzQsNyBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dExvc3RDYWxsYmFj a0FkYXB0ZXI6CiAKIFBhc3NPd25QdHI8R3JhcGhpY3NDb250ZXh0TG9zdENhbGxiYWNrQWRhcHRl cj4gR3JhcGhpY3NDb250ZXh0TG9zdENhbGxiYWNrQWRhcHRlcjo6Y3JlYXRlKFBhc3NPd25QdHI8 R3JhcGhpY3NDb250ZXh0M0Q6OkNvbnRleHRMb3N0Q2FsbGJhY2s+IGNiKQogewotICAgIHJldHVy biBhZG9wdFB0cihuZXcgR3JhcGhpY3NDb250ZXh0TG9zdENhbGxiYWNrQWRhcHRlcihjYikpOwor ICAgIHJldHVybiBhZG9wdFB0cihjYi5nZXQoKSA/IG5ldyBHcmFwaGljc0NvbnRleHRMb3N0Q2Fs bGJhY2tBZGFwdGVyKGNiKSA6IDApOwogfQogCiB2b2lkIEdyYXBoaWNzQ29udGV4dDNESW50ZXJu YWw6OnNldENvbnRleHRMb3N0Q2FsbGJhY2soUGFzc093blB0cjxHcmFwaGljc0NvbnRleHQzRDo6 Q29udGV4dExvc3RDYWxsYmFjaz4gY2IpCg== 96497 2011-06-08 15:49:48 -0700 2011-06-08 23:40:55 -0700 Patch bug-62324-20110608184947.patch text/plain 3428 junov SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4Mzk1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDYtMDggIEp1c3RpbiBO b3Zvc2FkICA8anVub3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gQ3Jhc2ggd2hlbiBjbG9zaW5nIGEgdGFi IHdpdGggYWNjZWxlcmF0ZWQgMmQgY2FudmFzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02MjMyNAorICAgICAgICBVcG9uIGdyYXBoaWNzIGNvbnRleHQg ZGVzdHJ1Y3Rpb24sIGl0IGlzIGltcG9ydGFudCB0byBzaWduYWwgc2tpYQorICAgICAgICB0byBh YmFuZG9uIGFsbCBvZiBpdHMgcmVzb3VyY2UgaGFuZGxlcy4gIFRoaXMgcHJldmVudHMgYSBjcmFz aCBjYXVzZWQKKyAgICAgICAgYnkgc2tpYSBhdHRlbXB0aW5nIHRvIHJlbGVhc2UgcmVzb3VyY2Vz IHRoYXQgd2VyZSBpbiB0aGUgZGVzdHJveWVkCisgICAgICAgIGdyYXBoaWNzIGNvbnRleHQuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ncHUvU2hhcmVkR3JhcGhpY3NDb250ZXh0M0Qu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6U2hhcmVkR3JhcGhpY3NDb250ZXh0M0Q6On5TaGFyZWRH cmFwaGljc0NvbnRleHQzRCk6CisKIDIwMTEtMDYtMDYgIE5hdGUgQ2hhcGluICA8amFwaGV0QGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1NoYXJlZEdyYXBoaWNzQ29udGV4dDNE LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUv U2hhcmVkR3JhcGhpY3NDb250ZXh0M0QuY3BwCShyZXZpc2lvbiA4ODM5NCkKKysrIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9TaGFyZWRHcmFwaGljc0NvbnRleHQzRC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTEyMSw3ICsxMjEsMTAgQEAgU2hhcmVkR3JhcGhpY3NDb250ZXh0 M0Q6On5TaGFyZWRHcmFwaGljcwogICAgIG1fY29udGV4dC0+ZGVsZXRlQnVmZmVyKG1fcXVhZFZl cnRpY2VzKTsKICAgICBhbGxDb250ZXh0cygpLT5yZW1vdmUodGhpcyk7CiAjaWYgVVNFKFNLSUEp Ci0gICAgR3JTYWZlVW5yZWYobV9nckNvbnRleHQpOworICAgIGlmIChtX2dyQ29udGV4dCkgewor ICAgICAgICBtX2dyQ29udGV4dC0+Y29udGV4dERlc3Ryb3llZCgpOworICAgICAgICBHclNhZmVV bnJlZihtX2dyQ29udGV4dCk7CisgICAgfQogI2VuZGlmCiB9CiAKSW5kZXg6IFNvdXJjZS9XZWJL aXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21p dW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA4ODM5NSkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDYtMDggIEp1 c3RpbiBOb3Zvc2FkICA8anVub3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gQ3Jhc2ggd2hlbiBjbG9zaW5n IGEgdGFiIHdpdGggYWNjZWxlcmF0ZWQgMmQgY2FudmFzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MjMyNAorICAgICAgICBJbiBHcmFwaGljc0NvbnRl eHQzREludGVybmFsOjpzZXRDb250ZXh0TG9zdENhbGxiYWNrIHdlIGFyZSBwYXNzaW5nIGEKKyAg ICAgICAgbm9uLXJlZmNvdW50ZWQgcHRyIHRvIGEgcmVmY291bnRlZCBtZW1iZXIuIHRoaXMgY2Fu IGNhdXNlIGFuIGFjY2VzcworICAgICAgICB2aW9sYXRpb24gYWZ0ZXIgdGhlIGRlc3RydWN0aW9u IG9mIEdyYXBoaWNzQ29udGV4dDNELiAgVXBvbiBkZXN0cnVjdGlvbgorICAgICAgICBhIG51bGwg Y2FsbGJhY2sgaXMgc2VudCB0byBzZXRDb250ZXh0TG9zdENhbGxiYWNrLCB3aGljaCBpcyBnb29k CisgICAgICAgIGV4Y2VwdCB0aGF0IGl0IGdldHMgcGxhY2VkIGluIGEgbm9uLW51bGwgYWRhcHRl ciBvYmplY3QuICBUaGlzIGZpeAorICAgICAgICBwcmV2ZW50cyB0aGUgY3JlYXRpb24gb2YgdGhl IGFkYXB0ZXIgd2hlbiB0aGUgY2FsbGJhY2sgaXMgbnVsbCwgdGh1cworICAgICAgICBwcmV2ZW50 aW5nIGEgbGF0ZXIgY3Jhc2guCisKKyAgICAgICAgKiBzcmMvR3JhcGhpY3NDb250ZXh0M0RDaHJv bWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHRMb3N0Q2FsbGJhY2tB ZGFwdGVyOjpjcmVhdGUpOgorCiAyMDExLTA2LTA4ICBUb20gU2VwZXogIDx0c2VwZXpAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBTb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9HcmFwaGljc0NvbnRleHQzRENocm9taXVtLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9HcmFwaGljc0NvbnRleHQzRENocm9t aXVtLmNwcAkocmV2aXNpb24gODgzOTQpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9H cmFwaGljc0NvbnRleHQzRENocm9taXVtLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTE3NCw3ICsx MTc0LDcgQEAgdm9pZCBHcmFwaGljc0NvbnRleHRMb3N0Q2FsbGJhY2tBZGFwdGVyOgogCiBQYXNz T3duUHRyPEdyYXBoaWNzQ29udGV4dExvc3RDYWxsYmFja0FkYXB0ZXI+IEdyYXBoaWNzQ29udGV4 dExvc3RDYWxsYmFja0FkYXB0ZXI6OmNyZWF0ZShQYXNzT3duUHRyPEdyYXBoaWNzQ29udGV4dDNE OjpDb250ZXh0TG9zdENhbGxiYWNrPiBjYikKIHsKLSAgICByZXR1cm4gYWRvcHRQdHIobmV3IEdy YXBoaWNzQ29udGV4dExvc3RDYWxsYmFja0FkYXB0ZXIoY2IpKTsKKyAgICByZXR1cm4gYWRvcHRQ dHIoY2IuZ2V0KCkgPyBuZXcgR3JhcGhpY3NDb250ZXh0TG9zdENhbGxiYWNrQWRhcHRlcihjYikg OiAwKTsKIH0KIAogdm9pZCBHcmFwaGljc0NvbnRleHQzREludGVybmFsOjpzZXRDb250ZXh0TG9z dENhbGxiYWNrKFBhc3NPd25QdHI8R3JhcGhpY3NDb250ZXh0M0Q6OkNvbnRleHRMb3N0Q2FsbGJh Y2s+IGNiKQo=