62319 2011-06-08 14:04:42 -0700 [Skia] check for null-shader from gradient factory 2011-06-08 14:39:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 reed reed jamesr vangelis oldest_to_newest 417492 0 reed 2011-06-08 14:04:42 -0700 [Skia] check for null-shader from gradient factory 417520 1 96479 reed 2011-06-08 14:17:48 -0700 Created attachment 96479 Patch 417524 2 reed 2011-06-08 14:19:33 -0700 abandoned 62279, as it was from my mac, and I couldn't get the run_webkit_tests.sh to run there (operator error I'm sure) 417528 3 reed 2011-06-08 14:21:59 -0700 *** Bug 62279 has been marked as a duplicate of this bug. *** 417537 4 96479 jamesr 2011-06-08 14:28:15 -0700 Comment on attachment 96479 Patch Looks good. Want me to land this by hand? 417539 5 reed 2011-06-08 14:31:10 -0700 that would be great. We should then send the rev. # to vangelis for cherry-picking for M13 417548 6 96479 jamesr 2011-06-08 14:39:56 -0700 Comment on attachment 96479 Patch Clearing flags on attachment: 96479 Committed r88390: <http://trac.webkit.org/changeset/88390> 417549 7 jamesr 2011-06-08 14:39:59 -0700 All reviewed patches have been landed. Closing bug. 96479 2011-06-08 14:17:48 -0700 2011-06-08 14:39:56 -0700 Patch bug-62319-20110608171746.patch text/plain 4383 reed SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4Mzg0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDYtMDggIE1pa2UgUmVl ZCAgPHJlZWRAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBbU2tpYV0gY2hlY2sgZm9yIG51bGwtc2hhZGVyIGZyb20gZ3JhZGllbnQg ZmFjdG9yeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NjIzMTkKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhZGllbnRTa2lhLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYWRpZW50OjpwbGF0Zm9ybURlc3Ryb3kpOgorICAgICAg ICAoV2ViQ29yZTo6R3JhZGllbnQ6OnBsYXRmb3JtR3JhZGllbnQpOgorCiAyMDExLTA2LTA4ICBK YW1lcyBTaW1vbnNlbiAgPHNpbW9uamFtQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBUb255IEdlbnRpbGNvcmUuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9za2lhL0dyYWRpZW50U2tpYS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFkaWVudFNraWEuY3BwCShyZXZpc2lvbiA4ODM0NSkK KysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhZGllbnRTa2lhLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMzQsNiArMzQsNyBAQAogI2luY2x1ZGUgIkNTU1BhcnNlci5o IgogI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dC5oIgogCisjaW5jbHVkZSAiU2tDb2xvclNoYWRl ci5oIgogI2luY2x1ZGUgIlNrR3JhZGllbnRTaGFkZXIuaCIKICNpbmNsdWRlICJTa2lhVXRpbHMu aCIKIApAQCAtNDEsOCArNDIsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIHZvaWQgR3JhZGll bnQ6OnBsYXRmb3JtRGVzdHJveSgpCiB7Ci0gICAgaWYgKG1fZ3JhZGllbnQpCi0gICAgICAgIFNr U2FmZVVucmVmKG1fZ3JhZGllbnQpOworICAgIFNrU2FmZVVucmVmKG1fZ3JhZGllbnQpOwogICAg IG1fZ3JhZGllbnQgPSAwOwogfQogCkBAIC0xNDYsMTEgKzE0Niw3IEBAIFNrU2hhZGVyKiBHcmFk aWVudDo6cGxhdGZvcm1HcmFkaWVudCgpCiAgICAgICAgIC8vIFNpbmNlIHRoZSB0d28tcG9pbnQg cmFkaWFsIGdyYWRpZW50IGlzIHNsb3dlciB0aGFuIHRoZSBwbGFpbiByYWRpYWwsCiAgICAgICAg IC8vIG9ubHkgdXNlIGl0IGlmIHdlIGhhdmUgdG8uCiAgICAgICAgIGlmIChtX3AwID09IG1fcDEg JiYgbV9yMCA8PSAwLjBmKSB7Ci0gICAgICAgICAgICAvLyBUaGUgcmFkaXVzIHdlIGdpdmUgdG8g U2tpYSBtdXN0IGJlIHBvc2l0aXZlIChhbmQgbm9uLXplcm8pLiAgSWYKLSAgICAgICAgICAgIC8v IHdlJ3JlIGdpdmVuIGEgemVybyByYWRpdXMsIGp1c3QgYXNrIGZvciBhIHZlcnkgc21hbGwgcmFk aXVzIHNvCi0gICAgICAgICAgICAvLyBTa2lhIHdpbGwgc3RpbGwgcmV0dXJuIGFuIG9iamVjdC4K LSAgICAgICAgICAgIFNrU2NhbGFyIHJhZGl1cyA9IG1fcjEgPiAwID8gV2ViQ29yZUZsb2F0VG9T a1NjYWxhcihtX3IxKSA6IFNLX1NjYWxhck1pbjsKLSAgICAgICAgICAgIG1fZ3JhZGllbnQgPSBT a0dyYWRpZW50U2hhZGVyOjpDcmVhdGVSYWRpYWwobV9wMSwgcmFkaXVzLCBjb2xvcnMsIHBvcywg c3RhdGljX2Nhc3Q8aW50Pihjb3VudFVzZWQpLCB0aWxlKTsKKyAgICAgICAgICAgIG1fZ3JhZGll bnQgPSBTa0dyYWRpZW50U2hhZGVyOjpDcmVhdGVSYWRpYWwobV9wMSwgbV9yMSwgY29sb3JzLCBw b3MsIHN0YXRpY19jYXN0PGludD4oY291bnRVc2VkKSwgdGlsZSk7CiAgICAgICAgIH0gZWxzZSB7 CiAgICAgICAgICAgICAvLyBUaGUgcmFkaWkgd2UgZ2l2ZSB0byBTa2lhIG11c3QgYmUgcG9zaXRp dmUuICBJZiB3ZSdyZSBnaXZlbiBhIAogICAgICAgICAgICAgLy8gbmVnYXRpdmUgcmFkaXVzLCBh c2sgZm9yIHplcm8gaW5zdGVhZC4KQEAgLTE3Miw5ICsxNjgsMTEgQEAgU2tTaGFkZXIqIEdyYWRp ZW50OjpwbGF0Zm9ybUdyYWRpZW50KCkKICAgICAgICAgbV9ncmFkaWVudCA9IFNrR3JhZGllbnRT aGFkZXI6OkNyZWF0ZUxpbmVhcihwdHMsIGNvbG9ycywgcG9zLCBzdGF0aWNfY2FzdDxpbnQ+KGNv dW50VXNlZCksIHRpbGUpOwogICAgIH0KIAotICAgIEFTU0VSVChtX2dyYWRpZW50KTsKLSAgICBT a01hdHJpeCBtYXRyaXggPSBtX2dyYWRpZW50U3BhY2VUcmFuc2Zvcm1hdGlvbjsKLSAgICBtX2dy YWRpZW50LT5zZXRMb2NhbE1hdHJpeChtYXRyaXgpOworICAgIGlmICghbV9ncmFkaWVudCkKKyAg ICAgICAgLy8gdXNlIGxhc3QgY29sb3IsIHNpbmNlIG91ciAiZ2VvbWV0cnkiIHdhcyBkZWdlbmVy YXRlIChlLmcuIHJhZGl1cz09MCkKKyAgICAgICAgbV9ncmFkaWVudCA9IG5ldyBTa0NvbG9yU2hh ZGVyKGNvbG9yc1tjb3VudFVzZWQgLSAxXSk7CisgICAgZWxzZQorICAgICAgICBtX2dyYWRpZW50 LT5zZXRMb2NhbE1hdHJpeChtX2dyYWRpZW50U3BhY2VUcmFuc2Zvcm1hdGlvbik7CiAgICAgcmV0 dXJuIG1fZ3JhZGllbnQ7CiB9CiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4Mzg0KQorKysgTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDYt MDggIE1pa2UgUmVlZCAgPHJlZWRAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbU2tpYV0gY2hlY2sgZm9yIG51bGwtc2hhZGVyIGZy b20gZ3JhZGllbnQgZmFjdG9yeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NjIzMTkKKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtLWxpbnV4L2Zh c3QvZ3JhZGllbnRzL2NyYXNoLW9uLWRlZ2VuZXJhdGUtZ3JhZGllbnQtZXhwZWN0ZWQudHh0OiBB ZGRlZC4KKwogMjAxMS0wNi0wOCAgTWFyayBQaWxncmltICA8cGlsZ3JpbUBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVG9ueSBDaGFuZy4KSW5kZXg6IExheW91dFRlc3RzL2Zh c3QvZ3JhZGllbnRzL2NyYXNoLW9uLWRlZ2VuZXJhdGUtZ3JhZGllbnQuaHRtbAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2dyYWRpZW50cy9jcmFzaC1vbi1kZWdlbmVyYXRlLWdyYWRp ZW50Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2dyYWRpZW50cy9jcmFz aC1vbi1kZWdlbmVyYXRlLWdyYWRpZW50Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTEg QEAKKzxoZWFkPgorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisg IHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cis8L3NjcmlwdD4KKzwv aGVhZD4KKzxib2R5PgorPGgxPkRlZ2VuZXJhdGUgTGluZWFyIGdyYWRpZW50LiBTaG91bGQgbm90 IGNyYXNoPC9oMT4KKzxidXR0b24gc3R5bGU9ImJhY2tncm91bmQtaW1hZ2U6IC13ZWJraXQtcmFk aWFsLWdyYWRpZW50KDEgMSwgU2Nyb2xsYmFyIC0xLCByZWQgLTEpIj4KKzwvYm9keT4KKwpJbmRl eDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0tbGludXgvZmFzdC9ncmFkaWVudHMvY3Jh c2gtb24tZGVnZW5lcmF0ZS1ncmFkaWVudC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0tbGludXgvZmFzdC9ncmFkaWVudHMvY3Jhc2gtb24t ZGVnZW5lcmF0ZS1ncmFkaWVudC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRU ZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS1saW51eC9mYXN0L2dyYWRpZW50cy9jcmFzaC1vbi1kZWdl bmVyYXRlLWdyYWRpZW50LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzIEBA CitEZWdlbmVyYXRlIExpbmVhciBncmFkaWVudC4gU2hvdWxkIG5vdCBjcmFzaAorCisK