62307 2011-06-08 12:40:50 -0700 Fix clang issue, virtual function const mismatch 2011-06-09 14:28:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simonjam simonjam abarth dglazkov jamesr tonyg oldest_to_newest 417418 0 simonjam 2011-06-08 12:40:50 -0700 Fix clang issue, virtual function const mismatch 417423 1 96463 simonjam 2011-06-08 12:47:48 -0700 Created attachment 96463 Patch 417476 2 simonjam 2011-06-08 13:44:01 -0700 Committed r88382: <http://trac.webkit.org/changeset/88382> 417620 3 96463 darin 2011-06-08 15:43:56 -0700 Comment on attachment 96463 Patch This almost certainly had some real symptom too. When possible we try to make a test case to show what was broken. 418241 4 simonjam 2011-06-09 13:41:31 -0700 (In reply to comment #3) > (From update of attachment 96463 [details]) > This almost certainly had some real symptom too. When possible we try to make a test case to show what was broken. Fortunately, the code was only broken in the tree for several hours. Chromium runs clang on all WebKit rolls and those happen a few times a day. I expect that we'll catch these sorts of bugs pretty quickly. I hope someone is working on a Clang EWS bot. That would be even quicker at detecting these sorts of problems. 418295 5 abarth 2011-06-09 14:23:26 -0700 > I hope someone is working on a Clang EWS bot. That would be even quicker at detecting these sorts of problems. Great idea. I'll talk to Nico about that. 418303 6 abarth 2011-06-09 14:28:48 -0700 The instructions are here. We'll need to adapt them a bit to work for WebKit: http://code.google.com/p/chromium/wiki/Clang This isn't high on my priority list, but it definitely sounds like something we should do. 96463 2011-06-08 12:47:48 -0700 2011-06-08 15:43:56 -0700 Patch bug-62307-20110608124747.patch text/plain 1511 simonjam U3VidmVyc2lvbiBSZXZpc2lvbjogODgzNjkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjYzJhMTI5NDJhMjg1ODhl ZmZlMWJmNGNmN2NjNTNlMmM1NTcxMDUwLi4zNTA5MjRiZmM4MTllMjg0MTAzM2RlMzU3MzNkNzFl YjY5MjhiNGM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMDggIEphbWVz IFNpbW9uc2VuICA8c2ltb25qYW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBjbGFuZyBpc3N1ZSwgdmlydHVhbCBmdW5j dGlvbiBjb25zdCBtaXNtYXRjaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NjIzMDcKKworICAgICAgICBObyBuZXcgdGVzdHMuIEJ1aWx0IHdpdGggY2xh bmcgJiByYW4gbGF5b3V0IHRlc3RzLgorCisgICAgICAgICogcGFnZS9NZWRpYVN0cmVhbUZyYW1l Q29udHJvbGxlci5oOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFTdHJlYW1GcmFtZUNvbnRyb2xs ZXI6OkdlbmVyaWNDbGllbnQ6OmlzR2VuZXJpY0NsaWVudCk6CisKIDIwMTEtMDYtMDggIFNoZXJp ZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQsIHJvbGxpbmcgb3V0IHI4ODM2NS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv TWVkaWFTdHJlYW1GcmFtZUNvbnRyb2xsZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvTWVkaWFT dHJlYW1GcmFtZUNvbnRyb2xsZXIuaAppbmRleCA0YzBiNTg2MGIzMGI2MTcyNTc3NDg2YjgzYTU3 MzI4ZmQ4YTVmYjJmLi42ZjYzYTE0ZTcwMjVhMzJmYjU0MjhhN2I5NGQ3YmI1YzMwMGJiNDFjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL01lZGlhU3RyZWFtRnJhbWVDb250cm9sbGVy LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9NZWRpYVN0cmVhbUZyYW1lQ29udHJvbGxlci5o CkBAIC0xMzIsNyArMTMyLDcgQEAgcHVibGljOgogICAgICAgICBHZW5lcmljQ2xpZW50KCkgeyB9 CiAgICAgICAgIEdlbmVyaWNDbGllbnQoTWVkaWFTdHJlYW1GcmFtZUNvbnRyb2xsZXIqIGZyYW1l Q29udHJvbGxlciwgaW50IGlkKSA6IENsaWVudEJhc2U8aW50PihmcmFtZUNvbnRyb2xsZXIsIGlk KSB7IH0KICAgICAgICAgdmlydHVhbCB+R2VuZXJpY0NsaWVudCgpIHsgdW5yZWdpc3RlcigpOyB9 Ci0gICAgICAgIHZpcnR1YWwgYm9vbCBpc0dlbmVyaWNDbGllbnQoKSB7IHJldHVybiB0cnVlOyB9 CisgICAgICAgIHZpcnR1YWwgYm9vbCBpc0dlbmVyaWNDbGllbnQoKSBjb25zdCB7IHJldHVybiB0 cnVlOyB9CiAKICAgICBwcml2YXRlOgogICAgICAgICB2aXJ0dWFsIHZvaWQgdW5yZWdpc3Rlcigp IHsgdW5yZWdpc3RlckNsaWVudCh0aGlzKTsgfQo=