62300 2011-06-08 11:24:50 -0700 IndexedDB test: key sort order for Date objects 2011-06-08 15:08:12 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 pilgrim webkit-unassigned dgrogan hans tony webkit.review.bot oldest_to_newest 417367 0 pilgrim 2011-06-08 11:24:50 -0700 http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#key-construct states "Values of type Date are compared to other Date values chronologically." This test creates an objectstore and fills it with Date keys in non-chronological order, then opens and iterates a cursor to verify that the keys appear in chronological order. WebKit passes this test. 417368 1 96443 pilgrim 2011-06-08 11:25:52 -0700 Created attachment 96443 Patch 417434 2 96443 dgrogan 2011-06-08 12:56:24 -0700 Comment on attachment 96443 Patch LGTM 417466 3 96443 dgrogan 2011-06-08 13:31:11 -0700 Comment on attachment 96443 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96443&action=review LGTM > LayoutTests/storage/indexeddb/key-sort-order-date.html:89 > + shouldBe("cursor.key.toString()", "sortedKeys[keyIndex]"); So the problem with dates is that shouldBe will try to compare Date objects using == ? If so you might be able to use shouldEvaluateTo: shouldEvaluateTo("cursor.key", sortedKeys[keyIndex]) if sortedKeys[keyIndex] holds a date.toString(), the == might call the Date object's toString method before comparing. It's no big deal, the test is fine as is. Only do this if you want to play around with javascript. 417514 4 96443 tony 2011-06-08 14:16:06 -0700 Comment on attachment 96443 Patch Mark, if you want to land this patch as-is, please set cq?. Otherwise, just upload a new patch. 417582 5 96443 webkit.review.bot 2011-06-08 15:08:08 -0700 Comment on attachment 96443 Patch Clearing flags on attachment: 96443 Committed r88395: <http://trac.webkit.org/changeset/88395> 417583 6 webkit.review.bot 2011-06-08 15:08:12 -0700 All reviewed patches have been landed. Closing bug. 96443 2011-06-08 11:25:52 -0700 2011-06-08 15:08:08 -0700 Patch bug-62300-20110608142604.patch text/plain 6171 pilgrim SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDg4MzY1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDYtMDggIE1hcmsgUGlsZ3JpbSAgPHBp bGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEluZGV4ZWREQiB0ZXN0OiBrZXkgc29ydCBvcmRlciBmb3IgRGF0ZSBvYmpl Y3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MjMw MAorCisgICAgICAgICogc3RvcmFnZS9pbmRleGVkZGIva2V5LXNvcnQtb3JkZXItZGF0ZS1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHN0b3JhZ2UvaW5kZXhlZGRiL2tleS1zb3J0LW9y ZGVyLWRhdGUuaHRtbDogQWRkZWQuCisKIDIwMTEtMDYtMDggIE1hcmsgUGlsZ3JpbSAgPHBpbGdy aW1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvbnkgQ2hhbmcuCkluZGV4 OiBMYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9rZXktc29ydC1vcmRlci1kYXRlLWV4cGVj dGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9rZXkt c29ydC1vcmRlci1kYXRlLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3Rz L3N0b3JhZ2UvaW5kZXhlZGRiL2tleS1zb3J0LW9yZGVyLWRhdGUtZXhwZWN0ZWQudHh0CShyZXZp c2lvbiAwKQpAQCAtMCwwICsxLDQ5IEBACitUZXN0IEluZGV4ZWREQiBrZXkgY29tcGFyaXNvbgor CitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBm b2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworaW5kZXhlZERCID0gd2luZG93LmluZGV4 ZWREQiB8fCB3aW5kb3cud2Via2l0SW5kZXhlZERCIHx8IHdpbmRvdy5tb3pJbmRleGVkREI7CitQ QVNTIGluZGV4ZWREQiA9PSBudWxsIGlzIGZhbHNlCitJREJEYXRhYmFzZUV4Y2VwdGlvbiA9IHdp bmRvdy5JREJEYXRhYmFzZUV4Y2VwdGlvbiB8fCB3aW5kb3cud2Via2l0SURCRGF0YWJhc2VFeGNl cHRpb247CitQQVNTIElEQkRhdGFiYXNlRXhjZXB0aW9uID09IG51bGwgaXMgZmFsc2UKK0lEQkN1 cnNvciA9IHdpbmRvdy5JREJDdXJzb3IgfHwgd2luZG93LndlYmtpdElEQkN1cnNvcjsKK1BBU1Mg SURCQ3Vyc29yID09IG51bGwgaXMgZmFsc2UKK0lEQktleVJhbmdlID0gd2luZG93LklEQktleVJh bmdlIHx8IHdpbmRvdy53ZWJraXRJREJLZXlSYW5nZTsKK1BBU1MgSURCS2V5UmFuZ2UgPT0gbnVs bCBpcyBmYWxzZQoraW5kZXhlZERCLm9wZW4obmFtZSwgZGVzY3JpcHRpb24pCitkYiA9IGV2ZW50 LnRhcmdldC5yZXN1bHQKK3JlcXVlc3QgPSBkYi5zZXRWZXJzaW9uKCcxJykKK0RlbGV0ZWQgYWxs IG9iamVjdCBzdG9yZXMuCitkYi5jcmVhdGVPYmplY3RTdG9yZSgnZm9vJyk7CitkYXRlMSA9IG5l dyBEYXRlKDEwMDApOworcmVxdWVzdCA9IG9iamVjdFN0b3JlLmFkZChbXSwgZGF0ZTEpOworZGF0 ZTAgPSBuZXcgRGF0ZSgwKTsKK3JlcXVlc3QgPSBvYmplY3RTdG9yZS5hZGQoW10sIGRhdGUwKTsK K2RhdGUzID0gbmV3IERhdGUoMzAwMCk7CityZXF1ZXN0ID0gb2JqZWN0U3RvcmUuYWRkKFtdLCBk YXRlMyk7CitkYXRlMiA9IG5ldyBEYXRlKDIwMDApOworcmVxdWVzdCA9IG9iamVjdFN0b3JlLmFk ZChbXSwgZGF0ZTIpOworc29ydGVkS2V5cyA9IFtkYXRlMC50b1N0cmluZygpLCBkYXRlMS50b1N0 cmluZygpLCBkYXRlMi50b1N0cmluZygpLCBkYXRlMy50b1N0cmluZygpXTsKK3JlcXVlc3QgPSBv YmplY3RTdG9yZS5vcGVuQ3Vyc29yKCk7CitjdXJzb3IgPSBldmVudC50YXJnZXQucmVzdWx0Owor UEFTUyBjdXJzb3Iua2V5LnRvU3RyaW5nKCkgaXMgc29ydGVkS2V5c1trZXlJbmRleF0KK2N1cnNv ci5jb250aW51ZSgpOwora2V5SW5kZXgrKzsKK2N1cnNvciA9IGV2ZW50LnRhcmdldC5yZXN1bHQ7 CitQQVNTIGN1cnNvci5rZXkudG9TdHJpbmcoKSBpcyBzb3J0ZWRLZXlzW2tleUluZGV4XQorY3Vy c29yLmNvbnRpbnVlKCk7CitrZXlJbmRleCsrOworY3Vyc29yID0gZXZlbnQudGFyZ2V0LnJlc3Vs dDsKK1BBU1MgY3Vyc29yLmtleS50b1N0cmluZygpIGlzIHNvcnRlZEtleXNba2V5SW5kZXhdCitj dXJzb3IuY29udGludWUoKTsKK2tleUluZGV4Kys7CitjdXJzb3IgPSBldmVudC50YXJnZXQucmVz dWx0OworUEFTUyBjdXJzb3Iua2V5LnRvU3RyaW5nKCkgaXMgc29ydGVkS2V5c1trZXlJbmRleF0K K2N1cnNvci5jb250aW51ZSgpOwora2V5SW5kZXgrKzsKK2N1cnNvciA9IGV2ZW50LnRhcmdldC5y ZXN1bHQ7CitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUK KwpJbmRleDogTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIva2V5LXNvcnQtb3JkZXItZGF0 ZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2tleS1z b3J0LW9yZGVyLWRhdGUuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL3N0b3JhZ2Uv aW5kZXhlZGRiL2tleS1zb3J0LW9yZGVyLWRhdGUuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSwxMDUgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0ic3R5 bGVzaGVldCIgaHJlZj0iLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3Mi PgorPHNjcmlwdCBzcmM9Ii4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48 L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXBv c3QtZnVuY3Rpb24uanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9InJlc291cmNlcy9zaGFyZWQu anMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4K KzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPHNjcmlwdD4KKworZGVzY3JpcHRpb24oIlRlc3Qg SW5kZXhlZERCIGtleSBjb21wYXJpc29uIik7CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9s bGVyKQorICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKworZnVuY3Rp b24gdGVzdCgpCit7CisgICAgaW5kZXhlZERCID0gZXZhbEFuZExvZygiaW5kZXhlZERCID0gd2lu ZG93LmluZGV4ZWREQiB8fCB3aW5kb3cud2Via2l0SW5kZXhlZERCIHx8IHdpbmRvdy5tb3pJbmRl eGVkREI7Iik7CisgICAgc2hvdWxkQmVGYWxzZSgiaW5kZXhlZERCID09IG51bGwiKTsKKyAgICBJ REJEYXRhYmFzZUV4Y2VwdGlvbiA9IGV2YWxBbmRMb2coIklEQkRhdGFiYXNlRXhjZXB0aW9uID0g d2luZG93LklEQkRhdGFiYXNlRXhjZXB0aW9uIHx8IHdpbmRvdy53ZWJraXRJREJEYXRhYmFzZUV4 Y2VwdGlvbjsiKTsKKyAgICBzaG91bGRCZUZhbHNlKCJJREJEYXRhYmFzZUV4Y2VwdGlvbiA9PSBu dWxsIik7CisgICAgSURCQ3Vyc29yID0gZXZhbEFuZExvZygiSURCQ3Vyc29yID0gd2luZG93LklE QkN1cnNvciB8fCB3aW5kb3cud2Via2l0SURCQ3Vyc29yOyIpOworICAgIHNob3VsZEJlRmFsc2Uo IklEQkN1cnNvciA9PSBudWxsIik7CisgICAgSURCS2V5UmFuZ2UgPSBldmFsQW5kTG9nKCJJREJL ZXlSYW5nZSA9IHdpbmRvdy5JREJLZXlSYW5nZSB8fCB3aW5kb3cud2Via2l0SURCS2V5UmFuZ2U7 Iik7CisgICAgc2hvdWxkQmVGYWxzZSgiSURCS2V5UmFuZ2UgPT0gbnVsbCIpOworCisgICAgbmFt ZSA9IHdpbmRvdy5sb2NhdGlvbi5wYXRobmFtZTsKKyAgICBkZXNjcmlwdGlvbiA9ICJNeSBUZXN0 IERhdGFiYXNlIjsKKyAgICByZXF1ZXN0ID0gZXZhbEFuZExvZygiaW5kZXhlZERCLm9wZW4obmFt ZSwgZGVzY3JpcHRpb24pIik7CisgICAgcmVxdWVzdC5vbnN1Y2Nlc3MgPSBvcGVuU3VjY2VzczsK KyAgICByZXF1ZXN0Lm9uZXJyb3IgPSB1bmV4cGVjdGVkRXJyb3JDYWxsYmFjazsKK30KKworZnVu Y3Rpb24gb3BlblN1Y2Nlc3MoKQoreworICAgIGRiID0gZXZhbEFuZExvZygiZGIgPSBldmVudC50 YXJnZXQucmVzdWx0Iik7CisKKyAgICByZXF1ZXN0ID0gZXZhbEFuZExvZygicmVxdWVzdCA9IGRi LnNldFZlcnNpb24oJzEnKSIpOworICAgIHJlcXVlc3Qub25zdWNjZXNzID0gYWRkS2V5MTsKKyAg ICByZXF1ZXN0Lm9uZXJyb3IgPSB1bmV4cGVjdGVkRXJyb3JDYWxsYmFjazsKK30KKworZnVuY3Rp b24gYWRkS2V5MSgpCit7CisgICAgZGVsZXRlQWxsT2JqZWN0U3RvcmVzKGRiKTsKKworICAgIG9i amVjdFN0b3JlID0gZXZhbEFuZExvZygiZGIuY3JlYXRlT2JqZWN0U3RvcmUoJ2ZvbycpOyIpOwor ICAgIGRhdGUxID0gZXZhbEFuZExvZygiZGF0ZTEgPSBuZXcgRGF0ZSgxMDAwKTsiKTsKKyAgICBy ZXF1ZXN0ID0gZXZhbEFuZExvZygicmVxdWVzdCA9IG9iamVjdFN0b3JlLmFkZChbXSwgZGF0ZTEp OyIpOworICAgIHJlcXVlc3Qub25zdWNjZXNzID0gYWRkS2V5MjsKKyAgICByZXF1ZXN0Lm9uZXJy b3IgPSB1bmV4cGVjdGVkRXJyb3JDYWxsYmFjazsKK30KKworZnVuY3Rpb24gYWRkS2V5MigpCit7 CisgICAgZGF0ZTAgPSBldmFsQW5kTG9nKCJkYXRlMCA9IG5ldyBEYXRlKDApOyIpOworICAgIHJl cXVlc3QgPSBldmFsQW5kTG9nKCJyZXF1ZXN0ID0gb2JqZWN0U3RvcmUuYWRkKFtdLCBkYXRlMCk7 Iik7CisgICAgcmVxdWVzdC5vbnN1Y2Nlc3MgPSBhZGRLZXkzOworICAgIHJlcXVlc3Qub25lcnJv ciA9IHVuZXhwZWN0ZWRFcnJvckNhbGxiYWNrOworfQorCitmdW5jdGlvbiBhZGRLZXkzKCkKK3sK KyAgICBkYXRlMyA9IGV2YWxBbmRMb2coImRhdGUzID0gbmV3IERhdGUoMzAwMCk7Iik7CisgICAg cmVxdWVzdCA9IGV2YWxBbmRMb2coInJlcXVlc3QgPSBvYmplY3RTdG9yZS5hZGQoW10sIGRhdGUz KTsiKTsKKyAgICByZXF1ZXN0Lm9uc3VjY2VzcyA9IGFkZEtleTQ7CisgICAgcmVxdWVzdC5vbmVy cm9yID0gdW5leHBlY3RlZEVycm9yQ2FsbGJhY2s7Cit9CisKK2Z1bmN0aW9uIGFkZEtleTQoKQor eworICAgIGRhdGUyID0gZXZhbEFuZExvZygiZGF0ZTIgPSBuZXcgRGF0ZSgyMDAwKTsiKTsKKyAg ICByZXF1ZXN0ID0gZXZhbEFuZExvZygicmVxdWVzdCA9IG9iamVjdFN0b3JlLmFkZChbXSwgZGF0 ZTIpOyIpOworICAgIHJlcXVlc3Qub25zdWNjZXNzID0gb3BlbkFDdXJzb3I7CisgICAgcmVxdWVz dC5vbmVycm9yID0gdW5leHBlY3RlZEVycm9yQ2FsbGJhY2s7Cit9CisKK2Z1bmN0aW9uIG9wZW5B Q3Vyc29yKCkKK3sKKyAgICBrZXlJbmRleCA9IDA7CisgICAgc29ydGVkS2V5cyA9IGV2YWxBbmRM b2coInNvcnRlZEtleXMgPSBbZGF0ZTAudG9TdHJpbmcoKSwgZGF0ZTEudG9TdHJpbmcoKSwgZGF0 ZTIudG9TdHJpbmcoKSwgZGF0ZTMudG9TdHJpbmcoKV07Iik7CisgICAgcmVxdWVzdCA9IGV2YWxB bmRMb2coInJlcXVlc3QgPSBvYmplY3RTdG9yZS5vcGVuQ3Vyc29yKCk7Iik7CisgICAgcmVxdWVz dC5vbmVycm9yID0gdW5leHBlY3RlZEVycm9yQ2FsbGJhY2s7CisgICAgcmVxdWVzdC5vbnN1Y2Nl c3MgPSBmdW5jdGlvbiAoZXZlbnQpIHsKKyAgICAgICAgY3Vyc29yID0gZXZhbEFuZExvZygiY3Vy c29yID0gZXZlbnQudGFyZ2V0LnJlc3VsdDsiKTsKKyAgICAgICAgaWYgKGN1cnNvcikgeworICAg ICAgICAgICAgc2hvdWxkQmUoImN1cnNvci5rZXkudG9TdHJpbmcoKSIsICJzb3J0ZWRLZXlzW2tl eUluZGV4XSIpOworICAgICAgICAgICAgZXZhbEFuZExvZygiY3Vyc29yLmNvbnRpbnVlKCk7Iik7 CisgICAgICAgICAgICBldmFsQW5kTG9nKCJrZXlJbmRleCsrOyIpOworICAgICAgICB9CisgICAg ICAgIGVsc2UgeworICAgICAgICAgICAgZG9uZSgpOworICAgICAgICB9CisgICAgfQorfQorCit2 YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKKwordGVzdCgpOworCis8L3NjcmlwdD4KKzwv Ym9keT4KKzwvaHRtbD4K