62299 2011-06-08 11:17:07 -0700 IndexedDB test: key sort order across types 2011-06-10 17:24:23 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 pilgrim webkit-unassigned dgrogan hans tony webkit.review.bot oldest_to_newest 417359 0 pilgrim 2011-06-08 11:17:07 -0700 http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#key-construct states "For purposes of comparison, all Arrays are greater than all DOMString, Date and float values; all DOMString values are greater than all Date and float values; and all Date values are greater than all float values." Further, http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#dfn-object-store states "Each record consists of a key and a value. The list is sorted according to key in ascending order." This test adds a number of keys not in sorted order, then opens and iterates a cursor to check that the keys appear in sorted order according ot the sort rules laid out in the spec. WebKit passes this test. 417361 1 96441 pilgrim 2011-06-08 11:18:18 -0700 Created attachment 96441 Patch 417425 2 dgrogan 2011-06-08 12:49:22 -0700 LGTM This reminded me that we don't handle Date yet. 417432 3 dgrogan 2011-06-08 12:54:42 -0700 (In reply to comment #2) > LGTM > > This reminded me that we don't handle Date yet. I guess bug 62300 proves this statement incorrect. Why does this test not include comparing dates to these other types? Just how the mozilla tests were? 417437 4 pilgrim 2011-06-08 13:00:44 -0700 Actually we're done with the Mozilla tests; these are original tests I made up last week (and am just getting around to uploading now). I could add some dates, but I'd have to change how we're comparing values since new Date(0) != new Date(0) in JavaScript. 417459 5 dgrogan 2011-06-08 13:17:29 -0700 (In reply to comment #4) > Actually we're done with the Mozilla tests; these are original tests I made up last week (and am just getting around to uploading now). Hey, congratulations. (Now I see that your usual link to the mozilla test isn't present here.) > > I could add some dates, but I'd have to change how we're comparing values since new Date(0) != new Date(0) in JavaScript. Following up in bug 62300. 417612 6 96441 webkit.review.bot 2011-06-08 15:35:19 -0700 Comment on attachment 96441 Patch Clearing flags on attachment: 96441 Committed r88397: <http://trac.webkit.org/changeset/88397> 417613 7 webkit.review.bot 2011-06-08 15:35:24 -0700 All reviewed patches have been landed. Closing bug. 417914 8 hans 2011-06-09 02:22:32 -0700 (In reply to comment #2) > This reminded me that we don't handle Date yet. I thought we did support dates. Am I missing something? 418192 9 dgrogan 2011-06-09 12:38:38 -0700 (In reply to comment #8) > (In reply to comment #2) > > This reminded me that we don't handle Date yet. > > I thought we did support dates. Am I missing something? We do, you're not missing anything. I had a vague recollection of seeing a TODO somewhere that talked about *something* not supporting dates. Now I'm trying to remember what that was about. 418702 10 pilgrim 2011-06-10 07:26:38 -0700 LayoutTests/storage/indexedb/tutorial.html mentions that WebKit does not support dates or arrays. // Keys can be integers, strings, or null. (The spec also defines dates and there's talk of // handling arrays, but these are not implemented yet in Chromium/WebKit.) I'd be happy to open another bug about updating the tutorial with current information, if you like. 419067 11 dgrogan 2011-06-10 17:24:23 -0700 (In reply to comment #10) > LayoutTests/storage/indexedb/tutorial.html mentions that WebKit does not support dates or arrays. > > > // Keys can be integers, strings, or null. (The spec also defines dates and there's talk of > // handling arrays, but these are not implemented yet in Chromium/WebKit.) > > I'd be happy to open another bug about updating the tutorial with current information, if you like. Sure! 96441 2011-06-08 11:18:18 -0700 2011-06-08 15:35:19 -0700 Patch bug-62299-20110608141830.patch text/plain 6128 pilgrim SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDg4MzYyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDYtMDggIE1hcmsgUGlsZ3JpbSAgPHBp bGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEluZGV4ZWREQiB0ZXN0OiBrZXkgc29ydCBvcmRlciBhY3Jvc3MgdHlwZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyMjk5CisK KyAgICAgICAgKiBzdG9yYWdlL2luZGV4ZWRkYi9rZXktc29ydC1vcmRlci1hY3Jvc3MtdHlwZXMt ZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBzdG9yYWdlL2luZGV4ZWRkYi9rZXktc29y dC1vcmRlci1hY3Jvc3MtdHlwZXMuaHRtbDogQWRkZWQuCisKIDIwMTEtMDYtMDggIE1hcmsgUGls Z3JpbSAgPHBpbGdyaW1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvbnkg Q2hhbmcuCkluZGV4OiBMYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9rZXktc29ydC1vcmRl ci1hY3Jvc3MtdHlwZXMtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3N0 b3JhZ2UvaW5kZXhlZGRiL2tleS1zb3J0LW9yZGVyLWFjcm9zcy10eXBlcy1leHBlY3RlZC50eHQJ KHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9rZXktc29ydC1v cmRlci1hY3Jvc3MtdHlwZXMtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDUw IEBACitUZXN0IEluZGV4ZWREQiBrZXkgY29tcGFyaXNvbgorCitPbiBzdWNjZXNzLCB5b3Ugd2ls bCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01Q TEVURSIuCisKKworaW5kZXhlZERCID0gd2luZG93LmluZGV4ZWREQiB8fCB3aW5kb3cud2Via2l0 SW5kZXhlZERCIHx8IHdpbmRvdy5tb3pJbmRleGVkREI7CitQQVNTIGluZGV4ZWREQiA9PSBudWxs IGlzIGZhbHNlCitJREJEYXRhYmFzZUV4Y2VwdGlvbiA9IHdpbmRvdy5JREJEYXRhYmFzZUV4Y2Vw dGlvbiB8fCB3aW5kb3cud2Via2l0SURCRGF0YWJhc2VFeGNlcHRpb247CitQQVNTIElEQkRhdGFi YXNlRXhjZXB0aW9uID09IG51bGwgaXMgZmFsc2UKK0lEQkN1cnNvciA9IHdpbmRvdy5JREJDdXJz b3IgfHwgd2luZG93LndlYmtpdElEQkN1cnNvcjsKK1BBU1MgSURCQ3Vyc29yID09IG51bGwgaXMg ZmFsc2UKK0lEQktleVJhbmdlID0gd2luZG93LklEQktleVJhbmdlIHx8IHdpbmRvdy53ZWJraXRJ REJLZXlSYW5nZTsKK1BBU1MgSURCS2V5UmFuZ2UgPT0gbnVsbCBpcyBmYWxzZQoraW5kZXhlZERC Lm9wZW4obmFtZSwgZGVzY3JpcHRpb24pCitkYiA9IGV2ZW50LnRhcmdldC5yZXN1bHQKK3JlcXVl c3QgPSBkYi5zZXRWZXJzaW9uKCcxJykKK0RlbGV0ZWQgYWxsIG9iamVjdCBzdG9yZXMuCitkYi5j cmVhdGVPYmplY3RTdG9yZSgnZm9vJyk7CityZXF1ZXN0ID0gb2JqZWN0U3RvcmUuYWRkKFtdLCBJ bmZpbml0eSk7CityZXF1ZXN0ID0gb2JqZWN0U3RvcmUuYWRkKFtdLCAtSW5maW5pdHkpOworcmVx dWVzdCA9IG9iamVjdFN0b3JlLmFkZChbXSwgMS4wKTsKK3JlcXVlc3QgPSBvYmplY3RTdG9yZS5h ZGQoW10sICcnKTsKK3JlcXVlc3QgPSBvYmplY3RTdG9yZS5hZGQoW10sICcxLjAnKTsKK3NvcnRl ZEtleSA9IFstSW5maW5pdHksIDEuMCwgSW5maW5pdHksICcnLCAnMS4wJ107CityZXF1ZXN0ID0g b2JqZWN0U3RvcmUub3BlbkN1cnNvcigpOworY3Vyc29yID0gZXZlbnQudGFyZ2V0LnJlc3VsdDsK K1BBU1MgY3Vyc29yLmtleSBpcyBzb3J0ZWRLZXlzW2tleUluZGV4XQorY3Vyc29yLmNvbnRpbnVl KCk7CitrZXlJbmRleCsrOworY3Vyc29yID0gZXZlbnQudGFyZ2V0LnJlc3VsdDsKK1BBU1MgY3Vy c29yLmtleSBpcyBzb3J0ZWRLZXlzW2tleUluZGV4XQorY3Vyc29yLmNvbnRpbnVlKCk7CitrZXlJ bmRleCsrOworY3Vyc29yID0gZXZlbnQudGFyZ2V0LnJlc3VsdDsKK1BBU1MgY3Vyc29yLmtleSBp cyBzb3J0ZWRLZXlzW2tleUluZGV4XQorY3Vyc29yLmNvbnRpbnVlKCk7CitrZXlJbmRleCsrOwor Y3Vyc29yID0gZXZlbnQudGFyZ2V0LnJlc3VsdDsKK1BBU1MgY3Vyc29yLmtleSBpcyBzb3J0ZWRL ZXlzW2tleUluZGV4XQorY3Vyc29yLmNvbnRpbnVlKCk7CitrZXlJbmRleCsrOworY3Vyc29yID0g ZXZlbnQudGFyZ2V0LnJlc3VsdDsKK1BBU1MgY3Vyc29yLmtleSBpcyBzb3J0ZWRLZXlzW2tleUlu ZGV4XQorY3Vyc29yLmNvbnRpbnVlKCk7CitrZXlJbmRleCsrOworY3Vyc29yID0gZXZlbnQudGFy Z2V0LnJlc3VsdDsKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01Q TEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9rZXktc29ydC1vcmRl ci1hY3Jvc3MtdHlwZXMuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9zdG9yYWdlL2lu ZGV4ZWRkYi9rZXktc29ydC1vcmRlci1hY3Jvc3MtdHlwZXMuaHRtbAkocmV2aXNpb24gMCkKKysr IExheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2tleS1zb3J0LW9yZGVyLWFjcm9zcy10eXBl cy5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEwOCBAQAorPCFET0NUWVBFIGh0bWw+Cis8 aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIuLi8uLi9mYXN0L2pz L3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vLi4vZmFzdC9q cy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4u L2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC1mdW5jdGlvbi5qcyI+PC9zY3JpcHQ+Cis8 c2NyaXB0IHNyYz0icmVzb3VyY2VzL3NoYXJlZC5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9k eT4KKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8 c2NyaXB0PgorCitkZXNjcmlwdGlvbigiVGVzdCBJbmRleGVkREIga2V5IGNvbXBhcmlzb24iKTsK K2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgbGF5b3V0VGVzdENvbnRyb2xs ZXIud2FpdFVudGlsRG9uZSgpOworCitmdW5jdGlvbiB0ZXN0KCkKK3sKKyAgICBpbmRleGVkREIg PSBldmFsQW5kTG9nKCJpbmRleGVkREIgPSB3aW5kb3cuaW5kZXhlZERCIHx8IHdpbmRvdy53ZWJr aXRJbmRleGVkREIgfHwgd2luZG93Lm1vekluZGV4ZWREQjsiKTsKKyAgICBzaG91bGRCZUZhbHNl KCJpbmRleGVkREIgPT0gbnVsbCIpOworICAgIElEQkRhdGFiYXNlRXhjZXB0aW9uID0gZXZhbEFu ZExvZygiSURCRGF0YWJhc2VFeGNlcHRpb24gPSB3aW5kb3cuSURCRGF0YWJhc2VFeGNlcHRpb24g fHwgd2luZG93LndlYmtpdElEQkRhdGFiYXNlRXhjZXB0aW9uOyIpOworICAgIHNob3VsZEJlRmFs c2UoIklEQkRhdGFiYXNlRXhjZXB0aW9uID09IG51bGwiKTsKKyAgICBJREJDdXJzb3IgPSBldmFs QW5kTG9nKCJJREJDdXJzb3IgPSB3aW5kb3cuSURCQ3Vyc29yIHx8IHdpbmRvdy53ZWJraXRJREJD dXJzb3I7Iik7CisgICAgc2hvdWxkQmVGYWxzZSgiSURCQ3Vyc29yID09IG51bGwiKTsKKyAgICBJ REJLZXlSYW5nZSA9IGV2YWxBbmRMb2coIklEQktleVJhbmdlID0gd2luZG93LklEQktleVJhbmdl IHx8IHdpbmRvdy53ZWJraXRJREJLZXlSYW5nZTsiKTsKKyAgICBzaG91bGRCZUZhbHNlKCJJREJL ZXlSYW5nZSA9PSBudWxsIik7CisKKyAgICBuYW1lID0gd2luZG93LmxvY2F0aW9uLnBhdGhuYW1l OworICAgIGRlc2NyaXB0aW9uID0gIk15IFRlc3QgRGF0YWJhc2UiOworICAgIHJlcXVlc3QgPSBl dmFsQW5kTG9nKCJpbmRleGVkREIub3BlbihuYW1lLCBkZXNjcmlwdGlvbikiKTsKKyAgICByZXF1 ZXN0Lm9uc3VjY2VzcyA9IG9wZW5TdWNjZXNzOworICAgIHJlcXVlc3Qub25lcnJvciA9IHVuZXhw ZWN0ZWRFcnJvckNhbGxiYWNrOworfQorCitmdW5jdGlvbiBvcGVuU3VjY2VzcygpCit7CisgICAg ZGIgPSBldmFsQW5kTG9nKCJkYiA9IGV2ZW50LnRhcmdldC5yZXN1bHQiKTsKKworICAgIHJlcXVl c3QgPSBldmFsQW5kTG9nKCJyZXF1ZXN0ID0gZGIuc2V0VmVyc2lvbignMScpIik7CisgICAgcmVx dWVzdC5vbnN1Y2Nlc3MgPSBhZGRLZXkxOworICAgIHJlcXVlc3Qub25lcnJvciA9IHVuZXhwZWN0 ZWRFcnJvckNhbGxiYWNrOworfQorCitmdW5jdGlvbiBhZGRLZXkxKCkKK3sKKyAgICBkZWxldGVB bGxPYmplY3RTdG9yZXMoZGIpOworCisgICAgb2JqZWN0U3RvcmUgPSBldmFsQW5kTG9nKCJkYi5j cmVhdGVPYmplY3RTdG9yZSgnZm9vJyk7Iik7CisgICAgcmVxdWVzdCA9IGV2YWxBbmRMb2coInJl cXVlc3QgPSBvYmplY3RTdG9yZS5hZGQoW10sIEluZmluaXR5KTsiKTsKKyAgICByZXF1ZXN0Lm9u c3VjY2VzcyA9IGFkZEtleTI7CisgICAgcmVxdWVzdC5vbmVycm9yID0gdW5leHBlY3RlZEVycm9y Q2FsbGJhY2s7Cit9CisKK2Z1bmN0aW9uIGFkZEtleTIoKQoreworICAgIHJlcXVlc3QgPSBldmFs QW5kTG9nKCJyZXF1ZXN0ID0gb2JqZWN0U3RvcmUuYWRkKFtdLCAtSW5maW5pdHkpOyIpOworICAg IHJlcXVlc3Qub25zdWNjZXNzID0gYWRkS2V5MzsKKyAgICByZXF1ZXN0Lm9uZXJyb3IgPSB1bmV4 cGVjdGVkRXJyb3JDYWxsYmFjazsKK30KKworZnVuY3Rpb24gYWRkS2V5MygpCit7CisgICAgcmVx dWVzdCA9IGV2YWxBbmRMb2coInJlcXVlc3QgPSBvYmplY3RTdG9yZS5hZGQoW10sIDEuMCk7Iik7 CisgICAgcmVxdWVzdC5vbnN1Y2Nlc3MgPSBhZGRLZXk0OworICAgIHJlcXVlc3Qub25lcnJvciA9 IHVuZXhwZWN0ZWRFcnJvckNhbGxiYWNrOworfQorCitmdW5jdGlvbiBhZGRLZXk0KCkKK3sKKyAg ICByZXF1ZXN0ID0gZXZhbEFuZExvZygicmVxdWVzdCA9IG9iamVjdFN0b3JlLmFkZChbXSwgJycp OyIpOworICAgIHJlcXVlc3Qub25zdWNjZXNzID0gYWRkS2V5NTsKKyAgICByZXF1ZXN0Lm9uZXJy b3IgPSB1bmV4cGVjdGVkRXJyb3JDYWxsYmFjazsKK30KKworZnVuY3Rpb24gYWRkS2V5NSgpCit7 CisgICAgcmVxdWVzdCA9IGV2YWxBbmRMb2coInJlcXVlc3QgPSBvYmplY3RTdG9yZS5hZGQoW10s ICcxLjAnKTsiKTsKKyAgICByZXF1ZXN0Lm9uc3VjY2VzcyA9IG9wZW5BQ3Vyc29yOworICAgIHJl cXVlc3Qub25lcnJvciA9IHVuZXhwZWN0ZWRFcnJvckNhbGxiYWNrOworfQorCitmdW5jdGlvbiBv cGVuQUN1cnNvcigpCit7CisgICAga2V5SW5kZXggPSAwOworICAgIHNvcnRlZEtleXMgPSBldmFs QW5kTG9nKCJzb3J0ZWRLZXkgPSBbLUluZmluaXR5LCAxLjAsIEluZmluaXR5LCAnJywgJzEuMCdd OyIpOworICAgIHJlcXVlc3QgPSBldmFsQW5kTG9nKCJyZXF1ZXN0ID0gb2JqZWN0U3RvcmUub3Bl bkN1cnNvcigpOyIpOworICAgIHJlcXVlc3Qub25lcnJvciA9IHVuZXhwZWN0ZWRFcnJvckNhbGxi YWNrOworICAgIHJlcXVlc3Qub25zdWNjZXNzID0gZnVuY3Rpb24gKGV2ZW50KSB7CisgICAgICAg IGN1cnNvciA9IGV2YWxBbmRMb2coImN1cnNvciA9IGV2ZW50LnRhcmdldC5yZXN1bHQ7Iik7Cisg ICAgICAgIGlmIChjdXJzb3IpIHsKKyAgICAgICAgICAgIHNob3VsZEJlKCJjdXJzb3Iua2V5Iiwg InNvcnRlZEtleXNba2V5SW5kZXhdIik7CisgICAgICAgICAgICBldmFsQW5kTG9nKCJjdXJzb3Iu Y29udGludWUoKTsiKTsKKyAgICAgICAgICAgIGV2YWxBbmRMb2coImtleUluZGV4Kys7Iik7Cisg ICAgICAgIH0KKyAgICAgICAgZWxzZSB7CisgICAgICAgICAgICBkb25lKCk7CisgICAgICAgIH0K KyAgICB9Cit9CisKK3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworCit0ZXN0KCk7CisK Kzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=