62295 2011-06-08 10:01:22 -0700 Fix a ?: precedence error in ScrollbarThemeMac and ScrollbarThemeChromium 2011-06-08 11:20:36 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thakis thakis darin hyatt thakis webkit.review.bot oldest_to_newest 417308 0 thakis 2011-06-08 10:01:22 -0700 Fix a ?: precedence error in ScrollbarThemeMac and ScrollbarThemeChromium 417311 1 96438 thakis 2011-06-08 10:02:33 -0700 Created attachment 96438 Patch 417323 2 96438 darin 2011-06-08 10:18:31 -0700 Comment on attachment 96438 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96438&action=review Please post a new patch that gets the ScrollbarThemeMac.mm part right. Anyone got information on what the symptom of this was? Clearly the old code was incorrect. But we normally want regression testing too. > Source/WebCore/platform/mac/ScrollbarThemeMac.mm:295 > - result = IntRect(scrollbar->x(), scrollbar->y(), cOuterButtonLength[scrollbar->controlSize()] + painting ? cOuterButtonOverlap : 0, thickness); > + result = IntRect(scrollbar->x(), scrollbar->y(), cOuterButtonLength[scrollbar->controlSize()] + painting ? (cOuterButtonOverlap : 0), thickness); This looks wrong. The parentheses are added in the wrong place here! 417327 3 96438 thakis 2011-06-08 10:21:08 -0700 Comment on attachment 96438 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96438&action=review >> Source/WebCore/platform/mac/ScrollbarThemeMac.mm:295 >> + result = IntRect(scrollbar->x(), scrollbar->y(), cOuterButtonLength[scrollbar->controlSize()] + painting ? (cOuterButtonOverlap : 0), thickness); > > This looks wrong. The parentheses are added in the wrong place here! |painting| is a bool. What this code did before I added the parens was |(int + bool) ? overlap : 0|. I would have thought it's supposed to be |int + (bool ? overlap : 0)|, which is what this patch does. Am I misunderstanding the code? 417328 4 thakis 2011-06-08 10:21:53 -0700 Thanks for your comment, Darin. I replied to it – I'm afraid I don't get it :-/ 417329 5 darin 2011-06-08 10:22:48 -0700 (In reply to comment #3) > (From update of attachment 96438 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=96438&action=review > > >> Source/WebCore/platform/mac/ScrollbarThemeMac.mm:295 > >> + result = IntRect(scrollbar->x(), scrollbar->y(), cOuterButtonLength[scrollbar->controlSize()] + painting ? (cOuterButtonOverlap : 0), thickness); > > > > This looks wrong. The parentheses are added in the wrong place here! > > |painting| is a bool. What this code did before I added the parens was |(int + bool) ? overlap : 0|. I would have thought it's supposed to be |int + (bool ? overlap : 0)|, which is what this patch does. > > Am I misunderstanding the code? The above says: painting ? (cOuterButtonOverlap : 0) But you need to say: (painting ? cOuterButtonOverlap : 0) Maybe you just had trouble seeing it. 417330 6 96439 thakis 2011-06-08 10:25:48 -0700 Created attachment 96439 Patch 417331 7 thakis 2011-06-08 10:26:06 -0700 9_9 Sorry. 417333 8 darin 2011-06-08 10:27:35 -0700 Still would be good to find out what the symptom of this was. 417337 9 thakis 2011-06-08 10:33:40 -0700 This codepath was hit only when (buttonsPlacement() == ScrollbarButtonsDoubleStart || buttonsPlacement() == ScrollbarButtonsDoubleBoth is true which I think isn't true for most people in practice. The only interesting called of this function is RenderScrollbarTheme::trackRect(), so from reading the code it looks like for doublestart / doubleboth scrollbars, the track would appear slightly too large. 417362 10 96439 webkit.review.bot 2011-06-08 11:20:31 -0700 Comment on attachment 96439 Patch Clearing flags on attachment: 96439 Committed r88364: <http://trac.webkit.org/changeset/88364> 417363 11 webkit.review.bot 2011-06-08 11:20:36 -0700 All reviewed patches have been landed. Closing bug. 96438 2011-06-08 10:02:33 -0700 2011-06-08 10:25:45 -0700 Patch bug-62295-20110608100232.patch text/plain 3632 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogODgzMjYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3YWMxMmFjOGI3ZWY1Y2Vl N2Y5NmY5MGY3YWJhNGM0MzgzZmIxNjFmLi5mMTNkZDExNzJmMjIxYWJjMDhkNzEzNWQyNzU0N2U3 NzY3MTMzZjJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDYtMDggIE5pY28g V2ViZXIgIDx0aGFraXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeCBhID86IHByZWNlZGVuY2UgZXJyb3IgaW4gU2Nyb2xs YmFyVGhlbWVNYWMgYW5kIFNjcm9sbGJhclRoZW1lQ2hyb21pdW0KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyMjk1CisKKyAgICAgICAgVGhpcyB3YXMg Zm91bmQgYnkgYSBuZXcgd2FybmluZyByZWNlbnRseSBhZGRlZCB0byBjbGFuZydzIC1XcGFyZW50 aGVzZXMKKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21p dW1NYWMubW06CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxiYXJUaGVtZUNocm9taXVtTWFjOjpi YWNrQnV0dG9uUmVjdCk6CisgICAgICAgICogcGxhdGZvcm0vbWFjL1Njcm9sbGJhclRoZW1lTWFj Lm1tOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyVGhlbWVNYWM6OmJhY2tCdXR0b25SZWN0 KToKKwogMjAxMS0wNi0wNyAgSWFuIEhlbmRlcnNvbiAgPGlhbmhAYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxiYXJUaGVtZUNocm9taXVtTWFjLm1tIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bU1hYy5tbQpp bmRleCBkZDZjY2EyZGViMjBlMDM2YzYwZjYyMDMzMTNhNzc3NzMxODk4MDRiLi4yZjQ3N2FhNTA3 NjI4ODNkZGMzNzRlODgzNTg4NDIwYTAwYTZjYmMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxiYXJUaGVtZUNocm9taXVtTWFjLm1tCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW1NYWMu bW0KQEAgLTI0NSw5ICsyNDUsOSBAQCBJbnRSZWN0IFNjcm9sbGJhclRoZW1lQ2hyb21pdW1NYWM6 OmJhY2tCdXR0b25SZWN0KFNjcm9sbGJhciogc2Nyb2xsYmFyLCBTY3JvbGxiYQogICAgIGJvb2wg b3V0ZXJCdXR0b24gPSBwYXJ0ID09IEJhY2tCdXR0b25TdGFydFBhcnQgJiYgKGJ1dHRvbnNQbGFj ZW1lbnQoKSA9PSBTY3JvbGxiYXJCdXR0b25zRG91YmxlU3RhcnQgfHwgYnV0dG9uc1BsYWNlbWVu dCgpID09IFNjcm9sbGJhckJ1dHRvbnNEb3VibGVCb3RoKTsKICAgICBpZiAob3V0ZXJCdXR0b24p IHsKICAgICAgICAgaWYgKHNjcm9sbGJhci0+b3JpZW50YXRpb24oKSA9PSBIb3Jpem9udGFsU2Ny b2xsYmFyKQotICAgICAgICAgICAgcmVzdWx0ID0gSW50UmVjdChzY3JvbGxiYXItPngoKSwgc2Ny b2xsYmFyLT55KCksIGNPdXRlckJ1dHRvbkxlbmd0aFtzY3JvbGxiYXItPmNvbnRyb2xTaXplKCld ICsgcGFpbnRpbmcgPyBjT3V0ZXJCdXR0b25PdmVybGFwIDogMCwgdGhpY2tuZXNzKTsKKyAgICAg ICAgICAgIHJlc3VsdCA9IEludFJlY3Qoc2Nyb2xsYmFyLT54KCksIHNjcm9sbGJhci0+eSgpLCBj T3V0ZXJCdXR0b25MZW5ndGhbc2Nyb2xsYmFyLT5jb250cm9sU2l6ZSgpXSArIChwYWludGluZyA/ IGNPdXRlckJ1dHRvbk92ZXJsYXAgOiAwKSwgdGhpY2tuZXNzKTsKICAgICAgICAgZWxzZQotICAg ICAgICAgICAgcmVzdWx0ID0gSW50UmVjdChzY3JvbGxiYXItPngoKSwgc2Nyb2xsYmFyLT55KCks IHRoaWNrbmVzcywgY091dGVyQnV0dG9uTGVuZ3RoW3Njcm9sbGJhci0+Y29udHJvbFNpemUoKV0g KyBwYWludGluZyA/IGNPdXRlckJ1dHRvbk92ZXJsYXAgOiAwKTsKKyAgICAgICAgICAgIHJlc3Vs dCA9IEludFJlY3Qoc2Nyb2xsYmFyLT54KCksIHNjcm9sbGJhci0+eSgpLCB0aGlja25lc3MsIGNP dXRlckJ1dHRvbkxlbmd0aFtzY3JvbGxiYXItPmNvbnRyb2xTaXplKCldICsgKHBhaW50aW5nID8g Y091dGVyQnV0dG9uT3ZlcmxhcCA6IDApKTsKICAgICAgICAgcmV0dXJuIHJlc3VsdDsKICAgICB9 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxiYXJUaGVt ZU1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxiYXJUaGVtZU1hYy5t bQppbmRleCA5MjM3OWIyYmZmNzU1ODQzZmFlMDM5NDBmYTY1Mzg1MWRhMzM2YWJmLi5iNTg0OGYy MTFjMDU3OWQ4NWQ0NDc5MjAyYTg5YzZjZWI1NTZjMTBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsYmFyVGhlbWVNYWMubW0KKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbWFjL1Njcm9sbGJhclRoZW1lTWFjLm1tCkBAIC0yOTIsOSArMjkyLDkgQEAg SW50UmVjdCBTY3JvbGxiYXJUaGVtZU1hYzo6YmFja0J1dHRvblJlY3QoU2Nyb2xsYmFyKiBzY3Jv bGxiYXIsIFNjcm9sbGJhclBhcnQgcGEKICAgICBib29sIG91dGVyQnV0dG9uID0gcGFydCA9PSBC YWNrQnV0dG9uU3RhcnRQYXJ0ICYmIChidXR0b25zUGxhY2VtZW50KCkgPT0gU2Nyb2xsYmFyQnV0 dG9uc0RvdWJsZVN0YXJ0IHx8IGJ1dHRvbnNQbGFjZW1lbnQoKSA9PSBTY3JvbGxiYXJCdXR0b25z RG91YmxlQm90aCk7CiAgICAgaWYgKG91dGVyQnV0dG9uKSB7CiAgICAgICAgIGlmIChzY3JvbGxi YXItPm9yaWVudGF0aW9uKCkgPT0gSG9yaXpvbnRhbFNjcm9sbGJhcikKLSAgICAgICAgICAgIHJl c3VsdCA9IEludFJlY3Qoc2Nyb2xsYmFyLT54KCksIHNjcm9sbGJhci0+eSgpLCBjT3V0ZXJCdXR0 b25MZW5ndGhbc2Nyb2xsYmFyLT5jb250cm9sU2l6ZSgpXSArIHBhaW50aW5nID8gY091dGVyQnV0 dG9uT3ZlcmxhcCA6IDAsIHRoaWNrbmVzcyk7CisgICAgICAgICAgICByZXN1bHQgPSBJbnRSZWN0 KHNjcm9sbGJhci0+eCgpLCBzY3JvbGxiYXItPnkoKSwgY091dGVyQnV0dG9uTGVuZ3RoW3Njcm9s bGJhci0+Y29udHJvbFNpemUoKV0gKyBwYWludGluZyA/IChjT3V0ZXJCdXR0b25PdmVybGFwIDog MCksIHRoaWNrbmVzcyk7CiAgICAgICAgIGVsc2UKLSAgICAgICAgICAgIHJlc3VsdCA9IEludFJl Y3Qoc2Nyb2xsYmFyLT54KCksIHNjcm9sbGJhci0+eSgpLCB0aGlja25lc3MsIGNPdXRlckJ1dHRv bkxlbmd0aFtzY3JvbGxiYXItPmNvbnRyb2xTaXplKCldICsgcGFpbnRpbmcgPyBjT3V0ZXJCdXR0 b25PdmVybGFwIDogMCk7CisgICAgICAgICAgICByZXN1bHQgPSBJbnRSZWN0KHNjcm9sbGJhci0+ eCgpLCBzY3JvbGxiYXItPnkoKSwgdGhpY2tuZXNzLCBjT3V0ZXJCdXR0b25MZW5ndGhbc2Nyb2xs YmFyLT5jb250cm9sU2l6ZSgpXSArIChwYWludGluZyA/IGNPdXRlckJ1dHRvbk92ZXJsYXAgOiAw KSk7CiAgICAgICAgIHJldHVybiByZXN1bHQ7CiAgICAgfQogICAgIAo= 96439 2011-06-08 10:25:48 -0700 2011-06-08 11:20:31 -0700 Patch bug-62295-20110608102547.patch text/plain 3632 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogODgzMjYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3YWMxMmFjOGI3ZWY1Y2Vl N2Y5NmY5MGY3YWJhNGM0MzgzZmIxNjFmLi5mMTNkZDExNzJmMjIxYWJjMDhkNzEzNWQyNzU0N2U3 NzY3MTMzZjJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDYtMDggIE5pY28g V2ViZXIgIDx0aGFraXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeCBhID86IHByZWNlZGVuY2UgZXJyb3IgaW4gU2Nyb2xs YmFyVGhlbWVNYWMgYW5kIFNjcm9sbGJhclRoZW1lQ2hyb21pdW0KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyMjk1CisKKyAgICAgICAgVGhpcyB3YXMg Zm91bmQgYnkgYSBuZXcgd2FybmluZyByZWNlbnRseSBhZGRlZCB0byBjbGFuZydzIC1XcGFyZW50 aGVzZXMKKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21p dW1NYWMubW06CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxiYXJUaGVtZUNocm9taXVtTWFjOjpi YWNrQnV0dG9uUmVjdCk6CisgICAgICAgICogcGxhdGZvcm0vbWFjL1Njcm9sbGJhclRoZW1lTWFj Lm1tOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyVGhlbWVNYWM6OmJhY2tCdXR0b25SZWN0 KToKKwogMjAxMS0wNi0wNyAgSWFuIEhlbmRlcnNvbiAgPGlhbmhAYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxiYXJUaGVtZUNocm9taXVtTWFjLm1tIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bU1hYy5tbQpp bmRleCBkZDZjY2EyZGViMjBlMDM2YzYwZjYyMDMzMTNhNzc3NzMxODk4MDRiLi4yZjQ3N2FhNTA3 NjI4ODNkZGMzNzRlODgzNTg4NDIwYTAwYTZjYmMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxiYXJUaGVtZUNocm9taXVtTWFjLm1tCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW1NYWMu bW0KQEAgLTI0NSw5ICsyNDUsOSBAQCBJbnRSZWN0IFNjcm9sbGJhclRoZW1lQ2hyb21pdW1NYWM6 OmJhY2tCdXR0b25SZWN0KFNjcm9sbGJhciogc2Nyb2xsYmFyLCBTY3JvbGxiYQogICAgIGJvb2wg b3V0ZXJCdXR0b24gPSBwYXJ0ID09IEJhY2tCdXR0b25TdGFydFBhcnQgJiYgKGJ1dHRvbnNQbGFj ZW1lbnQoKSA9PSBTY3JvbGxiYXJCdXR0b25zRG91YmxlU3RhcnQgfHwgYnV0dG9uc1BsYWNlbWVu dCgpID09IFNjcm9sbGJhckJ1dHRvbnNEb3VibGVCb3RoKTsKICAgICBpZiAob3V0ZXJCdXR0b24p IHsKICAgICAgICAgaWYgKHNjcm9sbGJhci0+b3JpZW50YXRpb24oKSA9PSBIb3Jpem9udGFsU2Ny b2xsYmFyKQotICAgICAgICAgICAgcmVzdWx0ID0gSW50UmVjdChzY3JvbGxiYXItPngoKSwgc2Ny b2xsYmFyLT55KCksIGNPdXRlckJ1dHRvbkxlbmd0aFtzY3JvbGxiYXItPmNvbnRyb2xTaXplKCld ICsgcGFpbnRpbmcgPyBjT3V0ZXJCdXR0b25PdmVybGFwIDogMCwgdGhpY2tuZXNzKTsKKyAgICAg ICAgICAgIHJlc3VsdCA9IEludFJlY3Qoc2Nyb2xsYmFyLT54KCksIHNjcm9sbGJhci0+eSgpLCBj T3V0ZXJCdXR0b25MZW5ndGhbc2Nyb2xsYmFyLT5jb250cm9sU2l6ZSgpXSArIChwYWludGluZyA/ IGNPdXRlckJ1dHRvbk92ZXJsYXAgOiAwKSwgdGhpY2tuZXNzKTsKICAgICAgICAgZWxzZQotICAg ICAgICAgICAgcmVzdWx0ID0gSW50UmVjdChzY3JvbGxiYXItPngoKSwgc2Nyb2xsYmFyLT55KCks IHRoaWNrbmVzcywgY091dGVyQnV0dG9uTGVuZ3RoW3Njcm9sbGJhci0+Y29udHJvbFNpemUoKV0g KyBwYWludGluZyA/IGNPdXRlckJ1dHRvbk92ZXJsYXAgOiAwKTsKKyAgICAgICAgICAgIHJlc3Vs dCA9IEludFJlY3Qoc2Nyb2xsYmFyLT54KCksIHNjcm9sbGJhci0+eSgpLCB0aGlja25lc3MsIGNP dXRlckJ1dHRvbkxlbmd0aFtzY3JvbGxiYXItPmNvbnRyb2xTaXplKCldICsgKHBhaW50aW5nID8g Y091dGVyQnV0dG9uT3ZlcmxhcCA6IDApKTsKICAgICAgICAgcmV0dXJuIHJlc3VsdDsKICAgICB9 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxiYXJUaGVt ZU1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxiYXJUaGVtZU1hYy5t bQppbmRleCA5MjM3OWIyYmZmNzU1ODQzZmFlMDM5NDBmYTY1Mzg1MWRhMzM2YWJmLi5hYTc5ZGQ5 N2ViM2EzM2FlNzEzZTc0ZDI5MTAyOWE5ZjhiZDQzZTc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsYmFyVGhlbWVNYWMubW0KKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbWFjL1Njcm9sbGJhclRoZW1lTWFjLm1tCkBAIC0yOTIsOSArMjkyLDkgQEAg SW50UmVjdCBTY3JvbGxiYXJUaGVtZU1hYzo6YmFja0J1dHRvblJlY3QoU2Nyb2xsYmFyKiBzY3Jv bGxiYXIsIFNjcm9sbGJhclBhcnQgcGEKICAgICBib29sIG91dGVyQnV0dG9uID0gcGFydCA9PSBC YWNrQnV0dG9uU3RhcnRQYXJ0ICYmIChidXR0b25zUGxhY2VtZW50KCkgPT0gU2Nyb2xsYmFyQnV0 dG9uc0RvdWJsZVN0YXJ0IHx8IGJ1dHRvbnNQbGFjZW1lbnQoKSA9PSBTY3JvbGxiYXJCdXR0b25z RG91YmxlQm90aCk7CiAgICAgaWYgKG91dGVyQnV0dG9uKSB7CiAgICAgICAgIGlmIChzY3JvbGxi YXItPm9yaWVudGF0aW9uKCkgPT0gSG9yaXpvbnRhbFNjcm9sbGJhcikKLSAgICAgICAgICAgIHJl c3VsdCA9IEludFJlY3Qoc2Nyb2xsYmFyLT54KCksIHNjcm9sbGJhci0+eSgpLCBjT3V0ZXJCdXR0 b25MZW5ndGhbc2Nyb2xsYmFyLT5jb250cm9sU2l6ZSgpXSArIHBhaW50aW5nID8gY091dGVyQnV0 dG9uT3ZlcmxhcCA6IDAsIHRoaWNrbmVzcyk7CisgICAgICAgICAgICByZXN1bHQgPSBJbnRSZWN0 KHNjcm9sbGJhci0+eCgpLCBzY3JvbGxiYXItPnkoKSwgY091dGVyQnV0dG9uTGVuZ3RoW3Njcm9s bGJhci0+Y29udHJvbFNpemUoKV0gKyAocGFpbnRpbmcgPyBjT3V0ZXJCdXR0b25PdmVybGFwIDog MCksIHRoaWNrbmVzcyk7CiAgICAgICAgIGVsc2UKLSAgICAgICAgICAgIHJlc3VsdCA9IEludFJl Y3Qoc2Nyb2xsYmFyLT54KCksIHNjcm9sbGJhci0+eSgpLCB0aGlja25lc3MsIGNPdXRlckJ1dHRv bkxlbmd0aFtzY3JvbGxiYXItPmNvbnRyb2xTaXplKCldICsgcGFpbnRpbmcgPyBjT3V0ZXJCdXR0 b25PdmVybGFwIDogMCk7CisgICAgICAgICAgICByZXN1bHQgPSBJbnRSZWN0KHNjcm9sbGJhci0+ eCgpLCBzY3JvbGxiYXItPnkoKSwgdGhpY2tuZXNzLCBjT3V0ZXJCdXR0b25MZW5ndGhbc2Nyb2xs YmFyLT5jb250cm9sU2l6ZSgpXSArIChwYWludGluZyA/IGNPdXRlckJ1dHRvbk92ZXJsYXAgOiAw KSk7CiAgICAgICAgIHJldHVybiByZXN1bHQ7CiAgICAgfQogICAgIAo=