62283 2011-06-08 08:12:56 -0700 [Qt] Support for the gnash flash player plugin 2011-06-16 15:21:10 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Linux RESOLVED FIXED Qt P2 Normal --- 0 adawit webkit-unassigned eric evan ossy tony webkit.review.bot yael oldest_to_newest 417243 0 adawit 2011-06-08 08:12:56 -0700 Currently the gnash flash player does not work with QtWebKit. Instead it prints out the following error message: ERROR: NPAPI ERROR: No GTK2 support in this browser! Have version 0 The fix for it is to use the same workaround as the one used for the nspluginwrapper (npwrapper) in PluginPackageQt.cpp. 417244 1 96424 adawit 2011-06-08 08:17:14 -0700 Created attachment 96424 proposed patch 419962 2 96424 eric 2011-06-13 15:25:55 -0700 Comment on attachment 96424 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=96424&action=review Do we not have any tests in the repository which use flash? > Source/WebCore/ChangeLog:10 > + No new tests. (OOPS!) The OOPS in this line will cause your patch to fail the commit queue. You need to replace this line with a list of tests or reasons why testing is impossible/impractical. 421239 3 97289 adawit 2011-06-15 06:58:50 -0700 Created attachment 97289 proposed patch v2 Fixed changelog. 421245 4 97289 menard 2011-06-15 07:15:12 -0700 Comment on attachment 97289 proposed patch v2 LGTM. 422284 5 97289 webkit.review.bot 2011-06-16 15:21:05 -0700 Comment on attachment 97289 proposed patch v2 Clearing flags on attachment: 97289 Committed r89076: <http://trac.webkit.org/changeset/89076> 422285 6 webkit.review.bot 2011-06-16 15:21:10 -0700 All reviewed patches have been landed. Closing bug. 96424 2011-06-08 08:17:14 -0700 2011-06-15 06:58:50 -0700 proposed patch bug_62283.patch text/plain 1545 adawit Y29tbWl0IDNhNDY5OGUxYWJlYmJhM2I2NjBjMWY1ZjgxZTY5NDQxMWExYzdjNzcKQXV0aG9yOiBE YXdpdCBBbGVtYXllaHUgPGFkYXdpdEBrZGUub3JnPgpEYXRlOiAgIFdlZCBKdW4gOCAxMToxMzoz MCAyMDExIC0wNDAwCgogICAgU3VwcG9ydCBmb3IgZ25hc2ggZmxhc2ggcGxheWVyIHBsdWdpbiBp biBRdFdlYktpdAoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0NWYwNmQxLi45M2I5Yzk0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTEtMDYtMDggIERhd2l0IEFsZW1heWVodSAgPGFkYXdpdEBrZGUu b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN1 cHBvcnQgZm9yIGduYXNoIGZsYXNoIHBsYXllciBwbHVnaW4gaW4gUXRXZWJLaXQKKworICAgICAg ICBbUXRdIFN1cHBvcnQgZm9yIHRoZSBnbmFzaCBmbGFzaCBwbGF5ZXIgcGx1Z2luCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MjI4MworCisgICAgICAg IE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogcGx1Z2lucy9xdC9QbHVnaW5QYWNr YWdlUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luUGFja2FnZTo6bG9hZCk6CisKIDIw MTEtMDYtMDUgIElnb3IgT2xpdmVpcmEgIDxpZ29yLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL3F0L1BsdWdpblBhY2thZ2VRdC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbHVnaW5zL3F0L1BsdWdpblBhY2thZ2VRdC5jcHAKaW5kZXggMTk5NDFkNi4u ZTk4MDQ0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5QYWNr YWdlUXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1Z2luUGFja2FnZVF0 LmNwcApAQCAtMTYyLDcgKzE2Miw3IEBAIGJvb2wgUGx1Z2luUGFja2FnZTo6bG9hZCgpCiAKICAg ICBpbml0aWFsaXplQnJvd3NlckZ1bmNzKCk7CiAKLSAgICBpZiAobV9wYXRoLmNvbnRhaW5zKCJu cHdyYXBwZXIuIikpIHsKKyAgICBpZiAobV9wYXRoLmNvbnRhaW5zKCJucHdyYXBwZXIuIikgfHwg bV9wYXRoLmNvbnRhaW5zKCJnbmFzaCIpKSB7CiAgICAgICAgIC8vIG5zcGx1Z2lud3JhcHBlciBy ZWxpZXMgb24gdGhlIHRvb2xraXQgdmFsdWUgdG8ga25vdyBpZiBnbGliIGlzIGF2YWlsYWJsZQog ICAgICAgICAvLyBJdCBkb2VzIHNvIGluIE5QX0luaXRpYWxpemUgd2l0aCBhIG51bGwgaW5zdGFu Y2UsIHRoZXJlZm9yZSBpdCBpcyBkb25lIHRoaXMgd2F5OgogICAgICAgICBtX2Jyb3dzZXJGdW5j cy5nZXR2YWx1ZSA9IHN0YXRpY1BsdWdpblF1aXJrUmVxdWlyZXNHdGtUb29sS2l0X05QTl9HZXRW YWx1ZTsK 97289 2011-06-15 06:58:50 -0700 2011-06-16 15:21:05 -0700 proposed patch v2 bug_62283.patch text/plain 1584 adawit Y29tbWl0IDNhNDY5OGUxYWJlYmJhM2I2NjBjMWY1ZjgxZTY5NDQxMWExYzdjNzcKQXV0aG9yOiBE YXdpdCBBbGVtYXllaHUgPGFkYXdpdEBrZGUub3JnPgpEYXRlOiAgIFdlZCBKdW4gOCAxMToxMzoz MCAyMDExIC0wNDAwCgogICAgU3VwcG9ydCBmb3IgZ25hc2ggZmxhc2ggcGxheWVyIHBsdWdpbiBp biBRdFdlYktpdAoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0NWYwNmQxLi45M2I5Yzk0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTEtMDYtMDggIERhd2l0IEFsZW1heWVodSAgPGFkYXdpdEBrZGUu b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN1 cHBvcnQgZm9yIGduYXNoIGZsYXNoIHBsYXllciBwbHVnaW4gaW4gUXRXZWJLaXQKKworICAgICAg ICBbUXRdIFN1cHBvcnQgZm9yIHRoZSBnbmFzaCBmbGFzaCBwbGF5ZXIgcGx1Z2luCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MjI4MworCisgICAgICAg IE5vIG5ldyB0ZXN0cyBuZWVkZWQuIEV4aXN0aW5nIG5zcGx1Z2luIHRlc3RzIGFyZSBzdWZmaWNp ZW50LgorCisgICAgICAgICogcGx1Z2lucy9xdC9QbHVnaW5QYWNrYWdlUXQuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UGx1Z2luUGFja2FnZTo6bG9hZCk6CisKIDIwMTEtMDYtMDUgIElnb3IgT2xp dmVpcmEgIDxpZ29yLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbHVnaW5zL3F0L1BsdWdpblBhY2thZ2VRdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5z L3F0L1BsdWdpblBhY2thZ2VRdC5jcHAKaW5kZXggMTk5NDFkNi4uZTk4MDQ0MCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5QYWNrYWdlUXQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1Z2luUGFja2FnZVF0LmNwcApAQCAtMTYyLDcgKzE2 Miw3IEBAIGJvb2wgUGx1Z2luUGFja2FnZTo6bG9hZCgpCiAKICAgICBpbml0aWFsaXplQnJvd3Nl ckZ1bmNzKCk7CiAKLSAgICBpZiAobV9wYXRoLmNvbnRhaW5zKCJucHdyYXBwZXIuIikpIHsKKyAg ICBpZiAobV9wYXRoLmNvbnRhaW5zKCJucHdyYXBwZXIuIikgfHwgbV9wYXRoLmNvbnRhaW5zKCJn bmFzaCIpKSB7CiAgICAgICAgIC8vIG5zcGx1Z2lud3JhcHBlciByZWxpZXMgb24gdGhlIHRvb2xr aXQgdmFsdWUgdG8ga25vdyBpZiBnbGliIGlzIGF2YWlsYWJsZQogICAgICAgICAvLyBJdCBkb2Vz IHNvIGluIE5QX0luaXRpYWxpemUgd2l0aCBhIG51bGwgaW5zdGFuY2UsIHRoZXJlZm9yZSBpdCBp cyBkb25lIHRoaXMgd2F5OgogICAgICAgICBtX2Jyb3dzZXJGdW5jcy5nZXR2YWx1ZSA9IHN0YXRp Y1BsdWdpblF1aXJrUmVxdWlyZXNHdGtUb29sS2l0X05QTl9HZXRWYWx1ZTsK