62266 2011-06-07 22:41:43 -0700 [EFL] remove adjusting codes for zoom's center coordinate 2011-06-08 09:16:17 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 enmi.lee webkit-unassigned antognolli+webkit gyuyoung.kim kenneth leandro lucas.de.marchi ryuan.choi sangseok.lim tonikitoo webkit.review.bot youngtaeck.song oldest_to_newest 417094 0 enmi.lee 2011-06-07 22:41:43 -0700 There are adjusting codes in the ewk_view_zoom_set and ewk_view_zoom_weak_set functions as follows: if (cx >= sd->view.w) cx = sd->view.w - 1; if (cy >= sd->view.h) cy = sd->view.h - 1; if (cx < 0) cx = 0; if (cy < 0) cy = 0; But, it is possible that the application developers don't want to limit the zoom's center coordinate to the viewport for implementing some effects. and center coordinate out of the viewport does not affect to the zoom operation. So, I think we'd better to leave zoom's center coordinate freely. 417097 1 96382 enmi.lee 2011-06-07 22:47:05 -0700 Created attachment 96382 Patch 417183 2 lucas.de.marchi 2011-06-08 05:39:51 -0700 CC'ing Antognolli, who wrote this part. 417215 3 antognolli+webkit 2011-06-08 06:59:41 -0700 (In reply to comment #1) > Created an attachment (id=96382) [details] > Patch Looks good to me. Actually, I thought this limit was already removed before. 417272 4 96382 tonikitoo 2011-06-08 09:05:38 -0700 Comment on attachment 96382 Patch rs=me 417279 5 96382 webkit.review.bot 2011-06-08 09:16:12 -0700 Comment on attachment 96382 Patch Clearing flags on attachment: 96382 Committed r88352: <http://trac.webkit.org/changeset/88352> 417280 6 webkit.review.bot 2011-06-08 09:16:17 -0700 All reviewed patches have been landed. Closing bug. 96382 2011-06-07 22:47:05 -0700 2011-06-08 09:16:11 -0700 Patch bug-62266-20110608144703.patch text/plain 2157 enmi.lee U3VidmVyc2lvbiBSZXZpc2lvbjogODgyOTcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCBhOWZjNjMyYjcy ZDI0MWZjNWYwNjc3MDgzMWE2ZmZjNjI2NzIwNmZkLi5kY2IyOTljNDZiNjg1ODk1ZmZkY2QxZDll YWNhYWFkNTBkNzcyYjJmIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEt MDYtMDcgIEV1bm1pIExlZSAgPGV1bm1pMTUubGVlQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIHJlbW92ZSBhZGp1c3Rp bmcgY29kZXMgZm9yIHpvb20ncyBjZW50ZXIgY29vcmRpbmF0ZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjIyNjYKKworICAgICAgICBJdCBpcyBwb3Nz aWJsZSB0aGF0IHRoZSBhcHBsaWNhdGlvbiBkZXZlbG9wZXJzIGRvbid0IHdhbnQgdG8gbGltaXQK KyAgICAgICAgem9vbSdzIGNlbnRlciBjb29yZGluYXRlIHRvIHRoZSB2aWV3cG9ydCBmb3IgaW1w bGVtZW50aW5nIHNvbWUgZWZmZWN0cworICAgICAgICBhbmQgY2VudGVyIGNvb3JkaW5hdGUgb3V0 IG9mIHRoZSB2aWV3cG9ydCBkb2VzIG5vdCBhZmZlY3QgdG8gdGhlIHpvb20gb3BlcmF0aW9uLgor ICAgICAgICBTbywgSXQgaXMgYmV0dGVyIHRvIGxlYXZlIHpvb20ncyBjZW50ZXIgY29vcmRpbmF0 ZSBmcmVlbHkuCisKKyAgICAgICAgKiBld2svZXdrX3ZpZXcuY3BwOgorICAgICAgICAoZXdrX3Zp ZXdfem9vbV9zZXQpOgorICAgICAgICAoZXdrX3ZpZXdfem9vbV93ZWFrX3NldCk6CisKIDIwMTEt MDYtMDcgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEFudG9uaW8gR29tZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAppbmRl eCAyYTU0ZDYxMGExZGY5ZTAwYmEzZmFiNzdhMGIwYmJhNmU4NjNlNGViLi5iNjRiNDhkOWE1NmMx ZjhhNjllNWYyODI2NDMyM2EwOWUxZTRkZTFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Vm bC9ld2svZXdrX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5j cHAKQEAgLTE4NzEsMTQgKzE4NzEsNiBAQCBFaW5hX0Jvb2wgZXdrX3ZpZXdfem9vbV9zZXQoRXZh c19PYmplY3QqIG8sIGZsb2F0IHpvb20sIEV2YXNfQ29vcmQgY3gsIEV2YXNfQ29vcgogICAgICAg ICByZXR1cm4gRUlOQV9GQUxTRTsKICAgICB9CiAKLSAgICBpZiAoY3ggPj0gc2QtPnZpZXcudykK LSAgICAgICAgY3ggPSBzZC0+dmlldy53IC0gMTsKLSAgICBpZiAoY3kgPj0gc2QtPnZpZXcuaCkK LSAgICAgICAgY3kgPSBzZC0+dmlldy5oIC0gMTsKLSAgICBpZiAoY3ggPCAwKQotICAgICAgICBj eCA9IDA7Ci0gICAgaWYgKGN5IDwgMCkKLSAgICAgICAgY3kgPSAwOwogICAgIF9ld2tfdmlld196 b29tX2FuaW1hdGVkX21hcmtfc3RvcChzZCk7CiAgICAgcmV0dXJuIHNkLT5hcGktPnpvb21fc2V0 KHNkLCB6b29tLCBjeCwgY3kpOwogfQpAQCAtMTk0OSwxNSArMTk0MSw2IEBAIEVpbmFfQm9vbCBl d2tfdmlld196b29tX3dlYWtfc2V0KEV2YXNfT2JqZWN0KiBvLCBmbG9hdCB6b29tLCBFdmFzX0Nv b3JkIGN4LCBFdmFzCiAgICAgICAgIHJldHVybiBFSU5BX0ZBTFNFOwogICAgIH0KIAotICAgIGlm IChjeCA+PSBzZC0+dmlldy53KQotICAgICAgICBjeCA9IHNkLT52aWV3LncgLSAxOwotICAgIGlm IChjeSA+PSBzZC0+dmlldy5oKQotICAgICAgICBjeSA9IHNkLT52aWV3LmggLSAxOwotICAgIGlm IChjeCA8IDApCi0gICAgICAgIGN4ID0gMDsKLSAgICBpZiAoY3kgPCAwKQotICAgICAgICBjeSA9 IDA7Ci0KICAgICBzZC0+YW5pbWF0ZWRfem9vbS56b29tLnN0YXJ0ID0gZXdrX2ZyYW1lX3pvb21f Z2V0KHNkLT5tYWluX2ZyYW1lKTsKICAgICBzZC0+YW5pbWF0ZWRfem9vbS56b29tLmVuZCA9IHpv b207CiAgICAgc2QtPmFuaW1hdGVkX3pvb20uem9vbS5jdXJyZW50ID0gem9vbTsK