62264 2011-06-07 22:02:35 -0700 reduce and reduceRight bind callback's this to null rather than undefined 2011-07-26 23:03:11 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Trivial --- 0 erights mhahnenberg erights mhahnenberg webkit.review.bot oldest_to_newest 417082 0 erights 2011-06-07 22:02:35 -0700 Both [2,3].reduce(function(){'use strict';return this;}) and [2,3].reduceRight(function(){'use strict';return this;}) return null rather than undefined. This violates step 9.c.ii of sections 15.4.4.21 and 15.4.4.22 of ES5.1. 417083 1 erights 2011-06-07 22:02:58 -0700 See http://code.google.com/p/v8/issues/detail?id=1436 441900 2 101921 mhahnenberg 2011-07-25 15:10:19 -0700 Created attachment 101921 Patch 442747 3 101921 webkit.review.bot 2011-07-26 23:03:07 -0700 Comment on attachment 101921 Patch Clearing flags on attachment: 101921 Committed r91824: <http://trac.webkit.org/changeset/91824> 442748 4 webkit.review.bot 2011-07-26 23:03:11 -0700 All reviewed patches have been landed. Closing bug. 101921 2011-07-25 15:10:19 -0700 2011-07-26 23:03:07 -0700 Patch bug-62264-20110725151019.patch text/plain 7129 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTE3MDcpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAK KzIwMTEtMDctMjUgIE1hcmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4KKwor ICAgICAgICByZWR1Y2UgYW5kIHJlZHVjZVJpZ2h0IGJpbmQgY2FsbGJhY2sncyB0aGlzIHRvIG51 bGwgcmF0aGVyIHRoYW4gdW5kZWZpbmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02MjI2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEZpeGVkIEFycmF5LnByb3RvdHlwZS5yZWR1Y2UgYW5kIEFycmF5LnBy b3RvdHlwZS5yZWR1Y2VSaWdodCBzbyB0aGF0IHRoZXkgYmVoYXZlIGNvcnJlY3RseQorICAgICAg ICB3aGVuIGNhbGxpbmcgdGhlIGNhbGxiYWNrIGZ1bmN0aW9uIHdpdGhvdXQgYW4gYXJndW1lbnQg Zm9yIHRoaXMsIHdoaWNoIG1lYW5zIGl0IHNob3VsZCAKKyAgICAgICAgYmUgdW5kZWZpbmVkIGFj Y29yZGluZyB0byBFUyAxNS40LjQuMjEgYW5kIDE1LjQuNC4yMi4KKworICAgICAgICAqIHJ1bnRp bWUvQXJyYXlQcm90b3R5cGUuY3BwOgorICAgICAgICAoSlNDOjphcnJheVByb3RvRnVuY1JlZHVj ZSk6CisgICAgICAgIChKU0M6OmFycmF5UHJvdG9GdW5jUmVkdWNlUmlnaHQpOgorCiAyMDExLTA3 LTI1ICBKb24gTGVlICA8am9ubGVlQGFwcGxlLmNvbT4KIAogICAgICAgICBBc3NlcnRpb24gY2Fs bGVkIGluIEV4ZWN1dGFibGVCYXNlOjpnZW5lcmF0ZWRKSVRDb2RlRm9yQ2FsbCgpIHdoZW4gSklU IGlzIG5vdCBhdmFpbGFibGUKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0Fy cmF5UHJvdG90eXBlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9BcnJheVByb3RvdHlwZS5jcHAJKHJldmlzaW9uIDkxNzAzKQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvQXJyYXlQcm90b3R5cGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05 ODEsNyArOTgxLDcgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBhcnJheVByb3RvRgog ICAgIGlmIChjYWxsVHlwZSA9PSBDYWxsVHlwZUpTICYmIGFycmF5KSB7CiAgICAgICAgIENhY2hl ZENhbGwgY2FjaGVkQ2FsbChleGVjLCBhc0Z1bmN0aW9uKGZ1bmN0aW9uKSwgNCk7CiAgICAgICAg IGZvciAoOyBpIDwgbGVuZ3RoICYmICFleGVjLT5oYWRFeGNlcHRpb24oKTsgKytpKSB7Ci0gICAg ICAgICAgICBjYWNoZWRDYWxsLnNldFRoaXMoanNOdWxsKCkpOworICAgICAgICAgICAgY2FjaGVk Q2FsbC5zZXRUaGlzKGpzVW5kZWZpbmVkKCkpOwogICAgICAgICAgICAgY2FjaGVkQ2FsbC5zZXRB cmd1bWVudCgwLCBydik7CiAgICAgICAgICAgICBKU1ZhbHVlIHY7CiAgICAgICAgICAgICBpZiAo TElLRUxZKGFycmF5LT5jYW5HZXRJbmRleChpKSkpCkBAIC0xMDEwLDcgKzEwMTAsNyBAQCBFbmNv ZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGFycmF5UHJvdG9GCiAgICAgICAgIGVhY2hBcmd1bWVu dHMuYXBwZW5kKGpzTnVtYmVyKGkpKTsKICAgICAgICAgZWFjaEFyZ3VtZW50cy5hcHBlbmQodGhp c09iaik7CiAgICAgICAgIAotICAgICAgICBydiA9IGNhbGwoZXhlYywgZnVuY3Rpb24sIGNhbGxU eXBlLCBjYWxsRGF0YSwganNOdWxsKCksIGVhY2hBcmd1bWVudHMpOworICAgICAgICBydiA9IGNh bGwoZXhlYywgZnVuY3Rpb24sIGNhbGxUeXBlLCBjYWxsRGF0YSwganNVbmRlZmluZWQoKSwgZWFj aEFyZ3VtZW50cyk7CiAgICAgfQogICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUocnYpOwogfQpA QCAtMTA1Nyw3ICsxMDU3LDcgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBhcnJheVBy b3RvRgogICAgICAgICBDYWNoZWRDYWxsIGNhY2hlZENhbGwoZXhlYywgYXNGdW5jdGlvbihmdW5j dGlvbiksIDQpOwogICAgICAgICBmb3IgKDsgaSA8IGxlbmd0aCAmJiAhZXhlYy0+aGFkRXhjZXB0 aW9uKCk7ICsraSkgewogICAgICAgICAgICAgdW5zaWduZWQgaWR4ID0gbGVuZ3RoIC0gaSAtIDE7 Ci0gICAgICAgICAgICBjYWNoZWRDYWxsLnNldFRoaXMoanNOdWxsKCkpOworICAgICAgICAgICAg Y2FjaGVkQ2FsbC5zZXRUaGlzKGpzVW5kZWZpbmVkKCkpOwogICAgICAgICAgICAgY2FjaGVkQ2Fs bC5zZXRBcmd1bWVudCgwLCBydik7CiAgICAgICAgICAgICBpZiAoVU5MSUtFTFkoIWFycmF5LT5j YW5HZXRJbmRleChpZHgpKSkKICAgICAgICAgICAgICAgICBicmVhazsgLy8gbGVuZ3RoIGhhcyBi ZWVuIG1hZGUgdW5zYWZlIHdoaWxlIHdlIGVudW1lcmF0ZSBmYWxsYmFjayB0byBzbG93IHBhdGgK QEAgLTEwODQsNyArMTA4NCw3IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgYXJyYXlQ cm90b0YKICAgICAgICAgZWFjaEFyZ3VtZW50cy5hcHBlbmQoanNOdW1iZXIoaWR4KSk7CiAgICAg ICAgIGVhY2hBcmd1bWVudHMuYXBwZW5kKHRoaXNPYmopOwogICAgICAgICAKLSAgICAgICAgcnYg PSBjYWxsKGV4ZWMsIGZ1bmN0aW9uLCBjYWxsVHlwZSwgY2FsbERhdGEsIGpzTnVsbCgpLCBlYWNo QXJndW1lbnRzKTsKKyAgICAgICAgcnYgPSBjYWxsKGV4ZWMsIGZ1bmN0aW9uLCBjYWxsVHlwZSwg Y2FsbERhdGEsIGpzVW5kZWZpbmVkKCksIGVhY2hBcmd1bWVudHMpOwogICAgIH0KICAgICByZXR1 cm4gSlNWYWx1ZTo6ZW5jb2RlKHJ2KTsgICAgICAgIAogfQpJbmRleDogTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gOTE3 MDcpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx OSBAQAorMjAxMS0wNy0yNSAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29t PgorCisgICAgICAgIHJlZHVjZSBhbmQgcmVkdWNlUmlnaHQgYmluZCBjYWxsYmFjaydzIHRoaXMg dG8gbnVsbCByYXRoZXIgdGhhbiB1bmRlZmluZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTYyMjY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgYWRkaXRpb25hbCB0ZXN0cyB0byB0ZXN0IEFycmF5 LnByb3RvdHlwZS5yZWR1Y2UgYW5kIEFycmF5LnByb3RvdHlwZS5yZWR1Y2VSaWdodAorICAgICAg ICB3aGVuIGNhbGxpbmcgdGhlIGNhbGxiYWNrIGZ1bmN0aW9uIHdpdGhvdXQgYW4gYXJndW1lbnQg Zm9yIHRoaXMsIHdoaWNoIG1lYW5zIGl0IHNob3VsZCAKKyAgICAgICAgYmUgdW5kZWZpbmVkIGFj Y29yZGluZyB0byBFUyAxNS40LjQuMjEgYW5kIDE1LjQuNC4yMi4KKworICAgICAgICAqIGZhc3Qv anMvYXJyYXktcmVkdWNlLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2pzL2FycmF5LXJl ZHVjZVJpZ2h0LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2pzL3NjcmlwdC10ZXN0cy9h cnJheS1yZWR1Y2UuanM6CisgICAgICAgICogZmFzdC9qcy9zY3JpcHQtdGVzdHMvYXJyYXktcmVk dWNlUmlnaHQuanM6CisKIDIwMTEtMDYtMDcgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBp Z2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEd1c3Rhdm8gTm9yb25oYSBTaWx2YS4K SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvanMvYXJyYXktcmVkdWNlLWV4cGVjdGVkLnR4dAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2pzL2FycmF5LXJlZHVjZS1leHBlY3RlZC50eHQJ KHJldmlzaW9uIDkxNzAzKQorKysgTGF5b3V0VGVzdHMvZmFzdC9qcy9hcnJheS1yZWR1Y2UtZXhw ZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0zMyw2ICszMyw3IEBAIFBBU1MgdG9PYmplY3Qo WzAsMSwyLDMsNCw1XSkucmVkdWNlKGZ1bmMKIFBBU1MgdG9Vbm9yZGVyZWRPYmplY3QoW1swLDFd LCBbMiwzXSwgWzQsNV1dKS5yZWR1Y2UoZnVuY3Rpb24oYSxiKSB7cmV0dXJuIGEuY29uY2F0KGIp O30sIFtdKSBpcyBbMCwxLDIsMyw0LDVdCiBQQVNTIHRvVW5vcmRlcmVkT2JqZWN0KFswLDEsMiwz LDQsNV0pLnJlZHVjZShmdW5jdGlvbihhLGIsaSkge3JldHVybiBhLmNvbmNhdChbaSxiXSk7fSwg W10pIGlzIFswLDAsMSwxLDIsMiwzLDMsNCw0LDUsNV0KIFBBU1MgWzAsMSwyLDMsNCw1XS5yZWR1 Y2UoZnVuY3Rpb24oYSxiLGkpIHtyZXR1cm4gYS5jb25jYXQoW2ksYl0pO30sIFtdKSBpcyBbMCww LDEsMSwyLDIsMywzLDQsNCw1LDVdCitQQVNTIFsyLDNdLnJlZHVjZShmdW5jdGlvbigpIHsndXNl IHN0cmljdCc7IHJldHVybiB0aGlzO30pIGlzIHVuZGVmaW5lZAogUEFTUyBzdWNjZXNzZnVsbHlQ YXJzZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pz L2FycmF5LXJlZHVjZVJpZ2h0LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9mYXN0L2pzL2FycmF5LXJlZHVjZVJpZ2h0LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gOTE3MDMp CisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL2FycmF5LXJlZHVjZVJpZ2h0LWV4cGVjdGVkLnR4dAko d29ya2luZyBjb3B5KQpAQCAtMzQsNiArMzQsNyBAQCBQQVNTIHRvT2JqZWN0KFswLDEsMiwzLDQs NV0pLnJlZHVjZVJpZ2h0CiBQQVNTIHRvVW5vcmRlcmVkT2JqZWN0KFtbMCwxXSwgWzIsM10sIFs0 LDVdXSkucmVkdWNlUmlnaHQoZnVuY3Rpb24oYSxiKSB7cmV0dXJuIGEuY29uY2F0KGIpO30sIFtd KSBpcyBbNCw1LDIsMywwLDFdCiBQQVNTIHRvVW5vcmRlcmVkT2JqZWN0KFswLDEsMiwzLDQsNV0p LnJlZHVjZVJpZ2h0KGZ1bmN0aW9uKGEsYixpKSB7cmV0dXJuIGEuY29uY2F0KFtpLGJdKTt9LCBb XSkgaXMgWzUsNSw0LDQsMywzLDIsMiwxLDEsMCwwXQogUEFTUyBbMCwxLDIsMyw0LDVdLnJlZHVj ZVJpZ2h0KGZ1bmN0aW9uKGEsYixpKSB7cmV0dXJuIGEuY29uY2F0KFtpLGJdKTt9LCBbXSkgaXMg WzUsNSw0LDQsMywzLDIsMiwxLDEsMCwwXQorUEFTUyBbMiwzXS5yZWR1Y2VSaWdodChmdW5jdGlv bigpIHsndXNlIHN0cmljdCc7IHJldHVybiB0aGlzO30pIGlzIHVuZGVmaW5lZAogUEFTUyBzdWNj ZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCkluZGV4OiBMYXlvdXRUZXN0 cy9mYXN0L2pzL3NjcmlwdC10ZXN0cy9hcnJheS1yZWR1Y2UuanMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvYXJyYXktcmVkdWNlLmpzCShyZXZpc2lvbiA5 MTcwMykKKysrIExheW91dFRlc3RzL2Zhc3QvanMvc2NyaXB0LXRlc3RzL2FycmF5LXJlZHVjZS5q cwkod29ya2luZyBjb3B5KQpAQCAtNjUsNCArNjUsNSBAQCBzaG91bGRCZSgidG9PYmplY3QoWzAs MSwyLDMsNCw1XSkucmVkdWNlCiBzaG91bGRCZSgidG9Vbm9yZGVyZWRPYmplY3QoW1swLDFdLCBb MiwzXSwgWzQsNV1dKS5yZWR1Y2UoZnVuY3Rpb24oYSxiKSB7cmV0dXJuIGEuY29uY2F0KGIpO30s IFtdKSIsICJbMCwxLDIsMyw0LDVdIik7CiBzaG91bGRCZSgidG9Vbm9yZGVyZWRPYmplY3QoWzAs MSwyLDMsNCw1XSkucmVkdWNlKGZ1bmN0aW9uKGEsYixpKSB7cmV0dXJuIGEuY29uY2F0KFtpLGJd KTt9LCBbXSkiLCAiWzAsMCwxLDEsMiwyLDMsMyw0LDQsNSw1XSIpOwogc2hvdWxkQmUoIlswLDEs MiwzLDQsNV0ucmVkdWNlKGZ1bmN0aW9uKGEsYixpKSB7cmV0dXJuIGEuY29uY2F0KFtpLGJdKTt9 LCBbXSkiLCAiWzAsMCwxLDEsMiwyLDMsMyw0LDQsNSw1XSIpOworc2hvdWxkQmUoIlsyLDNdLnJl ZHVjZShmdW5jdGlvbigpIHsndXNlIHN0cmljdCc7IHJldHVybiB0aGlzO30pIiwgInVuZGVmaW5l ZCIpOwogc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qv anMvc2NyaXB0LXRlc3RzL2FycmF5LXJlZHVjZVJpZ2h0LmpzCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL2Zhc3QvanMvc2NyaXB0LXRlc3RzL2FycmF5LXJlZHVjZVJpZ2h0LmpzCShyZXZpc2lv biA5MTcwMykKKysrIExheW91dFRlc3RzL2Zhc3QvanMvc2NyaXB0LXRlc3RzL2FycmF5LXJlZHVj ZVJpZ2h0LmpzCSh3b3JraW5nIGNvcHkpCkBAIC02Nyw0ICs2Nyw1IEBAIHNob3VsZEJlKCJ0b09i amVjdChbMCwxLDIsMyw0LDVdKS5yZWR1Y2UKIHNob3VsZEJlKCJ0b1Vub3JkZXJlZE9iamVjdChb WzAsMV0sIFsyLDNdLCBbNCw1XV0pLnJlZHVjZVJpZ2h0KGZ1bmN0aW9uKGEsYikge3JldHVybiBh LmNvbmNhdChiKTt9LCBbXSkiLCAiWzQsNSwyLDMsMCwxXSIpOwogc2hvdWxkQmUoInRvVW5vcmRl cmVkT2JqZWN0KFswLDEsMiwzLDQsNV0pLnJlZHVjZVJpZ2h0KGZ1bmN0aW9uKGEsYixpKSB7cmV0 dXJuIGEuY29uY2F0KFtpLGJdKTt9LCBbXSkiLCAiWzUsNSw0LDQsMywzLDIsMiwxLDEsMCwwXSIp Owogc2hvdWxkQmUoIlswLDEsMiwzLDQsNV0ucmVkdWNlUmlnaHQoZnVuY3Rpb24oYSxiLGkpIHty ZXR1cm4gYS5jb25jYXQoW2ksYl0pO30sIFtdKSIsICJbNSw1LDQsNCwzLDMsMiwyLDEsMSwwLDBd Iik7CitzaG91bGRCZSgiWzIsM10ucmVkdWNlUmlnaHQoZnVuY3Rpb24oKSB7J3VzZSBzdHJpY3Qn OyByZXR1cm4gdGhpczt9KSIsICJ1bmRlZmluZWQiKTsKIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRy dWU7Cg==