62258 2011-06-07 19:30:36 -0700 (CG) Sub-image drawing clips unnecessarily 2011-06-07 22:33:06 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED P2 Normal --- 0 ian webkit-unassigned koz mitz simon.fraser webkit.review.bot oldest_to_newest 417022 0 ian 2011-06-07 19:30:36 -0700 When drawing sub-images in BitmapImage::draw, we clip to destRect, then draw into adjustedDestRect. If they're the same, we could avoid clipping and just draw the image. 417026 1 ian 2011-06-07 19:31:54 -0700 rdar://problem/9567167 417047 2 96366 ian 2011-06-07 20:06:52 -0700 Created attachment 96366 proposed patch 417051 3 96366 webkit.review.bot 2011-06-07 20:31:38 -0700 Comment on attachment 96366 proposed patch Clearing flags on attachment: 96366 Committed r88321: <http://trac.webkit.org/changeset/88321> 417052 4 webkit.review.bot 2011-06-07 20:31:42 -0700 All reviewed patches have been landed. Closing bug. 417092 5 koz 2011-06-07 22:33:06 -0700 I think this caused some pixel changes for SnowLeopard. The changes seemed fine to me so I commit them in r88325 if you wanted to verify. 96366 2011-06-07 20:06:52 -0700 2011-06-07 20:31:38 -0700 proposed patch 62258-1.patch text/plain 1442 ian SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4MzE4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDYtMDcgIElhbiBIZW5k ZXJzb24gIDxpYW5oQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAoQ0cpIFN1Yi1pbWFnZSBkcmF3aW5nIGNsaXBzIHVubmVjZXNzYXJp bHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyMjU4 CisKKyAgICAgICAgSWYgZGVzdFJlY3QgY29tcGxldGVseSBlbmNvbXBhc3NlcyB0aGUgYWRqdXN0 ZWREZXN0UmVjdCBpbnRvIHdoaWNoIHdlCisgICAgICAgIGRyYXcsIGNsaXBwaW5nIHRvIGRlc3RS ZWN0IHdpbGwgZG8gbm90aGluZy4gIFNraXAgdGhlIGNhbGwgdG8KKyAgICAgICAgQ0dDb250ZXh0 Q2xpcFRvUmVjdCBpbiB0aGlzIGNhc2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9j Zy9JbWFnZUNHLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkJpdG1hcEltYWdlOjpkcmF3KToKKwog MjAxMS0wNi0wNyAgWWkgU2hlbiAgPHlpLjQuc2hlbkBub2tpYS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jZy9JbWFnZUNHLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUNHLmNwcAkocmV2aXNpb24gODgzMTYpCisrKyBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUNHLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMjQxLDcgKzI0MSw4IEBACiAgICAgICAgICAgICBhZGp1c3RlZERlc3RSZWN0LnNldFNpemUo RmxvYXRTaXplKHNlbGZTaXplLndpZHRoKCkgLyB4U2NhbGUsIHNlbGZTaXplLmhlaWdodCgpIC8g eVNjYWxlKSk7CiAgICAgICAgIH0KIAotICAgICAgICBDR0NvbnRleHRDbGlwVG9SZWN0KGNvbnRl eHQsIGRlc3RSZWN0KTsKKyAgICAgICAgaWYgKCFkZXN0UmVjdC5jb250YWlucyhhZGp1c3RlZERl c3RSZWN0KSkKKyAgICAgICAgICAgIENHQ29udGV4dENsaXBUb1JlY3QoY29udGV4dCwgZGVzdFJl Y3QpOwogICAgIH0KIAogICAgIC8vIElmIHRoZSBpbWFnZSBpcyBvbmx5IHBhcnRpYWxseSBsb2Fk ZWQsIHRoZW4gc2hyaW5rIHRoZSBkZXN0aW5hdGlvbiByZWN0IHRoYXQgd2UncmUgZHJhd2luZyBp bnRvIGFjY29yZGluZ2x5Lgo=