62241 2011-06-07 15:32:12 -0700 rebaseline-chromium-webkit-tests: fix baselining order for linux, linux_x86_64 2011-06-07 16:22:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke ojan simonjam tony oldest_to_newest 416849 0 dpranke 2011-06-07 15:32:12 -0700 rebaseline-chromium-webkit-tests: fix baselining order for linux, linux_x86_64 416850 1 96315 dpranke 2011-06-07 15:33:54 -0700 Created attachment 96315 Patch 416853 2 dpranke 2011-06-07 15:35:29 -0700 When we made the 64-bit port the "generic" chromium-linux port, we forgot to switch the ordering of the ports in port.ALL_BASELINE_VARIANTS, which is used by rebaseline-chromium-webkit-tests to figure out which baselines to pull in which order. Without this change, we'd end up generating duplicate baselines for both linux variants and they wouldn't get deduped. 416854 3 96315 tony 2011-06-07 15:36:28 -0700 Comment on attachment 96315 Patch Can we write a test for this? 416868 4 dpranke 2011-06-07 15:45:26 -0700 (In reply to comment #3) > (From update of attachment 96315 [details]) > Can we write a test for this? It depends. what would you want to test? The _unittest file does test that, for example, if the Vista dir duplicates the Win dir, then deduping works, so there is already a test for the deduping logic by itself. But, if you wanted to test that the linux 32 port was deduped into the base linux port, all it would be testing was that the ports were listed in the right order in the same constant, creating another place to update if we change the order. 416876 5 tony 2011-06-07 15:55:38 -0700 (In reply to comment #4) > But, if you wanted to test that the linux 32 port was deduped into the base linux port, all it would be testing was that the ports were listed in the right order in the same constant, creating another place to update if we change the order. Yes, I think that would be valuable. 416900 6 dpranke 2011-06-07 16:20:10 -0700 (In reply to comment #5) > (In reply to comment #4) > > But, if you wanted to test that the linux 32 port was deduped into the base linux port, all it would be testing was that the ports were listed in the right order in the same constant, creating another place to update if we change the order. > > Yes, I think that would be valuable. Well, you would have had to know to change the test and change the list when you made your actual change. Since you missed the one place, you probably would've missed the other, so I don't think the test would've actually caught anything. More generally, if you wanted to test this particular case, presumably you'd test that all of the other deduping works as you'd expect (e.g., xp dups vista, etc.). That seems like a lot of work for little reward. 416903 7 96315 dpranke 2011-06-07 16:22:02 -0700 Comment on attachment 96315 Patch Clearing flags on attachment: 96315 Committed r88281: <http://trac.webkit.org/changeset/88281> 416904 8 dpranke 2011-06-07 16:22:05 -0700 All reviewed patches have been landed. Closing bug. 96315 2011-06-07 15:33:54 -0700 2011-06-07 16:22:02 -0700 Patch bug-62241-20110607153353.patch text/plain 1416 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogODgxODYKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3OTdiNzg0Mzg1Zjk2YWMyYTAyNTJhMDkyN2Q5YjViYmI4 ZDIwYzg4Li4zYWQ0MjE3YzIzYWFiNmQ4NGY3ZDQ0ODI4YWMxMjZiZjE3MGYxZDE1IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDYtMDcgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcmViYXNlbGluZS1j aHJvbWl1bS13ZWJraXQtdGVzdHM6IGZpeCBiYXNlbGluaW5nIG9yZGVyIGZvciBsaW51eCwgbGlu dXhfeDg2XzY0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02MjI0MQorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9j aHJvbWl1bS5weToKKwogMjAxMS0wNi0wNiAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGln YWxpYS5jb20+CiAKICAgICAgICAgRml4IHRoZSBHVEsrIGJ1aWxkIGJ5IGVuc3VyaW5nIHRoYXQg dGhlIGF1dG9nZW5lcmF0ZWQgc291cmNlcwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkKaW5kZXggNjlkZWI5NmFhNzM0MDFjZGQw OTJiNDQ0NDFiM2QxZjk2MzllNjkwZS4uYThkOWU4MmRhYzU4MzA2NDA0NjdlNTlmNGYyOTRlODhm MTU5YTRmOSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC9jaHJvbWl1bS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9wb3J0L2Nocm9taXVtLnB5CkBAIC01OCw3ICs1OCw3IEBAIGNsYXNzIENocm9taXVtUG9ydChi YXNlLlBvcnQpOgogICAgIEFMTF9CQVNFTElORV9WQVJJQU5UUyA9IFsKICAgICAgICAgJ2Nocm9t aXVtLW1hYy1zbm93bGVvcGFyZCcsICdjaHJvbWl1bS1tYWMtbGVvcGFyZCcsCiAgICAgICAgICdj aHJvbWl1bS13aW4td2luNycsICdjaHJvbWl1bS13aW4tdmlzdGEnLCAnY2hyb21pdW0td2luLXhw JywKLSAgICAgICAgJ2Nocm9taXVtLWxpbnV4LXg4NicsICdjaHJvbWl1bS1saW51eC14ODZfNjQn LAorICAgICAgICAnY2hyb21pdW0tbGludXgteDg2XzY0JywgJ2Nocm9taXVtLWxpbnV4LXg4Nics CiAgICAgICAgICdjaHJvbWl1bS1ncHUtbWFjLXNub3dsZW9wYXJkJywgJ2Nocm9taXVtLWdwdS13 aW4td2luNycsICdjaHJvbWl1bS1ncHUtbGludXgteDg2XzY0JywKICAgICBdCiAK