62239 2011-06-07 15:26:35 -0700 V8NodeFilterCondition should use OwnHandle 2011-10-13 15:50:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 62193 1 abarth abarth antonm dglazkov eric levin webkit.review.bot yurys oldest_to_newest 416842 0 abarth 2011-06-07 15:26:35 -0700 V8NodeFilterCondition should use OwnHandle 416843 1 96313 abarth 2011-06-07 15:27:07 -0700 Created attachment 96313 Patch 416917 2 96313 eric 2011-06-07 16:31:26 -0700 Comment on attachment 96313 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96313&action=review > Source/WebCore/bindings/v8/V8NodeFilterCondition.cpp:63 > + if (!m_filter.get()->IsObject()) Why don't we override -> on OwnHandle like we do for our other smartpointers? 416987 3 abarth 2011-06-07 18:07:45 -0700 (In reply to comment #2) > (From update of attachment 96313 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=96313&action=review > > > Source/WebCore/bindings/v8/V8NodeFilterCondition.cpp:63 > > + if (!m_filter.get()->IsObject()) > > Why don't we override -> on OwnHandle like we do for our other smartpointers? We could. It's a little confusing because v8::Handle has a bunch of APIs that you access with "." that are useful too. 419612 4 abarth 2011-06-13 09:57:27 -0700 Adding some potential reviewers. 419613 5 abarth 2011-06-13 09:59:50 -0700 Thank you sir. 419641 6 96313 webkit.review.bot 2011-06-13 10:33:29 -0700 Comment on attachment 96313 Patch Rejecting attachment 96313 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2 Last 500 characters of output: Source/WebCore/bindings/v8/V8GCController.h:72: note: candidates are: static void WebCore::V8GCController::unregisterGlobalHandle(void*, v8::Persistent<v8::Value>) CXX(target) out/Debug/obj.target/webcore_remaining/Source/WebCore/bindings/v8/V8Proxy.o CXX(target) out/Debug/obj.target/webcore_remaining/Source/WebCore/bindings/v8/V8Utilities.o make: *** [out/Debug/obj.target/webcore_remaining/Source/WebCore/bindings/v8/V8NodeFilterCondition.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/8833496 425469 7 98216 abarth 2011-06-22 12:35:07 -0700 Created attachment 98216 Patch for landing 425725 8 98216 webkit.review.bot 2011-06-22 16:35:34 -0700 Comment on attachment 98216 Patch for landing Rejecting attachment 98216 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2 Last 500 characters of output: lHandle(WebCore::V8NodeFilterCondition* const, v8::Handle<v8::Value>)' Source/WebCore/bindings/v8/V8GCController.h:72: note: candidates are: static void WebCore::V8GCController::unregisterGlobalHandle(void*, v8::Persistent<v8::Value>) CXX(target) out/Debug/obj.target/webcore_remaining/Source/WebCore/bindings/v8/custom/V8WebKitAnimationCustom.o make: *** [out/Debug/obj.target/webcore_remaining/Source/WebCore/bindings/v8/V8NodeFilterCondition.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/8921858 96313 2011-06-07 15:27:07 -0700 2011-06-22 12:34:57 -0700 Patch bug-62239-20110607152706.patch text/plain 3332 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4MjczKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDYtMDcgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBWOE5vZGVGaWx0ZXJDb25kaXRpb24gc2hvdWxkIHVzZSBPd25IYW5k bGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyMjM5 CisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOE5vZGVGaWx0ZXJDb25kaXRpb24uY3BwOgorICAg ICAgICAoV2ViQ29yZTo6VjhOb2RlRmlsdGVyQ29uZGl0aW9uOjpWOE5vZGVGaWx0ZXJDb25kaXRp b24pOgorICAgICAgICAoV2ViQ29yZTo6VjhOb2RlRmlsdGVyQ29uZGl0aW9uOjp+VjhOb2RlRmls dGVyQ29uZGl0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OlY4Tm9kZUZpbHRlckNvbmRpdGlvbjo6 YWNjZXB0Tm9kZSk6CisgICAgICAgICogYmluZGluZ3MvdjgvVjhOb2RlRmlsdGVyQ29uZGl0aW9u Lmg6CisKIDIwMTEtMDYtMDcgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI4ODIyMSwgcjg4MjI0LCBh bmQgcjg4MjMxLgpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhOb2RlRmlsdGVy Q29uZGl0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9W OE5vZGVGaWx0ZXJDb25kaXRpb24uY3BwCShyZXZpc2lvbiA4ODI2NykKKysrIFNvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4Tm9kZUZpbHRlckNvbmRpdGlvbi5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTQyLDM2ICs0MiwzNCBAQAogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBWOE5vZGVGaWx0ZXJD b25kaXRpb246OlY4Tm9kZUZpbHRlckNvbmRpdGlvbih2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gZmls dGVyKQotICAgIDogbV9maWx0ZXIodjg6OlBlcnNpc3RlbnQ8djg6OlZhbHVlPjo6TmV3KGZpbHRl cikpCisgICAgOiBtX2ZpbHRlcihmaWx0ZXIpCiB7CiAjaWZuZGVmIE5ERUJVRwotICAgIFY4R0ND b250cm9sbGVyOjpyZWdpc3Rlckdsb2JhbEhhbmRsZShOT0RFX0ZJTFRFUiwgdGhpcywgbV9maWx0 ZXIpOworICAgIFY4R0NDb250cm9sbGVyOjpyZWdpc3Rlckdsb2JhbEhhbmRsZShOT0RFX0ZJTFRF UiwgdGhpcywgbV9maWx0ZXIuZ2V0KCkpOwogI2VuZGlmCiB9CiAKIFY4Tm9kZUZpbHRlckNvbmRp dGlvbjo6flY4Tm9kZUZpbHRlckNvbmRpdGlvbigpCiB7CiAjaWZuZGVmIE5ERUJVRwotICAgIFY4 R0NDb250cm9sbGVyOjp1bnJlZ2lzdGVyR2xvYmFsSGFuZGxlKHRoaXMsIG1fZmlsdGVyKTsKKyAg ICBWOEdDQ29udHJvbGxlcjo6dW5yZWdpc3Rlckdsb2JhbEhhbmRsZSh0aGlzLCBtX2ZpbHRlci5n ZXQoKSk7CiAjZW5kaWYKLSAgICBtX2ZpbHRlci5EaXNwb3NlKCk7Ci0gICAgbV9maWx0ZXIuQ2xl YXIoKTsKIH0KIAogc2hvcnQgVjhOb2RlRmlsdGVyQ29uZGl0aW9uOjphY2NlcHROb2RlKFNjcmlw dFN0YXRlKiBzdGF0ZSwgTm9kZSogbm9kZSkgY29uc3QKIHsKICAgICBBU1NFUlQodjg6OkNvbnRl eHQ6OkluQ29udGV4dCgpKTsKIAotICAgIGlmICghbV9maWx0ZXItPklzT2JqZWN0KCkpCisgICAg aWYgKCFtX2ZpbHRlci5nZXQoKS0+SXNPYmplY3QoKSkKICAgICAgICAgcmV0dXJuIE5vZGVGaWx0 ZXI6OkZJTFRFUl9BQ0NFUFQ7CiAKICAgICB2ODo6VHJ5Q2F0Y2ggZXhjZXB0aW9uQ2F0Y2hlcjsK IAogICAgIHY4OjpIYW5kbGU8djg6OkZ1bmN0aW9uPiBjYWxsYmFjazsKLSAgICBpZiAobV9maWx0 ZXItPklzRnVuY3Rpb24oKSkKLSAgICAgICAgY2FsbGJhY2sgPSB2ODo6SGFuZGxlPHY4OjpGdW5j dGlvbj46OkNhc3QobV9maWx0ZXIpOworICAgIGlmIChtX2ZpbHRlci5nZXQoKS0+SXNGdW5jdGlv bigpKQorICAgICAgICBjYWxsYmFjayA9IHY4OjpIYW5kbGU8djg6OkZ1bmN0aW9uPjo6Q2FzdCht X2ZpbHRlci5nZXQoKSk7CiAgICAgZWxzZSB7Ci0gICAgICAgIHY4OjpMb2NhbDx2ODo6VmFsdWU+ IHZhbHVlID0gbV9maWx0ZXItPlRvT2JqZWN0KCktPkdldCh2ODo6U3RyaW5nOjpOZXcoImFjY2Vw dE5vZGUiKSk7CisgICAgICAgIHY4OjpMb2NhbDx2ODo6VmFsdWU+IHZhbHVlID0gbV9maWx0ZXIu Z2V0KCktPlRvT2JqZWN0KCktPkdldCh2ODo6U3RyaW5nOjpOZXcoImFjY2VwdE5vZGUiKSk7CiAg ICAgICAgIGlmICghdmFsdWUtPklzRnVuY3Rpb24oKSkgewogICAgICAgICAgICAgVjhQcm94eTo6 dGhyb3dFcnJvcihWOFByb3h5OjpUeXBlRXJyb3IsICJOb2RlRmlsdGVyIG9iamVjdCBkb2VzIG5v dCBoYXZlIGFuIGFjY2VwdE5vZGUgZnVuY3Rpb24iKTsKICAgICAgICAgICAgIHJldHVybiBOb2Rl RmlsdGVyOjpGSUxURVJfUkVKRUNUOwpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv VjhOb2RlRmlsdGVyQ29uZGl0aW9uLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvVjhOb2RlRmlsdGVyQ29uZGl0aW9uLmgJKHJldmlzaW9uIDg4MjY3KQorKysgU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhOb2RlRmlsdGVyQ29uZGl0aW9uLmgJKHdvcmtpbmcg Y29weSkKQEAgLTMyLDYgKzMyLDcgQEAKICNkZWZpbmUgVjhOb2RlRmlsdGVyQ29uZGl0aW9uX2gK IAogI2luY2x1ZGUgIk5vZGVGaWx0ZXJDb25kaXRpb24uaCIKKyNpbmNsdWRlICJPd25IYW5kbGUu aCIKICNpbmNsdWRlIDx2OC5oPgogI2luY2x1ZGUgPHd0Zi9QYXNzUmVmUHRyLmg+CiAKQEAgLTU2 LDcgKzU3LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIHByaXZhdGU6CiAgICAgICAgIGV4 cGxpY2l0IFY4Tm9kZUZpbHRlckNvbmRpdGlvbih2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gZmlsdGVy KTsKIAotICAgICAgICBtdXRhYmxlIHY4OjpQZXJzaXN0ZW50PHY4OjpWYWx1ZT4gbV9maWx0ZXI7 CisgICAgICAgIG11dGFibGUgT3duSGFuZGxlPHY4OjpWYWx1ZT4gbV9maWx0ZXI7CiAgICAgfTsK IAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo= 98216 2011-06-22 12:35:07 -0700 2011-06-22 16:35:33 -0700 Patch for landing bug-62239-20110622123506.patch text/plain 4414 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5NDU1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDYtMjIgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEds YXprb3YuCisKKyAgICAgICAgVjhOb2RlRmlsdGVyQ29uZGl0aW9uIHNob3VsZCB1c2UgT3duSGFu ZGxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MjIz OQorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhOb2RlRmlsdGVyQ29uZGl0aW9uLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlY4Tm9kZUZpbHRlckNvbmRpdGlvbjo6VjhOb2RlRmlsdGVyQ29uZGl0 aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OlY4Tm9kZUZpbHRlckNvbmRpdGlvbjo6flY4Tm9kZUZp bHRlckNvbmRpdGlvbik6CisgICAgICAgIChXZWJDb3JlOjpWOE5vZGVGaWx0ZXJDb25kaXRpb246 OmFjY2VwdE5vZGUpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4Tm9kZUZpbHRlckNvbmRpdGlv bi5oOgorCiAyMDExLTA2LTIyICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgQXR0ZW1wdCB0byBmaXggdGhlIEdUSyBidWlsZCBhZnRlciBteSBpbmNvbXBsZXRlIHJv bGxvdXQgb2YgODgzMzIuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOE5vZGVG aWx0ZXJDb25kaXRpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L1Y4Tm9kZUZpbHRlckNvbmRpdGlvbi5jcHAJKHJldmlzaW9uIDg5NDU0KQorKysgU291cmNl L1dlYkNvcmUvYmluZGluZ3MvdjgvVjhOb2RlRmlsdGVyQ29uZGl0aW9uLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNDIsMzYgKzQyLDM0IEBACiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIFY4Tm9kZUZp bHRlckNvbmRpdGlvbjo6VjhOb2RlRmlsdGVyQ29uZGl0aW9uKHY4OjpIYW5kbGU8djg6OlZhbHVl PiBmaWx0ZXIpCi0gICAgOiBtX2ZpbHRlcih2ODo6UGVyc2lzdGVudDx2ODo6VmFsdWU+OjpOZXco ZmlsdGVyKSkKKyAgICA6IG1fZmlsdGVyKGZpbHRlcikKIHsKICNpZm5kZWYgTkRFQlVHCi0gICAg VjhHQ0NvbnRyb2xsZXI6OnJlZ2lzdGVyR2xvYmFsSGFuZGxlKE5PREVfRklMVEVSLCB0aGlzLCBt X2ZpbHRlcik7CisgICAgVjhHQ0NvbnRyb2xsZXI6OnJlZ2lzdGVyR2xvYmFsSGFuZGxlKE5PREVf RklMVEVSLCB0aGlzLCBtX2ZpbHRlci5nZXQoKSk7CiAjZW5kaWYKIH0KIAogVjhOb2RlRmlsdGVy Q29uZGl0aW9uOjp+VjhOb2RlRmlsdGVyQ29uZGl0aW9uKCkKIHsKICNpZm5kZWYgTkRFQlVHCi0g ICAgVjhHQ0NvbnRyb2xsZXI6OnVucmVnaXN0ZXJHbG9iYWxIYW5kbGUodGhpcywgbV9maWx0ZXIp OworICAgIFY4R0NDb250cm9sbGVyOjp1bnJlZ2lzdGVyR2xvYmFsSGFuZGxlKHRoaXMsIG1fZmls dGVyLmdldCgpKTsKICNlbmRpZgotICAgIG1fZmlsdGVyLkRpc3Bvc2UoKTsKLSAgICBtX2ZpbHRl ci5DbGVhcigpOwogfQogCiBzaG9ydCBWOE5vZGVGaWx0ZXJDb25kaXRpb246OmFjY2VwdE5vZGUo U2NyaXB0U3RhdGUqIHN0YXRlLCBOb2RlKiBub2RlKSBjb25zdAogewogICAgIEFTU0VSVCh2ODo6 Q29udGV4dDo6SW5Db250ZXh0KCkpOwogCi0gICAgaWYgKCFtX2ZpbHRlci0+SXNPYmplY3QoKSkK KyAgICBpZiAoIW1fZmlsdGVyLmdldCgpLT5Jc09iamVjdCgpKQogICAgICAgICByZXR1cm4gTm9k ZUZpbHRlcjo6RklMVEVSX0FDQ0VQVDsKIAogICAgIHY4OjpUcnlDYXRjaCBleGNlcHRpb25DYXRj aGVyOwogCiAgICAgdjg6OkhhbmRsZTx2ODo6RnVuY3Rpb24+IGNhbGxiYWNrOwotICAgIGlmICht X2ZpbHRlci0+SXNGdW5jdGlvbigpKQotICAgICAgICBjYWxsYmFjayA9IHY4OjpIYW5kbGU8djg6 OkZ1bmN0aW9uPjo6Q2FzdChtX2ZpbHRlcik7CisgICAgaWYgKG1fZmlsdGVyLmdldCgpLT5Jc0Z1 bmN0aW9uKCkpCisgICAgICAgIGNhbGxiYWNrID0gdjg6OkhhbmRsZTx2ODo6RnVuY3Rpb24+OjpD YXN0KG1fZmlsdGVyLmdldCgpKTsKICAgICBlbHNlIHsKLSAgICAgICAgdjg6OkxvY2FsPHY4OjpW YWx1ZT4gdmFsdWUgPSBtX2ZpbHRlci0+VG9PYmplY3QoKS0+R2V0KHY4OjpTdHJpbmc6Ok5ldygi YWNjZXB0Tm9kZSIpKTsKKyAgICAgICAgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gdmFsdWUgPSBtX2Zp bHRlci5nZXQoKS0+VG9PYmplY3QoKS0+R2V0KHY4OjpTdHJpbmc6Ok5ldygiYWNjZXB0Tm9kZSIp KTsKICAgICAgICAgaWYgKCF2YWx1ZS0+SXNGdW5jdGlvbigpKSB7CiAgICAgICAgICAgICBWOFBy b3h5Ojp0aHJvd0Vycm9yKFY4UHJveHk6OlR5cGVFcnJvciwgIk5vZGVGaWx0ZXIgb2JqZWN0IGRv ZXMgbm90IGhhdmUgYW4gYWNjZXB0Tm9kZSBmdW5jdGlvbiIpOwogICAgICAgICAgICAgcmV0dXJu IE5vZGVGaWx0ZXI6OkZJTFRFUl9SRUpFQ1Q7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy92OC9WOE5vZGVGaWx0ZXJDb25kaXRpb24uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9WOE5vZGVGaWx0ZXJDb25kaXRpb24uaAkocmV2aXNpb24gODk0NTQpCisr KyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOE5vZGVGaWx0ZXJDb25kaXRpb24uaAkod29y a2luZyBjb3B5KQpAQCAtMzIsMzMgKzMyLDMyIEBACiAjZGVmaW5lIFY4Tm9kZUZpbHRlckNvbmRp dGlvbl9oCiAKICNpbmNsdWRlICJOb2RlRmlsdGVyQ29uZGl0aW9uLmgiCisjaW5jbHVkZSAiT3du SGFuZGxlLmgiCiAjaW5jbHVkZSA8djguaD4KICNpbmNsdWRlIDx3dGYvUGFzc1JlZlB0ci5oPgog Ci0vLyBOb2RlRmlsdGVyIGlzIGEgSmF2YVNjcmlwdCBmdW5jdGlvbiB0aGF0IHRha2VzIGEgTm9k ZSBhcyBwYXJhbWV0ZXIgYW5kIHJldHVybnMgYSBzaG9ydCAoQUNDRVBULCBTS0lQLCBSRUpFQ1Qp IGFzIHRoZSByZXN1bHQuCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLSAgICBjbGFzcyBOb2RlOwot ICAgIGNsYXNzIFNjcmlwdFN0YXRlOworY2xhc3MgTm9kZTsKK2NsYXNzIFNjcmlwdFN0YXRlOwog Ci0gICAgLy8gTm9kZUZpbHRlckNvbmRpdGlvbiBpcyBhIHdyYXBwZXIgYXJvdW5kIGEgTm9kZUZp bHRlciBKUyBmdW5jdGlvbi4KLSAgICBjbGFzcyBWOE5vZGVGaWx0ZXJDb25kaXRpb24gOiBwdWJs aWMgTm9kZUZpbHRlckNvbmRpdGlvbiB7Ci0gICAgcHVibGljOgotICAgICAgICBzdGF0aWMgUGFz c1JlZlB0cjxWOE5vZGVGaWx0ZXJDb25kaXRpb24+IGNyZWF0ZSh2ODo6SGFuZGxlPHY4OjpWYWx1 ZT4gZmlsdGVyKQotICAgICAgICB7Ci0gICAgICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IFY4 Tm9kZUZpbHRlckNvbmRpdGlvbihmaWx0ZXIpKTsKLSAgICAgICAgfQorY2xhc3MgVjhOb2RlRmls dGVyQ29uZGl0aW9uIDogcHVibGljIE5vZGVGaWx0ZXJDb25kaXRpb24geworcHVibGljOgorICAg IHN0YXRpYyBQYXNzUmVmUHRyPFY4Tm9kZUZpbHRlckNvbmRpdGlvbj4gY3JlYXRlKHY4OjpIYW5k bGU8djg6OlZhbHVlPiBmaWx0ZXIpCisgICAgeworICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3 IFY4Tm9kZUZpbHRlckNvbmRpdGlvbihmaWx0ZXIpKTsKKyAgICB9CiAKLSAgICAgICAgdmlydHVh bCB+VjhOb2RlRmlsdGVyQ29uZGl0aW9uKCk7CisgICAgdmlydHVhbCB+VjhOb2RlRmlsdGVyQ29u ZGl0aW9uKCk7CiAKLSAgICAgICAgdmlydHVhbCBzaG9ydCBhY2NlcHROb2RlKFNjcmlwdFN0YXRl KiwgTm9kZSopIGNvbnN0OworICAgIHZpcnR1YWwgc2hvcnQgYWNjZXB0Tm9kZShTY3JpcHRTdGF0 ZSosIE5vZGUqKSBjb25zdDsKIAotICAgIHByaXZhdGU6Ci0gICAgICAgIGV4cGxpY2l0IFY4Tm9k ZUZpbHRlckNvbmRpdGlvbih2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gZmlsdGVyKTsKK3ByaXZhdGU6 CisgICAgZXhwbGljaXQgVjhOb2RlRmlsdGVyQ29uZGl0aW9uKHY4OjpIYW5kbGU8djg6OlZhbHVl PiBmaWx0ZXIpOwogCi0gICAgICAgIG11dGFibGUgdjg6OlBlcnNpc3RlbnQ8djg6OlZhbHVlPiBt X2ZpbHRlcjsKLSAgICB9OworICAgIG11dGFibGUgT3duSGFuZGxlPHY4OjpWYWx1ZT4gbV9maWx0 ZXI7Cit9OwogCi19IC8vIG5hbWVzcGFjZSBXZWJDb3JlCit9CiAKLSNlbmRpZiAvLyBWOE5vZGVG aWx0ZXJDb25kaXRpb25faAorI2VuZGlmCg==