62237 2011-06-07 15:21:15 -0700 ScriptValue should use OwnHandle 2011-10-13 15:50:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 62193 1 abarth abarth antonm dglazkov eric webkit.review.bot oldest_to_newest 416832 0 abarth 2011-06-07 15:21:15 -0700 ScriptValue should use OwnHandle 416834 1 96310 abarth 2011-06-07 15:21:51 -0700 Created attachment 96310 Patch 416918 2 96310 eric 2011-06-07 16:32:23 -0700 Comment on attachment 96310 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96310&action=review > Source/WebCore/bindings/v8/ScriptValue.h:66 > + if (value.m_value.get().IsEmpty()) I see. We can't use -> here because the returned value is not a pointer? I still wonder if we shouldn't override -> on OwnHandle to make it work like a poitner. 416931 3 96310 webkit.review.bot 2011-06-07 16:50:13 -0700 Comment on attachment 96310 Patch Attachment 96310 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8776453 417019 4 96310 webkit.review.bot 2011-06-07 19:23:35 -0700 Comment on attachment 96310 Patch Attachment 96310 did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/8786386 417074 5 ap 2011-06-07 21:51:49 -0700 OwnHandle or OwnPtr? 417075 6 abarth 2011-06-07 21:53:04 -0700 (In reply to comment #5) > OwnHandle or OwnPtr? OwnHandle. It puts v8::Persistent through it's New/Dispose/Clear lifecycle. 417096 7 96310 eric 2011-06-07 22:42:49 -0700 Comment on attachment 96310 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96310&action=review > Source/WebCore/bindings/v8/ScriptValue.h:162 > + mutable OwnPtr<v8::Value> m_value; Except you used an OwnPtr... 417099 8 abarth 2011-06-07 22:52:33 -0700 > Except you used an OwnPtr... I think I was "on tilt" when I wrote these patches. You should just R- them. I'll try again another day. 96310 2011-06-07 15:21:51 -0700 2011-06-13 09:54:03 -0700 Patch bug-62237-20110607152150.patch text/plain 4929 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4MjcxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTEtMDYtMDcgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBTY3JpcHRWYWx1ZSBzaG91bGQgdXNlIE93bkhhbmRsZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjIyMzcKKworICAgICAg ICBUaGlzIGlzIHNsaWdodGx5IG1vcmUgdmVyYm9zZSwgYnV0IHNlZW1zIHNhZmVyLgorCisgICAg ICAgICogYmluZGluZ3MvdjgvU2NyaXB0VmFsdWUuaDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlw dFZhbHVlOjpTY3JpcHRWYWx1ZSk6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRWYWx1ZTo6b3Bl cmF0b3I9KToKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdFZhbHVlOjpvcGVyYXRvcj09KToKKyAg ICAgICAgKFdlYkNvcmU6OlNjcmlwdFZhbHVlOjppc0VxdWFsKToKKyAgICAgICAgKFdlYkNvcmU6 OlNjcmlwdFZhbHVlOjppc0Z1bmN0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdFZhbHVl Ojppc051bGwpOgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0VmFsdWU6OmlzVW5kZWZpbmVkKToK KyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdFZhbHVlOjppc09iamVjdCk6CisgICAgICAgIChXZWJD b3JlOjpTY3JpcHRWYWx1ZTo6aGFzTm9WYWx1ZSk6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRW YWx1ZTo6Y2xlYXIpOgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0VmFsdWU6OnY4VmFsdWUpOgor CiAyMDExLTA2LTA3ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IERhdmUgSHlhdHQuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9TY3JpcHRWYWx1ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3Y4L1NjcmlwdFZhbHVlLmgJKHJldmlzaW9uIDg4MjY3KQorKysgU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvU2NyaXB0VmFsdWUuaAkod29ya2luZyBjb3B5KQpAQCAtMzEsOSArMzEsOSBA QAogI2lmbmRlZiBTY3JpcHRWYWx1ZV9oCiAjZGVmaW5lIFNjcmlwdFZhbHVlX2gKIAorI2luY2x1 ZGUgIk93bkhhbmRsZS5oPiIKICNpbmNsdWRlICJQbGF0Zm9ybVN0cmluZy5oIgogI2luY2x1ZGUg IlNjcmlwdFN0YXRlLmgiCi0KICNpbmNsdWRlIDx2OC5oPgogI2luY2x1ZGUgPHd0Zi9QYXNzUmVm UHRyLmg+CiAKQEAgLTU1LDIwICs1NSwyMCBAQCBwdWJsaWM6CiAgICAgICAgIGlmICh2YWx1ZS5J c0VtcHR5KCkpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgbV92YWx1ZSA9IHY4OjpQ ZXJzaXN0ZW50PHY4OjpWYWx1ZT46Ok5ldyh2YWx1ZSk7CisgICAgICAgIG1fdmFsdWUuc2V0KHZh bHVlKTsKICNpZm5kZWYgTkRFQlVHCi0gICAgICAgIFY4R0NDb250cm9sbGVyOjpyZWdpc3Rlckds b2JhbEhhbmRsZShTQ1JJUFRWQUxVRSwgdGhpcywgbV92YWx1ZSk7CisgICAgICAgIFY4R0NDb250 cm9sbGVyOjpyZWdpc3Rlckdsb2JhbEhhbmRsZShTQ1JJUFRWQUxVRSwgdGhpcywgbV92YWx1ZS5n ZXQoKSk7CiAjZW5kaWYKICAgICB9CiAKICAgICBTY3JpcHRWYWx1ZShjb25zdCBTY3JpcHRWYWx1 ZSYgdmFsdWUpIAogICAgIHsKLSAgICAgICAgaWYgKHZhbHVlLm1fdmFsdWUuSXNFbXB0eSgpKQor ICAgICAgICBpZiAodmFsdWUubV92YWx1ZS5nZXQoKS5Jc0VtcHR5KCkpCiAgICAgICAgICAgICBy ZXR1cm47CiAKLSAgICAgICAgbV92YWx1ZSA9IHY4OjpQZXJzaXN0ZW50PHY4OjpWYWx1ZT46Ok5l dyh2YWx1ZS5tX3ZhbHVlKTsKKyAgICAgICAgbV92YWx1ZS5zZXQodmFsdWUubV92YWx1ZS5nZXQo KSk7CiAjaWZuZGVmIE5ERUJVRwotICAgICAgICBWOEdDQ29udHJvbGxlcjo6cmVnaXN0ZXJHbG9i YWxIYW5kbGUoU0NSSVBUVkFMVUUsIHRoaXMsIG1fdmFsdWUpOworICAgICAgICBWOEdDQ29udHJv bGxlcjo6cmVnaXN0ZXJHbG9iYWxIYW5kbGUoU0NSSVBUVkFMVUUsIHRoaXMsIG1fdmFsdWUuZ2V0 KCkpOwogI2VuZGlmCiAgICAgfQogCkBAIC03OSwxMiArNzksMTIgQEAgcHVibGljOgogCiAgICAg ICAgIGNsZWFyKCk7CiAKLSAgICAgICAgaWYgKHZhbHVlLm1fdmFsdWUuSXNFbXB0eSgpKQorICAg ICAgICBpZiAodmFsdWUubV92YWx1ZS5nZXQoKS5Jc0VtcHR5KCkpCiAgICAgICAgICAgICByZXR1 cm4gKnRoaXM7CiAKLSAgICAgICAgbV92YWx1ZSA9IHY4OjpQZXJzaXN0ZW50PHY4OjpWYWx1ZT46 Ok5ldyh2YWx1ZS5tX3ZhbHVlKTsKKyAgICAgICAgbV92YWx1ZS5zZXQodmFsdWUubV92YWx1ZS5n ZXQoKSk7CiAjaWZuZGVmIE5ERUJVRwotICAgICAgICBWOEdDQ29udHJvbGxlcjo6cmVnaXN0ZXJH bG9iYWxIYW5kbGUoU0NSSVBUVkFMVUUsIHRoaXMsIG1fdmFsdWUpOworICAgICAgICBWOEdDQ29u dHJvbGxlcjo6cmVnaXN0ZXJHbG9iYWxIYW5kbGUoU0NSSVBUVkFMVUUsIHRoaXMsIG1fdmFsdWUu Z2V0KCkpOwogI2VuZGlmCiAKICAgICAgICAgcmV0dXJuICp0aGlzOwpAQCAtOTIsMTcgKzkyLDE3 IEBAIHB1YmxpYzoKIAogICAgIGJvb2wgb3BlcmF0b3I9PShjb25zdCBTY3JpcHRWYWx1ZSB2YWx1 ZSkgY29uc3QKICAgICB7Ci0gICAgICAgIHJldHVybiBtX3ZhbHVlID09IHZhbHVlLm1fdmFsdWU7 CisgICAgICAgIHJldHVybiBtX3ZhbHVlLmdldCgpID09IHZhbHVlLm1fdmFsdWUuZ2V0KCk7CiAg ICAgfQogCiAgICAgYm9vbCBpc0VxdWFsKFNjcmlwdFN0YXRlKiwgY29uc3QgU2NyaXB0VmFsdWUm IHZhbHVlKSBjb25zdAogICAgIHsKLSAgICAgICAgcmV0dXJuIG1fdmFsdWUgPT0gdmFsdWUubV92 YWx1ZTsKKyAgICAgICAgcmV0dXJuIG1fdmFsdWUuZ2V0KCkgPT0gdmFsdWUubV92YWx1ZS5nZXQo KTsKICAgICB9CiAKICAgICBib29sIGlzRnVuY3Rpb24oKSBjb25zdAogICAgIHsKLSAgICAgICAg cmV0dXJuIG1fdmFsdWUtPklzRnVuY3Rpb24oKTsKKyAgICAgICAgcmV0dXJuIG1fdmFsdWUuZ2V0 KCktPklzRnVuY3Rpb24oKTsKICAgICB9CiAKICAgICBib29sIG9wZXJhdG9yIT0oY29uc3QgU2Ny aXB0VmFsdWUgdmFsdWUpIGNvbnN0CkBAIC0xMTIsMjIgKzExMiwyMiBAQCBwdWJsaWM6CiAKICAg ICBib29sIGlzTnVsbCgpIGNvbnN0CiAgICAgewotICAgICAgICByZXR1cm4gbV92YWx1ZS0+SXNO dWxsKCk7CisgICAgICAgIHJldHVybiBtX3ZhbHVlLmdldCgpLT5Jc051bGwoKTsKICAgICB9CiAK ICAgICBib29sIGlzVW5kZWZpbmVkKCkgY29uc3QKICAgICB7Ci0gICAgICAgIHJldHVybiBtX3Zh bHVlLT5Jc1VuZGVmaW5lZCgpOworICAgICAgICByZXR1cm4gbV92YWx1ZS5nZXQoKS0+SXNVbmRl ZmluZWQoKTsKICAgICB9CiAKICAgICBib29sIGlzT2JqZWN0KCkgY29uc3QKICAgICB7Ci0gICAg ICAgIHJldHVybiBtX3ZhbHVlLT5Jc09iamVjdCgpOworICAgICAgICByZXR1cm4gbV92YWx1ZS5n ZXQoKS0+SXNPYmplY3QoKTsKICAgICB9CiAKICAgICBib29sIGhhc05vVmFsdWUoKSBjb25zdAog ICAgIHsKLSAgICAgICAgcmV0dXJuIG1fdmFsdWUuSXNFbXB0eSgpOworICAgICAgICByZXR1cm4g bV92YWx1ZS5nZXQoKS5Jc0VtcHR5KCk7CiAgICAgfQogCiAgICAgUGFzc1JlZlB0cjxTZXJpYWxp emVkU2NyaXB0VmFsdWU+IHNlcmlhbGl6ZShTY3JpcHRTdGF0ZSopOwpAQCAtMTM3LDE0ICsxMzcs MTMgQEAgcHVibGljOgogCiAgICAgdm9pZCBjbGVhcigpCiAgICAgewotICAgICAgICBpZiAobV92 YWx1ZS5Jc0VtcHR5KCkpCisgICAgICAgIGlmIChtX3ZhbHVlLmdldCgpLklzRW1wdHkoKSkKICAg ICAgICAgICAgIHJldHVybjsKIAogI2lmbmRlZiBOREVCVUcKLSAgICAgICAgVjhHQ0NvbnRyb2xs ZXI6OnVucmVnaXN0ZXJHbG9iYWxIYW5kbGUodGhpcywgbV92YWx1ZSk7CisgICAgICAgIFY4R0ND b250cm9sbGVyOjp1bnJlZ2lzdGVyR2xvYmFsSGFuZGxlKHRoaXMsIG1fdmFsdWUuZ2V0KCkpOwog I2VuZGlmCi0gICAgICAgIG1fdmFsdWUuRGlzcG9zZSgpOwotICAgICAgICBtX3ZhbHVlLkNsZWFy KCk7CisgICAgICAgIG1fdmFsdWUuY2xlYXIoKTsKICAgICB9CiAKICAgICB2aXJ0dWFsIH5TY3Jp cHRWYWx1ZSgpIApAQCAtMTUyLDcgKzE1MSw3IEBAIHB1YmxpYzoKICAgICAgICAgY2xlYXIoKTsK ICAgICB9CiAKLSAgICB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdjhWYWx1ZSgpIGNvbnN0IHsgcmV0 dXJuIG1fdmFsdWU7IH0KKyAgICB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdjhWYWx1ZSgpIGNvbnN0 IHsgcmV0dXJuIG1fdmFsdWUuZ2V0KCk7IH0KICAgICBib29sIGdldFN0cmluZyhTY3JpcHRTdGF0 ZSosIFN0cmluZyYgcmVzdWx0KSBjb25zdCB7IHJldHVybiBnZXRTdHJpbmcocmVzdWx0KTsgfQog ICAgIGJvb2wgZ2V0U3RyaW5nKFN0cmluZyYgcmVzdWx0KSBjb25zdDsKICAgICBTdHJpbmcgdG9T dHJpbmcoU2NyaXB0U3RhdGUqKSBjb25zdDsKQEAgLTE2MCw3ICsxNTksNyBAQCBwdWJsaWM6CiAg ICAgUGFzc1JlZlB0cjxJbnNwZWN0b3JWYWx1ZT4gdG9JbnNwZWN0b3JWYWx1ZShTY3JpcHRTdGF0 ZSopIGNvbnN0OwogCiBwcml2YXRlOgotICAgIG11dGFibGUgdjg6OlBlcnNpc3RlbnQ8djg6OlZh bHVlPiBtX3ZhbHVlOworICAgIG11dGFibGUgT3duUHRyPHY4OjpWYWx1ZT4gbV92YWx1ZTsKIH07 CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK