62236 2011-06-07 15:21:13 -0700 [Chromium] WebAccessibilityObject needs access to line breaks in multiline text 2011-06-08 08:53:14 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 dmazzoni webkit-unassigned webkit.review.bot oldest_to_newest 416831 0 dmazzoni 2011-06-07 15:21:13 -0700 AccessibilityObject exposes dozens of low-level functions for dealing with multiline text. Rather than expose all of them, we should expose just the minimum interface we need in WebAccessibilityObject. 416949 1 96332 dmazzoni 2011-06-07 17:23:25 -0700 Created attachment 96332 Patch adds a method to return the indices of line breaks within the text content. 417262 2 96332 webkit.review.bot 2011-06-08 08:53:10 -0700 Comment on attachment 96332 Patch adds a method to return the indices of line breaks within the text content. Clearing flags on attachment: 96332 Committed r88351: <http://trac.webkit.org/changeset/88351> 417263 3 webkit.review.bot 2011-06-08 08:53:14 -0700 All reviewed patches have been landed. Closing bug. 96332 2011-06-07 17:23:25 -0700 2011-06-08 08:53:10 -0700 Patch adds a method to return the indices of line breaks within the text content. linebreaks.webkitpatch2 text/plain 2746 dmazzoni SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gODgyODkpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMDcgIERvbWlu aWMgTWF6em9uaSAgPGRtYXp6b25pQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgbWV0aG9kIHRvIHJldHVybiB0aGUgbGlu ZSBicmVha3MgZm9yIGFueSBlbGVtZW50IHdpdGgKKyAgICAgICAgbXVsdGlsaW5lIHRleHQgY29u dGVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYy MjM2CisKKyAgICAgICAgKiBwdWJsaWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdC5oOgorICAgICAg ICAqIHNyYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi QWNjZXNzaWJpbGl0eU9iamVjdDo6bGluZUJyZWFrcyk6CisKIDIwMTEtMDYtMDcgIFZhbmdlbGlz IEtva2tldmlzICA8dmFuZ2VsaXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEphbWVzIFJvYmluc29uLgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJBY2Nlc3Np YmlsaXR5T2JqZWN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJB Y2Nlc3NpYmlsaXR5T2JqZWN0LmgJKHJldmlzaW9uIDg4MDA1KQorKysgV2ViS2l0L2Nocm9taXVt L3B1YmxpYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmgJKHdvcmtpbmcgY29weSkKQEAgLTMzLDYg KzMzLDcgQEAKIAogI2luY2x1ZGUgIldlYkFjY2Vzc2liaWxpdHlSb2xlLmgiCiAjaW5jbHVkZSAi V2ViQ29tbW9uLmgiCisjaW5jbHVkZSAiV2ViVmVjdG9yLmgiCiAKICNpZiBXRUJLSVRfSU1QTEVN RU5UQVRJT04KIG5hbWVzcGFjZSBXZWJDb3JlIHsgY2xhc3MgQWNjZXNzaWJpbGl0eU9iamVjdDsg fQpAQCAtMTE5LDYgKzEyMCw3IEBAIHB1YmxpYzoKICAgICBXRUJLSVRfQVBJIGJvb2wgaGFzQ29t cHV0ZWRTdHlsZSgpIGNvbnN0OwogICAgIFdFQktJVF9BUEkgV2ViU3RyaW5nIGNvbXB1dGVkU3R5 bGVEaXNwbGF5KCkgY29uc3Q7CiAgICAgV0VCS0lUX0FQSSBib29sIGFjY2Vzc2liaWxpdHlJc0ln bm9yZWQoKSBjb25zdDsKKyAgICBXRUJLSVRfQVBJIGJvb2wgbGluZUJyZWFrcyhXZWJWZWN0b3I8 aW50PiYpIGNvbnN0OwogCiAjaWYgV0VCS0lUX0lNUExFTUVOVEFUSU9OCiAgICAgV2ViQWNjZXNz aWJpbGl0eU9iamVjdChjb25zdCBXVEY6OlBhc3NSZWZQdHI8V2ViQ29yZTo6QWNjZXNzaWJpbGl0 eU9iamVjdD4mKTsKSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViQWNjZXNzaWJpbGl0eU9i amVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJBY2Nlc3NpYmls aXR5T2JqZWN0LmNwcAkocmV2aXNpb24gODgwMDUpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dl YkFjY2Vzc2liaWxpdHlPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NDMsNiArNTQzLDI3 IEBAIGJvb2wgV2ViQWNjZXNzaWJpbGl0eU9iamVjdDo6YWNjZXNzaWJpbGkKICAgICByZXR1cm4g bV9wcml2YXRlLT5hY2Nlc3NpYmlsaXR5SXNJZ25vcmVkKCk7CiB9CiAKK2Jvb2wgV2ViQWNjZXNz aWJpbGl0eU9iamVjdDo6bGluZUJyZWFrcyhXZWJWZWN0b3I8aW50PiYgcmVzdWx0KSBjb25zdAor eworICAgIG1fcHJpdmF0ZS0+dXBkYXRlQmFja2luZ1N0b3JlKCk7CisgICAgaW50IHRleHRMZW5n dGggPSBtX3ByaXZhdGUtPnRleHRMZW5ndGgoKTsKKyAgICBpZiAoIXRleHRMZW5ndGgpCisgICAg ICAgIHJldHVybiBmYWxzZTsKKworICAgIFZpc2libGVQb3NpdGlvbiBwb3MgPSBtX3ByaXZhdGUt PnZpc2libGVQb3NpdGlvbkZvckluZGV4KHRleHRMZW5ndGgpOworICAgIGludCBsaW5lQnJlYWtD b3VudCA9IG1fcHJpdmF0ZS0+bGluZUZvclBvc2l0aW9uKHBvcyk7CisgICAgaWYgKCFsaW5lQnJl YWtDb3VudCkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgV2ViVmVjdG9yPGludD4gbGlu ZUJyZWFrcyhzdGF0aWNfY2FzdDxzaXplX3Q+KGxpbmVCcmVha0NvdW50KSk7CisgICAgZm9yIChp bnQgaSA9IDA7IGkgPCBsaW5lQnJlYWtDb3VudDsgaSsrKSB7CisgICAgICAgIFBsYWluVGV4dFJh bmdlIHJhbmdlID0gbV9wcml2YXRlLT5kb0FYUmFuZ2VGb3JMaW5lKGkpOworICAgICAgICBsaW5l QnJlYWtzW2ldID0gcmFuZ2Uuc3RhcnQgKyByYW5nZS5sZW5ndGg7CisgICAgfQorICAgIHJlc3Vs dC5zd2FwKGxpbmVCcmVha3MpOworICAgIHJldHVybiB0cnVlOworfQorCiBXZWJBY2Nlc3NpYmls aXR5T2JqZWN0OjpXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0KGNvbnN0IFdURjo6UGFzc1JlZlB0cjxX ZWJDb3JlOjpBY2Nlc3NpYmlsaXR5T2JqZWN0PiYgb2JqZWN0KQogICAgIDogbV9wcml2YXRlKHN0 YXRpY19jYXN0PFdlYkFjY2Vzc2liaWxpdHlPYmplY3RQcml2YXRlKj4ob2JqZWN0LnJlbGVhc2VS ZWYoKSkpCiB7Cg==