62235 2011-06-07 15:17:56 -0700 ScriptState should use OwnHandle 2011-10-13 15:49:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 62193 1 abarth abarth antonm dglazkov eric webkit.review.bot oldest_to_newest 416828 0 abarth 2011-06-07 15:17:56 -0700 ScriptState should use OwnHandle 416829 1 96308 abarth 2011-06-07 15:18:20 -0700 Created attachment 96308 Patch 416856 2 96308 webkit.review.bot 2011-06-07 15:38:01 -0700 Comment on attachment 96308 Patch Attachment 96308 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8715022 417000 3 96308 webkit.review.bot 2011-06-07 18:40:02 -0700 Comment on attachment 96308 Patch Attachment 96308 did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/8786379 96308 2011-06-07 15:18:20 -0700 2011-06-13 09:53:55 -0700 Patch bug-62235-20110607151818.patch text/plain 3300 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4MjcxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDYtMDcgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBTY3JpcHRTdGF0ZSBzaG91bGQgdXNlIE93bkhhbmRsZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjIyMzUKKworICAgICAg ICAqIGJpbmRpbmdzL3Y4L1NjcmlwdFN0YXRlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlw dFN0YXRlOjpTY3JpcHRTdGF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRTdGF0ZTo6flNj cmlwdFN0YXRlKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9TY3JpcHRTdGF0ZS5oOgorICAgICAg ICAoV2ViQ29yZTo6U2NyaXB0U3RhdGU6OmNvbnRleHQpOgorICAgICAgICAoV2ViQ29yZTo6U2Ny aXB0U3RhdGVQcm90ZWN0ZWRQdHI6OlNjcmlwdFN0YXRlUHJvdGVjdGVkUHRyKToKKyAgICAgICAg KFdlYkNvcmU6OlNjcmlwdFN0YXRlUHJvdGVjdGVkUHRyOjpnZXQpOgorCiAyMDExLTA2LTA3ICBT aW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERhdmUgSHlhdHQuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRT dGF0ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0 U3RhdGUuY3BwCShyZXZpc2lvbiA4ODI2NykKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1NjcmlwdFN0YXRlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDcsMTUgKzQ3LDEzIEBACiBuYW1l c3BhY2UgV2ViQ29yZSB7CiAKIFNjcmlwdFN0YXRlOjpTY3JpcHRTdGF0ZSh2ODo6SGFuZGxlPHY4 OjpDb250ZXh0PiBjb250ZXh0KQotICAgIDogbV9jb250ZXh0KHY4OjpQZXJzaXN0ZW50PHY4OjpD b250ZXh0Pjo6TmV3KGNvbnRleHQpKQorICAgIDogbV9jb250ZXh0KGNvbnRleHQpCiB7Ci0gICAg bV9jb250ZXh0Lk1ha2VXZWFrKHRoaXMsICZTY3JpcHRTdGF0ZTo6d2Vha1JlZmVyZW5jZUNhbGxi YWNrKTsKKyAgICBtX2NvbnRleHQuZ2V0KCkuTWFrZVdlYWsodGhpcywgJlNjcmlwdFN0YXRlOjp3 ZWFrUmVmZXJlbmNlQ2FsbGJhY2spOwogfQogCiBTY3JpcHRTdGF0ZTo6flNjcmlwdFN0YXRlKCkK IHsKLSAgICBtX2NvbnRleHQuRGlzcG9zZSgpOwotICAgIG1fY29udGV4dC5DbGVhcigpOwogfQog CiBTY3JpcHRTdGF0ZSogU2NyaXB0U3RhdGU6OmZvckNvbnRleHQodjg6OkxvY2FsPHY4OjpDb250 ZXh0PiBjb250ZXh0KQpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0U3Rh dGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRTdGF0 ZS5oCShyZXZpc2lvbiA4ODI2NykKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Njcmlw dFN0YXRlLmgJKHdvcmtpbmcgY29weSkKQEAgLTMyLDYgKzMyLDcgQEAKICNkZWZpbmUgU2NyaXB0 U3RhdGVfaAogCiAjaW5jbHVkZSAiRE9NV3JhcHBlcldvcmxkLmgiCisjaW5jbHVkZSAiT3duSGFu ZGxlLmgiCiAjaW5jbHVkZSA8djguaD4KICNpbmNsdWRlIDx3dGYvTm9uY29weWFibGUuaD4KICNp bmNsdWRlIDx3dGYvUmVmQ291bnRlZC5oPgpAQCAtNTUsNyArNTYsNyBAQCBwdWJsaWM6CiAKICAg ICB2ODo6TG9jYWw8djg6OkNvbnRleHQ+IGNvbnRleHQoKSBjb25zdAogICAgIHsKLSAgICAgICAg cmV0dXJuIHY4OjpMb2NhbDx2ODo6Q29udGV4dD46Ok5ldyhtX2NvbnRleHQpOworICAgICAgICBy ZXR1cm4gdjg6OkxvY2FsPHY4OjpDb250ZXh0Pjo6TmV3KG1fY29udGV4dC5nZXQoKSk7CiAgICAg fQogCiAgICAgc3RhdGljIFNjcmlwdFN0YXRlKiBmb3JDb250ZXh0KHY4OjpMb2NhbDx2ODo6Q29u dGV4dD4pOwpAQCAtNzIsNyArNzMsNyBAQCBwcml2YXRlOgogICAgIHN0YXRpYyB2b2lkIHdlYWtS ZWZlcmVuY2VDYWxsYmFjayh2ODo6UGVyc2lzdGVudDx2ODo6VmFsdWU+IG9iamVjdCwgdm9pZCog cGFyYW1ldGVyKTsKIAogICAgIHY4OjpMb2NhbDx2ODo6VmFsdWU+IG1fZXhjZXB0aW9uOwotICAg IHY4OjpQZXJzaXN0ZW50PHY4OjpDb250ZXh0PiBtX2NvbnRleHQ7CisgICAgT3duSGFuZGxlPHY4 OjpDb250ZXh0PiBtX2NvbnRleHQ7CiB9OwogCiBjbGFzcyBFbXB0eVNjcmlwdFN0YXRlIDogcHVi bGljIFNjcmlwdFN0YXRlIHsKQEAgLTg5LDE5ICs5MCwxMyBAQCBwdWJsaWM6CiAgICAgewogICAg ICAgICB2ODo6SGFuZGxlU2NvcGUgaGFuZGxlU2NvcGU7CiAgICAgICAgIC8vIEtlZXAgdGhlIGNv bnRleHQgZnJvbSBiZWluZyBHQydlZC4gU2NyaXB0U3RhdGUgaXMgZ3VhcmFudGVlZCB0byBiZSBs aXZlIHdoaWxlIHRoZSBjb250ZXh0IGlzIGxpdmUuCi0gICAgICAgIG1fY29udGV4dCA9IHY4OjpQ ZXJzaXN0ZW50PHY4OjpDb250ZXh0Pjo6TmV3KHNjcmlwdFN0YXRlLT5jb250ZXh0KCkpOworICAg ICAgICBtX2NvbnRleHQuc2V0KHNjcmlwdFN0YXRlLT5jb250ZXh0KCkpOwogICAgIH0KLSAgICB+ U2NyaXB0U3RhdGVQcm90ZWN0ZWRQdHIoKQotICAgIHsKLSAgICAgICAgaWYgKCFtX2NvbnRleHQu SXNFbXB0eSgpKSB7Ci0gICAgICAgICAgICBtX2NvbnRleHQuRGlzcG9zZSgpOwotICAgICAgICAg ICAgbV9jb250ZXh0LkNsZWFyKCk7Ci0gICAgICAgIH0KLSAgICB9Ci0gICAgU2NyaXB0U3RhdGUq IGdldCgpIGNvbnN0IHsgcmV0dXJuIG1fc2NyaXB0U3RhdGU7IH0KKyAgICBTY3JpcHRTdGF0ZSog Z2V0KCkgY29uc3QgeyByZXR1cm4gbV9zY3JpcHRTdGF0ZS5nZXQoKTsgfQorCiBwcml2YXRlOgog ICAgIFNjcmlwdFN0YXRlKiBtX3NjcmlwdFN0YXRlOwotICAgIHY4OjpQZXJzaXN0ZW50PHY4OjpD b250ZXh0PiBtX2NvbnRleHQ7CisgICAgT3duSGFuZGxlPHY4OjpDb250ZXh0PiBtX2NvbnRleHQ7 CiB9OwogCiBTY3JpcHRTdGF0ZSogbWFpbldvcmxkU2NyaXB0U3RhdGUoRnJhbWUqKTsK