6222 2005-12-23 17:56:14 -0800 HashMap does not work with const pointer keys or values 2005-12-24 14:09:13 -0800 1 1 1 Unclassified WebKit WebKit Misc. 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 mjs mjs oldest_to_newest 26451 0 mjs 2005-12-23 17:56:14 -0800 HashMap does not work for const foo * keys and values because the pointer specialization fails to cast away const and so fails some implicit conversions. 26452 1 5253 mjs 2005-12-23 18:00:08 -0800 Created attachment 5253 the fix 26463 2 5253 eric 2005-12-24 02:42:55 -0800 Comment on attachment 5253 the fix the KDE folks have been removing c-style casts from the kxmlcore code they imported from us. This just gives them more to remove. That said, this looks fine. r=me. 26497 3 mjs 2005-12-24 14:03:52 -0800 I think if you're going to const_cast and reinterpret_cast both, then you may as well just use a C-style cast. 5253 2005-12-23 18:00:08 -0800 2005-12-24 02:42:55 -0800 the fix HashMap-const-ptr-fix.patch.txt text/plain 4351 mjs SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjkyNQpkaWZmIC11IC1wIC1y MS45MjUgQ2hhbmdlTG9nCi0tLSBDaGFuZ2VMb2cJMjMgRGVjIDIwMDUgMDg6MzQ6NDAgLTAwMDAJ MS45MjUKKysrIENoYW5nZUxvZwkyNCBEZWMgMjAwNSAwMjowMDoxNiAtMDAwMApAQCAtMSw1ICsx LDE5IEBACiAyMDA1LTEyLTIzICBNYWNpZWogU3RhY2hvd2lhayAgPG1qc0BhcHBsZS5jb20+CiAK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKwktIGZpeGVkICJIYXNoTWFw IGRvZXMgbm90IHdvcmsgd2l0aCBjb25zdCBwb2ludGVyIGtleXMgb3IgdmFsdWVzIgorICAgICAg ICBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTYyMjIKKwkK KyAgICAgICAgKiBreG1sY29yZS9IYXNoTWFwUHRyU3BlYy5oOgorICAgICAgICAoS1hNTENvcmU6 Okhhc2hNYXApOiBJbiBhbGwgbWV0aG9kcywgZXhwbGljaXRseSBjYXN0IGFsbCBwb2ludGVycwor CXRvIHZvaWQgKiBiZWZvcmUgcGFzc2luZyB0byBpbnRlcm5hbCBpbXBsZW1lbnRhdGlvbi4gVXNl IEMtc3R5bGUKKwljYXN0cyBpbnN0ZWFkIG9mIG5ldy1zdHlsZSBjYXN0cywgYmVjYXVzZSB0aGUg cmVhbCBzb2x1dGlvbiB3b3VsZAorICAgICAgICByZXF1aXJlIGEgY29tYm8gb2YgcmVpbnRlcnBy ZXRfY2FzdCBhbmMgY29uc3RfY2FzdC4KKworCisyMDA1LTEyLTIzICBNYWNpZWogU3RhY2hvd2lh ayAgPG1qc0BhcHBsZS5jb20+CisKICAgICAgICAgLSB0aGlzIHRpbWUgZm9yIHN1cmUKIAogICAg ICAgICAqIGt4bWxjb3JlL1JlZlB0ci5oOgpJbmRleDoga3htbGNvcmUvSGFzaE1hcFB0clNwZWMu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvSmF2YVNjcmlwdENvcmUva3htbGNvcmUv SGFzaE1hcFB0clNwZWMuaCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4zCmRpZmYgLXUgLXAgLXIx LjMga3htbGNvcmUvSGFzaE1hcFB0clNwZWMuaAotLS0ga3htbGNvcmUvSGFzaE1hcFB0clNwZWMu aAkyMyBEZWMgMjAwNSAwMTo1Mjo0MyAtMDAwMAkxLjMKKysrIGt4bWxjb3JlL0hhc2hNYXBQdHJT cGVjLmgJMjQgRGVjIDIwMDUgMDI6MDA6MTggLTAwMDAKQEAgLTE1MSwxOCArMTUxLDE4IEBAIG5h bWVzcGFjZSBLWE1MQ29yZSB7CiAgICAgICAgIGNvbnN0X2l0ZXJhdG9yIGJlZ2luKCkgY29uc3Qg eyByZXR1cm4gbV9pbXBsLmJlZ2luKCk7IH0KICAgICAgICAgY29uc3RfaXRlcmF0b3IgZW5kKCkg Y29uc3QgeyByZXR1cm4gbV9pbXBsLmVuZCgpOyB9CiAgICAgICAgIAotICAgICAgICBpdGVyYXRv ciBmaW5kKGNvbnN0IEtleVR5cGUmIGtleSkgeyByZXR1cm4gbV9pbXBsLmZpbmQoa2V5KTsgfQot ICAgICAgICBjb25zdF9pdGVyYXRvciBmaW5kKGNvbnN0IEtleVR5cGUmIGtleSkgY29uc3QgeyBy ZXR1cm4gbV9pbXBsLmZpbmQoa2V5KTsgfQotICAgICAgICBib29sIGNvbnRhaW5zKGNvbnN0IEtl eVR5cGUmIGtleSkgY29uc3QgeyByZXR1cm4gbV9pbXBsLmNvbnRhaW5zKGtleSk7IH0KLSAgICAg ICAgTWFwcGVkVHlwZSBnZXQoY29uc3QgS2V5VHlwZSAma2V5KSBjb25zdCB7IHJldHVybiBtX2lt cGwuZ2V0KGtleSk7IH0KKyAgICAgICAgaXRlcmF0b3IgZmluZChjb25zdCBLZXlUeXBlJiBrZXkp IHsgcmV0dXJuIG1faW1wbC5maW5kKCh2b2lkICopKGtleSkpOyB9CisgICAgICAgIGNvbnN0X2l0 ZXJhdG9yIGZpbmQoY29uc3QgS2V5VHlwZSYga2V5KSBjb25zdCB7IHJldHVybiBtX2ltcGwuZmlu ZCgodm9pZCAqKShrZXkpKTsgfQorICAgICAgICBib29sIGNvbnRhaW5zKGNvbnN0IEtleVR5cGUm IGtleSkgY29uc3QgeyByZXR1cm4gbV9pbXBsLmNvbnRhaW5zKCh2b2lkICopKGtleSkpOyB9Cisg ICAgICAgIE1hcHBlZFR5cGUgZ2V0KGNvbnN0IEtleVR5cGUgJmtleSkgY29uc3QgeyByZXR1cm4g bV9pbXBsLmdldCgodm9pZCAqKShrZXkpKTsgfQogICAgICAgICAKICAgICAgICAgc3RkOjpwYWly PGl0ZXJhdG9yLCBib29sPiBzZXQoY29uc3QgS2V5VHlwZSAma2V5LCBjb25zdCBNYXBwZWRUeXBl ICZtYXBwZWQpIAotICAgICAgICB7IHJldHVybiBtX2ltcGwuc2V0KGtleSwgbWFwcGVkKTsgfQor ICAgICAgICB7IHJldHVybiBtX2ltcGwuc2V0KCh2b2lkICopKGtleSksIG1hcHBlZCk7IH0KIAog ICAgICAgICBzdGQ6OnBhaXI8aXRlcmF0b3IsIGJvb2w+IGFkZChjb25zdCBLZXlUeXBlICZrZXks IGNvbnN0IE1hcHBlZFR5cGUgJm1hcHBlZCkgCi0gICAgICAgIHsgcmV0dXJuIG1faW1wbC5hZGQo a2V5LCBtYXBwZWQpOyB9CisgICAgICAgIHsgcmV0dXJuIG1faW1wbC5hZGQoKHZvaWQgKikoa2V5 KSwgbWFwcGVkKTsgfQogICAgICAgICAKLSAgICAgICAgdm9pZCByZW1vdmUoY29uc3QgS2V5VHlw ZSYga2V5KSB7IG1faW1wbC5yZW1vdmUoa2V5KTsgfQorICAgICAgICB2b2lkIHJlbW92ZShjb25z dCBLZXlUeXBlJiBrZXkpIHsgbV9pbXBsLnJlbW92ZSgodm9pZCAqKShrZXkpKTsgfQogICAgICAg ICB2b2lkIHJlbW92ZShpdGVyYXRvciBpdCkgeyBtX2ltcGwucmVtb3ZlKGl0Lm1faW1wbCk7IH0K ICAgICAgICAgdm9pZCBjbGVhcigpIHsgbV9pbXBsLmNsZWFyKCk7IH0KICAgICAgICAgCkBAIC0x OTcsMTggKzE5NywxOCBAQCBuYW1lc3BhY2UgS1hNTENvcmUgewogICAgICAgICBjb25zdF9pdGVy YXRvciBiZWdpbigpIGNvbnN0IHsgcmV0dXJuIG1faW1wbC5iZWdpbigpOyB9CiAgICAgICAgIGNv bnN0X2l0ZXJhdG9yIGVuZCgpIGNvbnN0IHsgcmV0dXJuIG1faW1wbC5lbmQoKTsgfQogICAgICAg ICAKLSAgICAgICAgaXRlcmF0b3IgZmluZChjb25zdCBLZXlUeXBlJiBrZXkpIHsgcmV0dXJuIG1f aW1wbC5maW5kKGtleSk7IH0KLSAgICAgICAgY29uc3RfaXRlcmF0b3IgZmluZChjb25zdCBLZXlU eXBlJiBrZXkpIGNvbnN0IHsgcmV0dXJuIG1faW1wbC5maW5kKGtleSk7IH0KLSAgICAgICAgYm9v bCBjb250YWlucyhjb25zdCBLZXlUeXBlJiBrZXkpIGNvbnN0IHsgcmV0dXJuIG1faW1wbC5jb250 YWlucyhrZXkpOyB9Ci0gICAgICAgIE1hcHBlZFR5cGUgZ2V0KGNvbnN0IEtleVR5cGUgJmtleSkg Y29uc3QgeyByZXR1cm4gKE1hcHBlZFR5cGUpbV9pbXBsLmdldChrZXkpOyB9CisgICAgICAgIGl0 ZXJhdG9yIGZpbmQoY29uc3QgS2V5VHlwZSYga2V5KSB7IHJldHVybiBtX2ltcGwuZmluZCgodm9p ZCAqKShrZXkpKTsgfQorICAgICAgICBjb25zdF9pdGVyYXRvciBmaW5kKGNvbnN0IEtleVR5cGUm IGtleSkgY29uc3QgeyByZXR1cm4gbV9pbXBsLmZpbmQoKHZvaWQgKikoa2V5KSk7IH0KKyAgICAg ICAgYm9vbCBjb250YWlucyhjb25zdCBLZXlUeXBlJiBrZXkpIGNvbnN0IHsgcmV0dXJuIG1faW1w bC5jb250YWlucygodm9pZCAqKShrZXkpKTsgfQorICAgICAgICBNYXBwZWRUeXBlIGdldChjb25z dCBLZXlUeXBlICZrZXkpIGNvbnN0IHsgcmV0dXJuIHJlaW50ZXJwcmV0X2Nhc3Q8TWFwcGVkVHlw ZT4obV9pbXBsLmdldCgodm9pZCAqKShrZXkpKSk7IH0KICAgICAgICAgCiAgICAgICAgIHN0ZDo6 cGFpcjxpdGVyYXRvciwgYm9vbD4gc2V0KGNvbnN0IEtleVR5cGUgJmtleSwgY29uc3QgTWFwcGVk VHlwZSAmbWFwcGVkKSAKLSAgICAgICAgeyByZXR1cm4gbV9pbXBsLnNldChrZXksIG1hcHBlZCk7 IH0KKyAgICAgICAgeyByZXR1cm4gbV9pbXBsLnNldCgodm9pZCAqKShrZXkpLCAodm9pZCAqKSht YXBwZWQpKTsgfQogCiAgICAgICAgIHN0ZDo6cGFpcjxpdGVyYXRvciwgYm9vbD4gYWRkKGNvbnN0 IEtleVR5cGUgJmtleSwgY29uc3QgTWFwcGVkVHlwZSAmbWFwcGVkKSAKLSAgICAgICAgeyByZXR1 cm4gbV9pbXBsLmFkZChrZXksIG1hcHBlZCk7IH0KKyAgICAgICAgeyByZXR1cm4gbV9pbXBsLmFk ZCgodm9pZCAqKShrZXkpLCAodm9pZCAqKShtYXBwZWQpKTsgfQogICAgICAgICAKLSAgICAgICAg dm9pZCByZW1vdmUoY29uc3QgS2V5VHlwZSYga2V5KSB7IG1faW1wbC5yZW1vdmUoa2V5KTsgfQor ICAgICAgICB2b2lkIHJlbW92ZShjb25zdCBLZXlUeXBlJiBrZXkpIHsgbV9pbXBsLnJlbW92ZSgo dm9pZCAqKShrZXkpKTsgfQogICAgICAgICB2b2lkIHJlbW92ZShpdGVyYXRvciBpdCkgeyBtX2lt cGwucmVtb3ZlKGl0Lm1faW1wbCk7IH0KICAgICAgICAgdm9pZCBjbGVhcigpIHsgbV9pbXBsLmNs ZWFyKCk7IH0KICAgICAgICAgCg==