62219 2011-06-07 10:16:23 -0700 [Symbian] Float{32,64}Array and Int16Array fail to build. 2011-06-08 08:48:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling ademar oldest_to_newest 416603 0 kling 2011-06-07 10:16:23 -0700 SSIA 416604 1 96255 kling 2011-06-07 10:16:59 -0700 Created attachment 96255 Proposed patch 416606 2 96255 kenneth 2011-06-07 10:18:25 -0700 Comment on attachment 96255 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=96255&action=review Working on Symbian now :-) ? > Source/WebCore/html/canvas/Float32Array.h:41 > + // Can’t use "using" here due to a bug in the RVCT compiler. Wrong encoding it seems > Source/WebCore/html/canvas/Float64Array.h:41 > + // Can’t use "using" here due to a bug in the RVCT compiler. Same here 416730 3 96255 laszlo.gombos 2011-06-07 12:22:56 -0700 Comment on attachment 96255 Proposed patch LGTM. It would be good to mention that this is only needed for RVCT 2.2 (and not 4.0) for future reference in the ChangeLog. The encoding looks to be OK, unless one clicks on "Review patch". Perhaps an issue with "Review patch" ? 417167 4 kling 2011-06-08 03:52:54 -0700 Committed r88336: <http://trac.webkit.org/changeset/88336> 417259 5 ademar 2011-06-08 08:48:27 -0700 Revision r88336 cherry-picked into qtwebkit-2.2 with commit d7ac689 <http://gitorious.org/webkit/qtwebkit/commit/d7ac689> 96255 2011-06-07 10:16:59 -0700 2011-06-07 12:22:55 -0700 Proposed patch bug-62219.diff text/plain 3351 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwODkyMDY2Li5lZjZmZjY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTEtMDYtMDcgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbU3ltYmlh bl0gRmxvYXR7MzIsNjR9QXJyYXkgYW5kIEludDE2QXJyYXkgZmFpbCB0byBidWlsZC4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyMjE5CisKKyAgICAg ICAgRm9yIHNvbWUgcmVhc29uLCBSVkNUIGlzIG1vYW5pbmcgYWJvdXQgImNsYXNzIG1lbWJlciBk ZXNpZ25hdGVkIGJ5CisgICAgICAgIGEgdXNpbmctZGVjbGFyYXRpb24gbXVzdCBiZSB2aXNpYmxl IGluIGEgZGlyZWN0IGJhc2UgY2xhc3MiLgorICAgICAgICBBcHBseSBzYW1lIGZpeCBhcyByNjkx MjIgYW5kIHI3NjU5Mi4KKworICAgICAgICAqIGh0bWwvY2FudmFzL0Zsb2F0MzJBcnJheS5oOgor ICAgICAgICAoV2ViQ29yZTo6RmxvYXQzMkFycmF5OjpzZXQpOgorICAgICAgICAqIGh0bWwvY2Fu dmFzL0Zsb2F0NjRBcnJheS5oOgorICAgICAgICAoV2ViQ29yZTo6RmxvYXQ2NEFycmF5OjpzZXQp OgorICAgICAgICAqIGh0bWwvY2FudmFzL0ludDE2QXJyYXkuaDoKKyAgICAgICAgKFdlYkNvcmU6 OkludDE2QXJyYXk6OnNldCk6CisKIDIwMTEtMDYtMDcgIFlvdW5nIEhhbiBMZWUgIDxqb3licm9A Y29tcGFueTEwMC5uZXQ+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJp c3RpYW5zZW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9GbG9hdDMy QXJyYXkuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0Zsb2F0MzJBcnJheS5oCmluZGV4 IGVlMWVhNTYuLjVlYTdkOGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFz L0Zsb2F0MzJBcnJheS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0Zsb2F0MzJB cnJheS5oCkBAIC0zOCw3ICszOCw4IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxG bG9hdDMyQXJyYXk+IGNyZWF0ZShjb25zdCBmbG9hdCogYXJyYXksIHVuc2lnbmVkIGxlbmd0aCk7 CiAgICAgc3RhdGljIFBhc3NSZWZQdHI8RmxvYXQzMkFycmF5PiBjcmVhdGUoUGFzc1JlZlB0cjxB cnJheUJ1ZmZlcj4gYnVmZmVyLCB1bnNpZ25lZCBieXRlT2Zmc2V0LCB1bnNpZ25lZCBsZW5ndGgp OwogCi0gICAgdXNpbmcgVHlwZWRBcnJheUJhc2U8ZmxvYXQ+OjpzZXQ7CisgICAgLy8gQ2Fu4oCZ dCB1c2UgInVzaW5nIiBoZXJlIGR1ZSB0byBhIGJ1ZyBpbiB0aGUgUlZDVCBjb21waWxlci4KKyAg ICB2b2lkIHNldChUeXBlZEFycmF5QmFzZTxmbG9hdD4qIGFycmF5LCB1bnNpZ25lZCBvZmZzZXQs IEV4Y2VwdGlvbkNvZGUmIGVjKSB7IHJldHVybiBUeXBlZEFycmF5QmFzZTxmbG9hdD46OnNldChh cnJheSwgb2Zmc2V0LCBlYyk7IH0KIAogICAgIHZvaWQgc2V0KHVuc2lnbmVkIGluZGV4LCBkb3Vi bGUgdmFsdWUpCiAgICAgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMv RmxvYXQ2NEFycmF5LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9GbG9hdDY0QXJyYXku aAppbmRleCBmNDVhMjFjLi5lODAwNWE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1s L2NhbnZhcy9GbG9hdDY0QXJyYXkuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9G bG9hdDY0QXJyYXkuaApAQCAtMzgsNyArMzgsOCBAQCBwdWJsaWM6CiAgICAgc3RhdGljIFBhc3NS ZWZQdHI8RmxvYXQ2NEFycmF5PiBjcmVhdGUoY29uc3QgZG91YmxlKiBhcnJheSwgdW5zaWduZWQg bGVuZ3RoKTsKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxGbG9hdDY0QXJyYXk+IGNyZWF0ZShQYXNz UmVmUHRyPEFycmF5QnVmZmVyPiwgdW5zaWduZWQgYnl0ZU9mZnNldCwgdW5zaWduZWQgbGVuZ3Ro KTsKIAotICAgIHVzaW5nIFR5cGVkQXJyYXlCYXNlPGRvdWJsZT46OnNldDsKKyAgICAvLyBDYW7i gJl0IHVzZSAidXNpbmciIGhlcmUgZHVlIHRvIGEgYnVnIGluIHRoZSBSVkNUIGNvbXBpbGVyLgor ICAgIHZvaWQgc2V0KFR5cGVkQXJyYXlCYXNlPGRvdWJsZT4qIGFycmF5LCB1bnNpZ25lZCBvZmZz ZXQsIEV4Y2VwdGlvbkNvZGUmIGVjKSB7IHJldHVybiBUeXBlZEFycmF5QmFzZTxkb3VibGU+Ojpz ZXQoYXJyYXksIG9mZnNldCwgZWMpOyB9CiAKICAgICB2b2lkIHNldCh1bnNpZ25lZCBpbmRleCwg ZG91YmxlIHZhbHVlKQogICAgIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2Fu dmFzL0ludDE2QXJyYXkuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0ludDE2QXJyYXku aAppbmRleCA2YzRmNTRiLi4yZTFmMjU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1s L2NhbnZhcy9JbnQxNkFycmF5LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvSW50 MTZBcnJheS5oCkBAIC0zOCw4ICszOCw5IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgUGFzc1JlZlB0 cjxJbnQxNkFycmF5PiBjcmVhdGUoc2hvcnQqIGFycmF5LCB1bnNpZ25lZCBsZW5ndGgpOwogICAg IHN0YXRpYyBQYXNzUmVmUHRyPEludDE2QXJyYXk+IGNyZWF0ZShQYXNzUmVmUHRyPEFycmF5QnVm ZmVyPiBidWZmZXIsIHVuc2lnbmVkIGJ5dGVPZmZzZXQsIHVuc2lnbmVkIGxlbmd0aCk7CiAKLSAg ICB1c2luZyBUeXBlZEFycmF5QmFzZTxzaG9ydD46OnNldDsKLSAgICB1c2luZyBJbnRlZ3JhbFR5 cGVkQXJyYXlCYXNlPHNob3J0Pjo6c2V0OworICAgIC8vIENhbuKAmXQgdXNlICJ1c2luZyIgaGVy ZSBkdWUgdG8gYSBidWcgaW4gdGhlIFJWQ1QgY29tcGlsZXIuCisgICAgdm9pZCBzZXQoVHlwZWRB cnJheUJhc2U8c2hvcnQ+KiBhcnJheSwgdW5zaWduZWQgb2Zmc2V0LCBFeGNlcHRpb25Db2RlJiBl YykgeyBUeXBlZEFycmF5QmFzZTxzaG9ydD46OnNldChhcnJheSwgb2Zmc2V0LCBlYyk7IH0KKyAg ICB2b2lkIHNldCh1bnNpZ25lZCBpbmRleCwgZG91YmxlIHZhbHVlKSB7IEludGVncmFsVHlwZWRB cnJheUJhc2U8c2hvcnQ+OjpzZXQoaW5kZXgsIHZhbHVlKTsgfQogCiAgICAgUGFzc1JlZlB0cjxJ bnQxNkFycmF5PiBzdWJhcnJheShpbnQgc3RhcnQpIGNvbnN0OwogICAgIFBhc3NSZWZQdHI8SW50 MTZBcnJheT4gc3ViYXJyYXkoaW50IHN0YXJ0LCBpbnQgZW5kKSBjb25zdDsK