62215 2011-06-07 09:00:46 -0700 Make style/checkers/cpp.py allow comparisons with 0 in LIKELY and UNLIKELY 2011-06-07 12:55:19 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 dslomov webkit-unassigned dslomov levin webkit.review.bot oldest_to_newest 416539 0 dslomov 2011-06-07 09:00:46 -0700 cpp_style.py does not currenly allow if (LIKELY(ptr != 0)) .... 416623 1 96259 dslomov 2011-06-07 10:40:10 -0700 Created attachment 96259 Fix + unit-test 416743 2 96259 webkit.review.bot 2011-06-07 12:55:15 -0700 Comment on attachment 96259 Fix + unit-test Clearing flags on attachment: 96259 Committed r88256: <http://trac.webkit.org/changeset/88256> 416745 3 webkit.review.bot 2011-06-07 12:55:19 -0700 All reviewed patches have been landed. Closing bug. 96259 2011-06-07 10:40:10 -0700 2011-06-07 12:55:15 -0700 Fix + unit-test 62215.patch text/plain 2527 dslomov ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzZTBi MDdmLi4zOWZiOTFhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDYtMDcgIERtaXRyeSBMb21vdiAgPGRzbG9t b3ZAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjIyMTUKKyAg ICAgICAgQWxsb3cgY29tcGFyaXNvbnMgd2l0aCAwIGluIExJS0VMWSBhbmQgVU5MSUtFTFkgbWFj cm9zLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6 CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3Qu cHk6CisKIDIwMTEtMDYtMDcgIE5pY28gV2ViZXIgIDx0aGFraXNAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXggY2E1ZDFkOS4uZWMzYjNlZSAxMDA2NDQK LS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKKysrIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKQEAgLTIzNDEsOCAr MjM0MSw5IEBAIGRlZiBjaGVja19mb3JfY29tcGFyaXNvbnNfdG9femVybyhjbGVhbl9saW5lcywg bGluZV9udW1iZXIsIGVycm9yKToKIAogICAgICMgSW5jbHVkZSBOVUxMIGhlcmUgc28gdGhhdCB1 c2VycyBkb24ndCBoYXZlIHRvIGNvbnZlcnQgTlVMTCB0byAwIGZpcnN0IGFuZCB0aGVuIGdldCB0 aGlzIGVycm9yLgogICAgIGlmIHNlYXJjaChyJ1s9IV09XHMqKE5VTEx8MHx0cnVlfGZhbHNlKVxX JywgbGluZSkgb3Igc2VhcmNoKHInXFcoTlVMTHwwfHRydWV8ZmFsc2UpXHMqWz0hXT0nLCBsaW5l KToKLSAgICAgICAgZXJyb3IobGluZV9udW1iZXIsICdyZWFkYWJpbGl0eS9jb21wYXJpc29uX3Rv X3plcm8nLCA1LAotICAgICAgICAgICAgICAnVGVzdHMgZm9yIHRydWUvZmFsc2UsIG51bGwvbm9u LW51bGwsIGFuZCB6ZXJvL25vbi16ZXJvIHNob3VsZCBhbGwgYmUgZG9uZSB3aXRob3V0IGVxdWFs aXR5IGNvbXBhcmlzb25zLicpCisgICAgICAgIGlmIG5vdCBzZWFyY2goJ0xJS0VMWScsIGxpbmUp IGFuZCBub3Qgc2VhcmNoKCdVTkxJS0VMWScsIGxpbmUpOgorICAgICAgICAgICAgZXJyb3IobGlu ZV9udW1iZXIsICdyZWFkYWJpbGl0eS9jb21wYXJpc29uX3RvX3plcm8nLCA1LAorICAgICAgICAg ICAgICAgICAgJ1Rlc3RzIGZvciB0cnVlL2ZhbHNlLCBudWxsL25vbi1udWxsLCBhbmQgemVyby9u b24temVybyBzaG91bGQgYWxsIGJlIGRvbmUgd2l0aG91dCBlcXVhbGl0eSBjb21wYXJpc29ucy4n KQogCiAKIGRlZiBjaGVja19mb3JfbnVsbChjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGZpbGVf c3RhdGUsIGVycm9yKToKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9j aGVja2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXggMWJkOGEwZS4uOGUxYjhjNyAxMDA2NDQKLS0t IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3Qu cHkKQEAgLTQxMzcsNiArNDEzNywxOSBAQCBjbGFzcyBXZWJLaXRTdHlsZVRlc3QoQ3BwU3R5bGVU ZXN0QmFzZSk6CiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCiAgICAgICAgICAgICAnaWYgKG90 aGVydHJ1ZSA9PSBmb250VHlwZSknLAogICAgICAgICAgICAgJycpCisgICAgICAgIHNlbGYuYXNz ZXJ0X2xpbnQoCisgICAgICAgICAgICAnaWYgKExJS0VMWShmb28gPT0gMCkpJywKKyAgICAgICAg ICAgICcnKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KAorICAgICAgICAgICAgJ2lmIChVTkxJ S0VMWShmb28gPT0gMCkpJywKKyAgICAgICAgICAgICcnKQorICAgICAgICBzZWxmLmFzc2VydF9s aW50KAorICAgICAgICAgICAgJ2lmIChMSUtFTFkoZm9vID09IE5VTEwpKScsCisgICAgICAgICAg ICAnVXNlIDAgaW5zdGVhZCBvZiBOVUxMLiAgW3JlYWRhYmlsaXR5L251bGxdIFs1XScpCisgICAg ICAgIHNlbGYuYXNzZXJ0X2xpbnQoCisgICAgICAgICAgICAnaWYgKFVOTElLRUxZKGZvbyA9PSBO VUxMKSknLAorICAgICAgICAgICAgJ1VzZSAwIGluc3RlYWQgb2YgTlVMTC4gIFtyZWFkYWJpbGl0 eS9udWxsXSBbNV0nKQorCiAKICAgICBkZWYgdGVzdF91c2luZ19zdGQoc2VsZik6CiAgICAgICAg IHNlbGYuYXNzZXJ0X2xpbnQoCg==