62207 2011-06-07 06:32:15 -0700 [Qt] RenderThemeQt::adjustSliderThumbSize() should not refer to the parent style 2011-06-07 17:26:24 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Other Unspecified RESOLVED FIXED P2 Normal --- 52920 62208 1 tkent tkent dglazkov hausmann kling vestbo oldest_to_newest 416462 0 tkent 2011-06-07 06:32:15 -0700 RenderThemeQt::adjustSliderThumbSize() should not refer to the parent style. 416482 1 96241 tkent 2011-06-07 07:17:12 -0700 Created attachment 96241 Patch 416859 2 96241 kling 2011-06-07 15:41:08 -0700 Comment on attachment 96241 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96241&action=review Thanks for lookin' out for Qt! <3 r=me > Source/WebCore/ChangeLog:13 > + * platform/qt/RenderThemeQt.cpp: Use fixed values to avoid to refer to o->parent(). to refer -> referring > Source/WebCore/platform/qt/RenderThemeQt.cpp:1468 > + // timelineThumbHeight should match to the height property of -webkit-media-controls-timeline in mediaControlsQt.css. match to -> match > Source/WebCore/platform/qt/RenderThemeQt.cpp:1471 > + // volumeThmbWidth should match to the width property of -webkit-media-controls-volue-slider in mediaControlsQt.css. match to -> match volumeThmbWidth -> volumeThumbWidth volue -> volume 416946 3 tkent 2011-06-07 17:18:33 -0700 (In reply to comment #2) Thank you for reviewing! I'll land with these English corrections. 416950 4 tkent 2011-06-07 17:26:24 -0700 Committed r88294: <http://trac.webkit.org/changeset/88294> 96241 2011-06-07 07:17:12 -0700 2011-06-07 15:41:08 -0700 Patch bug-62207-20110607231710.patch text/plain 4303 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogODgyMzIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzMDYwYTZiMzIzNTdlMGMw OGY5N2QyN2M2NTY2NjM5ZWYyM2FjMTM5Li44NjhhYTFiZjMyZTc2YTY2Y2M0NDU3MGM2OTFhZDkw ZTc1YWU3MGYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDYtMDcgIEtlbnQg VGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUmVuZGVyVGhlbWVRdDo6YWRqdXN0U2xpZGVyVGh1 bWJTaXplKCkgc2hvdWxkIG5vdCByZWZlciB0byB0aGUgcGFyZW50IHN0eWxlLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjIyMDcKKworICAgICAgICAq IGNzcy9tZWRpYUNvbnRyb2xzUXQuY3NzOiBBZGQgY29tbWVudHMuCisgICAgICAgIChhdWRpbzo6 LXdlYmtpdC1tZWRpYS1jb250cm9scy10aW1lbGluZSk6CisgICAgICAgICh2aWRlbzo6LXdlYmtp dC1tZWRpYS1jb250cm9scy10aW1lbGluZSk6CisgICAgICAgIChhdWRpbzo6LXdlYmtpdC1tZWRp YS1jb250cm9scy12b2x1bWUtc2xpZGVyKToKKyAgICAgICAgKHZpZGVvOjotd2Via2l0LW1lZGlh LWNvbnRyb2xzLXZvbHVtZS1zbGlkZXIpOgorICAgICAgICAqIHBsYXRmb3JtL3F0L1JlbmRlclRo ZW1lUXQuY3BwOiBVc2UgZml4ZWQgdmFsdWVzIHRvIGF2b2lkIHRvIHJlZmVyIHRvIG8tPnBhcmVu dCgpLgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVRdDo6YWRqdXN0U2xpZGVyVGh1bWJT aXplKToKKwogMjAxMS0wNi0wNyAgTmFva2kgVGFrYW5vICA8dGFrYW5vLm5hb2tpQGdtYWlsLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW50IFRhbXVyYS4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2Nzcy9tZWRpYUNvbnRyb2xzUXQuY3NzIGIvU291cmNlL1dlYkNvcmUvY3NzL21l ZGlhQ29udHJvbHNRdC5jc3MKaW5kZXggZTMyZmNkNTUzZTNlYjM1YmQ3ZGU1MzZjNTM1MmQ3MmI1 NDVmNTM5Ni4uNjRlMGVjNTI0YzYxNjgyNWRhMzkyODg4YmQ0ZTYzOWQ0MmI0MDNiNyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL21lZGlhQ29udHJvbHNRdC5jc3MKKysrIGIvU291cmNl L1dlYkNvcmUvY3NzL21lZGlhQ29udHJvbHNRdC5jc3MKQEAgLTE0OSwxMyArMTQ5LDEzIEBAIHZp ZGVvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLXRpbWUtcmVtYWluaW5nLWRpc3BsYXkgewogfQog CiBhdWRpbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy10aW1lbGluZSB7Ci0gICAgaGVpZ2h0OiAx MnB4OworICAgIGhlaWdodDogMTJweDsgLyogU2VlIFJlbmRlclRoZW1lUXQ6OmFkanVzdFNsaWRl clRodW1iU2l6ZSgpLiAqLwogICAgIHBhZGRpbmc6IDZweCA4cHg7CiAgICAgbWFyZ2luOiA1cHgg M3B4OwogfQogCiB2aWRlbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy10aW1lbGluZSB7Ci0gICAg aGVpZ2h0OiAxMnB4OworICAgIGhlaWdodDogMTJweDsgLyogU2VlIFJlbmRlclRoZW1lUXQ6OmFk anVzdFNsaWRlclRodW1iU2l6ZSgpLiAqLwogICAgIHBhZGRpbmc6IDZweCA4cHg7CiAgICAgbWFy Z2luOiA1cHggM3B4OwogfQpAQCAtMTc5LDcgKzE3OSw3IEBAIGF1ZGlvOjotd2Via2l0LW1lZGlh LWNvbnRyb2xzLXZvbHVtZS1zbGlkZXIgewogICAgIGRpc3BsYXk6IGlubGluZTsKICAgICBwb3Np dGlvbjogYWJzb2x1dGU7CiAKLSAgICB3aWR0aDogMTJweDsKKyAgICB3aWR0aDogMTJweDsgLyog U2VlIFJlbmRlclRoZW1lUXQ6OmFkanVzdFNsaWRlclRodW1iU2l6ZSgpLiAqLwogICAgIHBhZGRp bmc6IDZweDsKICAgICBoZWlnaHQ6IDg4cHg7CiAgICAgbWFyZ2luOiAwIDAgM3B4IDA7CkBAIC0x OTAsNyArMTkwLDcgQEAgdmlkZW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtdm9sdW1lLXNsaWRl ciB7CiAgICAgZGlzcGxheTogaW5saW5lOwogICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKIAotICAg IHdpZHRoOiAxMnB4OworICAgIHdpZHRoOiAxMnB4OyAvKiBTZWUgUmVuZGVyVGhlbWVRdDo6YWRq dXN0U2xpZGVyVGh1bWJTaXplKCkuICovCiAgICAgcGFkZGluZzogNnB4OwogICAgIGhlaWdodDog ODhweDsKICAgICBtYXJnaW46IDAgMCAzcHggMDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v cXQvUmVuZGVyVGhlbWVRdC5jcHAKaW5kZXggNDFjMThhMmFlNzUwMWY2NWEzOWQyOTRlODdkMDBh ZjNkMTUzMTQwZS4uZGIzYmNkNzgzNGU4MGYwMWVhNWYxYTA2OGYxY2Q5Zjc1ODIzZWU3YiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvUmVuZGVyVGhlbWVRdC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvUmVuZGVyVGhlbWVRdC5jcHAKQEAgLTE0NjUs MjIgKzE0NjUsMjAgQEAgYm9vbCBSZW5kZXJUaGVtZVF0OjpwYWludE1lZGlhU2xpZGVyVGh1bWIo UmVuZGVyT2JqZWN0KiBvLCBjb25zdCBQYWludEluZm8mIHBhaW4KIAogdm9pZCBSZW5kZXJUaGVt ZVF0OjphZGp1c3RTbGlkZXJUaHVtYlNpemUoUmVuZGVyT2JqZWN0KiBvKSBjb25zdAogeworICAg IC8vIHRpbWVsaW5lVGh1bWJIZWlnaHQgc2hvdWxkIG1hdGNoIHRvIHRoZSBoZWlnaHQgcHJvcGVy dHkgb2YgLXdlYmtpdC1tZWRpYS1jb250cm9scy10aW1lbGluZSBpbiBtZWRpYUNvbnRyb2xzUXQu Y3NzLgorICAgIGNvbnN0IGludCB0aW1lbGluZVRodW1iSGVpZ2h0ID0gMTI7CisgICAgY29uc3Qg aW50IHRpbWVsaW5lVGh1bWJXaWR0aCA9IHRpbWVsaW5lVGh1bWJIZWlnaHQgLyAzOworICAgIC8v IHZvbHVtZVRobWJXaWR0aCBzaG91bGQgbWF0Y2ggdG8gdGhlIHdpZHRoIHByb3BlcnR5IG9mIC13 ZWJraXQtbWVkaWEtY29udHJvbHMtdm9sdWUtc2xpZGVyIGluIG1lZGlhQ29udHJvbHNRdC5jc3Mu CisgICAgY29uc3QgaW50IHZvbHVtZVRodW1iV2lkdGggPSAxMjsKKyAgICBjb25zdCBpbnQgdm9s dW1lVGh1bWJIZWlnaHQgPSB2b2x1bWVUaHVtYldpZHRoIC8gMzsKICAgICBDb250cm9sUGFydCBw YXJ0ID0gby0+c3R5bGUoKS0+YXBwZWFyYW5jZSgpOwogCiAgICAgaWYgKHBhcnQgPT0gTWVkaWFT bGlkZXJUaHVtYlBhcnQpIHsKLSAgICAgICAgUmVuZGVyU3R5bGUqIHBhcmVudFN0eWxlID0gby0+ cGFyZW50KCktPnN0eWxlKCk7Ci0gICAgICAgIFFfQVNTRVJUKHBhcmVudFN0eWxlKTsKLQotICAg ICAgICBpbnQgcGFyZW50SGVpZ2h0ID0gcGFyZW50U3R5bGUtPmhlaWdodCgpLnZhbHVlKCk7Ci0g ICAgICAgIG8tPnN0eWxlKCktPnNldFdpZHRoKExlbmd0aChwYXJlbnRIZWlnaHQgLyAzLCBGaXhl ZCkpOwotICAgICAgICBvLT5zdHlsZSgpLT5zZXRIZWlnaHQoTGVuZ3RoKHBhcmVudEhlaWdodCwg Rml4ZWQpKTsKKyAgICAgICAgby0+c3R5bGUoKS0+c2V0V2lkdGgoTGVuZ3RoKHRpbWVsaW5lVGh1 bWJXaWR0aCwgRml4ZWQpKTsKKyAgICAgICAgby0+c3R5bGUoKS0+c2V0SGVpZ2h0KExlbmd0aCh0 aW1lbGluZVRodW1iSGVpZ2h0LCBGaXhlZCkpOwogICAgIH0gZWxzZSBpZiAocGFydCA9PSBNZWRp YVZvbHVtZVNsaWRlclRodW1iUGFydCkgewotICAgICAgICBSZW5kZXJTdHlsZSogcGFyZW50U3R5 bGUgPSBvLT5wYXJlbnQoKS0+c3R5bGUoKTsKLSAgICAgICAgUV9BU1NFUlQocGFyZW50U3R5bGUp OwotCi0gICAgICAgIGludCBwYXJlbnRXaWR0aCA9IHBhcmVudFN0eWxlLT53aWR0aCgpLnZhbHVl KCk7Ci0gICAgICAgIG8tPnN0eWxlKCktPnNldEhlaWdodChMZW5ndGgocGFyZW50V2lkdGggLyAz LCBGaXhlZCkpOwotICAgICAgICBvLT5zdHlsZSgpLT5zZXRXaWR0aChMZW5ndGgocGFyZW50V2lk dGgsIEZpeGVkKSk7CisgICAgICAgIG8tPnN0eWxlKCktPnNldEhlaWdodChMZW5ndGgodm9sdW1l VGh1bWJIZWlnaHQsIEZpeGVkKSk7CisgICAgICAgIG8tPnN0eWxlKCktPnNldFdpZHRoKExlbmd0 aCh2b2x1bWVUaHVtYldpZHRoLCBGaXhlZCkpOwogICAgIH0gZWxzZSBpZiAocGFydCA9PSBTbGlk ZXJUaHVtYkhvcml6b250YWxQYXJ0IHx8IHBhcnQgPT0gU2xpZGVyVGh1bWJWZXJ0aWNhbFBhcnQp IHsKICAgICAgICAgUVN0eWxlT3B0aW9uU2xpZGVyIG9wdGlvbjsKICAgICAgICAgaWYgKHBhcnQg PT0gU2xpZGVyVGh1bWJWZXJ0aWNhbFBhcnQpCg==