62206 2011-06-07 06:20:45 -0700 Web Inspector: remove duplicate breakpoints from localStorage 2011-06-07 08:19:27 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 416454 0 yurys 2011-06-07 06:20:45 -0700 There was a bug that caused breakpoints duplication(see e.g. this Chromium report: http://crbug.com/85029). This may have caused breakpoint storage growth up to several megabytes which significantly slows down breakpoint operations. To overcome this we need to perform one-time settings normalization. 416464 1 96236 yurys 2011-06-07 06:36:14 -0700 Created attachment 96236 Patch 416495 2 96236 pfeldman 2011-06-07 07:44:54 -0700 Comment on attachment 96236 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96236&action=review > Source/WebCore/inspector/front-end/Settings.js:127 > + var start = s.indexOf("{", i); Seems like a weak assumption. Should we nuke it altogether? 416502 3 96245 yurys 2011-06-07 07:51:30 -0700 Created attachment 96245 Patch 416505 4 yurys 2011-06-07 07:54:22 -0700 (In reply to comment #3) > Created an attachment (id=96245) [details] > Patch As discussed offline the normalization logic looks overcomplicated. Instead of that we will simply clear breakpoint storage once. 416517 5 yurys 2011-06-07 08:19:27 -0700 Committed r88237: <http://trac.webkit.org/changeset/88237> 96236 2011-06-07 06:36:14 -0700 2011-06-07 07:51:22 -0700 Patch bug-62206-20110607173612.patch text/plain 4104 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogODgyMzMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzMDYwYTZiMzIzNTdlMGMw OGY5N2QyN2M2NTY2NjM5ZWYyM2FjMTM5Li4zM2Q4NWIxZjhhZGNjMzg4YjZkYjhkYjUzY2Q4NTk4 NmNlNDE0ZTc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDYtMDcgIFl1cnkg U2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogcmVtb3ZlIGR1cGxpY2F0 ZSBicmVha3BvaW50cyBmcm9tIGxvY2FsU3RvcmFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjIyMDYKKworICAgICAgICBQZXJmb3JtIG9uZS10aW1l IGJyZWFrcG9pbnQgc3RvcmFnZSBub3JtYWxpemF0aW9uKHJlbW92ZSBkdXBsaWNhdGVzKSBpbgor ICAgICAgICBjYXNlIHNldHRpbmdzIHZlcnNpb24gaXMgbGVzcyB0aGFuIDEuIAorCisgICAgICAg ICogaW5zcGVjdG9yL2Zyb250LWVuZC9TZXR0aW5ncy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5TZXR0aW5ncyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2V0dGluZ3MucHJvdG90eXBlLl9z ZXQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNldHRpbmdzLnByb3RvdHlwZS5fbWlncmF0ZVNl dHRpbmdzLnNwbGl0T2JqZWN0cyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2V0dGluZ3MucHJv dG90eXBlLl9taWdyYXRlU2V0dGluZ3MucmVtb3ZlRHVwbGljYXRlT2JqZWN0cyk6CisgICAgICAg IChXZWJJbnNwZWN0b3IuU2V0dGluZ3MucHJvdG90eXBlLl9taWdyYXRlU2V0dGluZ3MpOgorCiAy MDExLTA2LTA3ICBOYW9raSBUYWthbm8gIDx0YWthbm8ubmFva2lAZ21haWwuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEtlbnQgVGFtdXJhLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9TZXR0aW5ncy5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvU2V0dGluZ3MuanMKaW5kZXggNjgzNzM2M2IyM2ViNjQ0MDY2NTYzOWY5YWNj MWRkNmNlZTI3NTdjNi4uNGFiYzFkNWNmY2JlZjc0ODgyMDUyNWRkY2EwN2QzMjNmOTIwMDJiMCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TZXR0aW5ncy5q cworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NldHRpbmdzLmpzCkBA IC03Nyw4ICs3NywxMiBAQCBXZWJJbnNwZWN0b3IuU2V0dGluZ3MgPSBmdW5jdGlvbigpCiAgICAg dGhpcy5pbnN0YWxsQXBwbGljYXRpb25TZXR0aW5nKCJldmVudExpc3RlbmVyQnJlYWtwb2ludHMi LCBbXSk7CiAgICAgdGhpcy5pbnN0YWxsQXBwbGljYXRpb25TZXR0aW5nKCJkb21CcmVha3BvaW50 cyIsIFtdKTsKICAgICB0aGlzLmluc3RhbGxBcHBsaWNhdGlvblNldHRpbmcoInhockJyZWFrcG9p bnRzIiwgW10pOworCisgICAgdGhpcy5fbWlncmF0ZVNldHRpbmdzKCk7CiB9CiAKK1dlYkluc3Bl Y3Rvci5TZXR0aW5ncy52ZXJzaW9uID0gMTsKKwogV2ViSW5zcGVjdG9yLlNldHRpbmdzLnByb3Rv dHlwZSA9IHsKICAgICBpbnN0YWxsQXBwbGljYXRpb25TZXR0aW5nOiBmdW5jdGlvbihrZXksIGRl ZmF1bHRWYWx1ZSkKICAgICB7CkBAIC0xMDUsNiArMTA5LDY2IEBAIFdlYkluc3BlY3Rvci5TZXR0 aW5ncy5wcm90b3R5cGUgPSB7CiAgICAgewogICAgICAgICBpZiAod2luZG93LmxvY2FsU3RvcmFn ZSAhPSBudWxsKQogICAgICAgICAgICAgd2luZG93LmxvY2FsU3RvcmFnZVtrZXldID0gSlNPTi5z dHJpbmdpZnkodmFsdWUpOworICAgIH0sCisKKyAgICBfbWlncmF0ZVNldHRpbmdzOiBmdW5jdGlv bigpCisgICAgeworICAgICAgICBpZiAoIXdpbmRvdy5sb2NhbFN0b3JhZ2UpCisgICAgICAgICAg ICByZXR1cm47CisgICAgICAgIHZhciB2ZXJzaW9uID0gbG9jYWxTdG9yYWdlLnZlcnNpb247Cisg ICAgICAgIGlmICh2ZXJzaW9uID09PSBXZWJJbnNwZWN0b3IuU2V0dGluZ3MudmVyc2lvbikKKyAg ICAgICAgICAgIHJldHVybjsKKworICAgICAgICBmdW5jdGlvbiBzcGxpdE9iamVjdHMocykgewor ICAgICAgICAgICAgdmFyIHJlc3VsdCA9IFtdOworICAgICAgICAgICAgaWYgKCFzKQorICAgICAg ICAgICAgICAgIHJldHVybiByZXN1bHQ7CisgICAgICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8 IHMubGVuZ3RoOyBpKyspIHsKKyAgICAgICAgICAgICAgICB2YXIgc3RhcnQgPSBzLmluZGV4T2Yo InsiLCBpKTsKKyAgICAgICAgICAgICAgICBpZiAoc3RhcnQgPT0gLTEpCisgICAgICAgICAgICAg ICAgICAgIGJyZWFrOworICAgICAgICAgICAgICAgIHZhciBvcGVuZWRDb3VudCA9IDE7CisgICAg ICAgICAgICAgICAgZm9yIChpID0gc3RhcnQgKyAxOyBpIDwgcy5sZW5ndGg7IGkrKykgeworICAg ICAgICAgICAgICAgICAgICBpZiAoc1tpXSA9PT0gInsiKSB7CisgICAgICAgICAgICAgICAgICAg ICAgICBvcGVuZWRDb3VudCsrOworICAgICAgICAgICAgICAgICAgICAgICAgY29udGludWU7Cisg ICAgICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICAgICAgaWYgKHNbaV0gIT09ICJ9 IikKKyAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICAgICAgICAgICAg ICBvcGVuZWRDb3VudC0tOworICAgICAgICAgICAgICAgICAgICBpZiAob3BlbmVkQ291bnQgPT09 IDApIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIHJlc3VsdC5wdXNoKHMuc3Vic3RyaW5nKHN0 YXJ0LCBpICsgMSkpOworICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAg ICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9CisgICAgICAgICAg ICByZXR1cm4gcmVzdWx0OworICAgICAgICB9CisKKyAgICAgICAgZnVuY3Rpb24gcmVtb3ZlRHVw bGljYXRlT2JqZWN0cyhzZXJpYWxpemVkSlNPTkFycmF5T2ZPYmplY3RzKSB7CisgICAgICAgICAg ICBpZiAoIXNlcmlhbGl6ZWRKU09OQXJyYXlPZk9iamVjdHMpCisgICAgICAgICAgICAgICAgcmV0 dXJuIHNlcmlhbGl6ZWRKU09OQXJyYXlPZk9iamVjdHM7CisgICAgICAgICAgICB2YXIgb2JqZWN0 cyA9IHNwbGl0T2JqZWN0cyhzZXJpYWxpemVkSlNPTkFycmF5T2ZPYmplY3RzKTsKKyAgICAgICAg ICAgIG9iamVjdHMuc29ydCgpOworICAgICAgICAgICAgdmFyIGxhc3RTdHJpbmc7CisgICAgICAg ICAgICB2YXIgdW5pcXVlU3RyaW5ncyA9IG9iamVjdHMuZmlsdGVyKGZ1bmN0aW9uKG5leHRTdHJp bmcpIHsKKyAgICAgICAgICAgICAgICBpZiAobGFzdFN0cmluZyA9PT0gbmV4dFN0cmluZykKKyAg ICAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICAgICAgICAgIGxhc3RTdHJp bmcgPSBuZXh0U3RyaW5nOworICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOworICAgICAgICAg ICAgfSk7CisgICAgICAgICAgICByZXR1cm4gIlsiICsgdW5pcXVlU3RyaW5ncy5qb2luKCIsIikg KyAiXSI7CisgICAgICAgIH0KKworICAgICAgICB2YXIgYnJlYWtwb2ludEtleXMgPSBbImJyZWFr cG9pbnRzIiwgImV2ZW50TGlzdGVuZXJCcmVha3BvaW50cyIsICJkb21CcmVha3BvaW50cyIsICJ4 aHJCcmVha3BvaW50cyJdOworICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IGJyZWFrcG9pbnRL ZXlzLmxlbmd0aDsgaSsrKSB7CisgICAgICAgICAgICB2YXIga2V5ID0gYnJlYWtwb2ludEtleXNb aV07CisgICAgICAgICAgICB2YXIgdmFsdWUgPSBsb2NhbFN0b3JhZ2Vba2V5XTsKKyAgICAgICAg ICAgIGlmICh2YWx1ZSkKKyAgICAgICAgICAgICAgICBsb2NhbFN0b3JhZ2Vba2V5XSA9IHJlbW92 ZUR1cGxpY2F0ZU9iamVjdHModmFsdWUpOworICAgICAgICB9CisKKyAgICAgICAgbG9jYWxTdG9y YWdlLnZlcnNpb24gPSBXZWJJbnNwZWN0b3IuU2V0dGluZ3MudmVyc2lvbjsKICAgICB9CiB9CiAK 96245 2011-06-07 07:51:30 -0700 2011-06-07 07:55:08 -0700 Patch bug-62206-20110607185128.patch text/plain 2502 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogODgyMzUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxZDdiZDkwMDU4Zjk2ZmE3 NzE1ZTBiMjU1MzVhNmFjMjhhZWZmYmE2Li41MDNlODVlNzNlYWNlZWViZWFhOGJhNDJmNDQ1NmZj MDQ3N2UyNzdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDYtMDcgIFl1cnkg U2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogcmVtb3ZlIGR1cGxpY2F0 ZSBicmVha3BvaW50cyBmcm9tIGxvY2FsU3RvcmFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjIyMDYKKworICAgICAgICBQZXJmb3JtIG9uZS10aW1l IGJyZWFrcG9pbnQgc3RvcmFnZSBjbGVhbnVwIHRvIGdldCByaWQgb2YgZHVwbGljYXRlIGJyZWFr cG9pbnRzIGluCisgICAgICAgIGNhc2Ugd2hlbiBzZXR0aW5ncyB2ZXJzaW9uIGlzIGxlc3MgdGhh biAxLiAKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU2V0dGluZ3MuanM6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuU2V0dGluZ3MpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNldHRp bmdzLnByb3RvdHlwZS5fc2V0KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TZXR0aW5ncy5wcm90 b3R5cGUuX21pZ3JhdGVTZXR0aW5ncy5zcGxpdE9iamVjdHMpOgorICAgICAgICAoV2ViSW5zcGVj dG9yLlNldHRpbmdzLnByb3RvdHlwZS5fbWlncmF0ZVNldHRpbmdzLnJlbW92ZUR1cGxpY2F0ZU9i amVjdHMpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNldHRpbmdzLnByb3RvdHlwZS5fbWlncmF0 ZVNldHRpbmdzKToKKwogMjAxMS0wNi0wMyAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TZXR0aW5ncy5qcyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2V0dGluZ3MuanMKaW5kZXggNjgzNzM2M2Iy M2ViNjQ0MDY2NTYzOWY5YWNjMWRkNmNlZTI3NTdjNi4uMDZlMWFlNGUwMzBlODMzNjEwYzJiMjNi ZDZkYTg4NzJmZmNhY2I0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9TZXR0aW5ncy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL1NldHRpbmdzLmpzCkBAIC03Nyw4ICs3NywxMiBAQCBXZWJJbnNwZWN0b3IuU2V0dGluZ3Mg PSBmdW5jdGlvbigpCiAgICAgdGhpcy5pbnN0YWxsQXBwbGljYXRpb25TZXR0aW5nKCJldmVudExp c3RlbmVyQnJlYWtwb2ludHMiLCBbXSk7CiAgICAgdGhpcy5pbnN0YWxsQXBwbGljYXRpb25TZXR0 aW5nKCJkb21CcmVha3BvaW50cyIsIFtdKTsKICAgICB0aGlzLmluc3RhbGxBcHBsaWNhdGlvblNl dHRpbmcoInhockJyZWFrcG9pbnRzIiwgW10pOworCisgICAgdGhpcy5fbWlncmF0ZVNldHRpbmdz KCk7CiB9CiAKK1dlYkluc3BlY3Rvci5TZXR0aW5ncy52ZXJzaW9uID0gMTsKKwogV2ViSW5zcGVj dG9yLlNldHRpbmdzLnByb3RvdHlwZSA9IHsKICAgICBpbnN0YWxsQXBwbGljYXRpb25TZXR0aW5n OiBmdW5jdGlvbihrZXksIGRlZmF1bHRWYWx1ZSkKICAgICB7CkBAIC0xMDUsNiArMTA5LDIxIEBA IFdlYkluc3BlY3Rvci5TZXR0aW5ncy5wcm90b3R5cGUgPSB7CiAgICAgewogICAgICAgICBpZiAo d2luZG93LmxvY2FsU3RvcmFnZSAhPSBudWxsKQogICAgICAgICAgICAgd2luZG93LmxvY2FsU3Rv cmFnZVtrZXldID0gSlNPTi5zdHJpbmdpZnkodmFsdWUpOworICAgIH0sCisKKyAgICBfbWlncmF0 ZVNldHRpbmdzOiBmdW5jdGlvbigpCisgICAgeworICAgICAgICBpZiAoIXdpbmRvdy5sb2NhbFN0 b3JhZ2UpCisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIHZhciB2ZXJzaW9uID0gbG9jYWxT dG9yYWdlLnZlcnNpb247CisgICAgICAgIGlmICh2ZXJzaW9uID09PSBXZWJJbnNwZWN0b3IuU2V0 dGluZ3MudmVyc2lvbikKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICB2YXIgYnJlYWtw b2ludEtleXMgPSBbImJyZWFrcG9pbnRzIiwgImV2ZW50TGlzdGVuZXJCcmVha3BvaW50cyIsICJk b21CcmVha3BvaW50cyIsICJ4aHJCcmVha3BvaW50cyJdOworICAgICAgICBmb3IgKHZhciBpID0g MDsgaSA8IGJyZWFrcG9pbnRLZXlzLmxlbmd0aDsgaSsrKQorICAgICAgICAgICAgZGVsZXRlIGxv Y2FsU3RvcmFnZVticmVha3BvaW50S2V5c1tpXV07CisKKyAgICAgICAgbG9jYWxTdG9yYWdlLnZl cnNpb24gPSBXZWJJbnNwZWN0b3IuU2V0dGluZ3MudmVyc2lvbjsKICAgICB9CiB9CiAK