62201 2011-06-07 03:48:00 -0700 [EFL] Implements "undo" command execution. 2011-06-08 10:11:00 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 0 ljaehun.lim webkit-unassigned gyuyoung.kim kenneth lucas.de.marchi tonikitoo webkit.review.bot oldest_to_newest 416426 0 ljaehun.lim 2011-06-07 03:48:00 -0700 This is a basic implementaion to support execCommand("undo") in Javascript. I refered to GTK+ port. 416427 1 96226 ljaehun.lim 2011-06-07 03:54:58 -0700 Created attachment 96226 Proposed patch 416429 2 gyuyoung.kim 2011-06-07 04:09:04 -0700 LGTM. 416448 3 96226 lucas.de.marchi 2011-06-07 05:51:42 -0700 Comment on attachment 96226 Proposed patch LGTM 417316 4 96226 webkit.review.bot 2011-06-08 10:10:55 -0700 Comment on attachment 96226 Proposed patch Clearing flags on attachment: 96226 Committed r88354: <http://trac.webkit.org/changeset/88354> 417317 5 webkit.review.bot 2011-06-08 10:11:00 -0700 All reviewed patches have been landed. Closing bug. 96226 2011-06-07 03:54:58 -0700 2011-06-08 10:10:55 -0700 Proposed patch patch.diff text/plain 3011 ljaehun.lim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBjNDI4YjViLi5mOTQ1YTE5IDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTEtMDYtMDcgIEphZWh1biBMaW0gIDxsamFlaHVuLmxpbUBzYW1z dW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbRUZMXSBJbXBsZW1lbnRzICJ1bmRvIiBjb21tYW5kIGV4ZWN1dGlvbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjIyMDEKKworICAgICAgICBTdXBw b3J0cyB0byBleGVjdXRlICJVbmRvIiBjb21tYW5kLgorCisgICAgICAgICogV2ViQ29yZVN1cHBv cnQvRWRpdG9yQ2xpZW50RWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRvckNsaWVudEVm bDo6cmVnaXN0ZXJDb21tYW5kRm9yVW5kbyk6CisgICAgICAgIChXZWJDb3JlOjpFZGl0b3JDbGll bnRFZmw6OmNsZWFyVW5kb1JlZG9PcGVyYXRpb25zKToKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRv ckNsaWVudEVmbDo6Y2FuVW5kbyk6CisgICAgICAgIChXZWJDb3JlOjpFZGl0b3JDbGllbnRFZmw6 OnVuZG8pOgorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEVmbC5oOgorCiAy MDExLTA2LTA2ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRFZmwuY3BwIGIvU291cmNlL1dlYktpdC9lZmwv V2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50RWZsLmNwcAppbmRleCA5MjQ3MmY2Li43NDVhM2Jj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGll bnRFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0VkaXRvckNs aWVudEVmbC5jcHAKQEAgLTE0NSw5ICsxNDUsOSBAQCB2b2lkIEVkaXRvckNsaWVudEVmbDo6ZGlk U2V0U2VsZWN0aW9uVHlwZXNGb3JQYXN0ZWJvYXJkKCkKICAgICBub3RJbXBsZW1lbnRlZCgpOwog fQogCi12b2lkIEVkaXRvckNsaWVudEVmbDo6cmVnaXN0ZXJDb21tYW5kRm9yVW5kbyhXVEY6OlBh c3NSZWZQdHI8RWRpdENvbW1hbmQ+KQordm9pZCBFZGl0b3JDbGllbnRFZmw6OnJlZ2lzdGVyQ29t bWFuZEZvclVuZG8oV1RGOjpQYXNzUmVmUHRyPEVkaXRDb21tYW5kPiBjb21tYW5kKQogewotICAg IG5vdEltcGxlbWVudGVkKCk7CisgICAgdW5kb1N0YWNrLmFwcGVuZChjb21tYW5kKTsKIH0KIAog dm9pZCBFZGl0b3JDbGllbnRFZmw6OnJlZ2lzdGVyQ29tbWFuZEZvclJlZG8oV1RGOjpQYXNzUmVm UHRyPEVkaXRDb21tYW5kPikKQEAgLTE1Nyw3ICsxNTcsNyBAQCB2b2lkIEVkaXRvckNsaWVudEVm bDo6cmVnaXN0ZXJDb21tYW5kRm9yUmVkbyhXVEY6OlBhc3NSZWZQdHI8RWRpdENvbW1hbmQ+KQog CiB2b2lkIEVkaXRvckNsaWVudEVmbDo6Y2xlYXJVbmRvUmVkb09wZXJhdGlvbnMoKQogewotICAg IG5vdEltcGxlbWVudGVkKCk7CisgICAgdW5kb1N0YWNrLmNsZWFyKCk7CiB9CiAKIGJvb2wgRWRp dG9yQ2xpZW50RWZsOjpjYW5Db3B5Q3V0KEZyYW1lKiwgYm9vbCBkZWZhdWx0VmFsdWUpIGNvbnN0 CkBAIC0xNzIsOCArMTcyLDcgQEAgYm9vbCBFZGl0b3JDbGllbnRFZmw6OmNhblBhc3RlKEZyYW1l KiwgYm9vbCBkZWZhdWx0VmFsdWUpIGNvbnN0CiAKIGJvb2wgRWRpdG9yQ2xpZW50RWZsOjpjYW5V bmRvKCkgY29uc3QKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVybiBmYWxzZTsK KyAgICByZXR1cm4gIXVuZG9TdGFjay5pc0VtcHR5KCk7CiB9CiAKIGJvb2wgRWRpdG9yQ2xpZW50 RWZsOjpjYW5SZWRvKCkgY29uc3QKQEAgLTE4NCw3ICsxODMsOSBAQCBib29sIEVkaXRvckNsaWVu dEVmbDo6Y2FuUmVkbygpIGNvbnN0CiAKIHZvaWQgRWRpdG9yQ2xpZW50RWZsOjp1bmRvKCkKIHsK LSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIFJlZlB0cjxXZWJDb3JlOjpFZGl0Q29tbWFuZD4g Y29tbWFuZCgqKC0tdW5kb1N0YWNrLmVuZCgpKSk7CisgICAgdW5kb1N0YWNrLnJlbW92ZSgtLXVu ZG9TdGFjay5lbmQoKSk7CisgICAgY29tbWFuZC0+dW5hcHBseSgpOwogfQogCiB2b2lkIEVkaXRv ckNsaWVudEVmbDo6cmVkbygpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3Jl U3VwcG9ydC9FZGl0b3JDbGllbnRFZmwuaCBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBw b3J0L0VkaXRvckNsaWVudEVmbC5oCmluZGV4IDVjYjE2Y2QuLjkxNmY5NjAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEVmbC5oCisrKyBi L1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEVmbC5oCkBAIC0z Niw2ICszNiw3IEBACiAjaW5jbHVkZSAiRWRpdG9yQ2xpZW50LmgiCiAjaW5jbHVkZSAiVGV4dENo ZWNrZXJDbGllbnQuaCIKIAorI2luY2x1ZGUgPHd0Zi9EZXF1ZS5oPgogI2luY2x1ZGUgPHd0Zi9G b3J3YXJkLmg+CiAKIHR5cGVkZWYgc3RydWN0IF9FdmFzX09iamVjdCBFdmFzX09iamVjdDsKQEAg LTQ0LDYgKzQ1LDkgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogY2xhc3MgUGFnZTsKIAogY2xhc3Mg RWRpdG9yQ2xpZW50RWZsIDogcHVibGljIEVkaXRvckNsaWVudCwgcHVibGljIFRleHRDaGVja2Vy Q2xpZW50IHsKK3Byb3RlY3RlZDoKKyAgICBXVEY6OkRlcXVlPFdURjo6UmVmUHRyPFdlYkNvcmU6 OkVkaXRDb21tYW5kPiA+IHVuZG9TdGFjazsKKwogcHVibGljOgogICAgIEVkaXRvckNsaWVudEVm bChFdmFzX09iamVjdCAqdmlldyk7CiAgICAgfkVkaXRvckNsaWVudEVmbCgpOwo=