62199 2011-06-07 02:39:39 -0700 new-run-webkit-tests: support --repeat-each feature from old-run-webkit-tests 2011-11-07 12:42:54 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 64491 1 mnaganov eric abarth dpranke eric inferno ojan rniwa tony webkit.review.bot oldest_to_newest 416413 0 mnaganov 2011-06-07 02:39:39 -0700 This is a really useful thing for reproducing flaky test failures. What I'm doing now is replicating my test into a thousand files with different names, and passing them to nwrt. 492056 1 eric 2011-10-27 16:06:46 -0700 *** Bug 65894 has been marked as a duplicate of this bug. *** 496995 2 113828 eric 2011-11-06 23:46:52 -0800 Created attachment 113828 Patch 496996 3 eric 2011-11-06 23:48:24 -0800 Dirk: I assume it's kosher that I'm making self._test_files_list out of sync (count-wise) with self._test_files? I mean, I guess it's not really out of sync since the list would still colapse down to a set, but there are repeats in self._test_files_list. I assume this approximately matches what NRWT would do if I passed it: new-run-webkit-tests foo.html foo.html 497345 4 113828 dpranke 2011-11-07 11:45:33 -0800 Comment on attachment 113828 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113828&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:507 > + # FIXME: It's unclear how --repeat-each and --iterations should interact with chunks? I'd probably just make them mutually exclusive for now. chunks are only used on the bots and aren't likely to need either of those flags. Change looks fine. I'm cq-'ing it in case you want to make the flags mutually exclusive as I suggest (and possibly add some tests enforcing that). I don't feel strongly about it, however, so you can leave things as-is or just update the fixme to say that you should make them mutually exclusive at some point. 497368 5 113828 eric 2011-11-07 12:25:09 -0800 Comment on attachment 113828 Patch Thanks for the review! I think I'll just leave the code as-is for now, and see if anyone complains. :) I think the behavior as written is reasonable, and probably slightly better than an assert. 497385 6 113828 webkit.review.bot 2011-11-07 12:42:49 -0800 Comment on attachment 113828 Patch Clearing flags on attachment: 113828 Committed r99461: <http://trac.webkit.org/changeset/99461> 497386 7 webkit.review.bot 2011-11-07 12:42:54 -0800 All reviewed patches have been landed. Closing bug. 113828 2011-11-06 23:46:52 -0800 2011-11-07 12:42:49 -0800 Patch bug-62199-20111106234651.patch text/plain 4618 eric U3VidmVyc2lvbiBSZXZpc2lvbjogOTkzODEKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1MWNiMDQ3ZDZkMzBjMmY2NzA2OGJkMjdhN2VjNzY3ZjI4 NjQ4OTgyLi44Yzk4NWRkNjBhMGU4N2U3ZjY1OWIwNDYwMjMzNTI1YzQ4NTUzYjBlIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYg QEAKIDIwMTEtMTEtMDYgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAg IG5ldy1ydW4td2Via2l0LXRlc3RzOiBzdXBwb3J0IC0tcmVwZWF0LWVhY2ggZmVhdHVyZSBmcm9t IG9sZC1ydW4td2Via2l0LXRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02MjE5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMv bWFuYWdlci5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5f d2Via2l0X3Rlc3RzLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3J1bl93ZWJraXRfdGVzdHNfaW50ZWdyYXRpb250ZXN0LnB5OgorCisyMDExLTExLTA2ICBFcmlj IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKwogICAgICAgICBDbGFyaWZ5IGhvdyB0aGUgc3lt Ym9sIGFuZCBydW50aW1lLWZlYXR1cmUgYmFzZWQgdGVzdCBleGNsdXNpb24gd29ya3MgYW5kIGNs ZWFudXAgdGhlIGNvZGUgYSBiaXQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTY2MDc4CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyLnB5CmluZGV4IDk1YTJjMTQ3MjA4 MGRmZTNlMzNkNjIyZjE1MzhmZjM1ZDc1YTAyYTcuLmQzOTEyMjQ2MWZlNTQ5OTg1NmEwNGMwNDU1 NDRlMDgwZjBkMTNhYzUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlci5weQpAQCAtNTA0LDYgKzUwNCwxNiBA QCBjbGFzcyBNYW5hZ2VyKG9iamVjdCk6CiAKICAgICAgICAgc2tpcHBlZCA9IHNlbGYuX3NwbGl0 X2ludG9fY2h1bmtzX2lmX25lY2Vzc2FyeShza2lwcGVkKQogCisgICAgICAgICMgRklYTUU6IEl0 J3MgdW5jbGVhciBob3cgLS1yZXBlYXQtZWFjaCBhbmQgLS1pdGVyYXRpb25zIHNob3VsZCBpbnRl cmFjdCB3aXRoIGNodW5rcz8KKyAgICAgICAgaWYgc2VsZi5fb3B0aW9ucy5yZXBlYXRfZWFjaDoK KyAgICAgICAgICAgIGxpc3Rfd2l0aF9yZXBldGl0aW9ucyA9IFtdCisgICAgICAgICAgICBmb3Ig dGVzdCBpbiBzZWxmLl90ZXN0X2ZpbGVzX2xpc3Q6CisgICAgICAgICAgICAgICAgbGlzdF93aXRo X3JlcGV0aXRpb25zICs9IChbdGVzdF0gKiBzZWxmLl9vcHRpb25zLnJlcGVhdF9lYWNoKQorICAg ICAgICAgICAgc2VsZi5fdGVzdF9maWxlc19saXN0ID0gbGlzdF93aXRoX3JlcGV0aXRpb25zCisK KyAgICAgICAgaWYgc2VsZi5fb3B0aW9ucy5pdGVyYXRpb25zOgorICAgICAgICAgICAgc2VsZi5f dGVzdF9maWxlc19saXN0ID0gc2VsZi5fdGVzdF9maWxlc19saXN0ICogc2VsZi5fb3B0aW9ucy5p dGVyYXRpb25zCisKICAgICAgICAgcmVzdWx0X3N1bW1hcnkgPSBSZXN1bHRTdW1tYXJ5KHNlbGYu X2V4cGVjdGF0aW9ucywgc2VsZi5fdGVzdF9maWxlcyB8IHNraXBwZWQpCiAgICAgICAgIHNlbGYu X3ByaW50X2V4cGVjdGVkX3Jlc3VsdHNfb2ZfdHlwZShyZXN1bHRfc3VtbWFyeSwgdGVzdF9leHBl Y3RhdGlvbnMuUEFTUywgInBhc3NlcyIpCiAgICAgICAgIHNlbGYuX3ByaW50X2V4cGVjdGVkX3Jl c3VsdHNfb2ZfdHlwZShyZXN1bHRfc3VtbWFyeSwgdGVzdF9leHBlY3RhdGlvbnMuRkFJTCwgImZh aWx1cmVzIikKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3J1bl93ZWJraXRfdGVzdHMucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9ydW5fd2Via2l0X3Rlc3RzLnB5CmluZGV4IDMyNGY4ZjI1N2IxNTA4N2NjY2VjMGI0NDFmZDM5 MGEzOWVhZjVmNDcuLjZkNjI3YjY0OGI3YTJkMmZhMWRmY2EzOWE0ZGMyOWY3ZWVhZTA4ZDAgMTAw NzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRf dGVzdHMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dl YmtpdF90ZXN0cy5weQpAQCAtMzg3LDggKzM4Nyw4IEBAIGRlZiBwYXJzZV9hcmdzKGFyZ3M9Tm9u ZSk6CiAgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLWV4aXQtYWZ0ZXItbi1jcmFzaGVz LW9yLXRpbWVvdXRzIiwgdHlwZT0iaW50IiwKICAgICAgICAgICAgIGRlZmF1bHQ9MjAsIGhlbHA9 IkV4aXQgYWZ0ZXIgdGhlIGZpcnN0IE4gY3Jhc2hlcyBpbnN0ZWFkIG9mICIKICAgICAgICAgICAg ICJydW5uaW5nIGFsbCB0ZXN0cyIpLAotICAgICAgICAjIEZJWE1FOiBjb25zaWRlcjogLS1pdGVy YXRpb25zIG4KLSAgICAgICAgIyAgICAgIE51bWJlciBvZiB0aW1lcyB0byBydW4gdGhlIHNldCBv ZiB0ZXN0cyAoZS5nLiBBQkNBQkNBQkMpCisgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCIt LWl0ZXJhdGlvbnMiLCB0eXBlPSJpbnQiLCBoZWxwPSJOdW1iZXIgb2YgdGltZXMgdG8gcnVuIHRo ZSBzZXQgb2YgdGVzdHMgKGUuZy4gQUJDQUJDQUJDKSIpLAorICAgICAgICBvcHRwYXJzZS5tYWtl X29wdGlvbigiLS1yZXBlYXQtZWFjaCIsIHR5cGU9ImludCIsIGhlbHA9Ik51bWJlciBvZiB0aW1l cyB0byBydW4gZWFjaCB0ZXN0IChlLmcuIEFBQUJCQkNDQykiKSwKICAgICAgICAgb3B0cGFyc2Uu bWFrZV9vcHRpb24oIi0tcmV0cnktZmFpbHVyZXMiLCBhY3Rpb249InN0b3JlX3RydWUiLAogICAg ICAgICAgICAgZGVmYXVsdD1UcnVlLAogICAgICAgICAgICAgaGVscD0iUmUtdHJ5IGFueSB0ZXN0 cyB0aGF0IHByb2R1Y2UgdW5leHBlY3RlZCByZXN1bHRzIChkZWZhdWx0KSIpLApkaWZmIC0tZ2l0 IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0c19p bnRlZ3JhdGlvbnRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9y dW5fd2Via2l0X3Rlc3RzX2ludGVncmF0aW9udGVzdC5weQppbmRleCA3YWI3YmRlNzkwOTA2MGRl OWQ0NTcwMmVmM2UxMWY1Mzk5MGUyOGQ0Li4xYjcwNGJjMDc0ZWJhYjk1MWI0OGUyOTdjMDMzOTE5 NjkyYmUyNDdkIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9ydW5fd2Via2l0X3Rlc3RzX2ludGVncmF0aW9udGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzX2ludGVncmF0aW9udGVzdC5w eQpAQCAtMzI2LDYgKzMyNiwxNiBAQCBjbGFzcyBNYWluVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6 CiAgICAgZGVmIHRlc3RfdGhyZWFkZWQoc2VsZik6CiAgICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZShw YXNzaW5nX3J1bihbJy0tdGhyZWFkZWQnXSkpCiAKKyAgICBkZWYgdGVzdF9yZXBlYXRfZWFjaChz ZWxmKToKKyAgICAgICAgdGVzdHNfdG9fcnVuID0gWydwYXNzZXMvaW1hZ2UuaHRtbCcsICdwYXNz ZXMvdGV4dC5odG1sJ10KKyAgICAgICAgdGVzdHNfcnVuID0gZ2V0X3Rlc3RzX3J1bihbJy0tcmVw ZWF0LWVhY2gnLCAnMiddICsgdGVzdHNfdG9fcnVuLCB0ZXN0c19pbmNsdWRlZD1UcnVlLCBmbGF0 dGVuX2JhdGNoZXM9VHJ1ZSkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHModGVzdHNfcnVuLCBb J3Bhc3Nlcy9pbWFnZS5odG1sJywgJ3Bhc3Nlcy9pbWFnZS5odG1sJywgJ3Bhc3Nlcy90ZXh0Lmh0 bWwnLCAncGFzc2VzL3RleHQuaHRtbCddKQorCisgICAgZGVmIHRlc3RfaXRlcmF0aW9ucyhzZWxm KToKKyAgICAgICAgdGVzdHNfdG9fcnVuID0gWydwYXNzZXMvaW1hZ2UuaHRtbCcsICdwYXNzZXMv dGV4dC5odG1sJ10KKyAgICAgICAgdGVzdHNfcnVuID0gZ2V0X3Rlc3RzX3J1bihbJy0taXRlcmF0 aW9ucycsICcyJ10gKyB0ZXN0c190b19ydW4sIHRlc3RzX2luY2x1ZGVkPVRydWUsIGZsYXR0ZW5f YmF0Y2hlcz1UcnVlKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFscyh0ZXN0c19ydW4sIFsncGFz c2VzL2ltYWdlLmh0bWwnLCAncGFzc2VzL3RleHQuaHRtbCcsICdwYXNzZXMvaW1hZ2UuaHRtbCcs ICdwYXNzZXMvdGV4dC5odG1sJ10pCisKICAgICBkZWYgdGVzdF9ydW5fY2h1bmsoc2VsZik6CiAg ICAgICAgICMgVGVzdCB0aGF0IHdlIGFjdHVhbGx5IHNlbGVjdCB0aGUgcmlnaHQgY2h1bmsKICAg ICAgICAgYWxsX3Rlc3RzX3J1biA9IGdldF90ZXN0c19ydW4oZmxhdHRlbl9iYXRjaGVzPVRydWUp Cg==