62186 2011-06-06 22:17:37 -0700 [chromium] Make VideoFrameChromium's destructor virtual 2011-06-06 23:11:23 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thakis thakis webkit.review.bot oldest_to_newest 416322 0 thakis 2011-06-06 22:17:37 -0700 [chromium] Make VideoFrameChromium's destructor virtual 416325 1 96202 thakis 2011-06-06 22:20:33 -0700 Created attachment 96202 Patch 416331 2 thakis 2011-06-06 22:22:29 -0700 I missed this because it's virtually identical to bug 61742. Very similar code in WebMediaPlayerClientImpl::putCurrentFrame (in WebKit/chromium/src/WebMediaPlayerClientImpl) and WebMediaPlayerImpl::putCurrentFrame (in webkit/glue/webmediaplayer_impl.cc) :-/ 416360 3 96202 webkit.review.bot 2011-06-06 23:11:19 -0700 Comment on attachment 96202 Patch Clearing flags on attachment: 96202 Committed r88220: <http://trac.webkit.org/changeset/88220> 416361 4 webkit.review.bot 2011-06-06 23:11:23 -0700 All reviewed patches have been landed. Closing bug. 96202 2011-06-06 22:20:33 -0700 2011-06-06 23:11:19 -0700 Patch bug-62186-20110606222031.patch text/plain 2350 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogODgyMTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiMWU0NTkyOTg2ZDlmZTQy NzI5ZWVlYTRmZDY2OWMwMWE3ZDRlYTk5Li5jNzJjNDIwNzk5MTIwZmM5MWY4YTM1Mjc5NzBhYmIy ODJhMWU4YzQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDYtMDYgIE5pY28g V2ViZXIgIDx0aGFraXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gTWFrZSBWaWRlb0ZyYW1lQ2hyb21pdW0n cyBkZXN0cnVjdG9yIHZpcnR1YWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTYyMTg2CisKKyAgICAgICAgVGhpcyBmaXhlcyBhIHJlYWwgYnVnLCBzaW5j ZSBXZWJNZWRpYVBsYXllckNsaWVudEltcGw6OnB1dEN1cnJlbnRGcmFtZQorICAgICAgICBkZWxl dGVzIGEgVmlkZW9GcmFtZUNocm9taXVtIHN1YmNsYXNzIHR5cGUgdGhyb3VnaCB0aGlzIGludGVy ZmFjZQorICAgICAgICBjbGFzcywgY2F1c2luZyB+VmlkZW9GcmFtZUNocm9taXVtSW1wbCdzIGRl c3RydWN0b3Igbm90IHRvIHJ1bi4KKyAgICAgICAgKFZpZGVvRnJhbWVDaHJvaW11bUltcGwgaGFw cGVucyB0byBub3QgaGF2ZSBhIGRlc3RydWN0b3Igb3IgYW55CisgICAgICAgIG5vbi1QT0QgbWVt YmVyIHZhcmlhYmxlcywgc28gaXQncyBtb3JlIGEgbGF0ZW50IGJ1Zy4pCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9WaWRlb0ZyYW1lQ2hyb21pdW0uY3BwOgorICAgICAg ICAoV2ViQ29yZTo6VmlkZW9GcmFtZUNocm9taXVtOjp+VmlkZW9GcmFtZUNocm9taXVtKToKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9WaWRlb0ZyYW1lQ2hyb21pdW0uaDoK KwogMjAxMS0wNi0wNiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+ CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjg4MjAyLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVmlkZW9GcmFtZUNocm9t aXVtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1ZpZGVv RnJhbWVDaHJvbWl1bS5jcHAKaW5kZXggNDNiNDBlMjY3NjliYzM5YmMxZDliMTFjMzJlMDY2YzYx NTk4OTUyMC4uY2E5Mjg0MjI0MjEzNTQxMTFjNjliYzgzOTNjYTViNTY1M2M5NjMxMCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVmlkZW9GcmFt ZUNocm9taXVtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJv bWl1bS9WaWRlb0ZyYW1lQ2hyb21pdW0uY3BwCkBAIC00Miw2ICs0Miw4IEBAIGNvbnN0IHVuc2ln bmVkIFZpZGVvRnJhbWVDaHJvbWl1bTo6eVBsYW5lID0gMDsKIGNvbnN0IHVuc2lnbmVkIFZpZGVv RnJhbWVDaHJvbWl1bTo6dVBsYW5lID0gMTsKIGNvbnN0IHVuc2lnbmVkIFZpZGVvRnJhbWVDaHJv bWl1bTo6dlBsYW5lID0gMjsKIAorVmlkZW9GcmFtZUNocm9taXVtOjp+VmlkZW9GcmFtZUNocm9t aXVtKCkgeyB9CisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIAogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9WaWRlb0ZyYW1lQ2hyb21pdW0u aCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1ZpZGVvRnJhbWVD aHJvbWl1bS5oCmluZGV4IGFiNjY5ZDFkM2U0NGI5N2RiNDkyNWJiMGRkZWI4N2NlYmE0OTIyMjAu LjI1MjBiNmIyNTBmNDMyOTdjNTExYmViMzY0M2QwM2FhYzI4YWU0ZmIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1ZpZGVvRnJhbWVDaHJvbWl1 bS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1ZpZGVv RnJhbWVDaHJvbWl1bS5oCkBAIC02Niw2ICs2Niw3IEBAIHB1YmxpYzoKICAgICAgICAgVHlwZVRl eHR1cmUsCiAgICAgfTsKIAorICAgIHZpcnR1YWwgflZpZGVvRnJhbWVDaHJvbWl1bSgpOwogICAg IHZpcnR1YWwgU3VyZmFjZVR5cGUgc3VyZmFjZVR5cGUoKSBjb25zdCA9IDA7CiAgICAgdmlydHVh bCBGb3JtYXQgZm9ybWF0KCkgY29uc3QgPSAwOwogICAgIHZpcnR1YWwgdW5zaWduZWQgd2lkdGgo KSBjb25zdCA9IDA7Cg==