62173 2011-06-06 18:18:27 -0700 [EFL] Remove JSC dependency from WebKit/efl 2011-06-07 08:54:45 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60244 0 ryuan.choi webkit-unassigned commit-queue gyuyoung.kim kenneth lucas.de.marchi tonikitoo oldest_to_newest 416196 0 ryuan.choi 2011-06-06 18:18:27 -0700 patch will be updated. 416197 1 96169 ryuan.choi 2011-06-06 18:21:54 -0700 Created attachment 96169 Patch 416286 2 96169 tonikitoo 2011-06-06 21:23:31 -0700 Comment on attachment 96169 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96169&action=review > Source/WebKit/efl/ChangeLog:9 > + Change JSC::initializeThreading() and WTF::initializeMainThread() to > + WebCore::ScriptController::initializeThreading(). Could you explain why, please? 416312 3 ryuan.choi 2011-06-06 21:59:24 -0700 (In reply to comment #2) > (From update of attachment 96169 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=96169&action=review > > > Source/WebKit/efl/ChangeLog:9 > > + Change JSC::initializeThreading() and WTF::initializeMainThread() to > > + WebCore::ScriptController::initializeThreading(). > > Could you explain why, please? ScriptController::initializeThreading() hide above two functions to build WebKit/EFL with v8. I can recreate this patch if you want to comment it in ChangeLog. :) Thanks. 416314 4 gyuyoung.kim 2011-06-06 22:02:46 -0700 Yes, you have to mention the reason in Changelog. 416328 5 96204 ryuan.choi 2011-06-06 22:21:31 -0700 Created attachment 96204 Patch 416330 6 ryuan.choi 2011-06-06 22:22:04 -0700 (In reply to comment #4) > Yes, you have to mention the reason in Changelog. Done. 416492 7 96204 leandro 2011-06-07 07:37:37 -0700 Comment on attachment 96204 Patch LGTM. 416532 8 commit-queue 2011-06-07 08:53:02 -0700 The commit-queue encountered the following flaky tests while processing attachment 96204: inspector/debugger/source-frame.html bug 57399 (author: podivilov@chromium.org) The commit-queue is continuing to process your patch. 416533 9 96204 commit-queue 2011-06-07 08:54:39 -0700 Comment on attachment 96204 Patch Clearing flags on attachment: 96204 Committed r88241: <http://trac.webkit.org/changeset/88241> 416534 10 commit-queue 2011-06-07 08:54:45 -0700 All reviewed patches have been landed. Closing bug. 96169 2011-06-06 18:21:54 -0700 2011-06-06 22:21:22 -0700 Patch bug-62173-20110607102154.patch text/plain 1596 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogODgxOTkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCAwOGM0ZDk1NTRl MGFhMzAxZGI1ZDg0NzNhNTQzODU5YmZmYzIyYzRhLi4wNDM5OWY5OGFhOGUyZTA3OWI5ODM4YzJk MjYwNTg0OWQyNWFiYzk3IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEt MDYtMDYgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIFJlbW92ZSBKU0MgZGVw ZW5kZW5jeSBmcm9tIFdlYktpdC9lZmwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTYyMTczCisKKyAgICAgICAgQ2hhbmdlIEpTQzo6aW5pdGlhbGl6ZVRo cmVhZGluZygpIGFuZCBXVEY6OmluaXRpYWxpemVNYWluVGhyZWFkKCkgdG8KKyAgICAgICAgV2Vi Q29yZTo6U2NyaXB0Q29udHJvbGxlcjo6aW5pdGlhbGl6ZVRocmVhZGluZygpLgorCisgICAgICAg ICogZXdrL2V3a19tYWluLmNwcDoKKyAgICAgICAgKF9ld2tfaW5pdF9ib2R5KTogCisKIDIwMTEt MDYtMDMgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI4ODAxNC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvZWZsL2V3ay9ld2tfbWFpbi5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX21h aW4uY3BwCmluZGV4IDhjYTg3ZDEwYWUzYTdkMGQzMmVjYTU1OGJlMWMwMTczNzVhNmRhMGMuLmJm YmUzZjdhNzcwNDE0ZjE4OGVmODM2NmY5NjZjY2I2YjRkZDIzZDAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfbWFpbi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdr L2V3a19tYWluLmNwcApAQCAtMjYsNiArMjYsNyBAQAogI2luY2x1ZGUgIkxvZ2dpbmcuaCIKICNp bmNsdWRlICJQYWdlQ2FjaGUuaCIKICNpbmNsdWRlICJQYWdlR3JvdXAuaCIKKyNpbmNsdWRlICJT Y3JpcHRDb250cm9sbGVyLmgiCiAjaW5jbHVkZSAiZXdrX3ByaXZhdGUuaCIKICNpbmNsdWRlICJl d2tfc2V0dGluZ3MuaCIKICNpbmNsdWRlICJydW50aW1lL0luaXRpYWxpemVUaHJlYWRpbmcuaCIK QEAgLTE3NCw4ICsxNzUsNyBAQCBFaW5hX0Jvb2wgX2V3a19pbml0X2JvZHkodm9pZCkKICAgICAg ICAgICAgICJ3b3JrIChpZTogQWRvYmUgRmxhc2gpIik7CiAjZW5kaWYKIAotICAgIEpTQzo6aW5p dGlhbGl6ZVRocmVhZGluZygpOwotICAgIFdURjo6aW5pdGlhbGl6ZU1haW5UaHJlYWQoKTsKKyAg ICBXZWJDb3JlOjpTY3JpcHRDb250cm9sbGVyOjppbml0aWFsaXplVGhyZWFkaW5nKCk7CiAgICAg V2ViQ29yZTo6SW5pdGlhbGl6ZUxvZ2dpbmdDaGFubmVsc0lmTmVjZXNzYXJ5KCk7CiAKICAgICAv LyBQYWdlIGNhY2hlIGNhcGFjaXR5IChpbiBwYWdlcykuIENvbW1lbnQgZnJvbSBNYWMgcG9ydDoK 96204 2011-06-06 22:21:31 -0700 2011-06-07 08:54:39 -0700 Patch bug-62173-20110607142132.patch text/plain 1689 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogODgxOTkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCAwOGM0ZDk1NTRl MGFhMzAxZGI1ZDg0NzNhNTQzODU5YmZmYzIyYzRhLi5kNmQ0MTQ3MWNhM2VlODQ1Zjk5MDg3Mzc2 MmYxN2RjNzA4OTkxZjlmIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEt MDYtMDYgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIFJlbW92ZSBKU0MgZGVw ZW5kZW5jeSBmcm9tIFdlYktpdC9lZmwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTYyMTczCisKKyAgICAgICAgQ2hhbmdlIEpTQzo6aW5pdGlhbGl6ZVRo cmVhZGluZygpIGFuZCBXVEY6OmluaXRpYWxpemVNYWluVGhyZWFkKCkgdG8KKyAgICAgICAgV2Vi Q29yZTo6U2NyaXB0Q29udHJvbGxlcjo6aW5pdGlhbGl6ZVRocmVhZGluZygpIHdoaWNoIGNvbnRh aW5zIHRoZXNlCisgICAgICAgIGZ1bmN0aW9ucyBhbmQgcmVtb3ZlIEpTQyBkZXBlbmRlbmN5IHRv IGJ1aWxkIHdlYmtpdC9lZmwgd2l0aCB2OC4KKworICAgICAgICAqIGV3ay9ld2tfbWFpbi5jcHA6 CisgICAgICAgIChfZXdrX2luaXRfYm9keSk6CisKIDIwMTEtMDYtMDMgIFNoZXJpZmYgQm90ICA8 d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxp bmcgb3V0IHI4ODAxNC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfbWFp bi5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX21haW4uY3BwCmluZGV4IDhjYTg3ZDEw YWUzYTdkMGQzMmVjYTU1OGJlMWMwMTczNzVhNmRhMGMuLmJmYmUzZjdhNzcwNDE0ZjE4OGVmODM2 NmY5NjZjY2I2YjRkZDIzZDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tf bWFpbi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19tYWluLmNwcApAQCAtMjYs NiArMjYsNyBAQAogI2luY2x1ZGUgIkxvZ2dpbmcuaCIKICNpbmNsdWRlICJQYWdlQ2FjaGUuaCIK ICNpbmNsdWRlICJQYWdlR3JvdXAuaCIKKyNpbmNsdWRlICJTY3JpcHRDb250cm9sbGVyLmgiCiAj aW5jbHVkZSAiZXdrX3ByaXZhdGUuaCIKICNpbmNsdWRlICJld2tfc2V0dGluZ3MuaCIKICNpbmNs dWRlICJydW50aW1lL0luaXRpYWxpemVUaHJlYWRpbmcuaCIKQEAgLTE3NCw4ICsxNzUsNyBAQCBF aW5hX0Jvb2wgX2V3a19pbml0X2JvZHkodm9pZCkKICAgICAgICAgICAgICJ3b3JrIChpZTogQWRv YmUgRmxhc2gpIik7CiAjZW5kaWYKIAotICAgIEpTQzo6aW5pdGlhbGl6ZVRocmVhZGluZygpOwot ICAgIFdURjo6aW5pdGlhbGl6ZU1haW5UaHJlYWQoKTsKKyAgICBXZWJDb3JlOjpTY3JpcHRDb250 cm9sbGVyOjppbml0aWFsaXplVGhyZWFkaW5nKCk7CiAgICAgV2ViQ29yZTo6SW5pdGlhbGl6ZUxv Z2dpbmdDaGFubmVsc0lmTmVjZXNzYXJ5KCk7CiAKICAgICAvLyBQYWdlIGNhY2hlIGNhcGFjaXR5 IChpbiBwYWdlcykuIENvbW1lbnQgZnJvbSBNYWMgcG9ydDoK