62171 2011-06-06 17:56:36 -0700 Allow copying of KeyframeValueList 2011-06-06 21:43:01 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 noam noam simon.fraser webkit.review.bot oldest_to_newest 416184 0 noam 2011-06-06 17:56:36 -0700 For accelerated-compositing serialization in WebKit2, we need to copy around the KeyframeValueList structure. Right now it's non-copyable, which can be rectified. 416187 1 96166 noam 2011-06-06 18:02:21 -0700 Created attachment 96166 Patch 416298 2 96166 webkit.review.bot 2011-06-06 21:42:57 -0700 Comment on attachment 96166 Patch Clearing flags on attachment: 96166 Committed r88215: <http://trac.webkit.org/changeset/88215> 416299 3 webkit.review.bot 2011-06-06 21:43:01 -0700 All reviewed patches have been landed. Closing bug. 96166 2011-06-06 18:02:21 -0700 2011-06-06 21:42:57 -0700 Patch bug-62171-20110606180029.patch text/plain 3289 noam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4MjA2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDYtMDYgIE5vJ2FtIFJv c2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbGxvdyBjb3B5aW5nIG9mIEtleWZyYW1lVmFs dWVMaXN0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NjIxNzEKKworICAgICAgICBNYWtlIGEgZGVlcCBjb3B5IG9mIEtleWZyYW1lVmFsdWVMaXN0LCBj b3B5aW5nIGVhY2ggb2YgdGhlIGtleWZyYW1lcyB3aXRoIGEgdmlydHVhbCBjbG9uZSgpIGZ1bmN0 aW9uLgorCisgICAgICAgIE5vIG5ldyBmdW5jdGlvbmFsaXR5IHNvIG5vIG5ldyB0ZXN0cy4KKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXIuaDoKKyAgICAgICAgKFdl YkNvcmU6OkZsb2F0QW5pbWF0aW9uVmFsdWU6OmNsb25lKToKKyAgICAgICAgKFdlYkNvcmU6OlRy YW5zZm9ybUFuaW1hdGlvblZhbHVlOjpUcmFuc2Zvcm1BbmltYXRpb25WYWx1ZSk6CisgICAgICAg IChXZWJDb3JlOjpUcmFuc2Zvcm1BbmltYXRpb25WYWx1ZTo6Y2xvbmUpOgorICAgICAgICAoV2Vi Q29yZTo6VHJhbnNmb3JtQW5pbWF0aW9uVmFsdWU6OnZhbHVlKToKKyAgICAgICAgKFdlYkNvcmU6 OktleWZyYW1lVmFsdWVMaXN0OjpLZXlmcmFtZVZhbHVlTGlzdCk6CisKIDIwMTEtMDYtMDYgIEVt aWwgQSBFa2x1bmQgIDxlYWVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVy aWMgU2VpZGVsLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhp Y3NMYXllci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L0dyYXBoaWNzTGF5ZXIuaAkocmV2aXNpb24gODgyMDQpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTkwLDcgKzkw LDYgQEAgY2xhc3MgVGltaW5nRnVuY3Rpb247CiAvLyByZXByZXNlbnQgdmFsdWVzIGZvciBwcm9w ZXJ0aWVzIGJlaW5nIGFuaW1hdGVkIHZpYSB0aGUgR3JhcGhpY3NMYXllciwKIC8vIHdpdGhvdXQg cHVsbGluZyBpbiBzdHlsZS1yZWxhdGVkIGRhdGEgZnJvbSBvdXRzaWRlIG9mIHRoZSBwbGF0Zm9y bSBkaXJlY3RvcnkuCiBjbGFzcyBBbmltYXRpb25WYWx1ZSB7Ci0gICAgV1RGX01BS0VfTk9OQ09Q WUFCTEUoQW5pbWF0aW9uVmFsdWUpOyBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsKIHB1YmxpYzoK ICAgICBBbmltYXRpb25WYWx1ZShmbG9hdCBrZXlUaW1lLCBQYXNzUmVmUHRyPFRpbWluZ0Z1bmN0 aW9uPiB0aW1pbmdGdW5jdGlvbiA9IDApCiAgICAgICAgIDogbV9rZXlUaW1lKGtleVRpbWUpCkBA IC0xMDMsNiArMTAyLDcgQEAgcHVibGljOgogCiAgICAgZmxvYXQga2V5VGltZSgpIGNvbnN0IHsg cmV0dXJuIG1fa2V5VGltZTsgfQogICAgIGNvbnN0IFRpbWluZ0Z1bmN0aW9uKiB0aW1pbmdGdW5j dGlvbigpIGNvbnN0IHsgcmV0dXJuIG1fdGltaW5nRnVuY3Rpb24uZ2V0KCk7IH0KKyAgICB2aXJ0 dWFsIEFuaW1hdGlvblZhbHVlKiBjbG9uZSgpIGNvbnN0ID0gMDsKIAogcHJpdmF0ZToKICAgICBm bG9hdCBtX2tleVRpbWU7CkBAIC0xMTcsNiArMTE3LDcgQEAgcHVibGljOgogICAgICAgICAsIG1f dmFsdWUodmFsdWUpCiAgICAgewogICAgIH0KKyAgICB2aXJ0dWFsIEFuaW1hdGlvblZhbHVlKiBj bG9uZSgpIGNvbnN0IHsgcmV0dXJuIG5ldyBGbG9hdEFuaW1hdGlvblZhbHVlKCp0aGlzKTsgfQog CiAgICAgZmxvYXQgdmFsdWUoKSBjb25zdCB7IHJldHVybiBtX3ZhbHVlOyB9CiAKQEAgLTEzMSwy NiArMTMyLDMzIEBAIHB1YmxpYzoKICAgICAgICAgOiBBbmltYXRpb25WYWx1ZShrZXlUaW1lLCB0 aW1pbmdGdW5jdGlvbikKICAgICB7CiAgICAgICAgIGlmICh2YWx1ZSkKLSAgICAgICAgICAgIG1f dmFsdWUgPSBhZG9wdFB0cihuZXcgVHJhbnNmb3JtT3BlcmF0aW9ucygqdmFsdWUpKTsKKyAgICAg ICAgICAgIG1fdmFsdWUgPSAqdmFsdWU7CiAgICAgfQorICAgIHZpcnR1YWwgQW5pbWF0aW9uVmFs dWUqIGNsb25lKCkgY29uc3QgeyByZXR1cm4gbmV3IFRyYW5zZm9ybUFuaW1hdGlvblZhbHVlKCp0 aGlzKTsgfQogCi0gICAgY29uc3QgVHJhbnNmb3JtT3BlcmF0aW9ucyogdmFsdWUoKSBjb25zdCB7 IHJldHVybiBtX3ZhbHVlLmdldCgpOyB9CisgICAgY29uc3QgVHJhbnNmb3JtT3BlcmF0aW9ucyog dmFsdWUoKSBjb25zdCB7IHJldHVybiAmbV92YWx1ZTsgfQogCiBwcml2YXRlOgotICAgIE93blB0 cjxUcmFuc2Zvcm1PcGVyYXRpb25zPiBtX3ZhbHVlOworICAgIFRyYW5zZm9ybU9wZXJhdGlvbnMg bV92YWx1ZTsKIH07CiAKIC8vIFVzZWQgdG8gc3RvcmUgYSBzZXJpZXMgb2YgdmFsdWVzIGluIGEg a2V5ZnJhbWUgbGlzdC4gVmFsdWVzIHdpbGwgYWxsIGJlIG9mIHRoZSBzYW1lIHR5cGUsCiAvLyB3 aGljaCBjYW4gYmUgaW5mZXJyZWQgZnJvbSB0aGUgcHJvcGVydHkuCiBjbGFzcyBLZXlmcmFtZVZh bHVlTGlzdCB7Ci0gICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoS2V5ZnJhbWVWYWx1ZUxpc3QpOyBX VEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsKIHB1YmxpYzoKIAogICAgIEtleWZyYW1lVmFsdWVMaXN0 KEFuaW1hdGVkUHJvcGVydHlJRCBwcm9wZXJ0eSkKICAgICAgICAgOiBtX3Byb3BlcnR5KHByb3Bl cnR5KQogICAgIHsKICAgICB9Ci0gICAgCisKKyAgICBLZXlmcmFtZVZhbHVlTGlzdChjb25zdCBL ZXlmcmFtZVZhbHVlTGlzdCYgb3RoZXIpCisgICAgICAgIDogbV9wcm9wZXJ0eShvdGhlci5wcm9w ZXJ0eSgpKQorICAgIHsKKyAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBvdGhlci5tX3Zh bHVlcy5zaXplKCk7ICsraSkKKyAgICAgICAgICAgIG1fdmFsdWVzLmFwcGVuZChvdGhlci5tX3Zh bHVlc1tpXS0+Y2xvbmUoKSk7CisgICAgfQorCiAgICAgfktleWZyYW1lVmFsdWVMaXN0KCkKICAg ICB7CiAgICAgICAgIGRlbGV0ZUFsbFZhbHVlcyhtX3ZhbHVlcyk7Cg==