62168 2011-06-06 17:11:27 -0700 error: converting 'false' to pointer type when compiling with gcc-4.6.0 2011-08-23 13:11:05 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 asharif.tools webkit-unassigned abarth dglazkov thakis webkit.review.bot oldest_to_newest 416142 0 asharif.tools 2011-06-06 17:11:27 -0700 third_party/WebKit/Source/WebCore/dom/Element.cpp: In member function 'virtual void WebCore::Element::recalcStyle(WebCore::Node::StyleChange)': third_party/WebKit/Source/WebCore/dom/Element.cpp:1098:112: error: converting 'false' to pointer type 'WebCore::RenderStyle*' [-Werror=conversion-null] This can easily be fixed in the source (1 line change). 416146 1 asharif.tools 2011-06-06 17:13:08 -0700 Index: Element.cpp =================================================================== --- Element.cpp (revision 87771) +++ Element.cpp (working copy) @@ -1095,7 +1095,7 @@ { // Ref currentStyle in case it would otherwise be deleted when setRenderStyle() is called. RefPtr<RenderStyle> currentStyle(renderStyle()); - bool hasParentStyle = parentNodeForRenderingAndStyle() ? parentNodeForRenderingAndStyle()->renderStyle() : false; + bool hasParentStyle = parentNodeForRenderingAndStyle() ? (parentNodeForRenderingAndStyle()->renderStyle()? true:false) : false; bool hasDirectAdjacentRules = currentStyle && currentStyle->childrenAffectedByDirectAdjacentRules(); bool hasIndirectAdjacentRules = currentStyle && currentStyle->childrenAffectedByForwardPositionalRules(); Seems to fix the warning. 450109 2 103692 asharif.tools 2011-08-11 15:51:27 -0700 Created attachment 103692 patch to fix some warnings. 450111 3 asharif.tools 2011-08-11 15:52:21 -0700 I attached a patch to fix the warnings. Can someone review and submit it? 450137 4 103692 abarth 2011-08-11 16:22:20 -0700 Comment on attachment 103692 patch to fix some warnings. View in context: https://bugs.webkit.org/attachment.cgi?id=103692&action=review > Source/WebCore/dom/Element.cpp:1100 > - bool hasParentStyle = parentNodeForRenderingAndStyle() ? parentNodeForRenderingAndStyle()->renderStyle() : false; > + bool hasParentStyle = parentNodeForRenderingAndStyle() ? (bool) parentNodeForRenderingAndStyle()->renderStyle() : false; WebKit usually uses c++ style casts, not c-style casts: static_cast<bool>(...) 450142 5 103692 asharif.tools 2011-08-11 16:33:07 -0700 Comment on attachment 103692 patch to fix some warnings. View in context: https://bugs.webkit.org/attachment.cgi?id=103692&action=review >> Source/WebCore/dom/Element.cpp:1100 >> + bool hasParentStyle = parentNodeForRenderingAndStyle() ? (bool) parentNodeForRenderingAndStyle()->renderStyle() : false; > > WebKit usually uses c++ style casts, not c-style casts: > > static_cast<bool>(...) What do you think between: bool hasParentStyle = parentNodeForRenderingAndStyle() ? (parentNodeForRenderingAndStyle()->renderStyle() ? true : false) : false; and bool hasParentStyle = parentNodeForRenderingAndStyle() ? static_cast<bool>(parentNodeForRenderingAndStyle()->renderStyle()) : false; 450151 6 abarth 2011-08-11 16:39:26 -0700 > bool hasParentStyle = parentNodeForRenderingAndStyle() ? static_cast<bool>(parentNodeForRenderingAndStyle()->renderStyle()) : false; ^^^ this one is preferred. 450154 7 103702 asharif.tools 2011-08-11 16:42:20 -0700 Created attachment 103702 Addressed reviewer's comments. 451214 8 asharif.tools 2011-08-15 12:28:08 -0700 Ping. Can this be reviewed again? 451216 9 thakis 2011-08-15 12:30:16 -0700 You need to set r? on your new patch. 451221 10 webkit.review.bot 2011-08-15 12:33:29 -0700 Attachment 103702 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 451326 11 thakis 2011-08-15 15:30:56 -0700 The changelog needs to have a link to the bug right after the title line, see the other changelog entries. 451421 12 103986 asharif.tools 2011-08-15 17:44:56 -0700 Created attachment 103986 Addressed reviewer's comments about patch ChangeLog formatting. 451852 13 asharif.tools 2011-08-16 14:01:00 -0700 Ping. Can this be reviewed? 451855 14 thakis 2011-08-16 14:03:28 -0700 You need to remove the "No new tests (OOPS)" line as well. See http://www.webkit.org/coding/contributing.html 451987 15 104120 asharif.tools 2011-08-16 16:49:16 -0700 Created attachment 104120 Removed the OOPS no new tests line. 451988 16 thakis 2011-08-16 16:50:01 -0700 Looks good. abarth, can you r+? 452071 17 104120 webkit.review.bot 2011-08-16 19:05:56 -0700 Comment on attachment 104120 Removed the OOPS no new tests line. Rejecting attachment 104120 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2 Last 500 characters of output: from bug 62168. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 2 Parsed 3 diffs from patch file(s). patching file Source/WebCore/ChangeLog patch: **** malformed patch at line 22: patching file Source/WebCore/dom/Element.cpp patching file Source/WebCore/platform/ScrollAnimatorNone.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 2 Full output: http://queues.webkit.org/results/9405502 453152 18 104366 asharif.tools 2011-08-18 11:06:03 -0700 Created attachment 104366 Rebased patch 453161 19 webkit.review.bot 2011-08-18 11:13:20 -0700 Attachment 104366 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 453184 20 104366 thakis 2011-08-18 11:31:21 -0700 Comment on attachment 104366 Rebased patch r- over stylebot complaint I stumbled over the two missing `return 0`s myself yesterday and I'm fixing them here: https://bugs.webkit.org/show_bug.cgi?id=66480 You can remove them from this patch. 453199 21 104373 asharif.tools 2011-08-18 11:44:12 -0700 Created attachment 104373 Addressed comments. 453200 22 webkit.review.bot 2011-08-18 11:46:27 -0700 Attachment 104373 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 453209 23 104373 darin 2011-08-18 11:51:45 -0700 Comment on attachment 104373 Addressed comments. View in context: https://bugs.webkit.org/attachment.cgi?id=104373&action=review >> Source/WebCore/ChangeLog:1 >> +2011-08-11 Ahmad Sharif <asharif@chromium.org> > > ChangeLog entry has no bug number [changelog/bugnumber] [5] Need to fix this. > Source/WebCore/dom/Element.cpp:1100 > + bool hasParentStyle = parentNodeForRenderingAndStyle() ? static_cast<bool>(parentNodeForRenderingAndStyle()->renderStyle()) : false; I think it would be slightly more elegant to do something like "!!" rather than static_cast<bool>; not really sure. A much clearer way to write it would be to add a hasStyle function to RenderObject* that encapsulates this. Or even just a local helper function called hasStyle. Generally speaking, casts are harder to read than almost any alternative. 453935 24 104530 asharif.tools 2011-08-19 11:19:13 -0700 Created attachment 104530 Proposed fix. I haven't fully tested this fix because WebKit doesn't build on my machine (problems with dependencies with --gtk, build failures with --qt) but at least the changed files were compiling fine. Can you send this out to the patch tester and commit for me? Please rebase if necessary. 453936 25 webkit.review.bot 2011-08-19 11:21:34 -0700 Attachment 104530 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/dom/ContainerNode.cpp:766: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 453941 26 104533 asharif.tools 2011-08-19 11:31:39 -0700 Created attachment 104533 Fixed formatting issues. 453947 27 webkit.review.bot 2011-08-19 11:35:11 -0700 Attachment 104533 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 453980 28 104545 asharif.tools 2011-08-19 12:21:43 -0700 Created attachment 104545 Added bug link. 454017 29 104545 webkit.review.bot 2011-08-19 13:17:20 -0700 Comment on attachment 104545 Added bug link. Attachment 104545 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9432439 New failing tests: canvas/philip/tests/2d.text-custom-font-load-crash.html http/tests/cache/subresource-expiration-1.html http/tests/inspector/console-websocket-error.html css3/selectors3/xml/css3-modsel-25.xml http/tests/inspector/console-cd.html http/tests/inspector/console-cd-completions.html http/tests/inspector/resource-har-headers.html http/tests/inspector-enabled/console-clear-arguments-on-frame-remove.html http/tests/inspector/inspect-iframe-from-different-domain.html http/tests/cache/subresource-expiration-2.html http/tests/inspector/console-xhr-logging.html animations/body-removal-crash.html http/tests/inspector/network-preflight-options.html http/tests/cache/subresource-multiple-instances.html http/tests/inspector/resource-har-conversion.html http/tests/inspector/console-resource-errors.html http/tests/inspector/resource-parameters.html http/tests/inspector-enabled/console-log-before-frame-navigation.html animations/dynamic-stylesheet-loading.html http/tests/inspector/change-iframe-src.html 454025 30 104545 darin 2011-08-19 13:27:12 -0700 Comment on attachment 104545 Added bug link. View in context: https://bugs.webkit.org/attachment.cgi?id=104545&action=review > Source/WebCore/dom/ContainerNode.cpp:764 > +bool ContainerNode::hasStyle() const Thanks for doing what I asked. Style-wise this is way better. Since this code is quite hot, I think we probably want to make sure this is inlined. It’s slightly tricky to do that because we can’t put it in ContainerNode.h. Sorry, this is getting unpleasantly complicated. I guess we can try with it not inlined, but I do fear this will make things slower. > Source/WebCore/dom/ContainerNode.cpp:766 > + if (renderer()->style()) What guarantees the renderer is non-zero? I think we need to check that too. 454027 31 104545 darin 2011-08-19 13:27:44 -0700 Comment on attachment 104545 Added bug link. Given these new issues that arising, I think we should probably just go back to the static_cast<bool> version. Sorry for the churn. 454114 32 104573 asharif.tools 2011-08-19 14:50:47 -0700 Created attachment 104573 Used static_cast<bool> to fix compiler warning. Just rebased this and it should work I think. 454673 33 asharif.tools 2011-08-22 10:36:34 -0700 Ping. Can someone rebase and submit? 455575 34 104883 asharif.tools 2011-08-23 12:05:57 -0700 Created attachment 104883 rebased patch 455648 35 104883 webkit.review.bot 2011-08-23 13:10:58 -0700 Comment on attachment 104883 rebased patch Clearing flags on attachment: 104883 Committed r93631: <http://trac.webkit.org/changeset/93631> 455649 36 webkit.review.bot 2011-08-23 13:11:05 -0700 All reviewed patches have been landed. Closing bug. 103692 2011-08-11 15:51:27 -0700 2011-08-18 11:06:03 -0700 patch to fix some warnings. 4.6.patch text/plain 2464 asharif.tools SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyODg1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDgtMTEgIEFobWFkIFNo YXJpZiAgPGFzaGFyaWZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeGVkIHdhcm5pbmdzIHBy b2R1Y2VkIGJ5IGdjYy00LjYuMC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAgICAqIGRvbS9FbGVt ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnQ6OnJlY2FsY1N0eWxlKToKKyAgICAg ICAgKiBwbGF0Zm9ybS9TY3JvbGxBbmltYXRvck5vbmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 U2Nyb2xsQW5pbWF0b3JOb25lOjpQZXJBeGlzRGF0YTo6Y3VydmVBdCk6CisgICAgICAgIChXZWJD b3JlOjpTY3JvbGxBbmltYXRvck5vbmU6OlBlckF4aXNEYXRhOjpjdXJ2ZURlcml2YXRpdmVBdCk6 CisgICAgICAgICogdGhpcmRwYXJ0eTogQ29waWVkIGZyb20gU291cmNlL1dlYkNvcmUvdGhpcmRw YXJ0eS4KKwogMjAxMS0wOC0xMSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNv bT4KIAogICAgICAgICBBdm9pZCBhZGRpbmcgdGhlIHZpc2libGUgd2FzaCBsYXllciB0d2ljZQpJ bmRleDogU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAkocmV2aXNpb24gOTI4NzApCisrKyBTb3VyY2UvV2Vi Q29yZS9kb20vRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwOTcsNyArMTA5Nyw3IEBA IHZvaWQgRWxlbWVudDo6cmVjYWxjU3R5bGUoU3R5bGVDaGFuZ2UgY2gKIHsKICAgICAvLyBSZWYg Y3VycmVudFN0eWxlIGluIGNhc2UgaXQgd291bGQgb3RoZXJ3aXNlIGJlIGRlbGV0ZWQgd2hlbiBz ZXRSZW5kZXJTdHlsZSgpIGlzIGNhbGxlZC4KICAgICBSZWZQdHI8UmVuZGVyU3R5bGU+IGN1cnJl bnRTdHlsZShyZW5kZXJTdHlsZSgpKTsKLSAgICBib29sIGhhc1BhcmVudFN0eWxlID0gcGFyZW50 Tm9kZUZvclJlbmRlcmluZ0FuZFN0eWxlKCkgPyBwYXJlbnROb2RlRm9yUmVuZGVyaW5nQW5kU3R5 bGUoKS0+cmVuZGVyU3R5bGUoKSA6IGZhbHNlOworICAgIGJvb2wgaGFzUGFyZW50U3R5bGUgPSBw YXJlbnROb2RlRm9yUmVuZGVyaW5nQW5kU3R5bGUoKSA/IChib29sKSBwYXJlbnROb2RlRm9yUmVu ZGVyaW5nQW5kU3R5bGUoKS0+cmVuZGVyU3R5bGUoKSA6IGZhbHNlOwogICAgIGJvb2wgaGFzRGly ZWN0QWRqYWNlbnRSdWxlcyA9IGN1cnJlbnRTdHlsZSAmJiBjdXJyZW50U3R5bGUtPmNoaWxkcmVu QWZmZWN0ZWRCeURpcmVjdEFkamFjZW50UnVsZXMoKTsKICAgICBib29sIGhhc0luZGlyZWN0QWRq YWNlbnRSdWxlcyA9IGN1cnJlbnRTdHlsZSAmJiBjdXJyZW50U3R5bGUtPmNoaWxkcmVuQWZmZWN0 ZWRCeUZvcndhcmRQb3NpdGlvbmFsUnVsZXMoKTsKIApJbmRleDogU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vU2Nyb2xsQW5pbWF0b3JOb25lLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9TY3JvbGxBbmltYXRvck5vbmUuY3BwCShyZXZpc2lvbiA5Mjg3MCkKKysrIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbEFuaW1hdG9yTm9uZS5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTk4LDYgKzk4LDcgQEAgZG91YmxlIFNjcm9sbEFuaW1hdG9yTm9uZTo6UGVyQXhpc0Rh dGE6OgogICAgICAgICB0IC09IDIuNjI1IC8gMi43NTsKICAgICAgICAgcmV0dXJuIDcuNTYyNSAq IHQgKiB0ICsgLjk4NDM3NTsKICAgICB9CisgICAgcmV0dXJuIDA7CiB9CiAKIGRvdWJsZSBTY3Jv bGxBbmltYXRvck5vbmU6OlBlckF4aXNEYXRhOjphdHRhY2tDdXJ2ZShDdXJ2ZSBjdXJ2ZSwgZG91 YmxlIGRlbHRhVGltZSwgZG91YmxlIGN1cnZlVCwgZG91YmxlIHN0YXJ0UG9zaXRpb24sIGRvdWJs ZSBhdHRhY2tQb3NpdGlvbikKQEAgLTEyNiw2ICsxMjcsNyBAQCBkb3VibGUgU2Nyb2xsQW5pbWF0 b3JOb25lOjpQZXJBeGlzRGF0YTo6CiAgICAgY2FzZSBCb3VuY2U6CiAgICAgICAgIHJldHVybiB0 OwogICAgIH0KKyAgICByZXR1cm4gMDsKIH0KIAogU2Nyb2xsQW5pbWF0b3JOb25lOjpQZXJBeGlz RGF0YTo6UGVyQXhpc0RhdGEoU2Nyb2xsQW5pbWF0b3JOb25lKiBwYXJlbnQsIGZsb2F0KiBjdXJy ZW50UG9zaXRpb24pCg== 103702 2011-08-11 16:42:20 -0700 2011-08-18 11:06:03 -0700 Addressed reviewer's comments. 4.6.patch text/plain 2476 asharif.tools SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyODg1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDgtMTEgIEFobWFkIFNo YXJpZiAgPGFzaGFyaWZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeGVkIHdhcm5pbmdzIHBy b2R1Y2VkIGJ5IGdjYy00LjYuMC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAgICAqIGRvbS9FbGVt ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnQ6OnJlY2FsY1N0eWxlKToKKyAgICAg ICAgKiBwbGF0Zm9ybS9TY3JvbGxBbmltYXRvck5vbmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 U2Nyb2xsQW5pbWF0b3JOb25lOjpQZXJBeGlzRGF0YTo6Y3VydmVBdCk6CisgICAgICAgIChXZWJD b3JlOjpTY3JvbGxBbmltYXRvck5vbmU6OlBlckF4aXNEYXRhOjpjdXJ2ZURlcml2YXRpdmVBdCk6 CisgICAgICAgICogdGhpcmRwYXJ0eTogQ29waWVkIGZyb20gU291cmNlL1dlYkNvcmUvdGhpcmRw YXJ0eS4KKwogMjAxMS0wOC0xMSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNv bT4KIAogICAgICAgICBBdm9pZCBhZGRpbmcgdGhlIHZpc2libGUgd2FzaCBsYXllciB0d2ljZQpJ bmRleDogU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAkocmV2aXNpb24gOTI4NzApCisrKyBTb3VyY2UvV2Vi Q29yZS9kb20vRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwOTcsNyArMTA5Nyw3IEBA IHZvaWQgRWxlbWVudDo6cmVjYWxjU3R5bGUoU3R5bGVDaGFuZ2UgY2gKIHsKICAgICAvLyBSZWYg Y3VycmVudFN0eWxlIGluIGNhc2UgaXQgd291bGQgb3RoZXJ3aXNlIGJlIGRlbGV0ZWQgd2hlbiBz ZXRSZW5kZXJTdHlsZSgpIGlzIGNhbGxlZC4KICAgICBSZWZQdHI8UmVuZGVyU3R5bGU+IGN1cnJl bnRTdHlsZShyZW5kZXJTdHlsZSgpKTsKLSAgICBib29sIGhhc1BhcmVudFN0eWxlID0gcGFyZW50 Tm9kZUZvclJlbmRlcmluZ0FuZFN0eWxlKCkgPyBwYXJlbnROb2RlRm9yUmVuZGVyaW5nQW5kU3R5 bGUoKS0+cmVuZGVyU3R5bGUoKSA6IGZhbHNlOworICAgIGJvb2wgaGFzUGFyZW50U3R5bGUgPSBw YXJlbnROb2RlRm9yUmVuZGVyaW5nQW5kU3R5bGUoKSA/IHN0YXRpY19jYXN0PGJvb2w+KHBhcmVu dE5vZGVGb3JSZW5kZXJpbmdBbmRTdHlsZSgpLT5yZW5kZXJTdHlsZSgpKSA6IGZhbHNlOwogICAg IGJvb2wgaGFzRGlyZWN0QWRqYWNlbnRSdWxlcyA9IGN1cnJlbnRTdHlsZSAmJiBjdXJyZW50U3R5 bGUtPmNoaWxkcmVuQWZmZWN0ZWRCeURpcmVjdEFkamFjZW50UnVsZXMoKTsKICAgICBib29sIGhh c0luZGlyZWN0QWRqYWNlbnRSdWxlcyA9IGN1cnJlbnRTdHlsZSAmJiBjdXJyZW50U3R5bGUtPmNo aWxkcmVuQWZmZWN0ZWRCeUZvcndhcmRQb3NpdGlvbmFsUnVsZXMoKTsKIApJbmRleDogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsQW5pbWF0b3JOb25lLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxBbmltYXRvck5vbmUuY3BwCShyZXZpc2lvbiA5 Mjg3MCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbEFuaW1hdG9yTm9uZS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTk4LDYgKzk4LDcgQEAgZG91YmxlIFNjcm9sbEFuaW1hdG9yTm9u ZTo6UGVyQXhpc0RhdGE6OgogICAgICAgICB0IC09IDIuNjI1IC8gMi43NTsKICAgICAgICAgcmV0 dXJuIDcuNTYyNSAqIHQgKiB0ICsgLjk4NDM3NTsKICAgICB9CisgICAgcmV0dXJuIDA7CiB9CiAK IGRvdWJsZSBTY3JvbGxBbmltYXRvck5vbmU6OlBlckF4aXNEYXRhOjphdHRhY2tDdXJ2ZShDdXJ2 ZSBjdXJ2ZSwgZG91YmxlIGRlbHRhVGltZSwgZG91YmxlIGN1cnZlVCwgZG91YmxlIHN0YXJ0UG9z aXRpb24sIGRvdWJsZSBhdHRhY2tQb3NpdGlvbikKQEAgLTEyNiw2ICsxMjcsNyBAQCBkb3VibGUg U2Nyb2xsQW5pbWF0b3JOb25lOjpQZXJBeGlzRGF0YTo6CiAgICAgY2FzZSBCb3VuY2U6CiAgICAg ICAgIHJldHVybiB0OwogICAgIH0KKyAgICByZXR1cm4gMDsKIH0KIAogU2Nyb2xsQW5pbWF0b3JO b25lOjpQZXJBeGlzRGF0YTo6UGVyQXhpc0RhdGEoU2Nyb2xsQW5pbWF0b3JOb25lKiBwYXJlbnQs IGZsb2F0KiBjdXJyZW50UG9zaXRpb24pCg== 103986 2011-08-15 17:44:56 -0700 2011-08-18 11:06:03 -0700 Addressed reviewer's comments about patch ChangeLog formatting. 4.6.patch text/plain 2531 asharif.tools SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyODg1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDgtMTEgIEFobWFkIFNo YXJpZiAgPGFzaGFyaWZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeGVkIHdhcm5pbmdzIHBy b2R1Y2VkIGJ5IGdjYy00LjYuMC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTYyMTY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAgKiBkb20vRWxlbWVu dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50OjpyZWNhbGNTdHlsZSk6CisgICAgICAg ICogcGxhdGZvcm0vU2Nyb2xsQW5pbWF0b3JOb25lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNj cm9sbEFuaW1hdG9yTm9uZTo6UGVyQXhpc0RhdGE6OmN1cnZlQXQpOgorICAgICAgICAoV2ViQ29y ZTo6U2Nyb2xsQW5pbWF0b3JOb25lOjpQZXJBeGlzRGF0YTo6Y3VydmVEZXJpdmF0aXZlQXQpOgor ICAgICAgICAqIHRoaXJkcGFydHk6IENvcGllZCBmcm9tIFNvdXJjZS9XZWJDb3JlL3RoaXJkcGFy dHkuCisKIDIwMTEtMDgtMTEgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+ CiAKICAgICAgICAgQXZvaWQgYWRkaW5nIHRoZSB2aXNpYmxlIHdhc2ggbGF5ZXIgdHdpY2UKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9kb20vRWxlbWVudC5jcHAJKHJldmlzaW9uIDkyODcwKQorKysgU291cmNlL1dlYkNv cmUvZG9tL0VsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDk3LDcgKzEwOTcsNyBAQCB2 b2lkIEVsZW1lbnQ6OnJlY2FsY1N0eWxlKFN0eWxlQ2hhbmdlIGNoCiB7CiAgICAgLy8gUmVmIGN1 cnJlbnRTdHlsZSBpbiBjYXNlIGl0IHdvdWxkIG90aGVyd2lzZSBiZSBkZWxldGVkIHdoZW4gc2V0 UmVuZGVyU3R5bGUoKSBpcyBjYWxsZWQuCiAgICAgUmVmUHRyPFJlbmRlclN0eWxlPiBjdXJyZW50 U3R5bGUocmVuZGVyU3R5bGUoKSk7Ci0gICAgYm9vbCBoYXNQYXJlbnRTdHlsZSA9IHBhcmVudE5v ZGVGb3JSZW5kZXJpbmdBbmRTdHlsZSgpID8gcGFyZW50Tm9kZUZvclJlbmRlcmluZ0FuZFN0eWxl KCktPnJlbmRlclN0eWxlKCkgOiBmYWxzZTsKKyAgICBib29sIGhhc1BhcmVudFN0eWxlID0gcGFy ZW50Tm9kZUZvclJlbmRlcmluZ0FuZFN0eWxlKCkgPyBzdGF0aWNfY2FzdDxib29sPihwYXJlbnRO b2RlRm9yUmVuZGVyaW5nQW5kU3R5bGUoKS0+cmVuZGVyU3R5bGUoKSkgOiBmYWxzZTsKICAgICBi b29sIGhhc0RpcmVjdEFkamFjZW50UnVsZXMgPSBjdXJyZW50U3R5bGUgJiYgY3VycmVudFN0eWxl LT5jaGlsZHJlbkFmZmVjdGVkQnlEaXJlY3RBZGphY2VudFJ1bGVzKCk7CiAgICAgYm9vbCBoYXNJ bmRpcmVjdEFkamFjZW50UnVsZXMgPSBjdXJyZW50U3R5bGUgJiYgY3VycmVudFN0eWxlLT5jaGls ZHJlbkFmZmVjdGVkQnlGb3J3YXJkUG9zaXRpb25hbFJ1bGVzKCk7CiAKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL1Njcm9sbEFuaW1hdG9yTm9uZS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsQW5pbWF0b3JOb25lLmNwcAkocmV2aXNpb24gOTI4 NzApCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxBbmltYXRvck5vbmUuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC05OCw2ICs5OCw3IEBAIGRvdWJsZSBTY3JvbGxBbmltYXRvck5vbmU6 OlBlckF4aXNEYXRhOjoKICAgICAgICAgdCAtPSAyLjYyNSAvIDIuNzU7CiAgICAgICAgIHJldHVy biA3LjU2MjUgKiB0ICogdCArIC45ODQzNzU7CiAgICAgfQorICAgIHJldHVybiAwOwogfQogCiBk b3VibGUgU2Nyb2xsQW5pbWF0b3JOb25lOjpQZXJBeGlzRGF0YTo6YXR0YWNrQ3VydmUoQ3VydmUg Y3VydmUsIGRvdWJsZSBkZWx0YVRpbWUsIGRvdWJsZSBjdXJ2ZVQsIGRvdWJsZSBzdGFydFBvc2l0 aW9uLCBkb3VibGUgYXR0YWNrUG9zaXRpb24pCkBAIC0xMjYsNiArMTI3LDcgQEAgZG91YmxlIFNj cm9sbEFuaW1hdG9yTm9uZTo6UGVyQXhpc0RhdGE6OgogICAgIGNhc2UgQm91bmNlOgogICAgICAg ICByZXR1cm4gdDsKICAgICB9CisgICAgcmV0dXJuIDA7CiB9CiAKIFNjcm9sbEFuaW1hdG9yTm9u ZTo6UGVyQXhpc0RhdGE6OlBlckF4aXNEYXRhKFNjcm9sbEFuaW1hdG9yTm9uZSogcGFyZW50LCBm bG9hdCogY3VycmVudFBvc2l0aW9uKQo= 104120 2011-08-16 16:49:16 -0700 2011-08-18 11:06:03 -0700 Removed the OOPS no new tests line. 4.6.patch text/plain 2498 asharif.tools SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyODg1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDgtMTEgIEFobWFkIFNo YXJpZiAgPGFzaGFyaWZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeGVkIHdhcm5pbmdzIHBy b2R1Y2VkIGJ5IGdjYy00LjYuMC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTYyMTY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBkb20vRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50 OjpyZWNhbGNTdHlsZSk6CisgICAgICAgICogcGxhdGZvcm0vU2Nyb2xsQW5pbWF0b3JOb25lLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbEFuaW1hdG9yTm9uZTo6UGVyQXhpc0RhdGE6OmN1 cnZlQXQpOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsQW5pbWF0b3JOb25lOjpQZXJBeGlzRGF0 YTo6Y3VydmVEZXJpdmF0aXZlQXQpOgorICAgICAgICAqIHRoaXJkcGFydHk6IENvcGllZCBmcm9t IFNvdXJjZS9XZWJDb3JlL3RoaXJkcGFydHkuCisKIDIwMTEtMDgtMTEgIFNpbW9uIEZyYXNlciAg PHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgQXZvaWQgYWRkaW5nIHRoZSB2aXNp YmxlIHdhc2ggbGF5ZXIgdHdpY2UKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAJKHJldmlzaW9u IDkyODcwKQorKysgU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xMDk3LDcgKzEwOTcsNyBAQCB2b2lkIEVsZW1lbnQ6OnJlY2FsY1N0eWxlKFN0eWxlQ2hh bmdlIGNoCiB7CiAgICAgLy8gUmVmIGN1cnJlbnRTdHlsZSBpbiBjYXNlIGl0IHdvdWxkIG90aGVy d2lzZSBiZSBkZWxldGVkIHdoZW4gc2V0UmVuZGVyU3R5bGUoKSBpcyBjYWxsZWQuCiAgICAgUmVm UHRyPFJlbmRlclN0eWxlPiBjdXJyZW50U3R5bGUocmVuZGVyU3R5bGUoKSk7Ci0gICAgYm9vbCBo YXNQYXJlbnRTdHlsZSA9IHBhcmVudE5vZGVGb3JSZW5kZXJpbmdBbmRTdHlsZSgpID8gcGFyZW50 Tm9kZUZvclJlbmRlcmluZ0FuZFN0eWxlKCktPnJlbmRlclN0eWxlKCkgOiBmYWxzZTsKKyAgICBi b29sIGhhc1BhcmVudFN0eWxlID0gcGFyZW50Tm9kZUZvclJlbmRlcmluZ0FuZFN0eWxlKCkgPyBz dGF0aWNfY2FzdDxib29sPihwYXJlbnROb2RlRm9yUmVuZGVyaW5nQW5kU3R5bGUoKS0+cmVuZGVy U3R5bGUoKSkgOiBmYWxzZTsKICAgICBib29sIGhhc0RpcmVjdEFkamFjZW50UnVsZXMgPSBjdXJy ZW50U3R5bGUgJiYgY3VycmVudFN0eWxlLT5jaGlsZHJlbkFmZmVjdGVkQnlEaXJlY3RBZGphY2Vu dFJ1bGVzKCk7CiAgICAgYm9vbCBoYXNJbmRpcmVjdEFkamFjZW50UnVsZXMgPSBjdXJyZW50U3R5 bGUgJiYgY3VycmVudFN0eWxlLT5jaGlsZHJlbkFmZmVjdGVkQnlGb3J3YXJkUG9zaXRpb25hbFJ1 bGVzKCk7CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbEFuaW1hdG9yTm9u ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsQW5pbWF0 b3JOb25lLmNwcAkocmV2aXNpb24gOTI4NzApCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9T Y3JvbGxBbmltYXRvck5vbmUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05OCw2ICs5OCw3IEBAIGRv dWJsZSBTY3JvbGxBbmltYXRvck5vbmU6OlBlckF4aXNEYXRhOjoKICAgICAgICAgdCAtPSAyLjYy NSAvIDIuNzU7CiAgICAgICAgIHJldHVybiA3LjU2MjUgKiB0ICogdCArIC45ODQzNzU7CiAgICAg fQorICAgIHJldHVybiAwOwogfQogCiBkb3VibGUgU2Nyb2xsQW5pbWF0b3JOb25lOjpQZXJBeGlz RGF0YTo6YXR0YWNrQ3VydmUoQ3VydmUgY3VydmUsIGRvdWJsZSBkZWx0YVRpbWUsIGRvdWJsZSBj dXJ2ZVQsIGRvdWJsZSBzdGFydFBvc2l0aW9uLCBkb3VibGUgYXR0YWNrUG9zaXRpb24pCkBAIC0x MjYsNiArMTI3LDcgQEAgZG91YmxlIFNjcm9sbEFuaW1hdG9yTm9uZTo6UGVyQXhpc0RhdGE6Ogog ICAgIGNhc2UgQm91bmNlOgogICAgICAgICByZXR1cm4gdDsKICAgICB9CisgICAgcmV0dXJuIDA7 CiB9CiAKIFNjcm9sbEFuaW1hdG9yTm9uZTo6UGVyQXhpc0RhdGE6OlBlckF4aXNEYXRhKFNjcm9s bEFuaW1hdG9yTm9uZSogcGFyZW50LCBmbG9hdCogY3VycmVudFBvc2l0aW9uKQo= 104366 2011-08-18 11:06:03 -0700 2011-08-18 11:44:12 -0700 Rebased patch 4.6.patch text/plain 2425 asharif.tools SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzMzIwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMTEgIEFobWFkIFNo YXJpZiAgPGFzaGFyaWZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeGVkIHdhcm5pbmdzIHBy b2R1Y2VkIGJ5IGdjYy00LjYuMC4KKworICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgor CisgICAgICAgICogZG9tL0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudDo6 cmVjYWxjU3R5bGUpOgorICAgICAgICAqIHBsYXRmb3JtL1Njcm9sbEFuaW1hdG9yTm9uZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxBbmltYXRvck5vbmU6OlBlckF4aXNEYXRhOjpjdXJ2 ZUF0KToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbEFuaW1hdG9yTm9uZTo6UGVyQXhpc0RhdGE6 OmN1cnZlRGVyaXZhdGl2ZUF0KToKKyAgICAgICAgKiB0aGlyZHBhcnR5OiBDb3BpZWQgZnJvbSBT b3VyY2UvV2ViQ29yZS90aGlyZHBhcnR5LgorCiAyMDExLTA4LTE4ICBBbmRlcnMgQ2FybHNzb24g IDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IGNsYW5nIGxpYmMrKyBDKysweCBi dWlsZApJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAkocmV2aXNpb24gOTMzMjApCisrKyBTb3Vy Y2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwOTcsNyArMTA5 Nyw3IEBAIHZvaWQgRWxlbWVudDo6cmVjYWxjU3R5bGUoU3R5bGVDaGFuZ2UgY2gKIHsKICAgICAv LyBSZWYgY3VycmVudFN0eWxlIGluIGNhc2UgaXQgd291bGQgb3RoZXJ3aXNlIGJlIGRlbGV0ZWQg d2hlbiBzZXRSZW5kZXJTdHlsZSgpIGlzIGNhbGxlZC4KICAgICBSZWZQdHI8UmVuZGVyU3R5bGU+ IGN1cnJlbnRTdHlsZShyZW5kZXJTdHlsZSgpKTsKLSAgICBib29sIGhhc1BhcmVudFN0eWxlID0g cGFyZW50Tm9kZUZvclJlbmRlcmluZ0FuZFN0eWxlKCkgPyBwYXJlbnROb2RlRm9yUmVuZGVyaW5n QW5kU3R5bGUoKS0+cmVuZGVyU3R5bGUoKSA6IGZhbHNlOworICAgIGJvb2wgaGFzUGFyZW50U3R5 bGUgPSBwYXJlbnROb2RlRm9yUmVuZGVyaW5nQW5kU3R5bGUoKSA/IHN0YXRpY19jYXN0PGJvb2w+ KHBhcmVudE5vZGVGb3JSZW5kZXJpbmdBbmRTdHlsZSgpLT5yZW5kZXJTdHlsZSgpKSA6IGZhbHNl OwogICAgIGJvb2wgaGFzRGlyZWN0QWRqYWNlbnRSdWxlcyA9IGN1cnJlbnRTdHlsZSAmJiBjdXJy ZW50U3R5bGUtPmNoaWxkcmVuQWZmZWN0ZWRCeURpcmVjdEFkamFjZW50UnVsZXMoKTsKICAgICBi b29sIGhhc0luZGlyZWN0QWRqYWNlbnRSdWxlcyA9IGN1cnJlbnRTdHlsZSAmJiBjdXJyZW50U3R5 bGUtPmNoaWxkcmVuQWZmZWN0ZWRCeUZvcndhcmRQb3NpdGlvbmFsUnVsZXMoKTsKIApJbmRleDog U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsQW5pbWF0b3JOb25lLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxBbmltYXRvck5vbmUuY3BwCShyZXZp c2lvbiA5MzMyMCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbEFuaW1hdG9yTm9u ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk4LDYgKzk4LDcgQEAgZG91YmxlIFNjcm9sbEFuaW1h dG9yTm9uZTo6UGVyQXhpc0RhdGE6OgogICAgICAgICB0IC09IDIuNjI1IC8gMi43NTsKICAgICAg ICAgcmV0dXJuIDcuNTYyNSAqIHQgKiB0ICsgLjk4NDM3NTsKICAgICB9CisgICAgcmV0dXJuIDA7 CiB9CiAKIGRvdWJsZSBTY3JvbGxBbmltYXRvck5vbmU6OlBlckF4aXNEYXRhOjphdHRhY2tDdXJ2 ZShDdXJ2ZSBjdXJ2ZSwgZG91YmxlIGRlbHRhVGltZSwgZG91YmxlIGN1cnZlVCwgZG91YmxlIHN0 YXJ0UG9zaXRpb24sIGRvdWJsZSBhdHRhY2tQb3NpdGlvbikKQEAgLTEyNiw2ICsxMjcsNyBAQCBk b3VibGUgU2Nyb2xsQW5pbWF0b3JOb25lOjpQZXJBeGlzRGF0YTo6CiAgICAgY2FzZSBCb3VuY2U6 CiAgICAgICAgIHJldHVybiB0OwogICAgIH0KKyAgICByZXR1cm4gMDsKIH0KIAogU2Nyb2xsQW5p bWF0b3JOb25lOjpQZXJBeGlzRGF0YTo6UGVyQXhpc0RhdGEoU2Nyb2xsQW5pbWF0b3JOb25lKiBw YXJlbnQsIGZsb2F0KiBjdXJyZW50UG9zaXRpb24pCg== 104373 2011-08-18 11:44:12 -0700 2011-08-19 11:31:39 -0700 Addressed comments. 4.6.patch text/plain 1646 asharif.tools SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzMzI1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMTEgIEFobWFkIFNo YXJpZiAgPGFzaGFyaWZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeGVkIHdhcm5pbmdzIHBy b2R1Y2VkIGJ5IGdjYy00LjYuMC4KKworICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgor CisgICAgICAgICogZG9tL0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudDo6 cmVjYWxjU3R5bGUpOgorICAgICAgICAqIHBsYXRmb3JtL1Njcm9sbEFuaW1hdG9yTm9uZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxBbmltYXRvck5vbmU6OlBlckF4aXNEYXRhOjpjdXJ2 ZUF0KToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbEFuaW1hdG9yTm9uZTo6UGVyQXhpc0RhdGE6 OmN1cnZlRGVyaXZhdGl2ZUF0KToKKyAgICAgICAgKiB0aGlyZHBhcnR5OiBDb3BpZWQgZnJvbSBT b3VyY2UvV2ViQ29yZS90aGlyZHBhcnR5LgorCiAyMDExLTA4LTE4ICBBbmRlcnMgQ2FybHNzb24g IDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IGNsYW5nIGxpYmMrKyBDKysweCBi dWlsZApJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAkocmV2aXNpb24gOTMzMjUpCisrKyBTb3Vy Y2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwOTcsNyArMTA5 Nyw3IEBAIHZvaWQgRWxlbWVudDo6cmVjYWxjU3R5bGUoU3R5bGVDaGFuZ2UgY2gKIHsKICAgICAv LyBSZWYgY3VycmVudFN0eWxlIGluIGNhc2UgaXQgd291bGQgb3RoZXJ3aXNlIGJlIGRlbGV0ZWQg d2hlbiBzZXRSZW5kZXJTdHlsZSgpIGlzIGNhbGxlZC4KICAgICBSZWZQdHI8UmVuZGVyU3R5bGU+ IGN1cnJlbnRTdHlsZShyZW5kZXJTdHlsZSgpKTsKLSAgICBib29sIGhhc1BhcmVudFN0eWxlID0g cGFyZW50Tm9kZUZvclJlbmRlcmluZ0FuZFN0eWxlKCkgPyBwYXJlbnROb2RlRm9yUmVuZGVyaW5n QW5kU3R5bGUoKS0+cmVuZGVyU3R5bGUoKSA6IGZhbHNlOworICAgIGJvb2wgaGFzUGFyZW50U3R5 bGUgPSBwYXJlbnROb2RlRm9yUmVuZGVyaW5nQW5kU3R5bGUoKSA/IHN0YXRpY19jYXN0PGJvb2w+ KHBhcmVudE5vZGVGb3JSZW5kZXJpbmdBbmRTdHlsZSgpLT5yZW5kZXJTdHlsZSgpKSA6IGZhbHNl OwogICAgIGJvb2wgaGFzRGlyZWN0QWRqYWNlbnRSdWxlcyA9IGN1cnJlbnRTdHlsZSAmJiBjdXJy ZW50U3R5bGUtPmNoaWxkcmVuQWZmZWN0ZWRCeURpcmVjdEFkamFjZW50UnVsZXMoKTsKICAgICBi b29sIGhhc0luZGlyZWN0QWRqYWNlbnRSdWxlcyA9IGN1cnJlbnRTdHlsZSAmJiBjdXJyZW50U3R5 bGUtPmNoaWxkcmVuQWZmZWN0ZWRCeUZvcndhcmRQb3NpdGlvbmFsUnVsZXMoKTsKIAo= 104530 2011-08-19 11:19:13 -0700 2011-08-19 11:31:39 -0700 Proposed fix. 4.6.patch text/plain 2688 asharif.tools SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzNDIzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMTEgIEFobWFkIFNo YXJpZiAgPGFzaGFyaWZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeGVkIHdhcm5pbmdzIHBy b2R1Y2VkIGJ5IGdjYy00LjYuMC4KKworICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgor CisgICAgICAgICogZG9tL0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudDo6 cmVjYWxjU3R5bGUpOgorICAgICAgICAqIHBsYXRmb3JtL1Njcm9sbEFuaW1hdG9yTm9uZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxBbmltYXRvck5vbmU6OlBlckF4aXNEYXRhOjpjdXJ2 ZUF0KToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbEFuaW1hdG9yTm9uZTo6UGVyQXhpc0RhdGE6 OmN1cnZlRGVyaXZhdGl2ZUF0KToKKyAgICAgICAgKiB0aGlyZHBhcnR5OiBDb3BpZWQgZnJvbSBT b3VyY2UvV2ViQ29yZS90aGlyZHBhcnR5LgorCiAyMDExLTA4LTE5ICBEYW4gQmVybnN0ZWluICA8 bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgQmV0dGVyIGJ1aWxkIGZpeCBhZnRlciByOTMzODQu CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuY3BwCShyZXZpc2lvbiA5MzQyMykK KysrIFNvdXJjZS9XZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNzYxLDYgKzc2MSwxNCBAQCB2b2lkIENvbnRhaW5lck5vZGU6OnNjaGVkdWxlU2V0TmVlZHNT dHlsCiAgICAgICAgIHNldE5lZWRzU3R5bGVSZWNhbGMoY2hhbmdlVHlwZSk7CiB9CiAKK2Jvb2wg Q29udGFpbmVyTm9kZTo6aGFzU3R5bGUoKSBjb25zdAoreworICAgIGlmIChyZW5kZXJlcigpLT5z dHlsZSgpKQorICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICBlbHNlCisgICAgICAgIHJldHVybiBm YWxzZTsKK30KKwogdm9pZCBDb250YWluZXJOb2RlOjphdHRhY2goKQogewogICAgIGZvciAoTm9k ZSogY2hpbGQgPSBtX2ZpcnN0Q2hpbGQ7IGNoaWxkOyBjaGlsZCA9IGNoaWxkLT5uZXh0U2libGlu ZygpKQpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5oCShyZXZpc2lvbiA5MzQyMykK KysrIFNvdXJjZS9XZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmgJKHdvcmtpbmcgY29weSkKQEAg LTU3LDYgKzU3LDcgQEAgcHVibGljOgogICAgIHZvaWQgcGFyc2VySW5zZXJ0QmVmb3JlKFBhc3NS ZWZQdHI8Tm9kZT4gbmV3Q2hpbGQsIE5vZGUqIHJlZkNoaWxkKTsKIAogICAgIGJvb2wgaGFzQ2hp bGROb2RlcygpIGNvbnN0IHsgcmV0dXJuIG1fZmlyc3RDaGlsZDsgfQorICAgIGJvb2wgaGFzU3R5 bGUoKSBjb25zdDsKICAgICB2aXJ0dWFsIHZvaWQgYXR0YWNoKCk7CiAgICAgdmlydHVhbCB2b2lk IGRldGFjaCgpOwogICAgIHZpcnR1YWwgdm9pZCB3aWxsUmVtb3ZlKCk7CkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9kb20vRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9t L0VsZW1lbnQuY3BwCShyZXZpc2lvbiA5MzQyMykKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVt ZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA5Nyw3ICsxMDk3LDcgQEAgdm9pZCBFbGVtZW50 OjpyZWNhbGNTdHlsZShTdHlsZUNoYW5nZSBjaAogewogICAgIC8vIFJlZiBjdXJyZW50U3R5bGUg aW4gY2FzZSBpdCB3b3VsZCBvdGhlcndpc2UgYmUgZGVsZXRlZCB3aGVuIHNldFJlbmRlclN0eWxl KCkgaXMgY2FsbGVkLgogICAgIFJlZlB0cjxSZW5kZXJTdHlsZT4gY3VycmVudFN0eWxlKHJlbmRl clN0eWxlKCkpOwotICAgIGJvb2wgaGFzUGFyZW50U3R5bGUgPSBwYXJlbnROb2RlRm9yUmVuZGVy aW5nQW5kU3R5bGUoKSA/IHBhcmVudE5vZGVGb3JSZW5kZXJpbmdBbmRTdHlsZSgpLT5yZW5kZXJT dHlsZSgpIDogZmFsc2U7CisgICAgYm9vbCBoYXNQYXJlbnRTdHlsZSA9IHBhcmVudE5vZGVGb3JS ZW5kZXJpbmdBbmRTdHlsZSgpID8gcGFyZW50Tm9kZUZvclJlbmRlcmluZ0FuZFN0eWxlKCktPmhh c1N0eWxlKCkgOiBmYWxzZTsKICAgICBib29sIGhhc0RpcmVjdEFkamFjZW50UnVsZXMgPSBjdXJy ZW50U3R5bGUgJiYgY3VycmVudFN0eWxlLT5jaGlsZHJlbkFmZmVjdGVkQnlEaXJlY3RBZGphY2Vu dFJ1bGVzKCk7CiAgICAgYm9vbCBoYXNJbmRpcmVjdEFkamFjZW50UnVsZXMgPSBjdXJyZW50U3R5 bGUgJiYgY3VycmVudFN0eWxlLT5jaGlsZHJlbkFmZmVjdGVkQnlGb3J3YXJkUG9zaXRpb25hbFJ1 bGVzKCk7CiAK 104533 2011-08-19 11:31:39 -0700 2011-08-19 12:21:43 -0700 Fixed formatting issues. 4.6.patch text/plain 2715 asharif.tools SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzNDI0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMTEgIEFobWFkIFNo YXJpZiAgPGFzaGFyaWZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeGVkIHdhcm5pbmdzIHBy b2R1Y2VkIGJ5IGdjYy00LjYuMC4KKworICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgor CisgICAgICAgICogZG9tL0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudDo6 cmVjYWxjU3R5bGUpOgorICAgICAgICAqIHBsYXRmb3JtL1Njcm9sbEFuaW1hdG9yTm9uZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxBbmltYXRvck5vbmU6OlBlckF4aXNEYXRhOjpjdXJ2 ZUF0KToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbEFuaW1hdG9yTm9uZTo6UGVyQXhpc0RhdGE6 OmN1cnZlRGVyaXZhdGl2ZUF0KToKKyAgICAgICAgKiB0aGlyZHBhcnR5OiBDb3BpZWQgZnJvbSBT b3VyY2UvV2ViQ29yZS90aGlyZHBhcnR5LgorCiAyMDExLTA4LTE3ICBBZHJpZW5uZSBXYWxrZXIg IDxlbm5lQGdvb2dsZS5jb20+CiAKICAgICAgICAgW2Nocm9taXVtXSBTcGxpdCB0aWxlciBpbnRv IG1haW4gdGhyZWFkIC8gY29tcG9zaXRvciB0aHJlYWQgdmVyc2lvbnMKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9kb20vQ29udGFpbmVyTm9kZS5jcHAJKHJldmlzaW9uIDkzNDI0KQorKysgU291cmNlL1dlYkNv cmUvZG9tL0NvbnRhaW5lck5vZGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NjEsNiArNzYxLDEz IEBAIHZvaWQgQ29udGFpbmVyTm9kZTo6c2NoZWR1bGVTZXROZWVkc1N0eWwKICAgICAgICAgc2V0 TmVlZHNTdHlsZVJlY2FsYyhjaGFuZ2VUeXBlKTsKIH0KIAorYm9vbCBDb250YWluZXJOb2RlOjpo YXNTdHlsZSgpIGNvbnN0Cit7CisgICAgaWYgKHJlbmRlcmVyKCktPnN0eWxlKCkpCisgICAgICAg IHJldHVybiB0cnVlOworICAgIHJldHVybiBmYWxzZTsKK30KKwogdm9pZCBDb250YWluZXJOb2Rl OjphdHRhY2goKQogewogICAgIGZvciAoTm9kZSogY2hpbGQgPSBtX2ZpcnN0Q2hpbGQ7IGNoaWxk OyBjaGlsZCA9IGNoaWxkLT5uZXh0U2libGluZygpKQpJbmRleDogU291cmNlL1dlYkNvcmUvZG9t L0NvbnRhaW5lck5vZGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vQ29udGFp bmVyTm9kZS5oCShyZXZpc2lvbiA5MzQyNCkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9Db250YWlu ZXJOb2RlLmgJKHdvcmtpbmcgY29weSkKQEAgLTU3LDYgKzU3LDcgQEAgcHVibGljOgogICAgIHZv aWQgcGFyc2VySW5zZXJ0QmVmb3JlKFBhc3NSZWZQdHI8Tm9kZT4gbmV3Q2hpbGQsIE5vZGUqIHJl ZkNoaWxkKTsKIAogICAgIGJvb2wgaGFzQ2hpbGROb2RlcygpIGNvbnN0IHsgcmV0dXJuIG1fZmly c3RDaGlsZDsgfQorICAgIGJvb2wgaGFzU3R5bGUoKSBjb25zdDsKICAgICB2aXJ0dWFsIHZvaWQg YXR0YWNoKCk7CiAgICAgdmlydHVhbCB2b2lkIGRldGFjaCgpOwogICAgIHZpcnR1YWwgdm9pZCB3 aWxsUmVtb3ZlKCk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCShyZXZpc2lvbiA5MzQyNCkK KysrIFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA5 Nyw3ICsxMDk3LDcgQEAgdm9pZCBFbGVtZW50OjpyZWNhbGNTdHlsZShTdHlsZUNoYW5nZSBjaAog ewogICAgIC8vIFJlZiBjdXJyZW50U3R5bGUgaW4gY2FzZSBpdCB3b3VsZCBvdGhlcndpc2UgYmUg ZGVsZXRlZCB3aGVuIHNldFJlbmRlclN0eWxlKCkgaXMgY2FsbGVkLgogICAgIFJlZlB0cjxSZW5k ZXJTdHlsZT4gY3VycmVudFN0eWxlKHJlbmRlclN0eWxlKCkpOwotICAgIGJvb2wgaGFzUGFyZW50 U3R5bGUgPSBwYXJlbnROb2RlRm9yUmVuZGVyaW5nQW5kU3R5bGUoKSA/IHBhcmVudE5vZGVGb3JS ZW5kZXJpbmdBbmRTdHlsZSgpLT5yZW5kZXJTdHlsZSgpIDogZmFsc2U7CisgICAgYm9vbCBoYXNQ YXJlbnRTdHlsZSA9IHBhcmVudE5vZGVGb3JSZW5kZXJpbmdBbmRTdHlsZSgpID8gcGFyZW50Tm9k ZUZvclJlbmRlcmluZ0FuZFN0eWxlKCktPmhhc1N0eWxlKCkgOiBmYWxzZTsKICAgICBib29sIGhh c0RpcmVjdEFkamFjZW50UnVsZXMgPSBjdXJyZW50U3R5bGUgJiYgY3VycmVudFN0eWxlLT5jaGls ZHJlbkFmZmVjdGVkQnlEaXJlY3RBZGphY2VudFJ1bGVzKCk7CiAgICAgYm9vbCBoYXNJbmRpcmVj dEFkamFjZW50UnVsZXMgPSBjdXJyZW50U3R5bGUgJiYgY3VycmVudFN0eWxlLT5jaGlsZHJlbkFm ZmVjdGVkQnlGb3J3YXJkUG9zaXRpb25hbFJ1bGVzKCk7CiAK 104545 2011-08-19 12:21:43 -0700 2011-08-19 14:50:47 -0700 Added bug link. 4.6.patch text/plain 2796 asharif.tools SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzNDI3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDgtMTEgIEFobWFkIFNo YXJpZiAgPGFzaGFyaWZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeGVkIHdhcm5pbmdzIHBy b2R1Y2VkIGJ5IGdjYy00LjYuMC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTYyMTY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KKwor ICAgICAgICAqIGRvbS9FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnQ6OnJl Y2FsY1N0eWxlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9TY3JvbGxBbmltYXRvck5vbmUuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsQW5pbWF0b3JOb25lOjpQZXJBeGlzRGF0YTo6Y3VydmVB dCk6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxBbmltYXRvck5vbmU6OlBlckF4aXNEYXRhOjpj dXJ2ZURlcml2YXRpdmVBdCk6CisgICAgICAgICogdGhpcmRwYXJ0eTogQ29waWVkIGZyb20gU291 cmNlL1dlYkNvcmUvdGhpcmRwYXJ0eS4KKwogMjAxMS0wOC0xOSAgSnVsaWVuIENoYWZmcmFpeCAg PGpjaGFmZnJhaXhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSRUdSRVNTSU9OIChyODQzMjctcjg0 MzI5KTogQ1NTIHN0eWxlc2hlZXRzIGZhaWwgdG8gbG9hZCBvbiB3d3cuZmxhZ3N0YXIuY29tIGxv Z2luIHBhZ2UKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5jcHAJKHJldmlzaW9u IDkzNDI3KQorKysgU291cmNlL1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC03NjEsNiArNzYxLDEzIEBAIHZvaWQgQ29udGFpbmVyTm9kZTo6c2NoZWR1bGVT ZXROZWVkc1N0eWwKICAgICAgICAgc2V0TmVlZHNTdHlsZVJlY2FsYyhjaGFuZ2VUeXBlKTsKIH0K IAorYm9vbCBDb250YWluZXJOb2RlOjpoYXNTdHlsZSgpIGNvbnN0Cit7CisgICAgaWYgKHJlbmRl cmVyKCktPnN0eWxlKCkpCisgICAgICAgIHJldHVybiB0cnVlOworICAgIHJldHVybiBmYWxzZTsK K30KKwogdm9pZCBDb250YWluZXJOb2RlOjphdHRhY2goKQogewogICAgIGZvciAoTm9kZSogY2hp bGQgPSBtX2ZpcnN0Q2hpbGQ7IGNoaWxkOyBjaGlsZCA9IGNoaWxkLT5uZXh0U2libGluZygpKQpJ bmRleDogU291cmNlL1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5oCShyZXZpc2lvbiA5MzQyNykKKysrIFNv dXJjZS9XZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmgJKHdvcmtpbmcgY29weSkKQEAgLTU3LDYg KzU3LDcgQEAgcHVibGljOgogICAgIHZvaWQgcGFyc2VySW5zZXJ0QmVmb3JlKFBhc3NSZWZQdHI8 Tm9kZT4gbmV3Q2hpbGQsIE5vZGUqIHJlZkNoaWxkKTsKIAogICAgIGJvb2wgaGFzQ2hpbGROb2Rl cygpIGNvbnN0IHsgcmV0dXJuIG1fZmlyc3RDaGlsZDsgfQorICAgIGJvb2wgaGFzU3R5bGUoKSBj b25zdDsKICAgICB2aXJ0dWFsIHZvaWQgYXR0YWNoKCk7CiAgICAgdmlydHVhbCB2b2lkIGRldGFj aCgpOwogICAgIHZpcnR1YWwgdm9pZCB3aWxsUmVtb3ZlKCk7CkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9kb20vRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL0VsZW1l bnQuY3BwCShyZXZpc2lvbiA5MzQyNykKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTA5Nyw3ICsxMDk3LDcgQEAgdm9pZCBFbGVtZW50OjpyZWNh bGNTdHlsZShTdHlsZUNoYW5nZSBjaAogewogICAgIC8vIFJlZiBjdXJyZW50U3R5bGUgaW4gY2Fz ZSBpdCB3b3VsZCBvdGhlcndpc2UgYmUgZGVsZXRlZCB3aGVuIHNldFJlbmRlclN0eWxlKCkgaXMg Y2FsbGVkLgogICAgIFJlZlB0cjxSZW5kZXJTdHlsZT4gY3VycmVudFN0eWxlKHJlbmRlclN0eWxl KCkpOwotICAgIGJvb2wgaGFzUGFyZW50U3R5bGUgPSBwYXJlbnROb2RlRm9yUmVuZGVyaW5nQW5k U3R5bGUoKSA/IHBhcmVudE5vZGVGb3JSZW5kZXJpbmdBbmRTdHlsZSgpLT5yZW5kZXJTdHlsZSgp IDogZmFsc2U7CisgICAgYm9vbCBoYXNQYXJlbnRTdHlsZSA9IHBhcmVudE5vZGVGb3JSZW5kZXJp bmdBbmRTdHlsZSgpID8gcGFyZW50Tm9kZUZvclJlbmRlcmluZ0FuZFN0eWxlKCktPmhhc1N0eWxl KCkgOiBmYWxzZTsKICAgICBib29sIGhhc0RpcmVjdEFkamFjZW50UnVsZXMgPSBjdXJyZW50U3R5 bGUgJiYgY3VycmVudFN0eWxlLT5jaGlsZHJlbkFmZmVjdGVkQnlEaXJlY3RBZGphY2VudFJ1bGVz KCk7CiAgICAgYm9vbCBoYXNJbmRpcmVjdEFkamFjZW50UnVsZXMgPSBjdXJyZW50U3R5bGUgJiYg Y3VycmVudFN0eWxlLT5jaGlsZHJlbkFmZmVjdGVkQnlGb3J3YXJkUG9zaXRpb25hbFJ1bGVzKCk7 CiAK 104573 2011-08-19 14:50:47 -0700 2011-08-23 12:05:57 -0700 Used static_cast<bool> to fix compiler warning. 4.6.patch text/plain 1715 asharif.tools SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzNDQwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDgtMTEgIEFobWFkIFNo YXJpZiAgPGFzaGFyaWZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeGVkIHdhcm5pbmdzIHBy b2R1Y2VkIGJ5IGdjYy00LjYuMC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTYyMTY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KKwor ICAgICAgICAqIGRvbS9FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnQ6OnJl Y2FsY1N0eWxlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9TY3JvbGxBbmltYXRvck5vbmUuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsQW5pbWF0b3JOb25lOjpQZXJBeGlzRGF0YTo6Y3VydmVB dCk6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxBbmltYXRvck5vbmU6OlBlckF4aXNEYXRhOjpj dXJ2ZURlcml2YXRpdmVBdCk6CisgICAgICAgICogdGhpcmRwYXJ0eTogQ29waWVkIGZyb20gU291 cmNlL1dlYkNvcmUvdGhpcmRwYXJ0eS4KKwogMjAxMS0wOC0xOSAgRW1pbCBBIEVrbHVuZCAgPGVh ZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgU3dpdGNoIGNsaXBwaW5nIGZvciBzdmcgdG8gdG8g bmV3IGxheW91dCB0eXBlcwpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAkocmV2aXNpb24gOTM0 NDApCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTEwOTcsNyArMTA5Nyw3IEBAIHZvaWQgRWxlbWVudDo6cmVjYWxjU3R5bGUoU3R5bGVDaGFuZ2Ug Y2gKIHsKICAgICAvLyBSZWYgY3VycmVudFN0eWxlIGluIGNhc2UgaXQgd291bGQgb3RoZXJ3aXNl IGJlIGRlbGV0ZWQgd2hlbiBzZXRSZW5kZXJTdHlsZSgpIGlzIGNhbGxlZC4KICAgICBSZWZQdHI8 UmVuZGVyU3R5bGU+IGN1cnJlbnRTdHlsZShyZW5kZXJTdHlsZSgpKTsKLSAgICBib29sIGhhc1Bh cmVudFN0eWxlID0gcGFyZW50Tm9kZUZvclJlbmRlcmluZ0FuZFN0eWxlKCkgPyBwYXJlbnROb2Rl Rm9yUmVuZGVyaW5nQW5kU3R5bGUoKS0+cmVuZGVyU3R5bGUoKSA6IGZhbHNlOworICAgIGJvb2wg aGFzUGFyZW50U3R5bGUgPSBwYXJlbnROb2RlRm9yUmVuZGVyaW5nQW5kU3R5bGUoKSA/IHN0YXRp Y19jYXN0PGJvb2w+KHBhcmVudE5vZGVGb3JSZW5kZXJpbmdBbmRTdHlsZSgpLT5yZW5kZXJTdHls ZSgpKSA6IGZhbHNlOwogICAgIGJvb2wgaGFzRGlyZWN0QWRqYWNlbnRSdWxlcyA9IGN1cnJlbnRT dHlsZSAmJiBjdXJyZW50U3R5bGUtPmNoaWxkcmVuQWZmZWN0ZWRCeURpcmVjdEFkamFjZW50UnVs ZXMoKTsKICAgICBib29sIGhhc0luZGlyZWN0QWRqYWNlbnRSdWxlcyA9IGN1cnJlbnRTdHlsZSAm JiBjdXJyZW50U3R5bGUtPmNoaWxkcmVuQWZmZWN0ZWRCeUZvcndhcmRQb3NpdGlvbmFsUnVsZXMo KTsKIAo= 104883 2011-08-23 12:05:57 -0700 2011-08-23 13:10:58 -0700 rebased patch 4.6.patch text/plain 1705 asharif.tools SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzNjIwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDgtMTEgIEFobWFkIFNo YXJpZiAgPGFzaGFyaWZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeGVkIHdhcm5pbmdzIHBy b2R1Y2VkIGJ5IGdjYy00LjYuMC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTYyMTY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KKwor ICAgICAgICAqIGRvbS9FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnQ6OnJl Y2FsY1N0eWxlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9TY3JvbGxBbmltYXRvck5vbmUuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsQW5pbWF0b3JOb25lOjpQZXJBeGlzRGF0YTo6Y3VydmVB dCk6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxBbmltYXRvck5vbmU6OlBlckF4aXNEYXRhOjpj dXJ2ZURlcml2YXRpdmVBdCk6CisgICAgICAgICogdGhpcmRwYXJ0eTogQ29waWVkIGZyb20gU291 cmNlL1dlYkNvcmUvdGhpcmRwYXJ0eS4KKwogMjAxMS0wNy0yNSAgUm9iZXJ0IEhvZ2FuICA8cm9i ZXJ0QHdlYmtpdC5vcmc+CiAKICAgICAgICAgZGl2IGFsaWduPSJjZW50ZXIiIHJlbmRlcmluZyBw cm9ibGVtCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCShyZXZpc2lvbiA5MzYyMCkKKysrIFNv dXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA5Nyw3ICsx MDk3LDcgQEAgdm9pZCBFbGVtZW50OjpyZWNhbGNTdHlsZShTdHlsZUNoYW5nZSBjaAogewogICAg IC8vIFJlZiBjdXJyZW50U3R5bGUgaW4gY2FzZSBpdCB3b3VsZCBvdGhlcndpc2UgYmUgZGVsZXRl ZCB3aGVuIHNldFJlbmRlclN0eWxlKCkgaXMgY2FsbGVkLgogICAgIFJlZlB0cjxSZW5kZXJTdHls ZT4gY3VycmVudFN0eWxlKHJlbmRlclN0eWxlKCkpOwotICAgIGJvb2wgaGFzUGFyZW50U3R5bGUg PSBwYXJlbnROb2RlRm9yUmVuZGVyaW5nQW5kU3R5bGUoKSA/IHBhcmVudE5vZGVGb3JSZW5kZXJp bmdBbmRTdHlsZSgpLT5yZW5kZXJTdHlsZSgpIDogZmFsc2U7CisgICAgYm9vbCBoYXNQYXJlbnRT dHlsZSA9IHBhcmVudE5vZGVGb3JSZW5kZXJpbmdBbmRTdHlsZSgpID8gc3RhdGljX2Nhc3Q8Ym9v bD4ocGFyZW50Tm9kZUZvclJlbmRlcmluZ0FuZFN0eWxlKCktPnJlbmRlclN0eWxlKCkpIDogZmFs c2U7CiAgICAgYm9vbCBoYXNEaXJlY3RBZGphY2VudFJ1bGVzID0gY3VycmVudFN0eWxlICYmIGN1 cnJlbnRTdHlsZS0+Y2hpbGRyZW5BZmZlY3RlZEJ5RGlyZWN0QWRqYWNlbnRSdWxlcygpOwogICAg IGJvb2wgaGFzSW5kaXJlY3RBZGphY2VudFJ1bGVzID0gY3VycmVudFN0eWxlICYmIGN1cnJlbnRT dHlsZS0+Y2hpbGRyZW5BZmZlY3RlZEJ5Rm9yd2FyZFBvc2l0aW9uYWxSdWxlcygpOwogCg==