62158 2011-06-06 15:43:51 -0700 Switch shouldPaint to use IntPoint 2011-06-06 16:21:27 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 leviw leviw darin eae eric simon.fraser oldest_to_newest 416075 0 leviw 2011-06-06 15:43:51 -0700 Last (hopefully) paint code IntPoint conversion before switching over the basic "paint" command! 416078 1 96142 leviw 2011-06-06 15:49:09 -0700 Created attachment 96142 Patch 416101 2 96142 leviw 2011-06-06 16:21:24 -0700 Comment on attachment 96142 Patch Clearing flags on attachment: 96142 Committed r88200: <http://trac.webkit.org/changeset/88200> 416102 3 leviw 2011-06-06 16:21:27 -0700 All reviewed patches have been landed. Closing bug. 96142 2011-06-06 15:49:09 -0700 2011-06-06 16:21:24 -0700 Patch bug-62158-20110606154908.patch text/plain 4565 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4MTk3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDYtMDYgIExldmkgV2Vp bnRyYXViICA8bGV2aXdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFN3aXRjaCBzaG91bGRQYWludCB0byB1c2UgSW50UG9pbnQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyMTU4CisK KyAgICAgICAgU3dpdGNoaW5nIHNob3VsZFBhaW50IHRvIHRha2UgYW4gSW50UG9pbnQgcmVwcmVz ZW50aW5nIHRoZSBwYWludCBvZmZzZXQgaW5zdGVhZAorICAgICAgICBvZiBhIHBhaXIgb2YgaW50 cy4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgdGhpcyBpcyBzaW1wbGUgcmVmYWN0b3Jpbmcu CisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyUmVwbGFjZWQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVyUmVwbGFjZWQ6OnBhaW50KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclJl cGxhY2VkOjpzaG91bGRQYWludCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclJlcGxhY2Vk Lmg6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlcldpZGdldC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpSZW5kZXJXaWRnZXQ6OnBhaW50KToKKwogMjAxMS0wNi0wNiAgTGV2aSBXZWludHJhdWIg IDxsZXZpd0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwu CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUmVwbGFjZWQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJSZXBsYWNlZC5jcHAJKHJl dmlzaW9uIDg4MTk1KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclJlcGxhY2Vk LmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTYsNyArOTYsNyBAQCB2b2lkIFJlbmRlclJlcGxhY2Vk OjppbnRyaW5zaWNTaXplQ2hhbmdlCiAKIHZvaWQgUmVuZGVyUmVwbGFjZWQ6OnBhaW50KFBhaW50 SW5mbyYgcGFpbnRJbmZvLCBpbnQgdHgsIGludCB0eSkKIHsKLSAgICBpZiAoIXNob3VsZFBhaW50 KHBhaW50SW5mbywgdHgsIHR5KSkKKyAgICBpZiAoIXNob3VsZFBhaW50KHBhaW50SW5mbywgSW50 UG9pbnQodHgsIHR5KSkpCiAgICAgICAgIHJldHVybjsKICAgICAKICAgICB0eCArPSB4KCk7CkBA IC0xNTYsNyArMTU2LDcgQEAgdm9pZCBSZW5kZXJSZXBsYWNlZDo6cGFpbnQoUGFpbnRJbmZvJiBw YQogICAgIH0KIH0KIAotYm9vbCBSZW5kZXJSZXBsYWNlZDo6c2hvdWxkUGFpbnQoUGFpbnRJbmZv JiBwYWludEluZm8sIGludCYgdHgsIGludCYgdHkpCitib29sIFJlbmRlclJlcGxhY2VkOjpzaG91 bGRQYWludChQYWludEluZm8mIHBhaW50SW5mbywgY29uc3QgSW50UG9pbnQmIHBhaW50T2Zmc2V0 KQogewogICAgIGlmIChwYWludEluZm8ucGhhc2UgIT0gUGFpbnRQaGFzZUZvcmVncm91bmQgJiYg cGFpbnRJbmZvLnBoYXNlICE9IFBhaW50UGhhc2VPdXRsaW5lICYmIHBhaW50SW5mby5waGFzZSAh PSBQYWludFBoYXNlU2VsZk91dGxpbmUgCiAgICAgICAgICAgICAmJiBwYWludEluZm8ucGhhc2Ug IT0gUGFpbnRQaGFzZVNlbGVjdGlvbiAmJiBwYWludEluZm8ucGhhc2UgIT0gUGFpbnRQaGFzZU1h c2spCkBAIC0xNjksMjEgKzE2OSwyMCBAQCBib29sIFJlbmRlclJlcGxhY2VkOjpzaG91bGRQYWlu dChQYWludEluCiAgICAgaWYgKHN0eWxlKCktPnZpc2liaWxpdHkoKSAhPSBWSVNJQkxFKQogICAg ICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICBpbnQgY3VycmVudFRYID0gdHggKyB4KCk7Ci0gICAg aW50IGN1cnJlbnRUWSA9IHR5ICsgeSgpOworICAgIEludFBvaW50IGFkanVzdGVkUGFpbnRPZmZz ZXQgPSBwYWludE9mZnNldCArIGxvY2F0aW9uKCk7CiAKICAgICAvLyBFYXJseSBleGl0IGlmIHRo ZSBlbGVtZW50IHRvdWNoZXMgdGhlIGVkZ2VzLgotICAgIGludCB0b3AgPSBjdXJyZW50VFkgKyBt aW5ZVmlzdWFsT3ZlcmZsb3coKTsKLSAgICBpbnQgYm90dG9tID0gY3VycmVudFRZICsgbWF4WVZp c3VhbE92ZXJmbG93KCk7CisgICAgaW50IHRvcCA9IGFkanVzdGVkUGFpbnRPZmZzZXQueSgpICsg bWluWVZpc3VhbE92ZXJmbG93KCk7CisgICAgaW50IGJvdHRvbSA9IGFkanVzdGVkUGFpbnRPZmZz ZXQueSgpICsgbWF4WVZpc3VhbE92ZXJmbG93KCk7CiAgICAgaWYgKGlzU2VsZWN0ZWQoKSAmJiBt X2lubGluZUJveFdyYXBwZXIpIHsKLSAgICAgICAgaW50IHNlbFRvcCA9IHR5ICsgbV9pbmxpbmVC b3hXcmFwcGVyLT5yb290KCktPnNlbGVjdGlvblRvcCgpOwotICAgICAgICBpbnQgc2VsQm90dG9t ID0gdHkgKyBzZWxUb3AgKyBtX2lubGluZUJveFdyYXBwZXItPnJvb3QoKS0+c2VsZWN0aW9uSGVp Z2h0KCk7CisgICAgICAgIGludCBzZWxUb3AgPSBwYWludE9mZnNldC55KCkgKyBtX2lubGluZUJv eFdyYXBwZXItPnJvb3QoKS0+c2VsZWN0aW9uVG9wKCk7CisgICAgICAgIGludCBzZWxCb3R0b20g PSBwYWludE9mZnNldC55KCkgKyBzZWxUb3AgKyBtX2lubGluZUJveFdyYXBwZXItPnJvb3QoKS0+ c2VsZWN0aW9uSGVpZ2h0KCk7CiAgICAgICAgIHRvcCA9IG1pbihzZWxUb3AsIHRvcCk7CiAgICAg ICAgIGJvdHRvbSA9IG1heChzZWxCb3R0b20sIGJvdHRvbSk7CiAgICAgfQogICAgIAogICAgIGlu dCBvcyA9IDIgKiBtYXhpbWFsT3V0bGluZVNpemUocGFpbnRJbmZvLnBoYXNlKTsKLSAgICBpZiAo Y3VycmVudFRYICsgbWluWFZpc3VhbE92ZXJmbG93KCkgPj0gcGFpbnRJbmZvLnJlY3QubWF4WCgp ICsgb3MgfHwgY3VycmVudFRYICsgbWF4WFZpc3VhbE92ZXJmbG93KCkgPD0gcGFpbnRJbmZvLnJl Y3QueCgpIC0gb3MpCisgICAgaWYgKGFkanVzdGVkUGFpbnRPZmZzZXQueCgpICsgbWluWFZpc3Vh bE92ZXJmbG93KCkgPj0gcGFpbnRJbmZvLnJlY3QubWF4WCgpICsgb3MgfHwgYWRqdXN0ZWRQYWlu dE9mZnNldC54KCkgKyBtYXhYVmlzdWFsT3ZlcmZsb3coKSA8PSBwYWludEluZm8ucmVjdC54KCkg LSBvcykKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIGlmICh0b3AgPj0gcGFpbnRJbmZvLnJl Y3QubWF4WSgpICsgb3MgfHwgYm90dG9tIDw9IHBhaW50SW5mby5yZWN0LnkoKSAtIG9zKQogICAg ICAgICByZXR1cm4gZmFsc2U7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy UmVwbGFjZWQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy UmVwbGFjZWQuaAkocmV2aXNpb24gODgxOTUpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyUmVwbGFjZWQuaAkod29ya2luZyBjb3B5KQpAQCAtNTIsNyArNTIsNyBAQCBwcm90ZWN0 ZWQ6CiAgICAgdm9pZCBzZXRIYXNJbnRyaW5zaWNTaXplKCkgeyBtX2hhc0ludHJpbnNpY1NpemUg PSB0cnVlOyB9CiAKICAgICB2aXJ0dWFsIHZvaWQgcGFpbnQoUGFpbnRJbmZvJiwgaW50IHR4LCBp bnQgdHkpOwotICAgIGJvb2wgc2hvdWxkUGFpbnQoUGFpbnRJbmZvJiwgaW50JiB0eCwgaW50JiB0 eSk7CisgICAgYm9vbCBzaG91bGRQYWludChQYWludEluZm8mLCBjb25zdCBJbnRQb2ludCYpOwog ICAgIEludFJlY3QgbG9jYWxTZWxlY3Rpb25SZWN0KGJvb2wgY2hlY2tXaGV0aGVyU2VsZWN0ZWQg PSB0cnVlKSBjb25zdDsgLy8gVGhpcyBpcyBpbiBsb2NhbCBjb29yZGluYXRlcywgYnV0IGl0J3Mg YSBwaHlzaWNhbCByZWN0IChzbyB0aGUgdG9wIGxlZnQgY29ybmVyIGlzIHBoeXNpY2FsIHRvcCBs ZWZ0KS4KIAogcHJpdmF0ZToKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJX aWRnZXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJX aWRnZXQuY3BwCShyZXZpc2lvbiA4ODE5NSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJXaWRnZXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNDksNyArMjQ5LDcgQEAgdm9pZCBS ZW5kZXJXaWRnZXQ6Om5vdGlmeVdpZGdldChXaWRnZXRObwogCiB2b2lkIFJlbmRlcldpZGdldDo6 cGFpbnQoUGFpbnRJbmZvJiBwYWludEluZm8sIGludCB0eCwgaW50IHR5KQogewotICAgIGlmICgh c2hvdWxkUGFpbnQocGFpbnRJbmZvLCB0eCwgdHkpKQorICAgIGlmICghc2hvdWxkUGFpbnQocGFp bnRJbmZvLCBJbnRQb2ludCh0eCwgdHkpKSkKICAgICAgICAgcmV0dXJuOwogCiAgICAgdHggKz0g eCgpOwo=