62124 2011-06-06 06:38:05 -0700 Do not use NPRuntimeObjectMap in NetscapePlugin::setException when plug-in is running out of process 2011-06-06 10:10:33 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 60546 1 cgarcia webkit-unassigned andersca oldest_to_newest 415805 0 cgarcia 2011-06-06 06:38:05 -0700 In the GTK+ port we build the plugin process with only the minimum files required, because we need to compile it with gtk2 even when building webkit with gtk3. NPRuntimeObjectMap::setGlobalException(exceptionString); breaks the build for us when building with plugin process enabled. 415806 1 96083 cgarcia 2011-06-06 06:41:48 -0700 Created attachment 96083 Patch Use #if !ENABLE(PLUGIN_PROCESS) block as suggested by Anders, it doesn't really fix the FIXME, but it allows us to build for now. 415821 2 96083 andersca 2011-06-06 07:19:05 -0700 Comment on attachment 96083 Patch Could you change the #ifdef to read something like: #if ENABLE(PLUGIN_PROCESS) // FIXME ... #else NPRuntimeObjectmap::setGlobalException() #end 415876 3 cgarcia 2011-06-06 10:07:13 -0700 Sure! 415879 4 cgarcia 2011-06-06 10:10:33 -0700 Committed r88171: <http://trac.webkit.org/changeset/88171> 96083 2011-06-06 06:41:48 -0700 2011-06-06 07:19:05 -0700 Patch wk2-set-exception.diff text/plain 1563 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5ZDk1OTQxLi40ZDdhZDQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUg QEAKIDIwMTEtMDYtMDYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvIG5v dCB1c2UgTlBSdW50aW1lT2JqZWN0TWFwIGluIE5ldHNjYXBlUGx1Z2luOjpzZXRFeGNlcHRpb24g d2hlbiBwbHVnLWluIGlzIHJ1bm5pbmcgb3V0IG9mIHByb2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyMTI0CisKKyAgICAgICAgKiBXZWJQcm9j ZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW4uY3BwOgorICAgICAgICAoV2ViS2l0 OjpOZXRzY2FwZVBsdWdpbjo6c2V0RXhjZXB0aW9uKToKKworMjAxMS0wNi0wNiAgQ2FybG9zIEdh cmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkg QW5kZXJzIENhcmxzc29uLgogCiAgICAgICAgIFtVTklYXSBTT0NLX0RHUkFNIHNvY2tldHMgYXJl IG5vdCBub3RpZmllZCB3aGVuIHRoZSBvdGhlciBlbmQgY2xvc2VzIHRoZSBjb25uZWN0aW9uCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0 c2NhcGVQbHVnaW4uY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNj YXBlL05ldHNjYXBlUGx1Z2luLmNwcAppbmRleCAxNzNlYjc3Li5mNzE1ZjNkIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVn aW4uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9O ZXRzY2FwZVBsdWdpbi5jcHAKQEAgLTIxMyw5ICsyMTMsMTEgQEAgdm9pZCBOZXRzY2FwZVBsdWdp bjo6c2V0U3RhdHVzYmFyVGV4dChjb25zdCBTdHJpbmcmIHN0YXR1c2JhclRleHQpCiAKIHZvaWQg TmV0c2NhcGVQbHVnaW46OnNldEV4Y2VwdGlvbihjb25zdCBTdHJpbmcmIGV4Y2VwdGlvblN0cmlu ZykKIHsKKyNpZiAhRU5BQkxFKFBMVUdJTl9QUk9DRVNTKQogICAgIC8vIEZJWE1FOiBJZiB0aGUg cGx1Zy1pbiBpcyBydW5uaW5nIGluIGl0cyBvd24gcHJvY2VzcywgdGhpcyBuZWVkcyB0byBzZW5k IGEgQ29yZUlQQyBtZXNzYWdlIGluc3RlYWQgb2YKICAgICAvLyBjYWxsaW5nIHRoZSBydW50aW1l IG9iamVjdCBtYXAgZGlyZWN0bHkuCiAgICAgTlBSdW50aW1lT2JqZWN0TWFwOjpzZXRHbG9iYWxF eGNlcHRpb24oZXhjZXB0aW9uU3RyaW5nKTsKKyNlbmRpZgogfQogCiBib29sIE5ldHNjYXBlUGx1 Z2luOjpldmFsdWF0ZShOUE9iamVjdCogbnBPYmplY3QsIGNvbnN0IFN0cmluZyYgc2NyaXB0U3Ry aW5nLCBOUFZhcmlhbnQqIHJlc3VsdCkK