62084 2011-06-03 21:50:21 -0700 clang build error: hidden overloaded virtual function 2011-06-03 22:03:26 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned joepeck leviw oldest_to_newest 415387 0 joepeck 2011-06-03 21:50:21 -0700 This seemed to cause a clang build warning (which is treated as an error). > CompileC RenderTable.o > In file included from /Users/pecoraro/Code/webkit-open-source/Source/WebCore/rendering/RenderTable.cpp:38: > Source/WebCore/rendering/RenderTableCell.h:146:18: error: 'WebCore::RenderTableCell::paintMask' hides overloaded virtual function [-Werror,-Woverloaded-virtual,3] > Source/WebCore/rendering/RenderBox.h:357:18: note: hidden overloaded virtual function 'WebCore::RenderBox::paintMask' declared here [3] > 1 error generated. > Command /Developer/usr/bin/clang failed with exit code 1 Indeed the functions have a similar but different signature: RenderBox.h: virtual void paintMask(PaintInfo&, const IntPoint&); RenderTableCell.h: virtual void paintMask(PaintInfo&, IntSize); RenderTableCell just takes the incoming IntSize and makes an IntPoint out of it anyways. 415389 1 joepeck 2011-06-03 21:51:10 -0700 I meant to say this was caused by: <http://trac.webkit.org/changeset/88087> But we should probably just fix RenderTableCell. 415394 2 96007 joepeck 2011-06-03 22:01:02 -0700 Created attachment 96007 [PATCH] Build Fix I just want a sanity check from someone on this one, but I'm pretty sure its the right fix. 415398 3 joepeck 2011-06-03 22:03:18 -0700 Mitz "The Master" landed this already in: <http://trac.webkit.org/changeset/88090> 96007 2011-06-03 22:01:02 -0700 2011-06-03 22:03:26 -0700 [PATCH] Build Fix patch text/plain 2478 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3ODU0MGQ5Li5jMWYzYWMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDYtMDMgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBjbGFuZyBidWls ZCBlcnJvcjogaGlkZGVuIG92ZXJsb2FkZWQgdmlydHVhbCBmdW5jdGlvbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjIwODQKKworICAgICAgICBGb2xs b3ctdXAgdG8gcjg4MDg3IGFuZCBjb252ZXJ0IGFub3RoZXIgcGFpbnRNYXNrIGZ1bmN0aW9uCisg ICAgICAgIGZyb20gSW50U2l6ZSB0byBJbnRQb2ludC4KKworICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJUYWJsZUNlbGwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGFibGVDZWxsOjpw YWludE1hc2spOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUYWJsZUNlbGwuaDoKKwogMjAx MS0wNi0wMSAgSm9zZXBoIFBlY29yYXJvICA8am9lcGVja0B3ZWJraXQub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRhYmxlQ2VsbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyVGFibGVDZWxsLmNwcAppbmRleCA5MzI0NzExLi5iNWYwNmFhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmNwcApAQCAtMTAyMCw3ICsxMDIwLDcg QEAgdm9pZCBSZW5kZXJUYWJsZUNlbGw6OnBhaW50Qm94RGVjb3JhdGlvbnMoUGFpbnRJbmZvJiBw YWludEluZm8sIGNvbnN0IEludFBvaW50JgogICAgIHBhaW50Qm9yZGVyKHBhaW50SW5mby5jb250 ZXh0LCBwYWludFJlY3QsIHN0eWxlKCkpOwogfQogCi12b2lkIFJlbmRlclRhYmxlQ2VsbDo6cGFp bnRNYXNrKFBhaW50SW5mbyYgcGFpbnRJbmZvLCBJbnRTaXplIHBhaW50T2Zmc2V0KQordm9pZCBS ZW5kZXJUYWJsZUNlbGw6OnBhaW50TWFzayhQYWludEluZm8mIHBhaW50SW5mbywgY29uc3QgSW50 UG9pbnQmIHBhaW50T2Zmc2V0KQogewogICAgIGlmIChzdHlsZSgpLT52aXNpYmlsaXR5KCkgIT0g VklTSUJMRSB8fCBwYWludEluZm8ucGhhc2UgIT0gUGFpbnRQaGFzZU1hc2spCiAgICAgICAgIHJl dHVybjsKQEAgLTEwMjksNyArMTAyOSw3IEBAIHZvaWQgUmVuZGVyVGFibGVDZWxsOjpwYWludE1h c2soUGFpbnRJbmZvJiBwYWludEluZm8sIEludFNpemUgcGFpbnRPZmZzZXQpCiAgICAgaWYgKCF0 YWJsZUVsdC0+Y29sbGFwc2VCb3JkZXJzKCkgJiYgc3R5bGUoKS0+ZW1wdHlDZWxscygpID09IEhJ REUgJiYgIWZpcnN0Q2hpbGQoKSkKICAgICAgICAgcmV0dXJuOwogICAgCi0gICAgcGFpbnRNYXNr SW1hZ2VzKHBhaW50SW5mbywgSW50UmVjdCh0b1BvaW50KHBhaW50T2Zmc2V0KSwgc2l6ZSgpKSk7 CisgICAgcGFpbnRNYXNrSW1hZ2VzKHBhaW50SW5mbywgSW50UmVjdChwYWludE9mZnNldCwgc2l6 ZSgpKSk7CiB9CiAKIHZvaWQgUmVuZGVyVGFibGVDZWxsOjpzY3JvbGxiYXJzQ2hhbmdlZChib29s IGhvcml6b250YWxTY3JvbGxiYXJDaGFuZ2VkLCBib29sIHZlcnRpY2FsU2Nyb2xsYmFyQ2hhbmdl ZCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZUNlbGwu aCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZUNlbGwuaAppbmRleCBlNTc4 NDZmLi5jZTNhY2U0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGFibGVDZWxsLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlQ2Vs bC5oCkBAIC0xNDMsNyArMTQzLDcgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgY29tcHV0 ZUxvZ2ljYWxXaWR0aCgpOwogCiAgICAgdmlydHVhbCB2b2lkIHBhaW50Qm94RGVjb3JhdGlvbnMo UGFpbnRJbmZvJiwgY29uc3QgSW50UG9pbnQmKTsKLSAgICB2aXJ0dWFsIHZvaWQgcGFpbnRNYXNr KFBhaW50SW5mbyYsIEludFNpemUpOworICAgIHZpcnR1YWwgdm9pZCBwYWludE1hc2soUGFpbnRJ bmZvJiwgY29uc3QgSW50UG9pbnQmKTsKIAogICAgIHZpcnR1YWwgSW50U2l6ZSBvZmZzZXRGcm9t Q29udGFpbmVyKFJlbmRlck9iamVjdCosIGNvbnN0IEludFBvaW50JikgY29uc3Q7CiAgICAgdmly dHVhbCBJbnRSZWN0IGNsaXBwZWRPdmVyZmxvd1JlY3RGb3JSZXBhaW50KFJlbmRlckJveE1vZGVs T2JqZWN0KiByZXBhaW50Q29udGFpbmVyKTsK