62076 2011-06-03 17:27:43 -0700 [chromium] Make ChromePrintContext's destructor virtual 2011-06-04 04:15:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thakis thakis webkit.review.bot oldest_to_newest 415323 0 thakis 2011-06-03 17:27:43 -0700 [chromium] Make ChromePrintContext's destructor virtual 415326 1 95997 thakis 2011-06-03 17:29:06 -0700 Created attachment 95997 Patch 415329 2 thakis 2011-06-03 17:33:57 -0700 jamesr points out that this isn't _really_ a bug since the subclass destructor doesn't do anything and has only POD members. 415457 3 95997 webkit.review.bot 2011-06-04 04:15:00 -0700 Comment on attachment 95997 Patch Clearing flags on attachment: 95997 Committed r88109: <http://trac.webkit.org/changeset/88109> 415458 4 webkit.review.bot 2011-06-04 04:15:04 -0700 All reviewed patches have been landed. Closing bug. 95997 2011-06-03 17:29:06 -0700 2011-06-04 04:15:00 -0700 Patch bug-62076-20110603172905.patch text/plain 1608 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogODc2MjcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg OGMwZjIwMGNmZTI3NzdmMzVjNTMwNTE1ZWY5ZGVkMGMxMzBjY2E3ZC4uMjZjMjNkNzgxMWJmYjVi ODFiM2Q1NjcyNzA0ZDZhMmUxNWVhMWFhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxOCBAQAorMjAxMS0wNi0wMyAgTmljbyBXZWJlciAgPHRoYWtpc0BjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2No cm9taXVtXSBNYWtlIENocm9tZVByaW50Q29udGV4dCdzIGRlc3RydWN0b3IgdmlydHVhbAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjIwNzYKKworICAg ICAgICBTaW5jZSBXZWJGcmFtZUltcGwncyBtX3ByaW50Q29udGV4dCBpcyBhIE9ud1B0cjxDaHJv bWVQcmludENvbnRleHQ+CisgICAgICAgIHRoYXQgaXMgZHluYW1pY2FsbHkgc2V0IHRvIGVpdGhl ciBhIENocm9tZVByaW50Q29udGV4dCBvciBhCisgICAgICAgIENocm9tZVBsdWdpblByaW50Q29u dGV4dCwgdGhpcyBmaXhlcyBhbiBhY3R1YWwgYnVnLgorCisgICAgICAgICogc3JjL1dlYkZyYW1l SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNocm9tZVByaW50Q29udGV4dDo6fkNocm9tZVBy aW50Q29udGV4dCk6CisgICAgICAgIChXZWJLaXQ6OkNocm9tZVBsdWdpblByaW50Q29udGV4dDo6 fkNocm9tZVBsdWdpblByaW50Q29udGV4dCk6CisKIDIwMTEtMDUtMjcgIEpvY2hlbiBFaXNpbmdl ciAgPGpvY2hlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0 aC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5j cHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCmluZGV4IDBk NjQyOGQ4NGZmMjQwMGU2NTllZWZjMTc2NjJkY2JiODE2OGVhZGYuLjE5ZDhjNzEzMTVlNTVlMzA4 ZGY4Yjk3NzFkZTI3ZTY4OTk0NTc4YzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViRnJhbWVJbXBsLmNwcApAQCAtMzA2LDYgKzMwNiw4IEBAIHB1YmxpYzoKICAgICB7CiAgICAg fQogCisgICAgdmlydHVhbCB+Q2hyb21lUHJpbnRDb250ZXh0KCkgeyB9CisKICAgICB2aXJ0dWFs IHZvaWQgYmVnaW4oZmxvYXQgd2lkdGgsIGZsb2F0IGhlaWdodCkKICAgICB7CiAgICAgICAgIEFT U0VSVCghbV9wcmludGVkUGFnZVdpZHRoKTsKQEAgLTM3Niw2ICszNzgsOCBAQCBwdWJsaWM6CiAg ICAgewogICAgIH0KIAorICAgIHZpcnR1YWwgfkNocm9tZVBsdWdpblByaW50Q29udGV4dCgpIHsg fQorCiAgICAgdmlydHVhbCB2b2lkIGJlZ2luKGZsb2F0IHdpZHRoLCBmbG9hdCBoZWlnaHQpCiAg ICAgewogICAgIH0K