62074 2011-06-03 17:22:50 -0700 [chromium] Make WebTextCheckingCompletionImpl's destructor virtual 2011-06-04 11:20:39 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thakis thakis webkit.review.bot oldest_to_newest 415320 0 thakis 2011-06-03 17:22:50 -0700 [chromium] Make WebTextCheckingCompletionImpl's destructor virtual 415321 1 95995 thakis 2011-06-03 17:23:34 -0700 Created attachment 95995 Patch 415455 2 95995 webkit.review.bot 2011-06-04 04:07:00 -0700 Comment on attachment 95995 Patch Clearing flags on attachment: 95995 Committed r88108: <http://trac.webkit.org/changeset/88108> 415456 3 webkit.review.bot 2011-06-04 04:07:04 -0700 All reviewed patches have been landed. Closing bug. 415508 4 95995 abarth 2011-06-04 11:20:39 -0700 Comment on attachment 95995 Patch Virtual functions in headers should be out-of-line, right? 95995 2011-06-03 17:23:34 -0700 2011-06-04 11:20:39 -0700 Patch bug-62074-20110603172333.patch text/plain 1552 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogODc2MjcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg OGMwZjIwMGNmZTI3NzdmMzVjNTMwNTE1ZWY5ZGVkMGMxMzBjY2E3ZC4uYmQ5NzI2OGQ5ZjA0OTIx OWNlMTdhMDIxZTgyYjMxODY2NTU4Njk1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxOCBAQAorMjAxMS0wNi0wMyAgTmljbyBXZWJlciAgPHRoYWtpc0BjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2No cm9taXVtXSBNYWtlIFdlYlRleHRDaGVja2luZ0NvbXBsZXRpb25JbXBsJ3MgZGVzdHJ1Y3RvciB2 aXJ0dWFsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 MjA3NAorCisgICAgICAgIFRoaXMgaXMgX25vdF8gdG8gZml4IGEgcmVhbCBidWcsIGp1c3QgdG8g bWFrZSBjbGFuZydzCisgICAgICAgIC1XZGVsZXRlLW5vbi12aXJ0dWFsLWR0b3IgaGFwcHkuIEFz IGRpc2N1c3NlZCBhdAorICAgICAgICBodHRwOi8vY29kZXJldmlldy5jaHJvbWl1bS5vcmcvNzA5 NDAwNS8sIHdlIHByZWZlciBtYWtpbmcgbGVhZiBjbGFzcworICAgICAgICBkZXN0cnVjdG9ycyB2 aXJ0dWFsIG92ZXIgbWFraW5nIHRoZSBsZWFmIGNsYXNzZXMgZmluYWwuCisKKyAgICAgICAgKiBz cmMvV2ViVGV4dENoZWNraW5nQ29tcGxldGlvbkltcGwuaDoKKyAgICAgICAgKFdlYktpdDo6V2Vi VGV4dENoZWNraW5nQ29tcGxldGlvbkltcGw6On5XZWJUZXh0Q2hlY2tpbmdDb21wbGV0aW9uSW1w bCk6CisKIDIwMTEtMDUtMjcgIEpvY2hlbiBFaXNpbmdlciAgPGpvY2hlbkBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYlRleHRDaGVja2luZ0NvbXBsZXRpb25JbXBsLmggYi9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJUZXh0Q2hlY2tpbmdDb21wbGV0aW9uSW1wbC5oCmlu ZGV4IGYxMDE3Yzc0YTRiZjYyOWQxM2YwODYxZDM2NTI0ZGY5OWY4Yzk2MzIuLjkzYjI4ZTMwOWU0 ZGFlYTI3NzUwZGViYjM2Y2FiZmVmNWRkMWY3YWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYlRleHRDaGVja2luZ0NvbXBsZXRpb25JbXBsLmgKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVGV4dENoZWNraW5nQ29tcGxldGlvbkltcGwuaApAQCAt NDYsNiArNDYsOCBAQCBwdWJsaWM6CiAgICAgewogICAgIH0KIAorICAgIHZpcnR1YWwgfldlYlRl eHRDaGVja2luZ0NvbXBsZXRpb25JbXBsKCkgeyB9CisKICAgICB2aXJ0dWFsIHZvaWQgZGlkRmlu aXNoQ2hlY2tpbmdUZXh0KGNvbnN0IFdlYlZlY3RvcjxXZWJUZXh0Q2hlY2tpbmdSZXN1bHQ+Jik7 CiAKIHByaXZhdGU6Cg==