62053 2011-06-03 14:32:16 -0700 Biquad filter coefficient naming is incorrect 2011-06-03 15:52:52 -0700 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 crogers crogers crogers kbr oldest_to_newest 415203 0 crogers 2011-06-03 14:32:16 -0700 Biquad filter coefficient naming is incorrect 415217 1 crogers 2011-06-03 14:46:24 -0700 This is just a simple variable naming change to reflect the commonly used naming convention for biquad filters: http://en.wikipedia.org/wiki/Digital_biquad_filter This is not a change in functionality, just in naming convention. The current names have the 'a' and 'b' variable names reversed. This patch changes the naming as follows: m_a0 -> m_b0 m_a1 -> m_b1 m_b2 -> m_b2 m_b1 -> m_a1 m_b2 -> m_a2 This minor naming change will help clarify filter coefficient calculation from cookbook filter formulas. Why did I have the names reversed in the first place? Because I was coding this from memory and got the names (if not the functionality) wrong. 415218 2 95967 crogers 2011-06-03 14:48:22 -0700 Created attachment 95967 Patch 415237 3 95967 kbr 2011-06-03 15:23:28 -0700 Comment on attachment 95967 Patch Looks fine. 415255 4 crogers 2011-06-03 15:52:52 -0700 Committed r88072: <http://trac.webkit.org/changeset/88072> 95967 2011-06-03 14:48:22 -0700 2011-06-03 15:23:28 -0700 Patch bug-62053-20110603144821.patch text/plain 5702 crogers SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4MDYzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDYtMDMgIENocmlzIFJv Z2VycyAgPGNyb2dlcnNAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBCaXF1YWQgZmlsdGVyIGNvZWZmaWNpZW50IG5hbWluZyBpcyBp bmNvcnJlY3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTYyMDUzCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHNpbmNlIGF1ZGlvIEFQSSBpcyBub3QgeWV0 IGltcGxlbWVudGVkLgorCisgICAgICAgICogcGxhdGZvcm0vYXVkaW8vQmlxdWFkLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkJpcXVhZDo6QmlxdWFkKToKKyAgICAgICAgKFdlYkNvcmU6OkJpcXVh ZDo6cHJvY2Vzcyk6CisgICAgICAgIChXZWJDb3JlOjpCaXF1YWQ6OnByb2Nlc3NGYXN0KToKKyAg ICAgICAgKFdlYkNvcmU6OkJpcXVhZDo6c2V0TG93cGFzc1BhcmFtcyk6CisgICAgICAgIChXZWJD b3JlOjpCaXF1YWQ6OnNldEhpZ2hwYXNzUGFyYW1zKToKKyAgICAgICAgKFdlYkNvcmU6OkJpcXVh ZDo6c2V0TG93U2hlbGZQYXJhbXMpOgorICAgICAgICAoV2ViQ29yZTo6QmlxdWFkOjpzZXRaZXJv UG9sZVBhaXJzKToKKyAgICAgICAgKiBwbGF0Zm9ybS9hdWRpby9CaXF1YWQuaDoKKwogMjAxMS0w Ni0wMyAgTGV2aSBXZWludHJhdWIgIDxsZXZpd0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRp by9CaXF1YWQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlv L0JpcXVhZC5jcHAJKHJldmlzaW9uIDg4MDYxKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v YXVkaW8vQmlxdWFkLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTMsMTMgKzUzLDExIEBAIEJpcXVh ZDo6QmlxdWFkKCkKICNlbmRpZgogCiAgICAgLy8gSW5pdGlhbGl6ZSBhcyBwYXNzLXRocnUgKHN0 cmFpZ2h0LXdpcmUsIG5vIGZpbHRlciBlZmZlY3QpCi0gICAgbV9hMCA9IDEuMDsKLSAgICBtX2Ex ID0gMC4wOwotICAgIG1fYTIgPSAwLjA7CisgICAgbV9iMCA9IDEuMDsKICAgICBtX2IxID0gMC4w OwogICAgIG1fYjIgPSAwLjA7Ci0KLSAgICBtX2cgPSAxLjA7CisgICAgbV9hMSA9IDAuMDsKKyAg ICBtX2EyID0gMC4wOwogCiAgICAgcmVzZXQoKTsgLy8gY2xlYXIgZmlsdGVyIG1lbW9yeQogfQpA QCAtNzgsMTggKzc2LDE2IEBAIHZvaWQgQmlxdWFkOjpwcm9jZXNzKGNvbnN0IGZsb2F0KiBzb3Vy Y2UKICAgICBkb3VibGUgeTEgPSBtX3kxOwogICAgIGRvdWJsZSB5MiA9IG1feTI7CiAKLSAgICBk b3VibGUgYTAgPSBtX2EwOwotICAgIGRvdWJsZSBhMSA9IG1fYTE7Ci0gICAgZG91YmxlIGEyID0g bV9hMjsKKyAgICBkb3VibGUgYjAgPSBtX2IwOwogICAgIGRvdWJsZSBiMSA9IG1fYjE7CiAgICAg ZG91YmxlIGIyID0gbV9iMjsKKyAgICBkb3VibGUgYTEgPSBtX2ExOworICAgIGRvdWJsZSBhMiA9 IG1fYTI7CiAKICAgICB3aGlsZSAobi0tKSB7CiAgICAgICAgIC8vIEZJWE1FOiB0aGlzIGNhbiBi ZSBvcHRpbWl6ZWQgYnkgcGlwZWxpbmluZyB0aGUgbXVsdGlwbHkgYWRkcy4uLgogICAgICAgICBm bG9hdCB4ID0gKnNvdXJjZVArKzsKLSAgICAgICAgZmxvYXQgeSA9IGEwKnggKyBhMSp4MSArIGEy KngyIC0gYjEqeTEgLSBiMip5MjsKLQotICAgICAgICB5ICo9IG1fZzsKKyAgICAgICAgZmxvYXQg eSA9IGIwKnggKyBiMSp4MSArIGIyKngyIC0gYTEqeTEgLSBhMip5MjsKIAogICAgICAgICAqZGVz dFArKyA9IHk7CiAKQEAgLTEwNiwxMSArMTAyLDExIEBAIHZvaWQgQmlxdWFkOjpwcm9jZXNzKGNv bnN0IGZsb2F0KiBzb3VyY2UKICAgICBtX3kxID0geTE7CiAgICAgbV95MiA9IHkyOwogCi0gICAg bV9hMCA9IGEwOwotICAgIG1fYTEgPSBhMTsKLSAgICBtX2EyID0gYTI7CisgICAgbV9iMCA9IGIw OwogICAgIG1fYjEgPSBiMTsKICAgICBtX2IyID0gYjI7CisgICAgbV9hMSA9IGExOworICAgIG1f YTIgPSBhMjsKICNlbmRpZgogfQogCkBAIC0xMjAsMTMgKzExNiwxMiBAQCB2b2lkIEJpcXVhZDo6 cHJvY2Vzcyhjb25zdCBmbG9hdCogc291cmNlCiAKIHZvaWQgQmlxdWFkOjpwcm9jZXNzRmFzdChj b25zdCBmbG9hdCogc291cmNlUCwgZmxvYXQqIGRlc3RQLCBzaXplX3QgZnJhbWVzVG9Qcm9jZXNz KQogewotICAgIC8vIEZpbHRlciBjb2VmZmljaWVudHMKLSAgICBkb3VibGUgQls1XTsKLSAgICBC WzBdID0gbV9hMDsKLSAgICBCWzFdID0gbV9hMTsKLSAgICBCWzJdID0gbV9hMjsKLSAgICBCWzNd ID0gbV9iMTsKLSAgICBCWzRdID0gbV9iMjsKKyAgICBkb3VibGUgZmlsdGVyQ29lZmZpY2llbnRz WzVdOworICAgIGZpbHRlckNvZWZmaWNpZW50c1swXSA9IG1fYjA7CisgICAgZmlsdGVyQ29lZmZp Y2llbnRzWzFdID0gbV9iMTsKKyAgICBmaWx0ZXJDb2VmZmljaWVudHNbMl0gPSBtX2IyOworICAg IGZpbHRlckNvZWZmaWNpZW50c1szXSA9IG1fYTE7CisgICAgZmlsdGVyQ29lZmZpY2llbnRzWzRd ID0gbV9hMjsKIAogICAgIGRvdWJsZSogaW5wdXRQID0gbV9pbnB1dEJ1ZmZlci5kYXRhKCk7CiAg ICAgZG91YmxlKiBvdXRwdXRQID0gbV9vdXRwdXRCdWZmZXIuZGF0YSgpOwpAQCAtMTQ1LDcgKzE0 MCw3IEBAIHZvaWQgQmlxdWFkOjpwcm9jZXNzRmFzdChjb25zdCBmbG9hdCogc28KICAgICAgICAg Zm9yIChpbnQgaSA9IDA7IGkgPCBmcmFtZXNUaGlzVGltZTsgKytpKQogICAgICAgICAgICAgaW5w dXQyUFtpXSA9ICpzb3VyY2VQKys7CiAKLSAgICAgICAgcHJvY2Vzc1NsaWNlRmFzdChpbnB1dFAs IG91dHB1dFAsIEIsIGZyYW1lc1RoaXNUaW1lKTsKKyAgICAgICAgcHJvY2Vzc1NsaWNlRmFzdChp bnB1dFAsIG91dHB1dFAsIGZpbHRlckNvZWZmaWNpZW50cywgZnJhbWVzVGhpc1RpbWUpOwogCiAg ICAgICAgIC8vIENvcHkgb3V0cHV0IGJ1ZmZlciB0byBvdXRwdXQgKGNvbnZlcnRzIGZsb2F0IC0+ IGRvdWJsZSkuCiAgICAgICAgIGZvciAoaW50IGkgPSAwOyBpIDwgZnJhbWVzVGhpc1RpbWU7ICsr aSkKQEAgLTIwMiwxMSArMTk3LDExIEBAIHZvaWQgQmlxdWFkOjpzZXRMb3dwYXNzUGFyYW1zKGRv dWJsZSBjdXQKICAgICBkb3VibGUgZ2FtbWEgPSAoMC41ICsgYmV0YSkgKiBjb3ModGhldGEpOwog ICAgIGRvdWJsZSBhbHBoYSA9IDAuMjUgKiAoMC41ICsgYmV0YSAtIGdhbW1hKTsKIAotICAgIG1f YTAgPSAyLjAgKiBhbHBoYTsKLSAgICBtX2ExID0gMi4wICogMi4wKmFscGhhOwotICAgIG1fYTIg PSAyLjAgKiBhbHBoYTsKLSAgICBtX2IxID0gMi4wICogLWdhbW1hOwotICAgIG1fYjIgPSAyLjAg KiBiZXRhOworICAgIG1fYjAgPSAyLjAgKiBhbHBoYTsKKyAgICBtX2IxID0gMi4wICogMi4wKmFs cGhhOworICAgIG1fYjIgPSAyLjAgKiBhbHBoYTsKKyAgICBtX2ExID0gMi4wICogLWdhbW1hOwor ICAgIG1fYTIgPSAyLjAgKiBiZXRhOwogfQogCiB2b2lkIEJpcXVhZDo6c2V0SGlnaHBhc3NQYXJh bXMoZG91YmxlIGN1dG9mZiwgZG91YmxlIHJlc29uYW5jZSkKQEAgLTIyMywxMSArMjE4LDExIEBA IHZvaWQgQmlxdWFkOjpzZXRIaWdocGFzc1BhcmFtcyhkb3VibGUgY3UKICAgICBkb3VibGUgZ2Ft bWEgPSAoMC41ICsgYmV0YSkgKiBjb3ModGhldGEpOwogICAgIGRvdWJsZSBhbHBoYSA9IDAuMjUg KiAoMC41ICsgYmV0YSArIGdhbW1hKTsKIAotICAgIG1fYTAgPSAyLjAgKiBhbHBoYTsKLSAgICBt X2ExID0gMi4wICogLTIuMCphbHBoYTsKLSAgICBtX2EyID0gMi4wICogYWxwaGE7Ci0gICAgbV9i MSA9IDIuMCAqIC1nYW1tYTsKLSAgICBtX2IyID0gMi4wICogYmV0YTsKKyAgICBtX2IwID0gMi4w ICogYWxwaGE7CisgICAgbV9iMSA9IDIuMCAqIC0yLjAqYWxwaGE7CisgICAgbV9iMiA9IDIuMCAq IGFscGhhOworICAgIG1fYTEgPSAyLjAgKiAtZ2FtbWE7CisgICAgbV9hMiA9IDIuMCAqIGJldGE7 CiB9CiAKIHZvaWQgQmlxdWFkOjpzZXRMb3dTaGVsZlBhcmFtcyhkb3VibGUgY3V0b2ZmLCBkb3Vi bGUgZGJHYWluKQpAQCAtMjUwLDI1ICsyNDUsMjUgQEAgdm9pZCBCaXF1YWQ6OnNldExvd1NoZWxm UGFyYW1zKGRvdWJsZSBjdQogCiAgICAgZG91YmxlIGEwSW52ZXJzZSA9IDEuMCAvIGEwOwogICAg IAotICAgIG1fYTAgPSBiMCAqIGEwSW52ZXJzZTsKLSAgICBtX2ExID0gYjEgKiBhMEludmVyc2U7 Ci0gICAgbV9hMiA9IGIyICogYTBJbnZlcnNlOwotICAgIG1fYjEgPSBhMSAqIGEwSW52ZXJzZTsK LSAgICBtX2IyID0gYTIgKiBhMEludmVyc2U7CisgICAgbV9iMCA9IGIwICogYTBJbnZlcnNlOwor ICAgIG1fYjEgPSBiMSAqIGEwSW52ZXJzZTsKKyAgICBtX2IyID0gYjIgKiBhMEludmVyc2U7Cisg ICAgbV9hMSA9IGExICogYTBJbnZlcnNlOworICAgIG1fYTIgPSBhMiAqIGEwSW52ZXJzZTsKIH0K IAogdm9pZCBCaXF1YWQ6OnNldFplcm9Qb2xlUGFpcnMoY29uc3QgQ29tcGxleCAmemVybywgY29u c3QgQ29tcGxleCAmcG9sZSkKIHsKLSAgICBtX2EwID0gMS4wOwotICAgIG1fYTEgPSAtMi4wICog emVyby5yZWFsKCk7CisgICAgbV9iMCA9IDEuMDsKKyAgICBtX2IxID0gLTIuMCAqIHplcm8ucmVh bCgpOwogCiAgICAgZG91YmxlIHplcm9NYWcgPSBhYnMoemVybyk7Ci0gICAgbV9hMiA9IHplcm9N YWcgKiB6ZXJvTWFnOworICAgIG1fYjIgPSB6ZXJvTWFnICogemVyb01hZzsKIAotICAgIG1fYjEg PSAtMi4wICogcG9sZS5yZWFsKCk7CisgICAgbV9hMSA9IC0yLjAgKiBwb2xlLnJlYWwoKTsKIAog ICAgIGRvdWJsZSBwb2xlTWFnID0gYWJzKHBvbGUpOwotICAgIG1fYjIgPSBwb2xlTWFnICogcG9s ZU1hZzsKKyAgICBtX2EyID0gcG9sZU1hZyAqIHBvbGVNYWc7CiB9CiAKIHZvaWQgQmlxdWFkOjpz ZXRBbGxwYXNzUG9sZShjb25zdCBDb21wbGV4ICZwb2xlKQpJbmRleDogU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vYXVkaW8vQmlxdWFkLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vYXVkaW8vQmlxdWFkLmgJKHJldmlzaW9uIDg4MDYxKQorKysgU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vYXVkaW8vQmlxdWFkLmgJKHdvcmtpbmcgY29weSkKQEAgLTcxLDEzICs3MSwxMSBA QCBwdWJsaWM6ICAgCiAKIHByaXZhdGU6CiAgICAgLy8gRmlsdGVyIGNvZWZmaWNpZW50cwotICAg IGRvdWJsZSBtX2EwOwotICAgIGRvdWJsZSBtX2ExOwotICAgIGRvdWJsZSBtX2EyOworICAgIGRv dWJsZSBtX2IwOwogICAgIGRvdWJsZSBtX2IxOwogICAgIGRvdWJsZSBtX2IyOwotCi0gICAgZG91 YmxlIG1fZzsKKyAgICBkb3VibGUgbV9hMTsKKyAgICBkb3VibGUgbV9hMjsKIAogICAgIC8vIEZp bHRlciBtZW1vcnkKICAgICBkb3VibGUgbV94MTsgLy8gaW5wdXQgZGVsYXllZCBieSAxIHNhbXBs ZQo=