62042 2011-06-03 12:53:49 -0700 Fix IntRect::expand(const IntSize& size) 2011-06-04 00:02:55 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eae eae commit-queue eric kling leviw oldest_to_newest 415108 0 eae 2011-06-03 12:53:49 -0700 The IntSize version of IntRect::expand currently moves the rect instead of resizing it. This is clearly incorrect. It was introduced about a month ago in r86377 and is not used anywhere yet. 415109 1 95949 eae 2011-06-03 12:57:07 -0700 Created attachment 95949 Patch 415113 2 95949 kling 2011-06-03 13:05:47 -0700 Comment on attachment 95949 Patch o_O 415115 3 eae 2011-06-03 13:07:43 -0700 Thanks for the quick review Andreas! 415120 4 kling 2011-06-03 13:12:09 -0700 (In reply to comment #3) > Thanks for the quick review Andreas! No problem! Now go use the function so we don't have to remove it. :) 415121 5 eae 2011-06-03 13:14:08 -0700 > No problem! Now go use the function so we don't have to remove it. :) I have a couple of patches for that coming up :) 415418 6 95949 commit-queue 2011-06-04 00:02:51 -0700 Comment on attachment 95949 Patch Clearing flags on attachment: 95949 Committed r88096: <http://trac.webkit.org/changeset/88096> 415419 7 commit-queue 2011-06-04 00:02:55 -0700 All reviewed patches have been landed. Closing bug. 95949 2011-06-03 12:57:07 -0700 2011-06-04 00:02:50 -0700 Patch bug-62042-20110603125705.patch text/plain 1328 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4MDQwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDYtMDMgIEVtaWwgQSBF a2x1bmQgIDxlYWVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEZpeCBJbnRSZWN0OjpleHBhbmQoY29uc3QgSW50U2l6ZSYgc2l6 ZSkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyMDQy CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv SW50UmVjdC5oOgorICAgICAgICAoV2ViQ29yZTo6SW50UmVjdDo6ZXhwYW5kKToKKyAgICAgICAg Rml4IEludFJlY3Q6OmV4cGFuZCB0byBleHBhbmQgdGhlIHNpemUgcmF0aGVyIHRoYW4gbW92ZSB0 aGUgbG9jYXRpb24uCisgICAgICAgIEN1cnJlbnRseSB1bnVzZWQuCisKIDIwMTEtMDYtMDMgIFJv YiBCdWlzICA8cmJ1aXNAcmltLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBOaWtvbGFzIFpp bW1lcm1hbm4uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbnRSZWN0 LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW50UmVj dC5oCShyZXZpc2lvbiA4Nzg2NSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L0ludFJlY3QuaAkod29ya2luZyBjb3B5KQpAQCAtMTExLDcgKzExMSw3IEBAIHB1YmxpYzoKICAg ICB2b2lkIG1vdmUoY29uc3QgSW50UG9pbnQmIG9mZnNldCkgeyBtX2xvY2F0aW9uLm1vdmUob2Zm c2V0LngoKSwgb2Zmc2V0LnkoKSk7IH0KICAgICB2b2lkIG1vdmUoaW50IGR4LCBpbnQgZHkpIHsg bV9sb2NhdGlvbi5tb3ZlKGR4LCBkeSk7IH0gCiAKLSAgICB2b2lkIGV4cGFuZChjb25zdCBJbnRT aXplJiBzaXplKSB7IG1fbG9jYXRpb24gKz0gc2l6ZTsgfQorICAgIHZvaWQgZXhwYW5kKGNvbnN0 IEludFNpemUmIHNpemUpIHsgbV9zaXplICs9IHNpemU7IH0KICAgICB2b2lkIGV4cGFuZChpbnQg ZHcsIGludCBkaCkgeyBtX3NpemUuZXhwYW5kKGR3LCBkaCk7IH0KIAogICAgIHZvaWQgc2hpZnRY RWRnZVRvKGludCBlZGdlKQo=