62040 2011-06-03 12:36:56 -0700 Support FontCustomPlatformData on Skia-Mac-Chrome variant 2011-06-03 17:22:24 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 caryclark caryclark commit-queue eric oldest_to_newest 415099 0 caryclark 2011-06-03 12:36:56 -0700 Support FontCustomPlatformData on Skia-Mac-Chrome variant 415148 1 95959 caryclark 2011-06-03 13:55:14 -0700 Created attachment 95959 Patch 415202 2 95959 eric 2011-06-03 14:30:19 -0700 Comment on attachment 95959 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95959&action=review This approach seems reasonable. > Source/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp:60 > + // This is request for the length of the stream. > + return m_buffer->size(); What an awkward api! 415318 3 95959 commit-queue 2011-06-03 17:22:19 -0700 Comment on attachment 95959 Patch Clearing flags on attachment: 95959 Committed r88081: <http://trac.webkit.org/changeset/88081> 415319 4 commit-queue 2011-06-03 17:22:24 -0700 All reviewed patches have been landed. Closing bug. 95959 2011-06-03 13:55:14 -0700 2011-06-03 17:22:19 -0700 Patch bug-62040-20110603165511.patch text/plain 5381 caryclark SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4MDM5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsNDAgQEAKKzIwMTEtMDYtMDMgIENhcnkgQ2xh cmsgIDxjYXJ5Y2xhcmtAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBTdXBwb3J0IEZvbnRDdXN0b21QbGF0Zm9ybURhdGEgb24gU2tp YS1NYWMtQ2hyb21lIHZhcmlhbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTYyMDQwCisKKyAgICAgICAgQ2FudmFzIHRleHQgaXMgb25seSByZWNvZ25p emVkIGJ5IFNraWEgaWYgaXQgaXMgcmVnaXN0ZXJlZAorICAgICAgICBieSBjcmVhdGluZyBhIG5l dyBTa1R5cGVmYWNlLiBTa2lhIHVzZXMgQ0dGb250IHRvIG1lYXN1cmUKKyAgICAgICAgYW5kIHJl bmRlciB0aGUgZ2x5cGhzLCB0aGVuIHRha2VzIGNhcmUgb2YgbWFuYWdpbmcgdGhlIGdseXBoCisg ICAgICAgIGNhY2hlLgorCisgICAgICAgIFNraWEgb24gTWFjIENocm9tZSBpcyBub3QgeWV0IGVu YWJsZWQsIHNvIHRoaXMgY2hhbmdlCisgICAgICAgIGRvZXMgbm90IGFmZmVjdCBleGlzdGluZyBj b2RlLCBhbmQgcmVxdWlyZXMgbm8gbmV3IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvbWFjL0ZvbnRDdXN0b21QbGF0Zm9ybURhdGEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 UmVtb3RlRm9udFN0cmVhbTo6UmVtb3RlRm9udFN0cmVhbSk6CisgICAgICAgIChXZWJDb3JlOjpS ZW1vdGVGb250U3RyZWFtOjp+UmVtb3RlRm9udFN0cmVhbSk6CisgICAgICAgIChXZWJDb3JlOjpS ZW1vdGVGb250U3RyZWFtOjpyZXdpbmQpOgorICAgICAgICAoV2ViQ29yZTo6UmVtb3RlRm9udFN0 cmVhbTo6cmVhZCk6CisgICAgICAgIFR1cm4gdGhlIGJ1ZmZlciBpbnRvIGEgc3RyZWFtLiBUaGlz IGlzIGlkZW50aWNhbCB0bworICAgICAgICB0aGUgaW1wbGVtZW50YXRpb24gaW4gc2tpYS9Gb250 Q3VzdG9tUGxhdGZvcm1EYXRhLmNwcC4KKyAgICAgICAgV2hpbGUgdGhhdCBmaWxlIGNvdWxkIGJl IG1vZGlmaWVkIGluc3RlYWQgb2YgdGhpcyBvbmUsCisgICAgICAgIGl0IHdhcyBzaW1wbGVyIHRv IGFkZCBTa1R5cGVmYWNlIHN0cmVhbWluZyB0byB0aGlzIGluc3RlYWQKKyAgICAgICAgb2YgYWRk aW5nIGFsbCBDR0ZvbnQgc3VwcG9ydCB0byB0aGUgc2tpYSBwbGF0Zm9ybSBmaWxlLgorCisgICAg ICAgIChXZWJDb3JlOjpGb250Q3VzdG9tUGxhdGZvcm1EYXRhOjp+Rm9udEN1c3RvbVBsYXRmb3Jt RGF0YSk6CisgICAgICAgIFJlbGVhc2UgdGhlIFNrVHlwZWZhY2UgcmVmZXJlbmNlLgorCisgICAg ICAgIChXZWJDb3JlOjpjcmVhdGVGb250Q3VzdG9tUGxhdGZvcm1EYXRhKToKKyAgICAgICAgQXNz b2NpYXRlIHRoZSBidWZmZXIgc3RyZWFtIHdpdGggYSBTa1R5cGVmYWNlIHNvIFNraWEKKyAgICAg ICAgY2FuIGZpbmQgdGhlIGN1c3RvbSBmb250IGRhdGEuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9tYWMvRm9udEN1c3RvbVBsYXRmb3JtRGF0YS5oOgorICAgICAgICAoV2ViQ29yZTo6 Rm9udEN1c3RvbVBsYXRmb3JtRGF0YTo6Rm9udEN1c3RvbVBsYXRmb3JtRGF0YSk6CisgICAgICAg IEFkZCBhIHNsb3QgdG8gaG9sZCB0aGUgU2tUeXBlZmFjZS4KKwogMjAxMS0wNi0wMyAgUm9iIEJ1 aXMgIDxyYnVpc0ByaW0uY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5pa29sYXMgWmltbWVy bWFubi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9Gb250Q3Vz dG9tUGxhdGZvcm1EYXRhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9tYWMvRm9udEN1c3RvbVBsYXRmb3JtRGF0YS5jcHAJKHJldmlzaW9uIDg4MDM4 KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0ZvbnRDdXN0b21QbGF0 Zm9ybURhdGEuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNywxNCArMjcsNjQgQEAKICNpbmNsdWRl ICJXT0ZGRmlsZUZvcm1hdC5oIgogI2luY2x1ZGUgPEFwcGxpY2F0aW9uU2VydmljZXMvQXBwbGlj YXRpb25TZXJ2aWNlcy5oPgogCisjaWYgVVNFKFNLSUFfT05fTUFDX0NIUk9NRSkKKyNpbmNsdWRl ICJTa1N0cmVhbS5oIgorI2luY2x1ZGUgIlNrVHlwZWZhY2UuaCIKKyNlbmRpZgorCiBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAKKyNpZiBVU0UoU0tJQV9PTl9NQUNfQ0hST01FKQorY2xhc3MgUmVtb3Rl Rm9udFN0cmVhbSA6IHB1YmxpYyBTa1N0cmVhbSB7CitwdWJsaWM6CisgICAgZXhwbGljaXQgUmVt b3RlRm9udFN0cmVhbShQYXNzUmVmUHRyPFNoYXJlZEJ1ZmZlcj4gYnVmZmVyKQorICAgICAgICA6 IG1fYnVmZmVyKGJ1ZmZlcikKKyAgICAgICAgLCBtX29mZnNldCgwKQorICAgIHsKKyAgICB9CisK KyAgICB2aXJ0dWFsIH5SZW1vdGVGb250U3RyZWFtKCkKKyAgICB7CisgICAgfQorCisgICAgdmly dHVhbCBib29sIHJld2luZCgpCisgICAgeworICAgICAgICBtX29mZnNldCA9IDA7CisgICAgICAg IHJldHVybiB0cnVlOworICAgIH0KKworICAgIHZpcnR1YWwgc2l6ZV90IHJlYWQodm9pZCogYnVm ZmVyLCBzaXplX3Qgc2l6ZSkKKyAgICB7CisgICAgICAgIGlmICghYnVmZmVyICYmICFzaXplKSB7 CisgICAgICAgICAgICAvLyBUaGlzIGlzIHJlcXVlc3QgZm9yIHRoZSBsZW5ndGggb2YgdGhlIHN0 cmVhbS4KKyAgICAgICAgICAgIHJldHVybiBtX2J1ZmZlci0+c2l6ZSgpOworICAgICAgICB9Cisg ICAgICAgIC8vIFRoaXMgaXMgYSByZXF1ZXN0IHRvIHJlYWQgYnl0ZXMgb3Igc2tpcCBieXRlcyAo d2hlbiBidWZmZXIgaXMgMCkuCisgICAgICAgIGlmICghbV9idWZmZXItPmRhdGEoKSB8fCAhbV9i dWZmZXItPnNpemUoKSkKKyAgICAgICAgICAgIHJldHVybiAwOworICAgICAgICBzaXplX3QgbGVm dCA9IG1fYnVmZmVyLT5zaXplKCkgLSBtX29mZnNldDsKKyAgICAgICAgc2l6ZV90IGJ5dGVzVG9D b25zdW1lID0gc3RkOjptaW4obGVmdCwgc2l6ZSk7CisgICAgICAgIGlmIChidWZmZXIpCisgICAg ICAgICAgICBzdGQ6Om1lbWNweShidWZmZXIsIG1fYnVmZmVyLT5kYXRhKCkgKyBtX29mZnNldCwg Ynl0ZXNUb0NvbnN1bWUpOworICAgICAgICBtX29mZnNldCArPSBieXRlc1RvQ29uc3VtZTsKKyAg ICAgICAgcmV0dXJuIGJ5dGVzVG9Db25zdW1lOworICAgIH0KKworcHJpdmF0ZToKKyAgICBSZWZQ dHI8U2hhcmVkQnVmZmVyPiBtX2J1ZmZlcjsKKyAgICBzaXplX3QgbV9vZmZzZXQ7Cit9OworI2Vu ZGlmCisKIEZvbnRDdXN0b21QbGF0Zm9ybURhdGE6On5Gb250Q3VzdG9tUGxhdGZvcm1EYXRhKCkK IHsKICNpZmRlZiBCVUlMRElOR19PTl9MRU9QQVJECiAgICAgaWYgKG1fYXRzQ29udGFpbmVyKQog ICAgICAgICBBVFNGb250RGVhY3RpdmF0ZShtX2F0c0NvbnRhaW5lciwgTlVMTCwga0FUU09wdGlv bkZsYWdzRGVmYXVsdCk7CiAjZW5kaWYKKyNpZiBVU0UoU0tJQV9PTl9NQUNfQ0hST01FKQorICAg IFNrU2FmZVVucmVmKG1fdHlwZWZhY2UpOworI2VuZGlmCiAgICAgQ0dGb250UmVsZWFzZShtX2Nn Rm9udCk7CiB9CiAKQEAgLTEwOSw3ICsxNTksMTIgQEAgRm9udEN1c3RvbVBsYXRmb3JtRGF0YSog Y3JlYXRlRm9udEN1c3RvbQogICAgIH0KICNlbmRpZiAvLyAhZGVmaW5lZChCVUlMRElOR19PTl9M RU9QQVJEKQogCi0gICAgcmV0dXJuIG5ldyBGb250Q3VzdG9tUGxhdGZvcm1EYXRhKGNvbnRhaW5l clJlZiwgY2dGb250UmVmLnJlbGVhc2VSZWYoKSk7CisgICAgRm9udEN1c3RvbVBsYXRmb3JtRGF0 YSogZm9udEN1c3RvbVBsYXRmb3JtRGF0YSA9IG5ldyBGb250Q3VzdG9tUGxhdGZvcm1EYXRhKGNv bnRhaW5lclJlZiwgY2dGb250UmVmLnJlbGVhc2VSZWYoKSk7CisjaWYgVVNFKFNLSUFfT05fTUFD X0NIUk9NRSkKKyAgICBSZW1vdGVGb250U3RyZWFtKiBzdHJlYW0gPSBuZXcgUmVtb3RlRm9udFN0 cmVhbShidWZmZXIpOworICAgIGZvbnRDdXN0b21QbGF0Zm9ybURhdGEtPm1fdHlwZWZhY2UgPSBT a1R5cGVmYWNlOjpDcmVhdGVGcm9tU3RyZWFtKHN0cmVhbSk7CisjZW5kaWYKKyAgICByZXR1cm4g Zm9udEN1c3RvbVBsYXRmb3JtRGF0YTsKIH0KIAogYm9vbCBGb250Q3VzdG9tUGxhdGZvcm1EYXRh OjpzdXBwb3J0c0Zvcm1hdChjb25zdCBTdHJpbmcmIGZvcm1hdCkKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9Gb250Q3VzdG9tUGxhdGZvcm1EYXRhLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0ZvbnRDdXN0b21Q bGF0Zm9ybURhdGEuaAkocmV2aXNpb24gODgwMzgpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9tYWMvRm9udEN1c3RvbVBsYXRmb3JtRGF0YS5oCSh3b3JraW5nIGNvcHkpCkBA IC0zMyw2ICszMywxMCBAQCB0eXBlZGVmIHN0cnVjdCBDR0ZvbnQqIENHRm9udFJlZjsKIHR5cGVk ZWYgVUludDMyIEFUU0ZvbnRDb250YWluZXJSZWY7CiB0eXBlZGVmIFVJbnQzMiBBVFNGb250UmVm OwogCisjaWYgVVNFKFNLSUFfT05fTUFDX0NIUk9NRSkKK3N0cnVjdCBTa1R5cGVmYWNlOworI2Vu ZGlmCisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgRm9udFBsYXRmb3JtRGF0YTsKQEAg LTQ0LDYgKzQ4LDkgQEAgcHVibGljOgogICAgIEZvbnRDdXN0b21QbGF0Zm9ybURhdGEoQVRTRm9u dENvbnRhaW5lclJlZiBjb250YWluZXIsIENHRm9udFJlZiBjZ0ZvbnQpCiAgICAgICAgIDogbV9h dHNDb250YWluZXIoY29udGFpbmVyKQogICAgICAgICAsIG1fY2dGb250KGNnRm9udCkKKyNpZiBV U0UoU0tJQV9PTl9NQUNfQ0hST01FKQorICAgICAgICAsIG1fdHlwZWZhY2UoMCkKKyNlbmRpZgog ICAgIHsKICAgICB9CiAKQEAgLTU1LDYgKzYyLDkgQEAgcHVibGljOgogCiAgICAgQVRTRm9udENv bnRhaW5lclJlZiBtX2F0c0NvbnRhaW5lcjsKICAgICBDR0ZvbnRSZWYgbV9jZ0ZvbnQ7CisjaWYg VVNFKFNLSUFfT05fTUFDX0NIUk9NRSkKKyAgICBTa1R5cGVmYWNlKiBtX3R5cGVmYWNlOworI2Vu ZGlmCiB9OwogCiBGb250Q3VzdG9tUGxhdGZvcm1EYXRhKiBjcmVhdGVGb250Q3VzdG9tUGxhdGZv cm1EYXRhKFNoYXJlZEJ1ZmZlciopOwo=