62029 2011-06-03 10:03:38 -0700 Cleanup member variable usage in svg/animation classes 2011-06-03 12:37:34 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rwlbuis rwlbuis zimmermann oldest_to_newest 414974 0 rwlbuis 2011-06-03 10:03:38 -0700 There is one case where member var reordering decreases the class instance size, and another one where member vars can be removed since the state does not need to be stored, it is just used once. 414978 1 95925 rwlbuis 2011-06-03 10:07:13 -0700 Created attachment 95925 Patch 415086 2 95925 zimmermann 2011-06-03 12:25:07 -0700 Comment on attachment 95925 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95925&action=review r=me with a comment: > Source/WebCore/svg/animation/SMILTimeContainer.cpp:222 > +void SMILTimeContainer::updateAnimations(SMILTime elapsed, double nextManualSampleTime, String nextSamplingTarget) Use const String&. > Source/WebCore/svg/animation/SMILTimeContainer.h:73 > + void updateAnimations(SMILTime elapsed, double nextManualSampleTime = 0, String nextSamplingTarget = String()); Do we need the default params? If yes, you can't switch const String&... 415100 3 rwlbuis 2011-06-03 12:37:34 -0700 Committed r88039: <http://trac.webkit.org/changeset/88039> 95925 2011-06-03 10:07:13 -0700 2011-06-03 12:25:07 -0700 Patch bug-62029-20110603130705.patch text/plain 5597 rwlbuis SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4MDIxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDYtMDMgIFJvYiBCdWlz ICA8cmJ1aXNAcmltLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBDbGVhbnVwIG1lbWJlciB2YXJpYWJsZSB1c2FnZSBpbiBzdmcvYW5pbWF0aW9u IGNsYXNzZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTYyMDI5CisKKyAgICAgICAgQ2xlYW51cCBtZW1iZXIgdmFyaWFibGVzLgorCisgICAgICAgICog c3ZnL2FuaW1hdGlvbi9TTUlMVGltZUNvbnRhaW5lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpT TUlMVGltZUNvbnRhaW5lcjo6U01JTFRpbWVDb250YWluZXIpOgorICAgICAgICAoV2ViQ29yZTo6 U01JTFRpbWVDb250YWluZXI6OnNhbXBsZUFuaW1hdGlvbkF0VGltZSk6CisgICAgICAgIChXZWJD b3JlOjpTTUlMVGltZUNvbnRhaW5lcjo6dXBkYXRlQW5pbWF0aW9ucyk6CisgICAgICAgICogc3Zn L2FuaW1hdGlvbi9TTUlMVGltZUNvbnRhaW5lci5oOgorICAgICAgICAqIHN2Zy9hbmltYXRpb24v U1ZHU01JTEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZHU01JTEVsZW1lbnQ6OlNW R1NNSUxFbGVtZW50KToKKyAgICAgICAgKiBzdmcvYW5pbWF0aW9uL1NWR1NNSUxFbGVtZW50Lmg6 CisKIDIwMTEtMDYtMDMgIE5hb2tpIFRha2FubyAgPHRha2Fuby5uYW9raUBnbWFpbC5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9z dmcvYW5pbWF0aW9uL1NNSUxUaW1lQ29udGFpbmVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9zdmcvYW5pbWF0aW9uL1NNSUxUaW1lQ29udGFpbmVyLmNwcAkocmV2aXNpb24gODgw MTkpCisrKyBTb3VyY2UvV2ViQ29yZS9zdmcvYW5pbWF0aW9uL1NNSUxUaW1lQ29udGFpbmVyLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNDYsNyArNDYsNiBAQCBTTUlMVGltZUNvbnRhaW5lcjo6U01J TFRpbWVDb250YWluZXIoU1ZHCiAgICAgOiBtX2JlZ2luVGltZSgwKQogICAgICwgbV9wYXVzZVRp bWUoMCkKICAgICAsIG1fYWNjdW11bGF0ZWRQYXVzZVRpbWUoMCkKLSAgICAsIG1fbmV4dE1hbnVh bFNhbXBsZVRpbWUoMCkKICAgICAsIG1fZG9jdW1lbnRPcmRlckluZGV4ZXNEaXJ0eShmYWxzZSkK ICAgICAsIG1fdGltZXIodGhpcywgJlNNSUxUaW1lQ29udGFpbmVyOjp0aW1lckZpcmVkKQogICAg ICwgbV9vd25lclNWR0VsZW1lbnQob3duZXIpCkBAIC0yMTYsMjAgKzIxNSwxOCBAQCB2b2lkIFNN SUxUaW1lQ29udGFpbmVyOjpzYW1wbGVBbmltYXRpb25BCiAKICAgICAvLyBGYXN0LWZvcndhcmQg dG8gdGhlIHRpbWUgRFJUIHdhbnRzIHRvIHNhbXBsZQogICAgIG1fdGltZXIuc3RvcCgpOwotICAg IG1fbmV4dFNhbXBsaW5nVGFyZ2V0ID0gZWxlbWVudElkOwotICAgIG1fbmV4dE1hbnVhbFNhbXBs ZVRpbWUgPSBuZXdUaW1lOwogCi0gICAgdXBkYXRlQW5pbWF0aW9ucyhlbGFwc2VkKCkpOworICAg IHVwZGF0ZUFuaW1hdGlvbnMoZWxhcHNlZCgpLCBuZXdUaW1lLCBlbGVtZW50SWQpOwogfQogCi12 b2lkIFNNSUxUaW1lQ29udGFpbmVyOjp1cGRhdGVBbmltYXRpb25zKFNNSUxUaW1lIGVsYXBzZWQp Cit2b2lkIFNNSUxUaW1lQ29udGFpbmVyOjp1cGRhdGVBbmltYXRpb25zKFNNSUxUaW1lIGVsYXBz ZWQsIGRvdWJsZSBuZXh0TWFudWFsU2FtcGxlVGltZSwgU3RyaW5nIG5leHRTYW1wbGluZ1Rhcmdl dCkKIHsKICAgICBTTUlMVGltZSBlYXJsaWVyc0ZpcmVUaW1lID0gU01JTFRpbWU6OnVucmVzb2x2 ZWQoKTsKIAogICAgIFZlY3RvcjxTVkdTTUlMRWxlbWVudCo+IHRvQW5pbWF0ZTsKICAgICBjb3B5 VG9WZWN0b3IobV9zY2hlZHVsZWRBbmltYXRpb25zLCB0b0FuaW1hdGUpOwogCi0gICAgaWYgKG1f bmV4dE1hbnVhbFNhbXBsZVRpbWUpIHsKKyAgICBpZiAobmV4dE1hbnVhbFNhbXBsZVRpbWUpIHsK ICAgICAgICAgU01JTFRpbWUgc2FtcGxpbmdEaWZmOwogICAgICAgICBmb3IgKHVuc2lnbmVkIG4g PSAwOyBuIDwgdG9BbmltYXRlLnNpemUoKTsgKytuKSB7CiAgICAgICAgICAgICBTVkdTTUlMRWxl bWVudCogYW5pbWF0aW9uID0gdG9BbmltYXRlW25dOwpAQCAtMjM3LDE1ICsyMzQsMTQgQEAgdm9p ZCBTTUlMVGltZUNvbnRhaW5lcjo6dXBkYXRlQW5pbWF0aW9ucwogCiAgICAgICAgICAgICBTVkdF bGVtZW50KiB0YXJnZXRFbGVtZW50ID0gYW5pbWF0aW9uLT50YXJnZXRFbGVtZW50KCk7CiAgICAg ICAgICAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQgcHJvYmFibHkgYmUgdXNpbmcgZ2V0SWRBdHRy aWJ1dGUgaW5zdGVhZCBvZiBpZEZvclN0eWxlUmVzb2x1dGlvbi4KLSAgICAgICAgICAgIGlmICgh dGFyZ2V0RWxlbWVudCB8fCAhdGFyZ2V0RWxlbWVudC0+aGFzSUQoKSB8fCB0YXJnZXRFbGVtZW50 LT5pZEZvclN0eWxlUmVzb2x1dGlvbigpICE9IG1fbmV4dFNhbXBsaW5nVGFyZ2V0KQorICAgICAg ICAgICAgaWYgKCF0YXJnZXRFbGVtZW50IHx8ICF0YXJnZXRFbGVtZW50LT5oYXNJRCgpIHx8IHRh cmdldEVsZW1lbnQtPmlkRm9yU3R5bGVSZXNvbHV0aW9uKCkgIT0gbmV4dFNhbXBsaW5nVGFyZ2V0 KQogICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogCiAgICAgICAgICAgICBzYW1wbGluZ0RpZmYg PSBhbmltYXRpb24tPmludGVydmFsQmVnaW4oKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAg ICB9CiAKLSAgICAgICAgZWxhcHNlZCA9IFNNSUxUaW1lKG1fbmV4dE1hbnVhbFNhbXBsZVRpbWUp ICsgc2FtcGxpbmdEaWZmOwotICAgICAgICBtX25leHRNYW51YWxTYW1wbGVUaW1lID0gMDsKKyAg ICAgICAgZWxhcHNlZCA9IFNNSUxUaW1lKG5leHRNYW51YWxTYW1wbGVUaW1lKSArIHNhbXBsaW5n RGlmZjsKICAgICB9CiAKICAgICAvLyBTb3J0IGFjY29yZGluZyB0byBwcmlvcml0eS4gRWxlbWVu dHMgd2l0aCBsYXRlciBiZWdpbiB0aW1lIGhhdmUgaGlnaGVyIHByaW9yaXR5LgpJbmRleDogU291 cmNlL1dlYkNvcmUvc3ZnL2FuaW1hdGlvbi9TTUlMVGltZUNvbnRhaW5lci5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3N2Zy9hbmltYXRpb24vU01JTFRpbWVDb250YWluZXIuaAkocmV2 aXNpb24gODgwMTkpCisrKyBTb3VyY2UvV2ViQ29yZS9zdmcvYW5pbWF0aW9uL1NNSUxUaW1lQ29u dGFpbmVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTcwLDcgKzcwLDcgQEAgcHJpdmF0ZToKICAgICAK ICAgICB2b2lkIHRpbWVyRmlyZWQoVGltZXI8U01JTFRpbWVDb250YWluZXI+Kik7CiAgICAgdm9p ZCBzdGFydFRpbWVyKFNNSUxUaW1lIGZpcmVUaW1lLCBTTUlMVGltZSBtaW5pbXVtRGVsYXkgPSAw KTsKLSAgICB2b2lkIHVwZGF0ZUFuaW1hdGlvbnMoU01JTFRpbWUgZWxhcHNlZCk7CisgICAgdm9p ZCB1cGRhdGVBbmltYXRpb25zKFNNSUxUaW1lIGVsYXBzZWQsIGRvdWJsZSBuZXh0TWFudWFsU2Ft cGxlVGltZSA9IDAsIFN0cmluZyBuZXh0U2FtcGxpbmdUYXJnZXQgPSBTdHJpbmcoKSk7CiAgICAg CiAgICAgdm9pZCB1cGRhdGVEb2N1bWVudE9yZGVySW5kZXhlcygpOwogICAgIHZvaWQgc29ydEJ5 UHJpb3JpdHkoVmVjdG9yPFNWR1NNSUxFbGVtZW50Kj4mIHNtaWxFbGVtZW50cywgU01JTFRpbWUg ZWxhcHNlZCk7CkBAIC04MSw4ICs4MSw2IEBAIHByaXZhdGU6CiAgICAgZG91YmxlIG1fYmVnaW5U aW1lOwogICAgIGRvdWJsZSBtX3BhdXNlVGltZTsKICAgICBkb3VibGUgbV9hY2N1bXVsYXRlZFBh dXNlVGltZTsKLSAgICBkb3VibGUgbV9uZXh0TWFudWFsU2FtcGxlVGltZTsKLSAgICBTdHJpbmcg bV9uZXh0U2FtcGxpbmdUYXJnZXQ7CiAKICAgICBib29sIG1fZG9jdW1lbnRPcmRlckluZGV4ZXNE aXJ0eTsKICAgICAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVs ZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3N2Zy9hbmltYXRpb24vU1ZH U01JTEVsZW1lbnQuY3BwCShyZXZpc2lvbiA4ODAxOSkKKysrIFNvdXJjZS9XZWJDb3JlL3N2Zy9h bmltYXRpb24vU1ZHU01JTEVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTksMTAgKzEx OSwxMCBAQCBTVkdTTUlMRWxlbWVudDo6U1ZHU01JTEVsZW1lbnQoY29uc3QgUXVhCiAgICAgLCBt X3RhcmdldEVsZW1lbnQoMCkKICAgICAsIG1fY29uZGl0aW9uc0Nvbm5lY3RlZChmYWxzZSkKICAg ICAsIG1faGFzRW5kRXZlbnRDb25kaXRpb25zKGZhbHNlKQorICAgICwgbV9pc1dhaXRpbmdGb3JG aXJzdEludGVydmFsKHRydWUpCiAgICAgLCBtX2ludGVydmFsQmVnaW4oU01JTFRpbWU6OnVucmVz b2x2ZWQoKSkKICAgICAsIG1faW50ZXJ2YWxFbmQoU01JTFRpbWU6OnVucmVzb2x2ZWQoKSkKICAg ICAsIG1fcHJldmlvdXNJbnRlcnZhbEJlZ2luKFNNSUxUaW1lOjp1bnJlc29sdmVkKCkpCi0gICAg LCBtX2lzV2FpdGluZ0ZvckZpcnN0SW50ZXJ2YWwodHJ1ZSkKICAgICAsIG1fYWN0aXZlU3RhdGUo SW5hY3RpdmUpCiAgICAgLCBtX2xhc3RQZXJjZW50KDApCiAgICAgLCBtX2xhc3RSZXBlYXQoMCkK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9zdmcvYW5pbWF0aW9uL1NWR1NNSUxFbGVtZW50LmgJ KHJldmlzaW9uIDg4MDE5KQorKysgU291cmNlL1dlYkNvcmUvc3ZnL2FuaW1hdGlvbi9TVkdTTUlM RWxlbWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xOTEsNiArMTkxLDggQEAgcHJpdmF0ZToKICAg ICBib29sIG1fY29uZGl0aW9uc0Nvbm5lY3RlZDsKICAgICBib29sIG1faGFzRW5kRXZlbnRDb25k aXRpb25zOyAgICAgCiAKKyAgICBib29sIG1faXNXYWl0aW5nRm9yRmlyc3RJbnRlcnZhbDsKKwog ICAgIHR5cGVkZWYgSGFzaFNldDxTVkdTTUlMRWxlbWVudCo+IFRpbWVEZXBlbmRlbnRTZXQ7CiAg ICAgVGltZURlcGVuZGVudFNldCBtX3RpbWVEZXBlbmRlbnRzOwogCkBAIC0yMDQsOCArMjA2LDYg QEAgcHJpdmF0ZToKIAogICAgIFNNSUxUaW1lIG1fcHJldmlvdXNJbnRlcnZhbEJlZ2luOwogCi0g ICAgYm9vbCBtX2lzV2FpdGluZ0ZvckZpcnN0SW50ZXJ2YWw7Ci0KICAgICBBY3RpdmVTdGF0ZSBt X2FjdGl2ZVN0YXRlOwogICAgIGZsb2F0IG1fbGFzdFBlcmNlbnQ7CiAgICAgdW5zaWduZWQgbV9s YXN0UmVwZWF0Owo=