61998 2011-06-03 01:01:01 -0700 [EFL] Implement startDownload() in FrameLoaderClientEfl 2011-06-06 18:03:47 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 62017 1 gyuyoung.kim gyuyoung.kim commit-queue kenneth lucas.de.marchi tonikitoo webkit.review.bot oldest_to_newest 414707 0 gyuyoung.kim 2011-06-03 01:01:01 -0700 Implement startDownload(). I think startDownload() operation is same with download(). 414710 1 95869 gyuyoung.kim 2011-06-03 01:03:37 -0700 Created attachment 95869 Patch 414860 2 95869 commit-queue 2011-06-03 07:17:57 -0700 Comment on attachment 95869 Patch Clearing flags on attachment: 95869 Committed r88014: <http://trac.webkit.org/changeset/88014> 414861 3 commit-queue 2011-06-03 07:18:02 -0700 All reviewed patches have been landed. Closing bug. 414894 4 tonikitoo 2011-06-03 07:48:14 -0700 Scanning dependencies of target ewebkit [100%] Building CXX object WebKit/CMakeFiles/ewebkit.dir/efl/WebCoreSupport/FrameLoaderClientEfl.cpp.o /mnt/buildbot/efl-linux-slave-1/efl-linux-release/build/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp: In member function ‘virtual void WebCore::FrameLoaderClientEfl::startDownload(const WebCore::ResourceRequest&)’: /mnt/buildbot/efl-linux-slave-1/efl-linux-release/build/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:875: error: ‘const class WebCore::KURL’ has no member named ‘prettyURL’ make[2]: *** [WebKit/CMakeFiles/ewebkit.dir/efl/WebCoreSupport/FrameLoaderClientEfl.cpp.o] Error 1 make[1]: *** [WebKit/CMakeFiles/ewebkit.dir/all] Error 2 414926 5 tonikitoo 2011-06-03 08:50:36 -0700 Rolled out. Please re-push a patch that builds. 416162 6 96162 gyuyoung.kim 2011-06-06 17:29:47 -0700 Created attachment 96162 Patch 416183 7 96162 gyuyoung.kim 2011-06-06 17:54:49 -0700 Comment on attachment 96162 Patch Hmm, strange build error. There is no build problem in my local box. If this patch make build break again, I'm going to roll out again. 416188 8 96162 webkit.review.bot 2011-06-06 18:03:40 -0700 Comment on attachment 96162 Patch Clearing flags on attachment: 96162 Committed r88207: <http://trac.webkit.org/changeset/88207> 416189 9 webkit.review.bot 2011-06-06 18:03:47 -0700 All reviewed patches have been landed. Closing bug. 95869 2011-06-03 01:03:37 -0700 2011-06-06 17:29:47 -0700 Patch patch-startdownload.patch text/plain 1506 gyuyoung.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA0ZDQ4ODMyLi40MDc4ZWI2IDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMDMgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbRUZMXSBJbXBsZW1lbnQgc3RhcnREb3dubG9hZCgpIGluIEZyYW1lTG9hZGVyQ2xpZW50 RWZsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTk5 OAorCisgICAgICAgIEltcGxlbWVudCBzdGFydERvd25sb2FkKCkgd2l0aCBkb3dubG9hZCgpLgor CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRFZmwuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXJDbGllbnRFZmw6OnN0YXJ0RG93bmxvYWQpOgorCiAy MDExLTA1LTE2ICBKb24gTGVlICA8am9ubGVlQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBTaW1vbiBGcmFzZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3Jl U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEVmbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJD b3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEVmbC5jcHAKaW5kZXggMjY3ZWViNC4uZjU5MDIx MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2Fk ZXJDbGllbnRFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0Zy YW1lTG9hZGVyQ2xpZW50RWZsLmNwcApAQCAtODY1LDkgKzg2NSwxNiBAQCB2b2lkIEZyYW1lTG9h ZGVyQ2xpZW50RWZsOjpzZXRNYWluRG9jdW1lbnRFcnJvcihEb2N1bWVudExvYWRlciogbG9hZGVy LCBjb25zdCBSZQogICAgIG1faGFzU2VudFJlc3BvbnNlVG9QbHVnaW4gPSBmYWxzZTsKIH0KIAot dm9pZCBGcmFtZUxvYWRlckNsaWVudEVmbDo6c3RhcnREb3dubG9hZChjb25zdCBSZXNvdXJjZVJl cXVlc3QmKQordm9pZCBGcmFtZUxvYWRlckNsaWVudEVmbDo6c3RhcnREb3dubG9hZChjb25zdCBS ZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QpCiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICBp ZiAoIW1fdmlldykKKyAgICAgICAgcmV0dXJuOworCisgICAgQ1N0cmluZyB1cmwgPSByZXF1ZXN0 LnVybCgpLnByZXR0eVVSTCgpLnV0ZjgoKTsKKyAgICBFd2tfRG93bmxvYWQgZG93bmxvYWQ7CisK KyAgICBkb3dubG9hZC51cmwgPSB1cmwuZGF0YSgpOworICAgIGV3a192aWV3X2Rvd25sb2FkX3Jl cXVlc3QobV92aWV3LCAmZG93bmxvYWQpOwogfQogCiB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50RWZs Ojp1cGRhdGVHbG9iYWxIaXN0b3J5KCkK 96162 2011-06-06 17:29:47 -0700 2011-06-06 18:03:40 -0700 Patch patch-startdownload.patch text/plain 1505 gyuyoung.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA0ZDQ4ODMyLi40YjYwMjRkIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMDMgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBBbnRvbmlvIEdvbWVzLgorCisgICAg ICAgIFtFRkxdIEltcGxlbWVudCBzdGFydERvd25sb2FkKCkgaW4gRnJhbWVMb2FkZXJDbGllbnRF ZmwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxOTk4 CisKKyAgICAgICAgSW1wbGVtZW50IHN0YXJ0RG93bmxvYWQoKSB3aXRoIGRvd25sb2FkKCkuCisK KyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEVmbC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudEVmbDo6c3RhcnREb3dubG9hZCk6CisKIDIw MTEtMDUtMTYgIEpvbiBMZWUgIDxqb25sZWVAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IFNpbW9uIEZyYXNlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVT dXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50RWZsLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNv cmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50RWZsLmNwcAppbmRleCAyNjdlZWI0Li5mNTkwMjEy IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRl ckNsaWVudEVmbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvRnJh bWVMb2FkZXJDbGllbnRFZmwuY3BwCkBAIC04NjUsOSArODY1LDE2IEBAIHZvaWQgRnJhbWVMb2Fk ZXJDbGllbnRFZmw6OnNldE1haW5Eb2N1bWVudEVycm9yKERvY3VtZW50TG9hZGVyKiBsb2FkZXIs IGNvbnN0IFJlCiAgICAgbV9oYXNTZW50UmVzcG9uc2VUb1BsdWdpbiA9IGZhbHNlOwogfQogCi12 b2lkIEZyYW1lTG9hZGVyQ2xpZW50RWZsOjpzdGFydERvd25sb2FkKGNvbnN0IFJlc291cmNlUmVx dWVzdCYpCit2b2lkIEZyYW1lTG9hZGVyQ2xpZW50RWZsOjpzdGFydERvd25sb2FkKGNvbnN0IFJl c291cmNlUmVxdWVzdCYgcmVxdWVzdCkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIGlm ICghbV92aWV3KQorICAgICAgICByZXR1cm47CisKKyAgICBDU3RyaW5nIHVybCA9IHJlcXVlc3Qu dXJsKCkucHJldHR5VVJMKCkudXRmOCgpOworICAgIEV3a19Eb3dubG9hZCBkb3dubG9hZDsKKwor ICAgIGRvd25sb2FkLnVybCA9IHVybC5kYXRhKCk7CisgICAgZXdrX3ZpZXdfZG93bmxvYWRfcmVx dWVzdChtX3ZpZXcsICZkb3dubG9hZCk7CiB9CiAKIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRFZmw6 OnVwZGF0ZUdsb2JhbEhpc3RvcnkoKQo=