61992 2011-06-02 21:52:49 -0700 Show a shadow root node itself in Node::showTreeForThisAcrossFrame 2011-06-19 22:19:15 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 hayato hayato rniwa webkit.review.bot oldest_to_newest 414648 0 hayato 2011-06-02 21:52:49 -0700 It's better to show a shadow root node itself for debugging. Skipping it didn't add any values. 414650 1 95852 hayato 2011-06-02 21:54:54 -0700 Created attachment 95852 show shadow root itself 423213 2 95852 webkit.review.bot 2011-06-18 13:19:19 -0700 Comment on attachment 95852 show shadow root itself Rejecting attachment 95852 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2 Last 500 characters of output: mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Ryosuke Niwa', u'--for..." exit_code: 1 Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/dom/Node.cpp Hunk #1 FAILED at 2364. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/dom/Node.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Ryosuke Niwa', u'--for..." exit_code: 1 Full output: http://queues.webkit.org/results/8878941 423475 3 hayato 2011-06-19 22:19:15 -0700 I forgot to commit this patch, and the following patch was a superset of this patch. http://trac.webkit.org/changeset/89021 So we don't need to do any action about this patch. 95852 2011-06-02 21:54:54 -0700 2011-06-19 22:23:59 -0700 show shadow root itself bug-61992-20110603135452.patch text/plain 1505 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogODc5NzkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4MjcwOWY2OTE0MWJkYmJl MzIyMTY0ZTYzNDA0YTU5OWE2ZWM2ZmI0Li5iMmJiOGQxMmM0MWM5NjBmMTUwNGNiNDJhYjZkNmI1 MTI4NjcwYmMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDYtMDIgIEhheWF0 byBJdG8gIDxoYXlhdG9AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFNob3cgYSBzaGFkb3cgcm9vdCBub2RlIGl0c2VsZiBpbiBO b2RlOjp0cmF2ZXJzZU5leHROb2RlQWNyb3NzRnJhbWUuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTk5MgorCisgICAgICAgIEl0J3MgYmV0dGVyIHRv IHNob3cgYSBzaGFkb3cgcm9vdCBub2RlIGl0c2VsZiBmb3IgZGVidWdnaW5nLgorICAgICAgICBT a2lwcGluZyBpdCBkaWRuJ3QgYWRkIGFueSB2YWx1ZXMuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz IHNpbmNlIHRoZSBmdW5jdGlvbiBpcyBvbmx5IGF2YWlsYWJsZSBpbiBkZWJ1ZyBidWlsZHMuCisK KyAgICAgICAgKiBkb20vTm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0cmF2ZXJzZU5leHRO b2RlQWNyb3NzRnJhbWUpOgorCiAyMDExLTA1LTI4ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5z b25AaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHdXN0YXZvIE5vcm9uaGEgU2ls dmEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vTm9kZS5jcHAKaW5kZXggYzQzYzFmYjFkMDgwNDJlMzZlMmY4NzhiZTRhZTc1ODhj NTdiYzFjMS4uNDA0OWQ4M2NlMWYyMmMwYzU2NjlkNWRmMjc3ZGI4ZGVjYjkzNWM4YiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Rv bS9Ob2RlLmNwcApAQCAtMjM2NCw3ICsyMzY0LDcgQEAgc3RhdGljIE5vZGUqIHRyYXZlcnNlTmV4 dE5vZGVBY3Jvc3NGcmFtZShOb2RlKiBub2RlKQogICAgIGlmIChub2RlLT5pc0ZyYW1lT3duZXJF bGVtZW50KCkpCiAgICAgICAgIHJldHVybiBzdGF0aWNfY2FzdDxIVE1MRnJhbWVPd25lckVsZW1l bnQqPihub2RlKS0+Y29udGVudERvY3VtZW50KCk7CiAgICAgaWYgKFNoYWRvd1Jvb3QqIHNoYWRv dyA9IHNoYWRvd1Jvb3Qobm9kZSkpCi0gICAgICAgIHJldHVybiB0cmF2ZXJzZU5leHROb2RlQWNy b3NzRnJhbWUoc2hhZG93KTsKKyAgICAgICAgcmV0dXJuIHNoYWRvdzsKICAgICBpZiAobm9kZS0+ Zmlyc3RDaGlsZCgpKQogICAgICAgICByZXR1cm4gbm9kZS0+Zmlyc3RDaGlsZCgpOwogICAgIGlm IChub2RlLT5uZXh0U2libGluZygpKQo=