61991 2011-06-02 20:59:55 -0700 Assertion fails in TextCheckingHelper by right-clicking on <input type=search> 2011-06-06 18:44:45 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All RESOLVED FIXED data:text/html,<input type=search> P2 Normal --- 1 tkent morrita morrita rniwa oldest_to_newest 414640 0 tkent 2011-06-02 20:59:55 -0700 1. Open data:text/html,<input type=search> 2. Right-click on a place where a cancel button should be on. Result: ARGUMENT BAD: m_range, m_range /Volumes/d2/WebKit/Source/WebCore/editing/TextCheckingHelper.cpp(160) : WebCore::TextCheckingHelper::TextCheckingHelper(WebCore::EditorClient*, WTF::PassRefPtr<WebCore::Range>) 1 WebCore::TextCheckingHelper::TextCheckingHelper(WebCore::EditorClient*, WTF::PassRefPtr<WebCore::Range>) 2 WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection(bool&, bool&) 3 WebCore::ContextMenuController::populate() 4 WebCore::ContextMenuController::handleContextMenuEvent(WebCore::Event*) 5 WebCore::Node::defaultEventHandler(WebCore::Event*) 6 WebCore::SearchFieldCancelButtonElement::defaultEventHandler(WebCore::Event*) 7 WebCore::EventDispatcher::dispatchEvent(WTF::PassRefPtr<WebCore::Event>) 8 WebCore::MouseEventDispatchMediator::dispatchEvent(WebCore::EventDispatcher*) const 9 WebCore::EventDispatcher::dispatchEvent(WebCore::Node*, WebCore::EventDispatchMediator const&) 10 WebCore::Node::dispatchMouseEvent(WebCore::PlatformMouseEvent const&, WTF::AtomicString const&, int, WebCore::Node*) 11 WebCore::EventHandler::dispatchMouseEvent(WTF::AtomicString const&, WebCore::Node*, bool, int, WebCore::PlatformMouseEvent const&, bool) 12 WebCore::EventHandler::sendContextMenuEvent(WebCore::PlatformMouseEvent const&) 13 -[WebHTMLView menuForEvent:] 14 -[NSView rightMouseDown:] Note: If the search field has a on-empty value and the cancel button is visible, this doesn't happen. 415763 1 96073 morrita 2011-06-06 03:28:37 -0700 Created attachment 96073 Patch 415766 2 96073 tkent 2011-06-06 03:36:24 -0700 Comment on attachment 96073 Patch Looks ok 416205 3 morrita 2011-06-06 18:44:45 -0700 Committed r88211: <http://trac.webkit.org/changeset/88211> 96073 2011-06-06 03:28:37 -0700 2011-06-06 03:36:24 -0700 Patch bug-61991-20110606192836.patch text/plain 5730 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogODgxMzcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA0ZTNhYWM1ODI5MzA4N2M1OWE1OGMx YWU3YzRjNzYxZDgxNTBiYjcwLi4zOWEzMWFmMzc2YWE2ZGUwZThjOTIxYTQwOTFlZmIxZTk0ZDVk NjBiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDYtMDYgIE1PUklUQSBIYWppbWUgIDxt b3JyaXRhQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQXNzZXJ0aW9uIGZhaWxzIGluIFRleHRDaGVja2luZ0hlbHBlciBieSByaWdo dC1jbGlja2luZyBvbiA8aW5wdXQgdHlwZT1zZWFyY2g+CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTk5MQorCisgICAgICAgICogZWRpdGluZy9zcGVs bGluZy9zcGVsbGNoZWNrLWlucHV0LXNlYXJjaC1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgor ICAgICAgICAqIGVkaXRpbmcvc3BlbGxpbmcvc3BlbGxjaGVjay1pbnB1dC1zZWFyY2gtY3Jhc2gu aHRtbDogQWRkZWQuCisKIDIwMTEtMDYtMDUgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2VkaXRpbmcvc3BlbGxpbmcvc3BlbGxjaGVjay1pbnB1dC1zZWFyY2gtY3Jh c2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZWRpdGluZy9zcGVsbGluZy9zcGVsbGNoZWNr LWlucHV0LXNlYXJjaC1jcmFzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMDA1ZDZjNTVjZjIy Mjk4ZmRmYTkyYTU1MGZhZDZmOTMwYjFkMDZiZQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2VkaXRpbmcvc3BlbGxpbmcvc3BlbGxjaGVjay1pbnB1dC1zZWFyY2gtY3Jhc2gtZXhwZWN0 ZWQudHh0CkBAIC0wLDAgKzEsMTAgQEAKK1RoaXMgdGVzdCBwYXNzZXMgaWYgaXQgZG9lc24ndCBj cmFzaCBhbmQgdGhlIGNvbnRleHQgbWVudSBpcyBzaG93biBmb3IgdGhlIHNlYXJjaCBpbnB1dAor CitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBm b2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQg aXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCitQQVNTIGNsaWNrZWQgaXMgdHJ1ZQorCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL3NwZWxsaW5nL3NwZWxsY2hlY2staW5wdXQtc2VhcmNo LWNyYXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NwZWxsaW5nL3NwZWxsY2hlY2staW5w dXQtc2VhcmNoLWNyYXNoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZjUyNGY1MmYwM2NjMjNjMjZlMWI5Yzdl MTYzNTIzYmU2ZmYwZDY0OQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcv c3BlbGxpbmcvc3BlbGxjaGVjay1pbnB1dC1zZWFyY2gtY3Jhc2guaHRtbApAQCAtMCwwICsxLDM1 IEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8aHRt bD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIuLi8uLi9mYXN0L2pzL3Jl c291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vLi4vZmFzdC9qcy9y ZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KK3ZhciBjbGlja2Vk ID0gZmFsc2U7CisKK2Z1bmN0aW9uIGhhbmRsZUNsaWNrZWQoKQoreworICAgIGNsaWNrZWQgPSB0 cnVlOworfQorCitmdW5jdGlvbiB0ZXN0KCkKK3sKKyAgICBkZXNjcmlwdGlvbigiVGhpcyB0ZXN0 IHBhc3NlcyBpZiBpdCBkb2Vzbid0IGNyYXNoIGFuZCB0aGUgY29udGV4dCBtZW51IGlzIHNob3du IGZvciB0aGUgc2VhcmNoIGlucHV0Iik7CisgICAgaWYgKCF3aW5kb3cuZXZlbnRTZW5kZXIpCisg ICAgICAgIHJldHVybjsKKyAgICB2YXIgdGFyZ2V0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo InRhcmdldCIpOworICAgIHZhciBjbGlja1ggPSB0YXJnZXQub2Zmc2V0TGVmdCArIHRhcmdldC5v ZmZzZXRXaWR0aCAtIDI7CisgICAgdmFyIGNsaWNrWSA9IHRhcmdldC5vZmZzZXRUb3AgKyB0YXJn ZXQub2Zmc2V0SGVpZ2h0IC8gMjsKKyAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyhjbGlja1gs IGNsaWNrWSk7CisgICAgZXZlbnRTZW5kZXIuY29udGV4dENsaWNrKCk7CisgICAgc2hvdWxkQmUo ImNsaWNrZWQiLCAidHJ1ZSIpOworfQordmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cis8 L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0idGVzdCgpOyI+Cis8cCBpZD0iZGVzY3Jp cHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPGlucHV0IGlkPSJ0YXJnZXQi IHR5cGU9InNlYXJjaCIgb25jb250ZXh0bWVudT0iaGFuZGxlQ2xpY2tlZCgpIj4KKzxzY3JpcHQg c3JjPSIuLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0Pgor PC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDMzMzk5NmIxNzYwZWIzYWY3NWMzNjhjM2I5 NTVjM2Q1Y2JhYjY0ODkuLjBhMDBhM2QzZWY0NGEzMzNiYTg4MDBkOGM2NzI0ZmVkYzY5ODA0M2Eg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMS0wNi0wNiAgTU9SSVRBIEhhamltZSAg PG1vcnJpdGFAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBc3NlcnRpb24gZmFpbHMgaW4gVGV4dENoZWNraW5nSGVscGVyIGJ5IHJp Z2h0LWNsaWNraW5nIG9uIDxpbnB1dCB0eXBlPXNlYXJjaD4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxOTkxCisKKyAgICAgICAgQWRkZWQgYSBndWFy ZCBib2ZvcmUgVGV4dENoZWNraW5nSGVscGVyIGNvbnN0cnVjdGlvbiBzaXRlcy4KKworICAgICAg ICBUZXN0OiBlZGl0aW5nL3NwZWxsaW5nL3NwZWxsY2hlY2staW5wdXQtc2VhcmNoLWNyYXNoLmh0 bWwKKworICAgICAgICAqIGVkaXRpbmcvRWRpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVk aXRvcjo6aXNTZWxlY3Rpb25VbmdyYW1tYXRpY2FsKToKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRv cjo6Z3Vlc3Nlc0ZvclVuZ3JhbW1hdGljYWxTZWxlY3Rpb24pOgorICAgICAgICAoV2ViQ29yZTo6 RWRpdG9yOjpndWVzc2VzRm9yTWlzc3BlbGxlZE9yVW5ncmFtbWF0aWNhbFNlbGVjdGlvbik6CisK IDIwMTEtMDYtMDUgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2VkaXRpbmcvRWRpdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcApp bmRleCA4NjllODYyMDJkMTVlMjg5NzM1ZDMxOThjMjdhNmM4NTEzYTVjM2M5Li4yZTRmYzQxMjM0 ZjcxMWRhZDdlYzc3M2U4NDZiMjY3YmUzMjExODA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9lZGl0aW5nL0VkaXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3Iu Y3BwCkBAIC0xODU1LDcgKzE4NTUsMTAgQEAgYm9vbCBFZGl0b3I6OmlzU2VsZWN0aW9uVW5ncmFt bWF0aWNhbCgpCiB7CiAjaWYgVVNFKEdSQU1NQVJfQ0hFQ0tJTkcpCiAgICAgVmVjdG9yPFN0cmlu Zz4gaWdub3JlZEd1ZXNzZXM7Ci0gICAgcmV0dXJuIFRleHRDaGVja2luZ0hlbHBlcihjbGllbnQo KSwgZnJhbWUoKS0+c2VsZWN0aW9uKCktPnRvTm9ybWFsaXplZFJhbmdlKCkpLmlzVW5ncmFtbWF0 aWNhbChpZ25vcmVkR3Vlc3Nlcyk7CisgICAgUmVmUHRyPFJhbmdlPiByYW5nZSA9IGZyYW1lKCkt PnNlbGVjdGlvbigpLT50b05vcm1hbGl6ZWRSYW5nZSgpOworICAgIGlmICghcmFuZ2UpCisgICAg ICAgIHJldHVybiBmYWxzZTsKKyAgICByZXR1cm4gVGV4dENoZWNraW5nSGVscGVyKGNsaWVudCgp LCByYW5nZSkuaXNVbmdyYW1tYXRpY2FsKGlnbm9yZWRHdWVzc2VzKTsKICNlbHNlCiAgICAgcmV0 dXJuIGZhbHNlOwogI2VuZGlmCkBAIC0xODY1LDggKzE4NjgsMTEgQEAgVmVjdG9yPFN0cmluZz4g RWRpdG9yOjpndWVzc2VzRm9yVW5ncmFtbWF0aWNhbFNlbGVjdGlvbigpCiB7CiAjaWYgVVNFKEdS QU1NQVJfQ0hFQ0tJTkcpCiAgICAgVmVjdG9yPFN0cmluZz4gZ3Vlc3NlczsKKyAgICBSZWZQdHI8 UmFuZ2U+IHJhbmdlID0gZnJhbWUoKS0+c2VsZWN0aW9uKCktPnRvTm9ybWFsaXplZFJhbmdlKCk7 CisgICAgaWYgKCFyYW5nZSkKKyAgICAgICAgcmV0dXJuIGd1ZXNzZXM7CiAgICAgLy8gSWdub3Jl IHRoZSByZXN1bHQgb2YgaXNVbmdyYW1tYXRpY2FsOyB3ZSBqdXN0IHdhbnQgdGhlIGd1ZXNzZXMs IHdoZXRoZXIgb3Igbm90IHRoZXJlIGFyZSBhbnkKLSAgICBUZXh0Q2hlY2tpbmdIZWxwZXIoY2xp ZW50KCksIGZyYW1lKCktPnNlbGVjdGlvbigpLT50b05vcm1hbGl6ZWRSYW5nZSgpKS5pc1VuZ3Jh bW1hdGljYWwoZ3Vlc3Nlcyk7CisgICAgVGV4dENoZWNraW5nSGVscGVyKGNsaWVudCgpLCByYW5n ZSkuaXNVbmdyYW1tYXRpY2FsKGd1ZXNzZXMpOwogICAgIHJldHVybiBndWVzc2VzOwogI2Vsc2UK ICAgICByZXR1cm4gVmVjdG9yPFN0cmluZz4oKTsKQEAgLTE4ODcsNyArMTg5MywxMCBAQCBWZWN0 b3I8U3RyaW5nPiBFZGl0b3I6Omd1ZXNzZXNGb3JNaXNzcGVsbGVkU2VsZWN0aW9uKCkKIFZlY3Rv cjxTdHJpbmc+IEVkaXRvcjo6Z3Vlc3Nlc0Zvck1pc3NwZWxsZWRPclVuZ3JhbW1hdGljYWxTZWxl Y3Rpb24oYm9vbCYgbWlzc3BlbGxlZCwgYm9vbCYgdW5ncmFtbWF0aWNhbCkKIHsKICNpZiBVU0Uo VU5JRklFRF9URVhUX0NIRUNLSU5HKQotICAgIHJldHVybiBUZXh0Q2hlY2tpbmdIZWxwZXIoY2xp ZW50KCksIGZyYW1lKCktPnNlbGVjdGlvbigpLT50b05vcm1hbGl6ZWRSYW5nZSgpKS5ndWVzc2Vz Rm9yTWlzc3BlbGxlZE9yVW5ncmFtbWF0aWNhbFJhbmdlKGlzR3JhbW1hckNoZWNraW5nRW5hYmxl ZCgpLCBtaXNzcGVsbGVkLCB1bmdyYW1tYXRpY2FsKTsKKyAgICBSZWZQdHI8UmFuZ2U+IHJhbmdl ID0gZnJhbWUoKS0+c2VsZWN0aW9uKCktPnRvTm9ybWFsaXplZFJhbmdlKCk7CisgICAgaWYgKCFy YW5nZSkKKyAgICAgICAgcmV0dXJuIFZlY3RvcjxTdHJpbmc+KCk7CisgICAgcmV0dXJuIFRleHRD aGVja2luZ0hlbHBlcihjbGllbnQoKSwgcmFuZ2UpLmd1ZXNzZXNGb3JNaXNzcGVsbGVkT3JVbmdy YW1tYXRpY2FsUmFuZ2UoaXNHcmFtbWFyQ2hlY2tpbmdFbmFibGVkKCksIG1pc3NwZWxsZWQsIHVu Z3JhbW1hdGljYWwpOwogI2Vsc2UKICAgICBtaXNzcGVsbGVkID0gaXNTZWxlY3Rpb25NaXNzcGVs bGVkKCk7CiAgICAgaWYgKG1pc3NwZWxsZWQpIHsK