61981 2011-06-02 17:47:44 -0700 nrwt: fix duplicate logging regression 2011-06-03 12:00:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth tony oldest_to_newest 414576 0 dpranke 2011-06-02 17:47:44 -0700 nrwt: fix duplicate logging regression 414577 1 95841 dpranke 2011-06-02 17:48:10 -0700 Created attachment 95841 Patch 414578 2 dpranke 2011-06-02 17:49:45 -0700 I apparently re-introduced the "duplicate logging" issue due to a bad merge in bug 60328. This fixes it. There's no test for this because it's difficult to do given the need for multiple processes and actual shared pipes. Good thing it's trivially easy to verify by eye :) 414581 3 95841 dpranke 2011-06-02 17:53:57 -0700 Comment on attachment 95841 Patch whoops. this patch won't work. 414582 4 95842 dpranke 2011-06-02 17:56:01 -0700 Created attachment 95842 Patch 415064 5 dpranke 2011-06-03 12:00:18 -0700 Committed r88035: <http://trac.webkit.org/changeset/88035> 95841 2011-06-02 17:48:10 -0700 2011-06-02 17:55:58 -0700 Patch bug-61981-20110602174809.patch text/plain 1897 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogODc5NjcKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2YzNjZjViZmY1ZTQ2MjllY2QzY2I3MDI1NWZhMTdkZThl MDFlZDYwLi42NWQwNmZlZTkzYmIyNmI0YjQwMmI4MjYzZjZlNzYzYmE1ZjIwNGMyIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQg QEAKIDIwMTEtMDYtMDIgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbnJ3dDogZml4IGR1 cGxpY2F0ZSBsb2dnaW5nIHJlZ3Jlc3Npb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTYxOTgxCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9wcmludGluZy5weToKKworMjAxMS0wNi0wMiAgRGly ayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBU b255IENoYW5nLgogCiAgICAgICAgIE5SV1QgbmVlZHMgYSB3YXkgdG8gbG9nIHRvIGEgZmlsZSB3 aXRob3V0IGluY2x1ZGluZyBiYWNrc3BhY2VzIHdpdGhvdXQgbmVlZGluZyAtLXZlcmJvc2UKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNr YWdlL3ByaW50aW5nLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5 b3V0X3BhY2thZ2UvcHJpbnRpbmcucHkKaW5kZXggNmFhOTVlODQ2Y2RhNGVlNWZmYWY5OGJhODQ1 Y2E5YWFjZGUyMjg1Ny4uYjQ2YTJhZDllZjJhMzg2NmQxZDM4NWIzZGE3YzUzMzgzYTYyNGI1NCAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3Bh Y2thZ2UvcHJpbnRpbmcucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvbGF5b3V0X3BhY2thZ2UvcHJpbnRpbmcucHkKQEAgLTIyMCwxMCArMjIwLDEyIEBAIGNsYXNz IFByaW50ZXIob2JqZWN0KToKICAgICAgICAgaWYgc2VsZi5fc3RyZWFtLmlzYXR0eSgpIGFuZCBu b3Qgb3B0aW9ucy52ZXJib3NlOgogICAgICAgICAgICAgc2VsZi5fdXBkYXRlX2ludGVydmFsX3Nl Y29uZHMgPSBGQVNUX1VQREFURVNfU0VDT05EUwogICAgICAgICAgICAgc2VsZi5fbWV0ZXIgPSBt ZXRlcmVkX3N0cmVhbS5NZXRlcmVkU3RyZWFtKHNlbGYuX3N0cmVhbSkKLSAgICAgICAgICAgIHNl bGYuX2xvZ2dpbmdfaGFuZGxlciA9IF9jb25maWd1cmVfbG9nZ2luZyhzZWxmLl9tZXRlciwgb3B0 aW9ucy52ZXJib3NlKQorICAgICAgICAgICAgaWYgY29uZmlndXJlX2xvZ2dpbmc6CisgICAgICAg ICAgICAgICAgc2VsZi5fbG9nZ2luZ19oYW5kbGVyID0gX2NvbmZpZ3VyZV9sb2dnaW5nKHNlbGYu X21ldGVyLCBvcHRpb25zLnZlcmJvc2UpCiAgICAgICAgIGVsc2U6Ci0gICAgICAgICAgICBzZWxm Ll9sb2dnaW5nX2hhbmRsZXIgPSBfY29uZmlndXJlX2xvZ2dpbmcoc2VsZi5fc3RyZWFtLCBvcHRp b25zLnZlcmJvc2UpCiAgICAgICAgICAgICBzZWxmLl91cGRhdGVfaW50ZXJ2YWxfc2Vjb25kcyA9 IFNMT1dfVVBEQVRFU19TRUNPTkRTCisgICAgICAgICAgICBpZiBjb25maWd1cmVfbG9nZ2luZzoK KyAgICAgICAgICAgICAgICBzZWxmLl9sb2dnaW5nX2hhbmRsZXIgPSBfY29uZmlndXJlX2xvZ2dp bmcoc2VsZi5fc3RyZWFtLCBvcHRpb25zLnZlcmJvc2UpCiAKICAgICBkZWYgY2xlYW51cChzZWxm KToKICAgICAgICAgIiIiUmVzdG9yZSBsb2dnaW5nIGNvbmZpZ3VyYXRpb24gdG8gaXRzIGluaXRp YWwgc2V0dGluZ3MuIiIiCg== 95842 2011-06-02 17:56:01 -0700 2011-06-03 09:33:34 -0700 Patch bug-61981-20110602175600.patch text/plain 2024 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogODc5NjcKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2YzNjZjViZmY1ZTQ2MjllY2QzY2I3MDI1NWZhMTdkZThl MDFlZDYwLi42NWQwNmZlZTkzYmIyNmI0YjQwMmI4MjYzZjZlNzYzYmE1ZjIwNGMyIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQg QEAKIDIwMTEtMDYtMDIgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbnJ3dDogZml4IGR1 cGxpY2F0ZSBsb2dnaW5nIHJlZ3Jlc3Npb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTYxOTgxCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9wcmludGluZy5weToKKworMjAxMS0wNi0wMiAgRGly ayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBU b255IENoYW5nLgogCiAgICAgICAgIE5SV1QgbmVlZHMgYSB3YXkgdG8gbG9nIHRvIGEgZmlsZSB3 aXRob3V0IGluY2x1ZGluZyBiYWNrc3BhY2VzIHdpdGhvdXQgbmVlZGluZyAtLXZlcmJvc2UKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNr YWdlL3ByaW50aW5nLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5 b3V0X3BhY2thZ2UvcHJpbnRpbmcucHkKaW5kZXggNmFhOTVlODQ2Y2RhNGVlNWZmYWY5OGJhODQ1 Y2E5YWFjZGUyMjg1Ny4uOWM4ZjdmYmNlNGVlMDA1MWI5YWU0MzAxZTdhMjg2YTY1YWFmYWVhYiAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3Bh Y2thZ2UvcHJpbnRpbmcucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvbGF5b3V0X3BhY2thZ2UvcHJpbnRpbmcucHkKQEAgLTIxNywxMyArMjE3LDE2IEBAIGNsYXNz IFByaW50ZXIob2JqZWN0KToKIAogICAgICAgICBzZWxmLnN3aXRjaGVzID0gcGFyc2VfcHJpbnRf b3B0aW9ucyhvcHRpb25zLnByaW50X29wdGlvbnMsIG9wdGlvbnMudmVyYm9zZSkKIAorICAgICAg ICBzZWxmLl9sb2dnaW5nX2hhbmRsZXIgPSBOb25lCiAgICAgICAgIGlmIHNlbGYuX3N0cmVhbS5p c2F0dHkoKSBhbmQgbm90IG9wdGlvbnMudmVyYm9zZToKICAgICAgICAgICAgIHNlbGYuX3VwZGF0 ZV9pbnRlcnZhbF9zZWNvbmRzID0gRkFTVF9VUERBVEVTX1NFQ09ORFMKICAgICAgICAgICAgIHNl bGYuX21ldGVyID0gbWV0ZXJlZF9zdHJlYW0uTWV0ZXJlZFN0cmVhbShzZWxmLl9zdHJlYW0pCi0g ICAgICAgICAgICBzZWxmLl9sb2dnaW5nX2hhbmRsZXIgPSBfY29uZmlndXJlX2xvZ2dpbmcoc2Vs Zi5fbWV0ZXIsIG9wdGlvbnMudmVyYm9zZSkKKyAgICAgICAgICAgIGlmIGNvbmZpZ3VyZV9sb2dn aW5nOgorICAgICAgICAgICAgICAgIHNlbGYuX2xvZ2dpbmdfaGFuZGxlciA9IF9jb25maWd1cmVf bG9nZ2luZyhzZWxmLl9tZXRlciwgb3B0aW9ucy52ZXJib3NlKQogICAgICAgICBlbHNlOgotICAg ICAgICAgICAgc2VsZi5fbG9nZ2luZ19oYW5kbGVyID0gX2NvbmZpZ3VyZV9sb2dnaW5nKHNlbGYu X3N0cmVhbSwgb3B0aW9ucy52ZXJib3NlKQogICAgICAgICAgICAgc2VsZi5fdXBkYXRlX2ludGVy dmFsX3NlY29uZHMgPSBTTE9XX1VQREFURVNfU0VDT05EUworICAgICAgICAgICAgaWYgY29uZmln dXJlX2xvZ2dpbmc6CisgICAgICAgICAgICAgICAgc2VsZi5fbG9nZ2luZ19oYW5kbGVyID0gX2Nv bmZpZ3VyZV9sb2dnaW5nKHNlbGYuX3N0cmVhbSwgb3B0aW9ucy52ZXJib3NlKQogCiAgICAgZGVm IGNsZWFudXAoc2VsZik6CiAgICAgICAgICIiIlJlc3RvcmUgbG9nZ2luZyBjb25maWd1cmF0aW9u IHRvIGl0cyBpbml0aWFsIHNldHRpbmdzLiIiIgo=