61961 2011-06-02 14:14:20 -0700 [chromium] Chromium bots on build.webkit.org don't upload results.html 2011-06-06 18:35:59 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa abarth dpranke eric tony wsiegrist oldest_to_newest 414426 0 rniwa 2011-06-02 14:14:20 -0700 None of Chromium Windows, Mac, or Linux upload results.html and other files. As a result, we can't see any diffs or stderr from build.webkit.org. 414437 1 rniwa 2011-06-02 14:24:44 -0700 The problem is that we fix dir. path in test-result-archive: if options.platform == 'chromium': # See results_directory() in webkitpy/layout_tests/port/chromium.py. layoutTestResultsDir = os.path.abspath(os.path.join(sourceRootDirectory, "Source", "WebKit", "chromium", "webkit", options.configuration.capitalize(), "layout-test-results")) Since we're running this script with the following arguments & path: python ./Tools/BuildSlaveSupport/test-result-archive --platform=chromium --release archive in dir /Users/chrome-bot/Desktop/WebKit-BuildSlave/chromium-mac-release-tests/build (timeout 1200 secs) watching logfiles {} argv: ['python', './Tools/BuildSlaveSupport/test-result-archive', '--platform=chromium', '--release', 'archive'] and test results live in /Users/chrome-bot/Desktop/WebKit-BuildSlave/chromium-mac-release-tests/build/layout-test-results we shouldn't be doing this fix up. I think this bug goes away if we get rid of the offending lines in test-result-archive. Or am I missing something? 414468 2 tony 2011-06-02 14:50:27 -0700 That sounds right. We used to put the results in Source/WebKit/chromium/webkit, but now the results should just be in the root of the source tree. If you want to be thorough, you can run a buildbot on your desktop. 414497 3 rniwa 2011-06-02 15:14:49 -0700 (In reply to comment #2) > That sounds right. We used to put the results in Source/WebKit/chromium/webkit, but now the results should just be in the root of the source tree. > > If you want to be thorough, you can run a buildbot on your desktop. Are there instructions on how to do it? Ideally, I can test it myself before making this change. Or I land the change in weekend when nobody is landing patches. 414505 4 tony 2011-06-02 15:36:52 -0700 (In reply to comment #3) > (In reply to comment #2) > > That sounds right. We used to put the results in Source/WebKit/chromium/webkit, but now the results should just be in the root of the source tree. > > > > If you want to be thorough, you can run a buildbot on your desktop. > > Are there instructions on how to do it? Ideally, I can test it myself before making this change. Or I land the change in weekend when nobody is landing patches. http://trac.webkit.org/wiki/BuildBot has instructions for running a slave. I can show you how to set up a master as well. If you plan on making future changes to the bots, this is probably worth doing. If not, then this change seems pretty safe and the worst case scenario is that test-result-archive continues to not work on the Chromium slaves. 416154 5 96158 rniwa 2011-06-06 17:25:54 -0700 Created attachment 96158 fixes the bug 416155 6 rniwa 2011-06-06 17:26:22 -0700 I have verified that his change at least fixes Mac bot. 416199 7 96158 rniwa 2011-06-06 18:35:56 -0700 Comment on attachment 96158 fixes the bug Clearing flags on attachment: 96158 Committed r88210: <http://trac.webkit.org/changeset/88210> 416200 8 rniwa 2011-06-06 18:35:59 -0700 All reviewed patches have been landed. Closing bug. 96158 2011-06-06 17:25:54 -0700 2011-06-06 18:35:56 -0700 fixes the bug bug-61961-20110606172552.patch text/plain 1566 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDg4MjA0KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTQgQEAKKzIwMTEtMDYtMDYgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVt XSBDaHJvbWl1bSBib3RzIG9uIGJ1aWxkLndlYmtpdC5vcmcgZG9uJ3QgdXBsb2FkIHJlc3VsdHMu aHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjE5 NjEKKworICAgICAgICBEb24ndCBmaXggdGhlIHBhdGggb24gY2hyb21pdW0gcG9ydCBlcnJvbmVv dXNseS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L3Rlc3QtcmVzdWx0LWFyY2hpdmU6 CisKIDIwMTEtMDYtMDYgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgog CiAgICAgICAgIEZpeCB0aGUgR1RLKyBidWlsZCBieSBlbnN1cmluZyB0aGF0IHRoZSBhdXRvZ2Vu ZXJhdGVkIHNvdXJjZXMKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L3Rlc3QtcmVzdWx0 LWFyY2hpdmUKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvdGVzdC1yZXN1 bHQtYXJjaGl2ZQkocmV2aXNpb24gODgyMDIpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC90 ZXN0LXJlc3VsdC1hcmNoaXZlCSh3b3JraW5nIGNvcHkpCkBAIC00MywxMiArNDMsNiBAQCBkZWYg bWFpbigpOgogICAgICAgICBwYXJzZXIuZXJyb3IoIkFjdGlvbiBpcyByZXF1aXJlZCIpCiAKICAg ICBsYXlvdXRUZXN0UmVzdWx0c0RpciA9IG9zLnBhdGguYWJzcGF0aChvcy5wYXRoLmpvaW4oc291 cmNlUm9vdERpcmVjdG9yeSwgImxheW91dC10ZXN0LXJlc3VsdHMiKSkKLSAgICBpZiBvcHRpb25z LnBsYXRmb3JtID09ICdjaHJvbWl1bSc6Ci0gICAgICAgICMgU2VlIHJlc3VsdHNfZGlyZWN0b3J5 KCkgaW4gd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkuCi0gICAgICAgIGxh eW91dFRlc3RSZXN1bHRzRGlyID0gb3MucGF0aC5hYnNwYXRoKG9zLnBhdGguam9pbihzb3VyY2VS b290RGlyZWN0b3J5LAotICAgICAgICAgICAgIlNvdXJjZSIsICJXZWJLaXQiLCAiY2hyb21pdW0i LCAid2Via2l0Iiwgb3B0aW9ucy5jb25maWd1cmF0aW9uLmNhcGl0YWxpemUoKSwKLSAgICAgICAg ICAgICJsYXlvdXQtdGVzdC1yZXN1bHRzIikpCi0KICAgICByZXR1cm4gYXJjaGl2ZVRlc3RSZXN1 bHRzKG9wdGlvbnMuY29uZmlndXJhdGlvbiwgb3B0aW9ucy5wbGF0Zm9ybSwgbGF5b3V0VGVzdFJl c3VsdHNEaXIpCiAKIGRlZiBhcmNoaXZlVGVzdFJlc3VsdHMoY29uZmlndXJhdGlvbiwgcGxhdGZv cm0sIGxheW91dFRlc3RSZXN1bHRzRGlyKToK