61954 2011-06-02 13:09:54 -0700 [chromium] Compositor HUD should respect mapTexSubImage2D returning NULL 2011-06-02 15:14:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enne enne enne jamesr nduca oldest_to_newest 414378 0 enne 2011-06-02 13:09:54 -0700 [chromium] Compositor HUD should respect mapTexSubImage2D returning NULL 414380 1 95795 enne 2011-06-02 13:13:59 -0700 Created attachment 95795 Patch 414412 2 95795 jamesr 2011-06-02 14:02:24 -0700 Comment on attachment 95795 Patch Looks good. Is there any reasonable way to share the CCHeadsUpDisplay uploading logic with the code we use for content layers so we don't have to do this stuff twice? 414420 3 enne 2011-06-02 14:09:44 -0700 We could probably add a tiler to the CCHeadsUpDisplay and replace all the drawing and uploading code. That looked like a lot more invasive of a change, so I thought I'd just fix the crash initially and consider refactoring later. 414495 4 enne 2011-06-02 15:14:20 -0700 Committed r87960: <http://trac.webkit.org/changeset/87960> 95795 2011-06-02 13:13:59 -0700 2011-06-02 14:02:24 -0700 Patch bug-61954-20110602131353.patch text/plain 2371 enne U3VidmVyc2lvbiBSZXZpc2lvbjogODc5NDcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkMjM2MDA0YjRkMDZjNDQx YzFhYjY2ZTEyNzUxMjIzOTIxNzg2M2QyLi4yZDU2NjJjNjM4ZTE4NGZhNjAxZDQ1YzgxNjI0YTU0 OTE2ZTNmYTg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDYtMDIgIEFkcmll bm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIENvbXBvc2l0b3IgSFVEIHNob3VsZCBy ZXNwZWN0IG1hcFRleFN1YkltYWdlMkQgcmV0dXJuaW5nIE5VTEwKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxOTU0CisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0hlYWRzVXBEaXNwbGF5LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkNDSGVhZHNVcERpc3BsYXk6OmRyYXcpOgorCiAyMDExLTA2LTAxICBBZHJpZW5uZSBX YWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlk ZWwuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1 bS9jYy9DQ0hlYWRzVXBEaXNwbGF5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL2NjL0NDSGVhZHNVcERpc3BsYXkuY3BwCmluZGV4IGUxOTlkNWVmODI4ZTcx Y2UyNzdjZDNjNmZhYWUxNWJmZDVhMzhkNWMuLmZiNjgxYWUzMjM5ODk1NmIzMjY3NTIwOTBkMWJl ZmUwYzc0Zjk4YzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2Nocm9taXVtL2NjL0NDSGVhZHNVcERpc3BsYXkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDSGVhZHNVcERpc3BsYXkuY3BwCkBAIC0xMTAs MTIgKzExMCwxOSBAQCB2b2lkIENDSGVhZHNVcERpc3BsYXk6OmRyYXcoKQogICAgICAgICBQbGF0 Zm9ybUNhbnZhczo6QXV0b0xvY2tlciBsb2NrZXIoJmNhbnZhcyk7CiAKICAgICAgICAgbV9odWRU ZXh0dXJlLT5iaW5kVGV4dHVyZSgpOworICAgICAgICBib29sIHVwbG9hZGVkVmlhTWFwID0gZmFs c2U7CiAgICAgICAgIGlmIChtX3VzZU1hcFN1YkZvclVwbG9hZHMpIHsKICAgICAgICAgICAgIEV4 dGVuc2lvbnMzRENocm9taXVtKiBleHRlbnNpb25zID0gc3RhdGljX2Nhc3Q8RXh0ZW5zaW9uczNE Q2hyb21pdW0qPihjb250ZXh0LT5nZXRFeHRlbnNpb25zKCkpOwogICAgICAgICAgICAgdWludDhf dCogcGl4ZWxEZXN0ID0gc3RhdGljX2Nhc3Q8dWludDhfdCo+KGV4dGVuc2lvbnMtPm1hcFRleFN1 YkltYWdlMkRDSFJPTUlVTShHcmFwaGljc0NvbnRleHQzRDo6VEVYVFVSRV8yRCwgMCwgMCwgMCwg aHVkU2l6ZS53aWR0aCgpLCBodWRTaXplLmhlaWdodCgpLCBHcmFwaGljc0NvbnRleHQzRDo6UkdC QSwgR3JhcGhpY3NDb250ZXh0M0Q6OlVOU0lHTkVEX0JZVEUsIEV4dGVuc2lvbnMzRENocm9taXVt OjpXUklURV9PTkxZKSk7Ci0gICAgICAgICAgICBtZW1jcHkocGl4ZWxEZXN0LCBsb2NrZXIucGl4 ZWxzKCksIGh1ZFNpemUud2lkdGgoKSAqIGh1ZFNpemUuaGVpZ2h0KCkgKiA0KTsKLSAgICAgICAg ICAgIGV4dGVuc2lvbnMtPnVubWFwVGV4U3ViSW1hZ2UyRENIUk9NSVVNKHBpeGVsRGVzdCk7Ci0g ICAgICAgIH0gZWxzZQorCisgICAgICAgICAgICBpZiAocGl4ZWxEZXN0KSB7CisgICAgICAgICAg ICAgICAgdXBsb2FkZWRWaWFNYXAgPSB0cnVlOworICAgICAgICAgICAgICAgIG1lbWNweShwaXhl bERlc3QsIGxvY2tlci5waXhlbHMoKSwgaHVkU2l6ZS53aWR0aCgpICogaHVkU2l6ZS5oZWlnaHQo KSAqIDQpOworICAgICAgICAgICAgICAgIGV4dGVuc2lvbnMtPnVubWFwVGV4U3ViSW1hZ2UyRENI Uk9NSVVNKHBpeGVsRGVzdCk7CisgICAgICAgICAgICB9CisgICAgICAgIH0KKworICAgICAgICBp ZiAoIXVwbG9hZGVkVmlhTWFwKQogICAgICAgICAgICAgR0xDKGNvbnRleHQsIGNvbnRleHQtPnRl eEltYWdlMkQoR3JhcGhpY3NDb250ZXh0M0Q6OlRFWFRVUkVfMkQsIDAsIEdyYXBoaWNzQ29udGV4 dDNEOjpSR0JBLCBjYW52YXMuc2l6ZSgpLndpZHRoKCksIGNhbnZhcy5zaXplKCkuaGVpZ2h0KCks IDAsIEdyYXBoaWNzQ29udGV4dDNEOjpSR0JBLCBHcmFwaGljc0NvbnRleHQzRDo6VU5TSUdORURf QllURSwgbG9ja2VyLnBpeGVscygpKSk7CiAgICAgfQogCg==