61899 2011-06-01 18:48:51 -0700 REGRESSION: inline style is lost when deleting line break between paragraphs with same style 2011-06-03 09:14:25 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P1 Normal --- 1 rniwa rniwa adele ademar darin enrica sullivan oldest_to_newest 413817 0 95698 rniwa 2011-06-01 18:48:51 -0700 Created attachment 95698 demo The attachment demonstrates the bug. When two paragraphs have same style, deleting a line break between them results in the second paragraph losing its font style. 413823 1 95699 rniwa 2011-06-01 18:54:27 -0700 Created attachment 95699 fixes the bug 414135 2 95699 eric 2011-06-02 08:27:42 -0700 Comment on attachment 95699 fixes the bug OK. Do we need to add a comment to document the ordering? Or is it obvious from the code? 414224 3 rniwa 2011-06-02 10:04:46 -0700 (In reply to comment #2) > (From update of attachment 95699 [details]) > OK. Do we need to add a comment to document the ordering? Or is it obvious from the code? It must be obvious from the code (at least to me). Also changing the order will make the added test to fail :) 414327 4 rniwa 2011-06-02 12:08:01 -0700 Committed r87937: <http://trac.webkit.org/changeset/87937> 414329 5 rniwa 2011-06-02 12:08:50 -0700 Thanks for the review! 414336 6 adele 2011-06-02 12:15:00 -0700 <rdar://problem/9543996> 414940 7 ademar 2011-06-03 09:14:25 -0700 Revision r87937 cherry-picked into qtwebkit-2.2 with commit dbda3e9 <http://gitorious.org/webkit/qtwebkit/commit/dbda3e9> 95698 2011-06-01 18:48:51 -0700 2011-06-01 18:48:51 -0700 demo delete-line-break-between-paragraphs-with-same-style.html text/html 386 rniwa PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8Ym9keT4KPGRpdiBpZD0idGVzdCIgY29udGVudGVkaXRh YmxlPgo8ZGl2Pjxmb250IGNsYXNzPSJBcHBsZS1zdHlsZS1zcGFuIiBmYWNlPSJtb25vc3BhY2Ui PmhlbGxvIHdvcmxkPC9mb250PjwvZGl2PjxkaXY+PGZvbnQgY2xhc3M9IkFwcGxlLXN0eWxlLXNw YW4iIGZhY2U9Im1vbm9zcGFjZSI+V2ViS2l0PC9mb250PjwvZGl2Pgo8L2Rpdj4KPHNjcmlwdD4K CmRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0ZXN0JykuZm9jdXMoKTsKd2luZG93LmdldFNlbGVj dGlvbigpLm1vZGlmeSgnbW92ZScsICdmb3J3YXJkJywgJ2xpbmUnKTsKZG9jdW1lbnQuZXhlY0Nv bW1hbmQoJ0RlbGV0ZScpOwoKPC9zY3JpcHQ+CjwvYm9keT4KPC9odG1sPgo= 95699 2011-06-01 18:54:27 -0700 2011-06-02 08:27:42 -0700 fixes the bug bug-61899-20110601185426.patch text/plain 5011 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg3ODcyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDYtMDEgIFJ5b3N1a2Ug Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTjogaW5saW5lIHN0eWxlIGlzIGxvc3Qgd2hlbiBk ZWxldGluZyBsaW5lIGJyZWFrIGJldHdlZW4gcGFyYWdyYXBocyB3aXRoIHNhbWUgc3R5bGUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxODk5CisKKyAg ICAgICAgVGhlIGJ1ZyB3YXMgY2F1c2VkIGJ5IFJlcGxhY2VTZWxlY3Rpb25Db21tYW5kOjpkb0Fw cGx5J3MgY2FsbGluZyBoYW5kbGVTdHlsZVNwYW5zQmVmb3JlSW5zZXJ0aW9uCisgICAgICAgIGJl Zm9yZSBpbnNlcnRpb25Qb3MgaXMgYWRqdXN0ZWQgYnkgcG9zaXRpb25Bdm9pZGluZ1ByZWNlZGlu Z05vZGVzIGFuZCBwb3NpdGlvbk91dHNpZGVUYWJTcGFuLgorCisgICAgICAgIEZpeGVkIHRoZSBi dWcgYnkgY2FsbGluZyBoYW5kbGVTdHlsZVNwYW5zQmVmb3JlSW5zZXJ0aW9uIGFmdGVyIHRoZSBj YWxscyB0byB0aGVzZSB0d28gZnVuY3Rpb25zLgorCisgICAgICAgIFRlc3Q6IGVkaXRpbmcvZGVs ZXRpbmcvZGVsZXRlLWxpbmUtYnJlYWstYmV0d2Vlbi1wYXJhZ3JhcGhzLXdpdGgtc2FtZS1zdHls ZS5odG1sCisKKyAgICAgICAgKiBlZGl0aW5nL1JlcGxhY2VTZWxlY3Rpb25Db21tYW5kLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlcGxhY2VTZWxlY3Rpb25Db21tYW5kOjpkb0FwcGx5KToKKwog MjAxMS0wNi0wMSAgQWRyaWVubmUgV2Fsa2VyICA8ZW5uZUBnb29nbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEphbWVzIFJvYmluc29uLgpJbmRleDogU291cmNlL1dlYkNvcmUvZWRpdGlu Zy9SZXBsYWNlU2VsZWN0aW9uQ29tbWFuZC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvZWRpdGluZy9SZXBsYWNlU2VsZWN0aW9uQ29tbWFuZC5jcHAJKHJldmlzaW9uIDg3ODM1KQor KysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9SZXBsYWNlU2VsZWN0aW9uQ29tbWFuZC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTkyMSw4ICs5MjEsNiBAQCB2b2lkIFJlcGxhY2VTZWxlY3Rpb25Db21t YW5kOjpkb0FwcGx5KCkKIAogICAgIHJlbW92ZUhlYWRDb250ZW50cyhmcmFnbWVudCk7CiAKLSAg ICBib29sIGhhbmRsZWRTdHlsZVNwYW5zID0gaGFuZGxlU3R5bGVTcGFuc0JlZm9yZUluc2VydGlv bihmcmFnbWVudCwgaW5zZXJ0aW9uUG9zKTsKLQogICAgIC8vIFdlIGRvbid0IHdhbnQgdGhlIGRl c3RpbmF0aW9uIHRvIGVuZCB1cCBpbnNpZGUgbm9kZXMgdGhhdCB3ZXJlbid0IHNlbGVjdGVkLiAg VG8gYXZvaWQgdGhhdCwgd2UgbW92ZSB0aGUKICAgICAvLyBwb3NpdGlvbiBmb3J3YXJkIHdpdGhv dXQgY2hhbmdpbmcgdGhlIHZpc2libGUgcG9zaXRpb24gc28gd2UncmUgc3RpbGwgYXQgdGhlIHNh bWUgdmlzaWJsZSBsb2NhdGlvbiwgYnV0CiAgICAgLy8gb3V0c2lkZSBvZiBwcmVjZWRpbmcgdGFn cy4KQEAgLTkzMSw2ICs5MjksOCBAQCB2b2lkIFJlcGxhY2VTZWxlY3Rpb25Db21tYW5kOjpkb0Fw cGx5KCkKICAgICAvLyBQYXN0ZSBpbnRvIHJ1biBvZiB0YWJzIHNwbGl0cyB0aGUgdGFiIHNwYW4u CiAgICAgaW5zZXJ0aW9uUG9zID0gcG9zaXRpb25PdXRzaWRlVGFiU3BhbihpbnNlcnRpb25Qb3Mp OwogCisgICAgYm9vbCBoYW5kbGVkU3R5bGVTcGFucyA9IGhhbmRsZVN0eWxlU3BhbnNCZWZvcmVJ bnNlcnRpb24oZnJhZ21lbnQsIGluc2VydGlvblBvcyk7CisKICAgICAvLyBJZiB3ZSBhcmUgbm90 IHRyeWluZyB0byBtYXRjaCB0aGUgZGVzdGluYXRpb24gc3R5bGUgd2UgcHJlZmVyIGEgcG9zaXRp b24KICAgICAvLyB0aGF0IGlzIG91dHNpZGUgaW5saW5lIGVsZW1lbnRzIHRoYXQgcHJvdmlkZSBz dHlsZS4KICAgICAvLyBUaGlzIHdheSB3ZSBjYW4gcHJvZHVjZSBhIGxlc3MgdmVyYm9zZSBtYXJr dXAuCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA4Nzg3MikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDExLTA2LTAxICBSeW9zdWtlIE5pd2Eg IDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFJFR1JFU1NJT046IGlubGluZSBzdHlsZSBpcyBsb3N0IHdoZW4gZGVsZXRp bmcgbGluZSBicmVhayBiZXR3ZWVuIHBhcmFncmFwaHMgd2l0aCBzYW1lIHN0eWxlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTg5OQorCisgICAgICAg IEFkZGVkIGEgcmVncmVzc2lvbiB0ZXN0IHRvIGVuc3VyZSBXZWJLaXQgcHJlc2VydmVzIGZvbnQg ZmFtaWx5IGZvciBhIHBhcmFncmFwaCBiZWluZyBtZXJnZWQKKyAgICAgICAgdG8gdGhlIHByZXZp b3VzIHBhcmFncmFwaCB3aGVuIGRlbGV0aW5nIGEgbGluZSBicmVhayBiZXR3ZWVuIHR3byBwYXJh Z3JhcGhzIHdpdGggdGhlIHNhbWUgc3R5bGUuCisKKyAgICAgICAgKiBlZGl0aW5nL2RlbGV0aW5n L2RlbGV0ZS1saW5lLWJyZWFrLWJldHdlZW4tcGFyYWdyYXBocy13aXRoLXNhbWUtc3R5bGUtZXhw ZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5nL2RlbGV0aW5nL2RlbGV0ZS1saW5l LWJyZWFrLWJldHdlZW4tcGFyYWdyYXBocy13aXRoLXNhbWUtc3R5bGUuaHRtbDogQWRkZWQuCisK IDIwMTEtMDYtMDEgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBU aGVyZSBzZWVtcyB0byBiZSBzb21ldGhpbmcgb2RkIGFib3V0IHJlZ2lzdGVyUHJvdG9jb2xIYW5k bGVyIG9uIE1hYy4KSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvZGVsZXRpbmcvZGVsZXRlLWxp bmUtYnJlYWstYmV0d2Vlbi1wYXJhZ3JhcGhzLXdpdGgtc2FtZS1zdHlsZS1leHBlY3RlZC50eHQK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9kZWxldGluZy9kZWxldGUtbGluZS1i cmVhay1iZXR3ZWVuLXBhcmFncmFwaHMtd2l0aC1zYW1lLXN0eWxlLWV4cGVjdGVkLnR4dAkocmV2 aXNpb24gMCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcvZGVsZXRpbmcvZGVsZXRlLWxpbmUtYnJl YWstYmV0d2Vlbi1wYXJhZ3JhcGhzLXdpdGgtc2FtZS1zdHlsZS1leHBlY3RlZC50eHQJKHJldmlz aW9uIDApCkBAIC0wLDAgKzEsMTQgQEAKK1RoaXMgdGVzdHMgZGVsZXRpbmcgYSBsaW5lIGJyZWFr IGJldHdlZW4gcGFyYWdyYXBocyB3aXRoIHRoZSBzYW1lIGlubGluZSBzdHlsZS4gSW5saW5lIHN0 eWxlIHNob3VsZCBiZSBwcmVzZXJ2ZWQgYWZ0ZXIgdGhlIG1lcmdlLgorfCAiCisiCit8IDxkaXY+ Cit8ICAgPGZvbnQ+Cit8ICAgICBjbGFzcz0iQXBwbGUtc3R5bGUtc3BhbiIKK3wgICAgIGZhY2U9 Im1vbm9zcGFjZSIKK3wgICAgICJoZWxsbyB3b3JsZDwjc2VsZWN0aW9uLWNhcmV0PiIKK3wgICA8 c3Bhbj4KK3wgICAgIGNsYXNzPSJBcHBsZS1zdHlsZS1zcGFuIgorfCAgICAgc3R5bGU9ImZvbnQt ZmFtaWx5OiBtb25vc3BhY2U7ICIKK3wgICAgICJXZWJLaXQiCit8ICIKKyIKSW5kZXg6IExheW91 dFRlc3RzL2VkaXRpbmcvZGVsZXRpbmcvZGVsZXRlLWxpbmUtYnJlYWstYmV0d2Vlbi1wYXJhZ3Jh cGhzLXdpdGgtc2FtZS1zdHlsZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRp bmcvZGVsZXRpbmcvZGVsZXRlLWxpbmUtYnJlYWstYmV0d2Vlbi1wYXJhZ3JhcGhzLXdpdGgtc2Ft ZS1zdHlsZS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9kZWxldGlu Zy9kZWxldGUtbGluZS1icmVhay1iZXR3ZWVuLXBhcmFncmFwaHMtd2l0aC1zYW1lLXN0eWxlLmh0 bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjEgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+ Cis8Ym9keT4KKzxkaXYgaWQ9InRlc3QiIGNvbnRlbnRlZGl0YWJsZT4KKzxkaXY+PGZvbnQgY2xh c3M9IkFwcGxlLXN0eWxlLXNwYW4iIGZhY2U9Im1vbm9zcGFjZSI+aGVsbG8gd29ybGQ8L2ZvbnQ+ PC9kaXY+PGRpdj48Zm9udCBjbGFzcz0iQXBwbGUtc3R5bGUtc3BhbiIgZmFjZT0ibW9ub3NwYWNl Ij5XZWJLaXQ8L2ZvbnQ+PC9kaXY+Cis8L2Rpdj4KKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJj ZXMvZHVtcC1hcy1tYXJrdXAuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KKworTWFya3VwLmRlc2Ny aXB0aW9uKCdUaGlzIHRlc3RzIGRlbGV0aW5nIGEgbGluZSBicmVhayBiZXR3ZWVuIHBhcmFncmFw aHMgd2l0aCB0aGUgc2FtZSBpbmxpbmUgc3R5bGUuJworKyAnIElubGluZSBzdHlsZSBzaG91bGQg YmUgcHJlc2VydmVkIGFmdGVyIHRoZSBtZXJnZS4nKTsKKworZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoJ3Rlc3QnKS5mb2N1cygpOword2luZG93LmdldFNlbGVjdGlvbigpLm1vZGlmeSgnbW92ZScs ICdmb3J3YXJkJywgJ2xpbmUnKTsKK2RvY3VtZW50LmV4ZWNDb21tYW5kKCdEZWxldGUnKTsKKwor TWFya3VwLmR1bXAoJ3Rlc3QnKTsKKworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==