61898 2011-06-01 17:59:28 -0700 [chromium] LayerChromium should use a RefPtr for replica layer 2011-06-02 13:01:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enne enne enne eric jamesr kbr vangelis oldest_to_newest 413797 0 enne 2011-06-01 17:59:28 -0700 [chromium] LayerChromium should use a RefPtr for replica layer 413798 1 95692 enne 2011-06-01 18:02:00 -0700 Created attachment 95692 Patch 414139 2 95692 eric 2011-06-02 08:28:58 -0700 Comment on attachment 95692 Patch So long as this doesn't cause a ref cycle, sure. 414351 3 enne 2011-06-02 12:45:52 -0700 Committed r87942: <http://trac.webkit.org/changeset/87942> 414374 4 enne 2011-06-02 13:01:54 -0700 (In reply to comment #2) > (From update of attachment 95692 [details]) > So long as this doesn't cause a ref cycle, sure. Thanks. I talked to a few folks and stared at it closely. My understanding like cycles can't happen given the way replica layers are created and assigned. 95692 2011-06-01 18:02:00 -0700 2011-06-02 08:28:58 -0700 Patch bug-61898-20110601180159.patch text/plain 1977 enne U3VidmVyc2lvbiBSZXZpc2lvbjogODc4NjgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlOTAxZWRkZWNiYjcxYzdh MjVjY2E0ZDdmMDllZDQyMzg5ZDJiZmZiLi40YzlkYjU0ZGZhNjFiZTEwODM1NGI4MTJkNDc1ODhm ZGIwMGFhMThmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMTEtMDYtMDEgIEFkcmll bm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIExheWVyQ2hyb21pdW0gc2hvdWxkIHVz ZSBhIFJlZlB0ciBmb3IgcmVwbGljYSBsYXllcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjE4OTgKKworICAgICAgICBIYXZpbmcgdGhpcyBtZW1iZXIg dmFyaWFibGUgYmUgYSByYXcgcG9pbnRlciBpcyBicml0dGxlIGFuZCBhc3N1bWVzCisgICAgICAg IHRoYXQgdGhlIEdyYXBoaWNzTGF5ZXIgdHJlZSBrZWVwcyB0aGlzIGluIHN5bmMuICBUaGVyZSBh cmVuJ3QgYW55CisgICAgICAgIGtub3duIGJ1Z3MgY2F1c2VkIGJ5IHRoaXMsIGJ1dCBpdCBzZWVt cyBsaWtlIGdvb2Qgc2Vuc2UgdG8gZG8gdGhpcy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL0xheWVyQ2hyb21pdW0uaDoKKyAgICAgICAgKFdlYkNvcmU6OkxheWVyQ2hy b21pdW06OnJlcGxpY2FMYXllcik6CisKKzIwMTEtMDYtMDEgIEFkcmllbm5lIFdhbGtlciAgPGVu bmVAZ29vZ2xlLmNvbT4KKwogICAgICAgICBSZXZpZXdlZCBieSBKYW1lcyBSb2JpbnNvbi4KIAog ICAgICAgICBbY2hyb21pdW1dIEZpeCBzeW5jaW5nIG9mIHJlbW92ZWQgbWFzayBhbmQgcmVwbGlj YSBsYXllcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL0xheWVyQ2hyb21pdW0uaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2Nocm9taXVtL0xheWVyQ2hyb21pdW0uaAppbmRleCAzNDA2MGRiNDYyNjUwZmE4ZjBmNjE4ZjZk ZWY1M2E4ODdlNjBmNDAzLi5iNGExMTJmMGEzNDhiZWIzNmJkNTQ2MDFkYjBlZGJkZTdlYjZlNzMw IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9M YXllckNocm9taXVtLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hy b21pdW0vTGF5ZXJDaHJvbWl1bS5oCkBAIC0xNDgsNyArMTQ4LDcgQEAgcHVibGljOgogICAgIHZv aWQgc2V0T3duZXIoR3JhcGhpY3NMYXllckNocm9taXVtKiBvd25lcikgeyBtX293bmVyID0gb3du ZXI7IH0KIAogICAgIHZvaWQgc2V0UmVwbGljYUxheWVyKExheWVyQ2hyb21pdW0qIGxheWVyKSB7 IG1fcmVwbGljYUxheWVyID0gbGF5ZXI7IH0KLSAgICBMYXllckNocm9taXVtKiByZXBsaWNhTGF5 ZXIoKSB7IHJldHVybiBtX3JlcGxpY2FMYXllcjsgfQorICAgIExheWVyQ2hyb21pdW0qIHJlcGxp Y2FMYXllcigpIHsgcmV0dXJuIG1fcmVwbGljYUxheWVyLmdldCgpOyB9CiAKICAgICAvLyBUaGVz ZSBtZXRob2RzIHR5cGljYWxseSBuZWVkIHRvIGJlIG92ZXJ3cml0dGVuIGJ5IGRlcml2ZWQgY2xh c3Nlcy4KICAgICB2aXJ0dWFsIGJvb2wgZHJhd3NDb250ZW50KCkgY29uc3QgeyByZXR1cm4gZmFs c2U7IH0KQEAgLTI3MSw3ICsyNzEsNyBAQCBwcml2YXRlOgogICAgIEZsb2F0UmVjdCBtX2ZyYW1l OwogCiAgICAgLy8gUmVwbGljYSBsYXllciB1c2VkIGZvciByZWZsZWN0aW9ucy4KLSAgICBMYXll ckNocm9taXVtKiBtX3JlcGxpY2FMYXllcjsKKyAgICBSZWZQdHI8TGF5ZXJDaHJvbWl1bT4gbV9y ZXBsaWNhTGF5ZXI7CiAKICAgICBTdHJpbmcgbV9uYW1lOwogfTsK