61890 2011-06-01 16:05:47 -0700 make-hash-tools.pl: Perl 5.14 compatibility 2011-07-18 10:15:45 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Minor --- 1 foutrelis abecsi abarth abecsi ademar a.radke benjamin eric gnome ossy webkit.review.bot oldest_to_newest 413733 0 95682 foutrelis 2011-06-01 16:05:47 -0700 Created attachment 95682 Patch for make-hash-tools.pl to use given/when instead of switch The make-hash-tools.pl script, executed during the build process, uses the Switch module which has been removed from Perl 5.14. In Arch Linux, we decided to patch make-hash-tools.pl to use the new given/when keywords available in Perl >= 5.10. I have attached our patch, which is quite trivial. However, you might want to retain compatibility with oder Perl versions, in which case a different patch will be needed (my Perl-fu is weak, and can't make a conditional dependency on either the Switch module or the new given/when syntax). Other reports of this issue: Gentoo: http://bugs.gentoo.org/show_bug.cgi?id=364489 FreeBSD: http://www.mail-archive.com/freebsd-ports@freebsd.org/msg33878.html 423605 1 abecsi 2011-06-20 05:11:15 -0700 (In reply to comment #0) > Created an attachment (id=95682) [details] > Patch for make-hash-tools.pl to use given/when instead of switch > > The make-hash-tools.pl script, executed during the build process, uses the Switch module which has been removed from Perl 5.14. > > In Arch Linux, we decided to patch make-hash-tools.pl to use the new given/when keywords available in Perl >= 5.10. I have attached our patch, which is quite trivial. However, you might want to retain compatibility with oder Perl versions, in which case a different patch will be needed (my Perl-fu is weak, and can't make a conditional dependency on either the Switch module or the new given/when syntax). > > Other reports of this issue: > > Gentoo: http://bugs.gentoo.org/show_bug.cgi?id=364489 > FreeBSD: http://www.mail-archive.com/freebsd-ports@freebsd.org/msg33878.html Because this is a generator script where performance is not an issue since, I think these could be simply changed to if/elif constructions, so we wouldn't need to worry about compatibility. 423612 2 ossy 2011-06-20 05:24:30 -0700 I agree with Andras, given/when can make <5.10 perl users unhappy, so if/elsif would be better here. 423618 3 97788 abecsi 2011-06-20 05:50:18 -0700 Created attachment 97788 proposed patch In addition to the previous comments, during the changes on the generation process only two options remained in this script so switch/case is overkill anyhow. 423619 4 97789 abecsi 2011-06-20 05:52:27 -0700 Created attachment 97789 proposed patch with newline 423621 5 97789 ossy 2011-06-20 05:59:24 -0700 Comment on attachment 97789 proposed patch with newline LGTM, r=me 423623 6 97789 webkit.review.bot 2011-06-20 06:01:12 -0700 Comment on attachment 97789 proposed patch with newline Rejecting attachment 97789 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 1 Last 500 characters of output: cripts/webkitpy/common/system/executive.py", line 382, in run_command close_fds=self._should_close_fds()) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 438, in popen return subprocess.Popen(*args, **kwargs) File "/usr/lib/python2.6/subprocess.py", line 623, in __init__ errread, errwrite) File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child raise child_exception TypeError: execv() arg 2 must contain only strings Full output: http://queues.webkit.org/results/8911496 423624 7 97789 ossy 2011-06-20 06:03:06 -0700 Comment on attachment 97789 proposed patch with newline One more attempt to cq+ 423626 8 97789 webkit.review.bot 2011-06-20 06:06:17 -0700 Comment on attachment 97789 proposed patch with newline Rejecting attachment 97789 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 1 Last 500 characters of output: cripts/webkitpy/common/system/executive.py", line 382, in run_command close_fds=self._should_close_fds()) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 438, in popen return subprocess.Popen(*args, **kwargs) File "/usr/lib/python2.6/subprocess.py", line 623, in __init__ errread, errwrite) File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child raise child_exception TypeError: execv() arg 2 must contain only strings Full output: http://queues.webkit.org/results/8907579 423628 9 ossy 2011-06-20 06:10:22 -0700 Eric, have you got any idea why CQ rejects this patch? 423788 10 eric 2011-06-20 11:18:53 -0700 No, but we saw one other such rejection the other day. Maybe one of the bots got sick. 423805 11 97789 abecsi 2011-06-20 11:36:33 -0700 Comment on attachment 97789 proposed patch with newline Let's have another try. 423806 12 97789 webkit.review.bot 2011-06-20 11:40:15 -0700 Comment on attachment 97789 proposed patch with newline Rejecting attachment 97789 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 1 Last 500 characters of output: cripts/webkitpy/common/system/executive.py", line 382, in run_command close_fds=self._should_close_fds()) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 438, in popen return subprocess.Popen(*args, **kwargs) File "/usr/lib/python2.6/subprocess.py", line 623, in __init__ errread, errwrite) File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child raise child_exception TypeError: execv() arg 2 must contain only strings Full output: http://queues.webkit.org/results/8885010 423815 13 97789 abecsi 2011-06-20 11:51:21 -0700 Comment on attachment 97789 proposed patch with newline Clearing flags on attachment: 97789 Committed r89265: <http://trac.webkit.org/changeset/89265> 423816 14 abecsi 2011-06-20 11:51:28 -0700 All reviewed patches have been landed. Closing bug. 423818 15 eric 2011-06-20 11:53:36 -0700 I think our handling of Ossy's name is broken again. 95682 2011-06-01 16:05:47 -0700 2011-06-20 05:50:18 -0700 Patch for make-hash-tools.pl to use given/when instead of switch replace-switch-with-given-when.patch text/plain 1376 foutrelis ZGlmZiAtdXByIHdlYmtpdC0xLjQuMC5vcmlnL1NvdXJjZS9XZWJDb3JlL21ha2UtaGFzaC10b29s cy5wbCB3ZWJraXQtMS40LjAvU291cmNlL1dlYkNvcmUvbWFrZS1oYXNoLXRvb2xzLnBsCi0tLSB3 ZWJraXQtMS40LjAub3JpZy9Tb3VyY2UvV2ViQ29yZS9tYWtlLWhhc2gtdG9vbHMucGwJMjAxMS0w NC0yNSAyMjoyNzoxNS4wMDAwMDAwMDAgKzAzMDAKKysrIHdlYmtpdC0xLjQuMC9Tb3VyY2UvV2Vi Q29yZS9tYWtlLWhhc2gtdG9vbHMucGwJMjAxMS0wNi0wMiAwMDo0MToyNi4wMDAwMDAwMDAgKzAz MDAKQEAgLTIwLDcgKzIwLDcgQEAKICMgICBCb3N0b24sIE1BIDAyMTEwLTEzMDEsIFVTQS4KIAog dXNlIHN0cmljdDsKLXVzZSBTd2l0Y2g7Cit1c2UgZmVhdHVyZSAnc3dpdGNoJzsKIHVzZSBGaWxl OjpCYXNlbmFtZTsKIAogbXkgJG91dGRpciA9ICRBUkdWWzBdOwpAQCAtMjgsOSArMjgsOSBAQCBz aGlmdDsKIG15ICRvcHRpb24gPSBiYXNlbmFtZSgkQVJHVlswXSwiLmdwZXJmIik7CiAKIAotc3dp dGNoICgkb3B0aW9uKSB7CitnaXZlbiAoJG9wdGlvbikgewogCi1jYXNlICJEb2NUeXBlU3RyaW5n cyIgeword2hlbiAoIkRvY1R5cGVTdHJpbmdzIikgewogCiAgICAgbXkgJGRvY1R5cGVTdHJpbmdz R2VuZXJhdGVkICAgID0gIiRvdXRkaXIvRG9jVHlwZVN0cmluZ3MuY3BwIjsKICAgICBteSAkZG9j VHlwZVN0cmluZ3NHcGVyZiAgICAgICAgPSAkQVJHVlswXTsKQEAgLTM4LDkgKzM4LDkgQEAgY2Fz ZSAiRG9jVHlwZVN0cmluZ3MiIHsKIAogICAgIHN5c3RlbSgiZ3BlcmYgLS1rZXktcG9zaXRpb25z PVwiKlwiIC1zIDIgJGRvY1R5cGVTdHJpbmdzR3BlcmYgPiAkZG9jVHlwZVN0cmluZ3NHZW5lcmF0 ZWQiKSA9PSAwIHx8IGRpZSAiY2FsbGluZyBncGVyZiBmYWlsZWQ6ICQ/IjsKIAotfSAjIGNhc2Ug IkRvY1R5cGVTdHJpbmdzIgorfSAjIHdoZW4gKCJEb2NUeXBlU3RyaW5ncyIpCiAKLWNhc2UgIkNv bG9yRGF0YSIgeword2hlbiAoIkNvbG9yRGF0YSIpIHsKIAogICAgIG15ICRjb2xvckRhdGFHZW5l cmF0ZWQgICAgICAgICA9ICIkb3V0ZGlyL0NvbG9yRGF0YS5jcHAiOwogICAgIG15ICRjb2xvckRh dGFHcGVyZiAgICAgICAgICAgICA9ICRBUkdWWzBdOwpAQCAtNDgsNiArNDgsNiBAQCBjYXNlICJD b2xvckRhdGEiIHsKIAogICAgIHN5c3RlbSgiZ3BlcmYgLS1rZXktcG9zaXRpb25zPVwiKlwiIC1E IC1zIDIgJGNvbG9yRGF0YUdwZXJmID4gJGNvbG9yRGF0YUdlbmVyYXRlZCIpID09IDAgfHwgZGll ICJjYWxsaW5nIGdwZXJmIGZhaWxlZDogJD8iOwogCi19ICMgY2FzZSAiQ29sb3JEYXRhIgorfSAj IHdoZW4gKCJDb2xvckRhdGEiKQogCi19ICMgc3dpdGNoICgkb3B0aW9uKQorfSAjIGdpdmVuICgk b3B0aW9uKQo= 97788 2011-06-20 05:50:18 -0700 2011-06-20 05:52:27 -0700 proposed patch makehashtools.patch text/plain 1810 abecsi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwYmMxM2M4Li5mZjA4YzI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDYtMjAgIEFuZHJhcyBCZWNzaSAgPGFiZWNzaUB3ZWJraXQub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIG1ha2UtaGFzaC10b29s cy5wbDogUGVybCA1LjE0IGNvbXBhdGliaWxpdHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTYxODkwCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRl ZC4KKworICAgICAgICAqIG1ha2UtaGFzaC10b29scy5wbDogVXNlIGlmL2Vsc2lmIGluc3RlYWQg b2Ygc3dpdGNoL2Nhc2UuCisKIDIwMTEtMDYtMTkgIE1hZHMgQWdlciAgPGFnZXJAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9tYWtlLWhhc2gtdG9vbHMucGwgYi9Tb3VyY2UvV2ViQ29yZS9tYWtlLWhhc2gt dG9vbHMucGwKaW5kZXggMzc2MzllYi4uOWQwNWE3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvbWFrZS1oYXNoLXRvb2xzLnBsCisrKyBiL1NvdXJjZS9XZWJDb3JlL21ha2UtaGFzaC10b29s cy5wbApAQCAtMjAsNyArMjAsNiBAQAogIyAgIEJvc3RvbiwgTUEgMDIxMTAtMTMwMSwgVVNBLgog CiB1c2Ugc3RyaWN0OwotdXNlIFN3aXRjaDsKIHVzZSBGaWxlOjpCYXNlbmFtZTsKIAogbXkgJG91 dGRpciA9ICRBUkdWWzBdOwpAQCAtMjgsOSArMjcsNyBAQCBzaGlmdDsKIG15ICRvcHRpb24gPSBi YXNlbmFtZSgkQVJHVlswXSwiLmdwZXJmIik7CiAKIAotc3dpdGNoICgkb3B0aW9uKSB7Ci0KLWNh c2UgIkRvY1R5cGVTdHJpbmdzIiB7CitpZiAoJG9wdGlvbiBlcSAiRG9jVHlwZVN0cmluZ3MiKSB7 CiAKICAgICBteSAkZG9jVHlwZVN0cmluZ3NHZW5lcmF0ZWQgICAgPSAiJG91dGRpci9Eb2NUeXBl U3RyaW5ncy5jcHAiOwogICAgIG15ICRkb2NUeXBlU3RyaW5nc0dwZXJmICAgICAgICA9ICRBUkdW WzBdOwpAQCAtMzgsOSArMzUsNyBAQCBjYXNlICJEb2NUeXBlU3RyaW5ncyIgewogCiAgICAgc3lz dGVtKCJncGVyZiAtLWtleS1wb3NpdGlvbnM9XCIqXCIgLXMgMiAkZG9jVHlwZVN0cmluZ3NHcGVy ZiA+ICRkb2NUeXBlU3RyaW5nc0dlbmVyYXRlZCIpID09IDAgfHwgZGllICJjYWxsaW5nIGdwZXJm IGZhaWxlZDogJD8iOwogCi19ICMgY2FzZSAiRG9jVHlwZVN0cmluZ3MiCi0KLWNhc2UgIkNvbG9y RGF0YSIgeworfSBlbHNpZiAoJG9wdGlvbiBlcSAiQ29sb3JEYXRhIikgewogCiAgICAgbXkgJGNv bG9yRGF0YUdlbmVyYXRlZCAgICAgICAgID0gIiRvdXRkaXIvQ29sb3JEYXRhLmNwcCI7CiAgICAg bXkgJGNvbG9yRGF0YUdwZXJmICAgICAgICAgICAgID0gJEFSR1ZbMF07CkBAIC00OCw2ICs0Myw2 IEBAIGNhc2UgIkNvbG9yRGF0YSIgewogCiAgICAgc3lzdGVtKCJncGVyZiAtLWtleS1wb3NpdGlv bnM9XCIqXCIgLUQgLXMgMiAkY29sb3JEYXRhR3BlcmYgPiAkY29sb3JEYXRhR2VuZXJhdGVkIikg PT0gMCB8fCBkaWUgImNhbGxpbmcgZ3BlcmYgZmFpbGVkOiAkPyI7CiAKLX0gIyBjYXNlICJDb2xv ckRhdGEiCi0KLX0gIyBzd2l0Y2ggKCRvcHRpb24pCit9IGVsc2UgeworICAgIGRpZSAiVW5rbm93 biBvcHRpb24uIjsKK30KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCg== 97789 2011-06-20 05:52:27 -0700 2011-06-20 11:51:21 -0700 proposed patch with newline makehashtools.patch text/plain 1782 abecsi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwYmMxM2M4Li5mZjA4YzI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDYtMjAgIEFuZHJhcyBCZWNzaSAgPGFiZWNzaUB3ZWJraXQub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIG1ha2UtaGFzaC10b29s cy5wbDogUGVybCA1LjE0IGNvbXBhdGliaWxpdHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTYxODkwCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRl ZC4KKworICAgICAgICAqIG1ha2UtaGFzaC10b29scy5wbDogVXNlIGlmL2Vsc2lmIGluc3RlYWQg b2Ygc3dpdGNoL2Nhc2UuCisKIDIwMTEtMDYtMTkgIE1hZHMgQWdlciAgPGFnZXJAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9tYWtlLWhhc2gtdG9vbHMucGwgYi9Tb3VyY2UvV2ViQ29yZS9tYWtlLWhhc2gt dG9vbHMucGwKaW5kZXggMzc2MzllYi4uMjgxMmNlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvbWFrZS1oYXNoLXRvb2xzLnBsCisrKyBiL1NvdXJjZS9XZWJDb3JlL21ha2UtaGFzaC10b29s cy5wbApAQCAtMjAsNyArMjAsNiBAQAogIyAgIEJvc3RvbiwgTUEgMDIxMTAtMTMwMSwgVVNBLgog CiB1c2Ugc3RyaWN0OwotdXNlIFN3aXRjaDsKIHVzZSBGaWxlOjpCYXNlbmFtZTsKIAogbXkgJG91 dGRpciA9ICRBUkdWWzBdOwpAQCAtMjgsOSArMjcsNyBAQCBzaGlmdDsKIG15ICRvcHRpb24gPSBi YXNlbmFtZSgkQVJHVlswXSwiLmdwZXJmIik7CiAKIAotc3dpdGNoICgkb3B0aW9uKSB7Ci0KLWNh c2UgIkRvY1R5cGVTdHJpbmdzIiB7CitpZiAoJG9wdGlvbiBlcSAiRG9jVHlwZVN0cmluZ3MiKSB7 CiAKICAgICBteSAkZG9jVHlwZVN0cmluZ3NHZW5lcmF0ZWQgICAgPSAiJG91dGRpci9Eb2NUeXBl U3RyaW5ncy5jcHAiOwogICAgIG15ICRkb2NUeXBlU3RyaW5nc0dwZXJmICAgICAgICA9ICRBUkdW WzBdOwpAQCAtMzgsOSArMzUsNyBAQCBjYXNlICJEb2NUeXBlU3RyaW5ncyIgewogCiAgICAgc3lz dGVtKCJncGVyZiAtLWtleS1wb3NpdGlvbnM9XCIqXCIgLXMgMiAkZG9jVHlwZVN0cmluZ3NHcGVy ZiA+ICRkb2NUeXBlU3RyaW5nc0dlbmVyYXRlZCIpID09IDAgfHwgZGllICJjYWxsaW5nIGdwZXJm IGZhaWxlZDogJD8iOwogCi19ICMgY2FzZSAiRG9jVHlwZVN0cmluZ3MiCi0KLWNhc2UgIkNvbG9y RGF0YSIgeworfSBlbHNpZiAoJG9wdGlvbiBlcSAiQ29sb3JEYXRhIikgewogCiAgICAgbXkgJGNv bG9yRGF0YUdlbmVyYXRlZCAgICAgICAgID0gIiRvdXRkaXIvQ29sb3JEYXRhLmNwcCI7CiAgICAg bXkgJGNvbG9yRGF0YUdwZXJmICAgICAgICAgICAgID0gJEFSR1ZbMF07CkBAIC00OCw2ICs0Myw2 IEBAIGNhc2UgIkNvbG9yRGF0YSIgewogCiAgICAgc3lzdGVtKCJncGVyZiAtLWtleS1wb3NpdGlv bnM9XCIqXCIgLUQgLXMgMiAkY29sb3JEYXRhR3BlcmYgPiAkY29sb3JEYXRhR2VuZXJhdGVkIikg PT0gMCB8fCBkaWUgImNhbGxpbmcgZ3BlcmYgZmFpbGVkOiAkPyI7CiAKLX0gIyBjYXNlICJDb2xv ckRhdGEiCi0KLX0gIyBzd2l0Y2ggKCRvcHRpb24pCit9IGVsc2UgeworICAgIGRpZSAiVW5rbm93 biBvcHRpb24uIjsKK30K