61882 2011-06-01 13:39:25 -0700 [CG] GraphicsContext::fillRoundedRect() ignores the gradient fill the CGContextFillEllipseInRect() code path 2011-06-02 03:04:50 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser webkit-unassigned commit-queue ian oldest_to_newest 413628 0 simon.fraser 2011-06-01 13:39:25 -0700 The CGContextFillEllipseInRect() fast path in GraphicsContext::fillRoundedRect() doesn't go through GraphicsContext::fillPath(), so ignores the gradient fill style. I don't think this code path can be hit via canvas or CG, but we should fix it anyway. Regressed in bug 58098. 413643 1 95657 ian 2011-06-01 14:00:58 -0700 Created attachment 95657 proposed patch 414015 2 95657 commit-queue 2011-06-02 03:04:46 -0700 Comment on attachment 95657 proposed patch Clearing flags on attachment: 95657 Committed r87887: <http://trac.webkit.org/changeset/87887> 414016 3 commit-queue 2011-06-02 03:04:50 -0700 All reviewed patches have been landed. Closing bug. 95657 2011-06-01 14:00:58 -0700 2011-06-02 03:04:46 -0700 proposed patch 61882-1.patch text/plain 1915 ian SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg3ODQyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDYtMDEgIElhbiBIZW5k ZXJzb24gIDxpYW5oQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBbQ0ddIEdyYXBoaWNzQ29udGV4dDo6ZmlsbFJvdW5kZWRSZWN0KCkg aWdub3JlcyB0aGUgZ3JhZGllbnQgZmlsbCB0aGUgQ0dDb250ZXh0RmlsbEVsbGlwc2VJblJlY3Qo KSBjb2RlIHBhdGgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTYxODgyCisKKyAgICAgICAgSWYgd2UgaGF2ZSBhIGdyYWRpZW50IG9yIHBhdHRlcm4gZmls bCBzZXQsIHRha2UgdGhlIHNsb3cgcGF0aCwgd2hpY2gKKyAgICAgICAgaGFuZGxlcyB0aGVzZSBj YXNlcyBwcm9wZXJseS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHNpbmNlIHdlIG5ldmVyIHRy eSB0byBmaWxsIGEgcm91bmRlZCByZWN0IHdpdGggYQorICAgICAgICBncmFkaWVudCBvciBwYXR0 ZXJuLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0Q0cu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0OjpmaWxsUm91bmRlZFJlY3Qp OgorCiAyMDExLTA2LTAxICBMZXZpIFdlaW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29udGV4dENHLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9HcmFwaGljc0NvbnRleHRDRy5jcHAJ KHJldmlzaW9uIDg3ODQwKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cv R3JhcGhpY3NDb250ZXh0Q0cuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NzAsNyArNzcwLDggQEAK IAogICAgIGJvb2wgZXF1YWxXaWR0aHMgPSAodG9wTGVmdC53aWR0aCgpID09IHRvcFJpZ2h0Lndp ZHRoKCkgJiYgdG9wUmlnaHQud2lkdGgoKSA9PSBib3R0b21MZWZ0LndpZHRoKCkgJiYgYm90dG9t TGVmdC53aWR0aCgpID09IGJvdHRvbVJpZ2h0LndpZHRoKCkpOwogICAgIGJvb2wgZXF1YWxIZWln aHRzID0gKHRvcExlZnQuaGVpZ2h0KCkgPT0gYm90dG9tTGVmdC5oZWlnaHQoKSAmJiBib3R0b21M ZWZ0LmhlaWdodCgpID09IHRvcFJpZ2h0LmhlaWdodCgpICYmIHRvcFJpZ2h0LmhlaWdodCgpID09 IGJvdHRvbVJpZ2h0LmhlaWdodCgpKTsKLSAgICBpZiAoZXF1YWxXaWR0aHMgJiYgZXF1YWxIZWln aHRzICYmIHRvcExlZnQud2lkdGgoKSAqIDIgPT0gcmVjdC53aWR0aCgpICYmIHRvcExlZnQuaGVp Z2h0KCkgKiAyID09IHJlY3QuaGVpZ2h0KCkpCisgICAgYm9vbCBoYXNDdXN0b21GaWxsID0gbV9z dGF0ZS5maWxsR3JhZGllbnQgfHwgbV9zdGF0ZS5maWxsUGF0dGVybjsKKyAgICBpZiAoIWhhc0N1 c3RvbUZpbGwgJiYgZXF1YWxXaWR0aHMgJiYgZXF1YWxIZWlnaHRzICYmIHRvcExlZnQud2lkdGgo KSAqIDIgPT0gcmVjdC53aWR0aCgpICYmIHRvcExlZnQuaGVpZ2h0KCkgKiAyID09IHJlY3QuaGVp Z2h0KCkpCiAgICAgICAgIENHQ29udGV4dEZpbGxFbGxpcHNlSW5SZWN0KGNvbnRleHQsIHJlY3Qp OwogICAgIGVsc2UgewogICAgICAgICBQYXRoIHBhdGg7Cg==