<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>61881</bug_id>
          
          <creation_ts>2011-06-01 13:32:26 -0700</creation_ts>
          <short_desc>gyp_webkit reports errors when advancing chromium_rev past version 87140</short_desc>
          <delta_ts>2011-06-02 10:41:11 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Aaron Colwell">acolwell</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>dglazkov</cc>
    
    <cc>eric</cc>
    
    <cc>evan</cc>
    
    <cc>levin</cc>
    
    <cc>thakis</cc>
    
    <cc>tony</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>413620</commentid>
    <comment_count>0</comment_count>
    <who name="Aaron Colwell">acolwell</who>
    <bug_when>2011-06-01 13:32:26 -0700</bug_when>
    <thetext>A change was made in chromium version 87140 that breaks the WebKit build if you try to advance chromium_rev in Source/WebKit/chromium/DEPS past this version. A patch will be submitted shortly to bring gyp_webkit in line with the changes made to gyp_chromium.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>413624</commentid>
    <comment_count>1</comment_count>
    <who name="Aaron Colwell">acolwell</who>
    <bug_when>2011-06-01 13:37:07 -0700</bug_when>
    <thetext>Original Chromium bug http://code.google.com/p/chromium/issues/detail?id=84611</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>413627</commentid>
    <comment_count>2</comment_count>
      <attachid>95652</attachid>
    <who name="Aaron Colwell">acolwell</who>
    <bug_when>2011-06-01 13:38:40 -0700</bug_when>
    <thetext>Created attachment 95652
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>414187</commentid>
    <comment_count>3</comment_count>
    <who name="Aaron Colwell">acolwell</who>
    <bug_when>2011-06-02 09:27:37 -0700</bug_when>
    <thetext>ping. C</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>414190</commentid>
    <comment_count>4</comment_count>
    <who name="Nico Weber">thakis</who>
    <bug_when>2011-06-02 09:30:41 -0700</bug_when>
    <thetext>This change is correct – lgtm.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>414191</commentid>
    <comment_count>5</comment_count>
      <attachid>95652</attachid>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2011-06-02 09:31:33 -0700</bug_when>
    <thetext>Comment on attachment 95652
Patch

I HAZ RUBBER STAMP.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>414195</commentid>
    <comment_count>6</comment_count>
    <who name="Aaron Colwell">acolwell</who>
    <bug_when>2011-06-02 09:36:57 -0700</bug_when>
    <thetext>Thanks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>414251</commentid>
    <comment_count>7</comment_count>
      <attachid>95652</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-06-02 10:41:05 -0700</bug_when>
    <thetext>Comment on attachment 95652
Patch

Clearing flags on attachment: 95652

Committed r87927: &lt;http://trac.webkit.org/changeset/87927&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>414253</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-06-02 10:41:11 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>95652</attachid>
            <date>2011-06-01 13:38:40 -0700</date>
            <delta_ts>2011-06-02 10:41:05 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-61881-20110601133838.patch</filename>
            <type>text/plain</type>
            <size>1514</size>
            <attacher name="Aaron Colwell">acolwell</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODc4NDAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy
b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg
MGEzYTFkODBjODM1ZWUzZjNlOWVkMjhjYmNkNmJlYzRlM2FlMjMwMC4uYWEwZWJmOGY3OTY3OThl
YjQ3ODFlNWNjY2NhZDNhOTRkMGFhZjc1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv
bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg
LTEsMyArMSwxNCBAQAorMjAxMS0wNi0wMSAgQWFyb24gQ29sd2VsbCAgPGFjb2x3ZWxsQGNocm9t
aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICBCcmluZyBneXBfd2Via2l0IHVwIHRvIGRhdGUgd2l0aCBjaGFuZ2VzIG1hZGUgdG8KKyAgICAg
ICAgZ3lwX2Nocm9taXVtIHNvIGNocm9taXVtX3JldiBjYW4gYmUgYWR2YW5jZWQgcGFzdAorICAg
ICAgICByZXZpc2lvbiA4NzE0MC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTYxODgxCisKKyAgICAgICAgKiBneXBfd2Via2l0OgorCiAyMDExLTA2LTAx
ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBV
bnJldmlld2VkLCByb2xsaW5nIG91dCByODc3ODguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0
L2Nocm9taXVtL2d5cF93ZWJraXQgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL2d5cF93ZWJraXQK
aW5kZXggNzY4YWNhY2VlNDRmYmVhOTU2MzU5YmFiNjcyYWM5Njg0Yjk2ZTI5NC4uMTg5ZGI1ZTU5
N2E2Njk4ZDA5ZDM4MDZjNWRkMTc2OTFhM2ZmMDZmMyAxMDA3NTUKLS0tIGEvU291cmNlL1dlYktp
dC9jaHJvbWl1bS9neXBfd2Via2l0CisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZ3lwX3dl
YmtpdApAQCAtMzYsMTAgKzM2LDE0IEBAIGltcG9ydCBzaGxleAogaW1wb3J0IHN5cwogCiBzY3Jp
cHRfZGlyID0gb3MucGF0aC5kaXJuYW1lKF9fZmlsZV9fKQorY2hyb21lX3NyYyA9IG9zLnBhdGgu
YWJzcGF0aChzY3JpcHRfZGlyKQogCi1zeXMucGF0aC5hcHBlbmQob3MucGF0aC5qb2luKHNjcmlw
dF9kaXIsICd0b29scycsICdneXAnLCAncHlsaWInKSkKK3N5cy5wYXRoLmluc2VydCgwLCBvcy5w
YXRoLmpvaW4oY2hyb21lX3NyYywgJ3Rvb2xzJywgJ2d5cCcsICdweWxpYicpKQogaW1wb3J0IGd5
cAogCisjIEFkZCB0b29scy9ncml0IHNvIHRoYXQgcHltb2RfZG9fbWFpbihncml0X2luZm8gLi4u
KSBjYW4gZmluZCBncml0X2luZm8ucHkuCitzeXMucGF0aC5pbnNlcnQoMSwgb3MucGF0aC5qb2lu
KGNocm9tZV9zcmMsICd0b29scycsICdncml0JykpCisKIGRlZiBhZGRpdGlvbmFsX2luY2x1ZGVf
ZmlsZXMoYXJncz1bXSk6CiAgICIiIgogICBSZXR1cm5zIGEgbGlzdCBvZiBhZGRpdGlvbmFsICgu
Z3lwaSkgZmlsZXMgdG8gaW5jbHVkZSwgd2l0aG91dAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>