61879 2011-06-01 12:59:07 -0700 Add single character lookup cache to IdentifierArena 2011-06-01 13:11:43 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver oldest_to_newest 413599 0 oliver 2011-06-01 12:59:07 -0700 Add single character lookup cache to IdentifierArena 413600 1 95646 oliver 2011-06-01 13:00:29 -0700 Created attachment 95646 Patch 413603 2 95646 ggaren 2011-06-01 13:07:09 -0700 Comment on attachment 95646 Patch r=me 413604 3 oliver 2011-06-01 13:10:00 -0700 Committed r87838: <http://trac.webkit.org/changeset/87838> 413606 4 95646 aroben 2011-06-01 13:11:43 -0700 Comment on attachment 95646 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95646&action=review > Source/JavaScriptCore/parser/ParserArena.h:51 > + for (unsigned i = 0; i < 128; i++) You should use the constant! And maybe size_t. > Source/JavaScriptCore/parser/ParserArena.h:57 > + static const int MaximumCachableCharacter = 128; Missing an "e" in there: "cacheable". 95646 2011-06-01 13:00:29 -0700 2011-06-01 13:11:43 -0700 Patch bug-61879-20110601130028.patch text/plain 2802 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogODc4MjYKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDZi Mjg0OWM5NTk4MWFjOTFjMjQwODdlZTQ5YzU0NzkwNWI4NzBjOWEuLjI1MmFjMzBlYThlODdjNzYx ODE4ZDMyYzAyNWE4ZjlkYzEzNGJhZDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE5IEBACisyMDExLTA2LTAxICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHNpbmds ZSBjaGFyYWN0ZXIgbG9va3VwIGNhY2hlIHRvIElkZW50aWZpZXJBcmVuYQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjE4NzkKKworICAgICAgICBBZGQg YSBzaW1wbGUgbG9va3VwIGNhY2hlIGZvciBzaW5nbGUgYXNjaWkgY2hhcmFjdGVyCisgICAgICAg IGlkZW50aWZpZXJzLiAgUHJvZHVjZXMgYXJvdW5kIGEgMiUgaW1wcm92ZW1lbnQgaW4gcGFyc2UK KyAgICAgICAgdGltZSBmb3IgbXkgYWRob2MgcGFyc2VyIHRlc3QuCisKKyAgICAgICAgKiBwYXJz ZXIvUGFyc2VyQXJlbmEuaDoKKyAgICAgICAgKEpTQzo6SWRlbnRpZmllckFyZW5hOjpJZGVudGlm aWVyQXJlbmEpOgorICAgICAgICAoSlNDOjpJZGVudGlmaWVyQXJlbmE6OmNsZWFyKToKKyAgICAg ICAgKEpTQzo6SWRlbnRpZmllckFyZW5hOjptYWtlSWRlbnRpZmllcik6CisKIDIwMTEtMDUtMzEg IE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBH ZW9mZnJleSBHYXJlbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIv UGFyc2VyQXJlbmEuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyQXJlbmEu aAppbmRleCA4MmZiODA4NTRkOGYwZjViOGJjOTUyMjc1YmMyN2NhNjAwNDdhMTUxLi4xNTYzZTQ5 OGY0MTZjZWYwMGMzY2I5ZmZmM2I2YTUyNDI2YmEzNzk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlckFyZW5hLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3BhcnNlci9QYXJzZXJBcmVuYS5oCkBAIC0zNywxOSArMzcsMzggQEAgbmFtZXNwYWNlIEpT QyB7CiAgICAgY2xhc3MgSWRlbnRpZmllckFyZW5hIHsKICAgICAgICAgV1RGX01BS0VfRkFTVF9B TExPQ0FURUQ7CiAgICAgcHVibGljOgorICAgICAgICBJZGVudGlmaWVyQXJlbmEoKQorICAgICAg ICB7CisgICAgICAgICAgICBjbGVhcigpOworICAgICAgICB9CisKICAgICAgICAgQUxXQVlTX0lO TElORSBjb25zdCBJZGVudGlmaWVyJiBtYWtlSWRlbnRpZmllcihKU0dsb2JhbERhdGEqLCBjb25z dCBVQ2hhciogY2hhcmFjdGVycywgc2l6ZV90IGxlbmd0aCk7CiAgICAgICAgIGNvbnN0IElkZW50 aWZpZXImIG1ha2VOdW1lcmljSWRlbnRpZmllcihKU0dsb2JhbERhdGEqLCBkb3VibGUgbnVtYmVy KTsKIAotICAgICAgICB2b2lkIGNsZWFyKCkgeyBtX2lkZW50aWZpZXJzLmNsZWFyKCk7IH0KKyAg ICAgICAgdm9pZCBjbGVhcigpCisgICAgICAgIHsKKyAgICAgICAgICAgIG1faWRlbnRpZmllcnMu Y2xlYXIoKTsKKyAgICAgICAgICAgIGZvciAodW5zaWduZWQgIGkgPSAwOyBpIDwgMTI4OyBpKysp CisgICAgICAgICAgICAgICAgbV9zaG9ydElkZW50aWZpZXJzW2ldID0gMDsKKyAgICAgICAgfQog ICAgICAgICBib29sIGlzRW1wdHkoKSBjb25zdCB7IHJldHVybiBtX2lkZW50aWZpZXJzLmlzRW1w dHkoKTsgfQogCiAgICAgcHJpdmF0ZToKKyAgICAgICAgc3RhdGljIGNvbnN0IGludCBNYXhpbXVt Q2FjaGFibGVDaGFyYWN0ZXIgPSAxMjg7CiAgICAgICAgIHR5cGVkZWYgU2VnbWVudGVkVmVjdG9y PElkZW50aWZpZXIsIDY0PiBJZGVudGlmaWVyVmVjdG9yOwogICAgICAgICBJZGVudGlmaWVyVmVj dG9yIG1faWRlbnRpZmllcnM7CisgICAgICAgIEZpeGVkQXJyYXk8SWRlbnRpZmllciosIE1heGlt dW1DYWNoYWJsZUNoYXJhY3Rlcj4gbV9zaG9ydElkZW50aWZpZXJzOwogICAgIH07CiAKICAgICBB TFdBWVNfSU5MSU5FIGNvbnN0IElkZW50aWZpZXImIElkZW50aWZpZXJBcmVuYTo6bWFrZUlkZW50 aWZpZXIoSlNHbG9iYWxEYXRhKiBnbG9iYWxEYXRhLCBjb25zdCBVQ2hhciogY2hhcmFjdGVycywg c2l6ZV90IGxlbmd0aCkKICAgICB7CisgICAgICAgIGlmIChsZW5ndGggPT0gMSAmJiBjaGFyYWN0 ZXJzWzBdIDwgTWF4aW11bUNhY2hhYmxlQ2hhcmFjdGVyKSB7CisgICAgICAgICAgICBpZiAoSWRl bnRpZmllciogaWRlbnQgPSBtX3Nob3J0SWRlbnRpZmllcnNbY2hhcmFjdGVyc1swXV0pCisgICAg ICAgICAgICAgICAgcmV0dXJuICppZGVudDsKKyAgICAgICAgICAgIG1faWRlbnRpZmllcnMuYXBw ZW5kKElkZW50aWZpZXIoZ2xvYmFsRGF0YSwgY2hhcmFjdGVycywgbGVuZ3RoKSk7CisgICAgICAg ICAgICBtX3Nob3J0SWRlbnRpZmllcnNbY2hhcmFjdGVyc1swXV0gPSAmbV9pZGVudGlmaWVycy5s YXN0KCk7CisgICAgICAgICAgICByZXR1cm4gbV9pZGVudGlmaWVycy5sYXN0KCk7CisgICAgICAg IH0KICAgICAgICAgbV9pZGVudGlmaWVycy5hcHBlbmQoSWRlbnRpZmllcihnbG9iYWxEYXRhLCBj aGFyYWN0ZXJzLCBsZW5ndGgpKTsKICAgICAgICAgcmV0dXJuIG1faWRlbnRpZmllcnMubGFzdCgp OwogICAgIH0K