61876 2011-06-01 12:03:00 -0700 Add IntPoint + IntPoint operator 2019-05-02 16:25:30 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 leviw leviw ap commit-queue darin eae eric mjs morrita simon.fraser vivekjkumar266 oldest_to_newest 413561 0 leviw 2011-06-01 12:03:00 -0700 There are a lot of places where it'd be really handy to add two IntPoints together to return an IntPoint, particularly as part of our move away from tx/ty int offsets. 413631 1 95653 leviw 2011-06-01 13:49:24 -0700 Created attachment 95653 Patch 413814 2 morrita 2011-06-01 18:43:00 -0700 (In reply to comment #1) > Created an attachment (id=95653) [details] > Patch Someone might say that adding two points doesn't make sense. In that case, another idea is to provide IntSize IntPoint::toSize(). There is no big difference though - it's a matter of preference... 413816 3 eae 2011-06-01 18:48:15 -0700 (In reply to comment #2) > Someone might say that adding two points doesn't make sense. > In that case, another idea is to provide IntSize IntPoint::toSize(). > There is no big difference though - it's a matter of preference... Strictly logically speaking you're right and this isn't ideal. Given that we use IntPoint as an offset in quite a few places though it would be very convenient to allow IntPoint + IntPoint. We already have a IntSize toSize(IntPoint) method but it adds extra overhead as it has to create a copy. 413820 4 95653 morrita 2011-06-01 18:51:42 -0700 Comment on attachment 95653 Patch Yeah, my last comment is as a logical troll ;-) I agree that this change is convenient and has no harm. 413821 5 eae 2011-06-01 18:52:27 -0700 :) 413846 6 leviw 2011-06-01 19:43:54 -0700 (In reply to comment #4) > (From update of attachment 95653 [details]) > Yeah, my last comment is as a logical troll ;-) > I agree that this change is convenient and has no harm. Thanks for the review :) 413897 7 95653 commit-queue 2011-06-01 21:51:21 -0700 Comment on attachment 95653 Patch Clearing flags on attachment: 95653 Committed r87878: <http://trac.webkit.org/changeset/87878> 413898 8 commit-queue 2011-06-01 21:51:26 -0700 All reviewed patches have been landed. Closing bug. 95653 2011-06-01 13:49:24 -0700 2011-06-01 21:51:21 -0700 Patch bug-61876-20110601134923.patch text/plain 2213 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg3ODQyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDYtMDEgIExldmkgV2Vp bnRyYXViICA8bGV2aXdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZCBJbnRQb2ludCArIEludFBvaW50IG9wZXJhdG9yCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTg3NgorCisg ICAgICAgIEFkZGluZyBhbiBvcGVyYXRvcisgY29udmVuaWVuY2UgbWV0aG9kIHRvIEludFBvaW50 IHRoYXQgc3VtcyB0d28gcG9pbnRzCisgICAgICAgIGFuZCByZXR1cm5zIHRoZSByZXN1bHQgYXMg YW4gSW50UG9pbnQuIENoYW5naW5nIGRvSW1hZ2VEcmFnIHRvIHVzZSBpdAorICAgICAgICBhcyBh IHByb29mIG9mIGNvbmNlcHQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHNpbmNlIHRoZXJlIGlz IG5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIHBhZ2UvRHJhZ0NvbnRyb2xsZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RHJhZ0NvbnRyb2xsZXI6OmRvSW1hZ2VEcmFnKToKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9JbnRQb2ludC5oOgorICAgICAgICAoV2ViQ29yZTo6 b3BlcmF0b3IrKToKKwogMjAxMS0wNi0wMSAgTGV2aSBXZWludHJhdWIgIDxsZXZpd0BjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9wYWdlL0RyYWdDb250cm9sbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9wYWdlL0RyYWdDb250cm9sbGVyLmNwcAkocmV2aXNpb24gODc4MjMpCisrKyBTb3VyY2Uv V2ViQ29yZS9wYWdlL0RyYWdDb250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODI1LDgg KzgyNSw3IEBAIHZvaWQgRHJhZ0NvbnRyb2xsZXI6OmRvSW1hZ2VEcmFnKEVsZW1lbnQKICAgICAg ICAgICAgIG9yaWdpbiA9IEludFBvaW50KERyYWdJY29uUmlnaHRJbnNldCAtIGRyYWdJbWFnZVNp emUoZHJhZ0ltYWdlKS53aWR0aCgpLCBEcmFnSWNvbkJvdHRvbUluc2V0KTsKICAgICB9CiAKLSAg ICBkcmFnSW1hZ2VPZmZzZXQuc2V0WChtb3VzZURvd25Qb2ludC54KCkgKyBvcmlnaW4ueCgpKTsK LSAgICBkcmFnSW1hZ2VPZmZzZXQuc2V0WShtb3VzZURvd25Qb2ludC55KCkgKyBvcmlnaW4ueSgp KTsKKyAgICBkcmFnSW1hZ2VPZmZzZXQgPSBtb3VzZURvd25Qb2ludCArIG9yaWdpbjsKICAgICBk b1N5c3RlbURyYWcoZHJhZ0ltYWdlLCBkcmFnSW1hZ2VPZmZzZXQsIGRyYWdPcmlnaW4sIGNsaXBi b2FyZCwgZnJhbWUsIGZhbHNlKTsKIAogICAgIGRlbGV0ZURyYWdJbWFnZShkcmFnSW1hZ2UpOwpJ bmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW50UG9pbnQuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbnRQb2ludC5oCShyZXZp c2lvbiA4NzgyMykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ludFBvaW50 LmgJKHdvcmtpbmcgY29weSkKQEAgLTE4MSw2ICsxODEsMTEgQEAgaW5saW5lIEludFBvaW50IG9w ZXJhdG9yKyhjb25zdCBJbnRQb2ludAogICAgIHJldHVybiBJbnRQb2ludChhLngoKSArIGIud2lk dGgoKSwgYS55KCkgKyBiLmhlaWdodCgpKTsKIH0KIAoraW5saW5lIEludFBvaW50IG9wZXJhdG9y Kyhjb25zdCBJbnRQb2ludCYgYSwgY29uc3QgSW50UG9pbnQmIGIpCit7CisgICAgcmV0dXJuIElu dFBvaW50KGEueCgpICsgYi54KCksIGEueSgpICsgYi55KCkpOworfQorCiBpbmxpbmUgSW50U2l6 ZSBvcGVyYXRvci0oY29uc3QgSW50UG9pbnQmIGEsIGNvbnN0IEludFBvaW50JiBiKQogewogICAg IHJldHVybiBJbnRTaXplKGEueCgpIC0gYi54KCksIGEueSgpIC0gYi55KCkpOwo=