61874 2011-06-01 11:35:17 -0700 Switch paintScrollCorner to use IntPoint 2011-06-01 14:59:10 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 leviw leviw darin eae eric simon.fraser oldest_to_newest 413540 0 leviw 2011-06-01 11:35:17 -0700 More tx/ty removal... 413557 1 95638 leviw 2011-06-01 11:54:09 -0700 Created attachment 95638 Patch 413571 2 95638 eric 2011-06-01 12:26:43 -0700 Comment on attachment 95638 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95638&action=review OK. > Source/WebCore/rendering/RenderLayer.cpp:2338 > + IntRect absRect = IntRect(cornerRect.x() + paintOffset.x(), cornerRect.y() + paintOffset.y(), cornerRect.width(), cornerRect.height()); This might be simpler as as IntRect absRect = cornerRect; absRect.move(paintOffset) 413590 3 95638 leviw 2011-06-01 12:35:37 -0700 Comment on attachment 95638 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95638&action=review >> Source/WebCore/rendering/RenderLayer.cpp:2338 >> + IntRect absRect = IntRect(cornerRect.x() + paintOffset.x(), cornerRect.y() + paintOffset.y(), cornerRect.width(), cornerRect.height()); > > This might be simpler as as IntRect absRect = cornerRect; absRect.move(paintOffset) Agreed! I'll change it and land. Thanks for the review! 413625 4 leviw 2011-06-01 13:38:25 -0700 Committed r87841: <http://trac.webkit.org/changeset/87841> 95638 2011-06-01 11:54:09 -0700 2011-06-01 14:59:10 -0700 Patch bug-61874-20110601115408.patch text/plain 4160 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg3ODMzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDYtMDEgIExldmkgV2Vp bnRyYXViICA8bGV2aXdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFN3aXRjaCBwYWludFNjcm9sbENvcm5lciB0byB1c2UgSW50 UG9pbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYx ODc0CisKKyAgICAgICAgQ2hhbmdpbmcgcGFpbnRTY3JvbGxDb3JuZXIgdG8gdGFrZSBhbiBJbnRQ b2ludCByZXByZXNlbnRpbmcgdGhlIHBhaW50CisgICAgICAgIG9mZnNldCBpbnN0ZWFkIG9mIGEg cGFpciBvZiBpbnRzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcyB0aGlzIGlzIHNpbXBsZSBy ZWZhY3RvcmluZy4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6cGFpbnRPdmVyZmxvd0NvbnRyb2xzKToKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpwYWludFNjcm9sbENvcm5lcik6CisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlckxheWVyLmg6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVy QmFja2luZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckJhY2tpbmc6OnBhaW50 Q29udGVudHMpOgorCiAyMDExLTA2LTAxICBBbmRyYXMgQmVjc2kgIDxhYmVjc2lAd2Via2l0Lm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBDc2FiYSBPc3p0cm9nb27DoWMuCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAJKHJldmlzaW9uIDg3ODI1KQorKysg U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMjMyMywxOSArMjMyMywxOSBAQCB2b2lkIFJlbmRlckxheWVyOjpwYWludE92ZXJmbG93Q29u dHJvbHMoCiAKICAgICAvLyBXZSBmaWxsIG91ciBzY3JvbGwgY29ybmVyIHdpdGggd2hpdGUgaWYg d2UgaGF2ZSBhIHNjcm9sbGJhciB0aGF0IGRvZXNuJ3QgcnVuIGFsbCB0aGUgd2F5IHVwIHRvIHRo ZQogICAgIC8vIGVkZ2Ugb2YgdGhlIGJveC4KLSAgICBwYWludFNjcm9sbENvcm5lcihjb250ZXh0 LCBvZmZzZXRYLCBvZmZzZXRZLCBkYW1hZ2VSZWN0KTsKKyAgICBwYWludFNjcm9sbENvcm5lcihj b250ZXh0LCBJbnRQb2ludChvZmZzZXRYLCBvZmZzZXRZKSwgZGFtYWdlUmVjdCk7CiAgICAgCiAg ICAgLy8gUGFpbnQgb3VyIHJlc2l6ZXIgbGFzdCwgc2luY2UgaXQgc2l0cyBvbiB0b3Agb2YgdGhl IHNjcm9sbCBjb3JuZXIuCiAgICAgcGFpbnRSZXNpemVyKGNvbnRleHQsIG9mZnNldFgsIG9mZnNl dFksIGRhbWFnZVJlY3QpOwogfQogCi12b2lkIFJlbmRlckxheWVyOjpwYWludFNjcm9sbENvcm5l cihHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsIGludCB0eCwgaW50IHR5LCBjb25zdCBJbnRSZWN0 JiBkYW1hZ2VSZWN0KQordm9pZCBSZW5kZXJMYXllcjo6cGFpbnRTY3JvbGxDb3JuZXIoR3JhcGhp Y3NDb250ZXh0KiBjb250ZXh0LCBjb25zdCBJbnRQb2ludCYgcGFpbnRPZmZzZXQsIGNvbnN0IElu dFJlY3QmIGRhbWFnZVJlY3QpCiB7CiAgICAgUmVuZGVyQm94KiBib3ggPSByZW5kZXJCb3goKTsK ICAgICBBU1NFUlQoYm94KTsKIAogICAgIEludFJlY3QgY29ybmVyUmVjdCA9IHNjcm9sbENvcm5l clJlY3QoKTsKLSAgICBJbnRSZWN0IGFic1JlY3QgPSBJbnRSZWN0KGNvcm5lclJlY3QueCgpICsg dHgsIGNvcm5lclJlY3QueSgpICsgdHksIGNvcm5lclJlY3Qud2lkdGgoKSwgY29ybmVyUmVjdC5o ZWlnaHQoKSk7CisgICAgSW50UmVjdCBhYnNSZWN0ID0gSW50UmVjdChjb3JuZXJSZWN0LngoKSAr IHBhaW50T2Zmc2V0LngoKSwgY29ybmVyUmVjdC55KCkgKyBwYWludE9mZnNldC55KCksIGNvcm5l clJlY3Qud2lkdGgoKSwgY29ybmVyUmVjdC5oZWlnaHQoKSk7CiAgICAgaWYgKCFhYnNSZWN0Lmlu dGVyc2VjdHMoZGFtYWdlUmVjdCkpCiAgICAgICAgIHJldHVybjsKIApAQCAtMjM0NSw3ICsyMzQ1 LDcgQEAgdm9pZCBSZW5kZXJMYXllcjo6cGFpbnRTY3JvbGxDb3JuZXIoR3JhcAogICAgIH0KIAog ICAgIGlmIChtX3Njcm9sbENvcm5lcikgewotICAgICAgICBtX3Njcm9sbENvcm5lci0+cGFpbnRJ bnRvUmVjdChjb250ZXh0LCB0eCwgdHksIGFic1JlY3QpOworICAgICAgICBtX3Njcm9sbENvcm5l ci0+cGFpbnRJbnRvUmVjdChjb250ZXh0LCBwYWludE9mZnNldC54KCksIHBhaW50T2Zmc2V0Lnko KSwgYWJzUmVjdCk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJMYXllci5oCShyZXZpc2lvbiA4NzgyNSkKKysrIFNvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNjIsNyArMjYy LDcgQEAgcHVibGljOgogICAgIEludFNpemUgb2Zmc2V0RnJvbVJlc2l6ZUNvcm5lcihjb25zdCBJ bnRQb2ludCYgYWJzb2x1dGVQb2ludCkgY29uc3Q7CiAKICAgICB2b2lkIHBhaW50T3ZlcmZsb3dD b250cm9scyhHcmFwaGljc0NvbnRleHQqLCBpbnQgdHgsIGludCB0eSwgY29uc3QgSW50UmVjdCYg ZGFtYWdlUmVjdCwgYm9vbCBwYWludGluZ092ZXJsYXlDb250cm9scyA9IGZhbHNlKTsKLSAgICB2 b2lkIHBhaW50U2Nyb2xsQ29ybmVyKEdyYXBoaWNzQ29udGV4dCosIGludCB0eCwgaW50IHR5LCBj b25zdCBJbnRSZWN0JiBkYW1hZ2VSZWN0KTsKKyAgICB2b2lkIHBhaW50U2Nyb2xsQ29ybmVyKEdy YXBoaWNzQ29udGV4dCosIGNvbnN0IEludFBvaW50JiwgY29uc3QgSW50UmVjdCYgZGFtYWdlUmVj dCk7CiAgICAgdm9pZCBwYWludFJlc2l6ZXIoR3JhcGhpY3NDb250ZXh0KiwgaW50IHR4LCBpbnQg dHksIGNvbnN0IEludFJlY3QmIGRhbWFnZVJlY3QpOwogCiAgICAgdm9pZCB1cGRhdGVTY3JvbGxJ bmZvQWZ0ZXJMYXlvdXQoKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJM YXllckJhY2tpbmcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJMYXllckJhY2tpbmcuY3BwCShyZXZpc2lvbiA4NzgyNSkKKysrIFNvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjM2 LDcgKzEyMzYsNyBAQCB2b2lkIFJlbmRlckxheWVyQmFja2luZzo6cGFpbnRDb250ZW50cyhjCiAg ICAgICAgIGNvbnRleHQudHJhbnNsYXRlKC1zY3JvbGxDb3JuZXJBbmRSZXNpemVyLngoKSwgLXNj cm9sbENvcm5lckFuZFJlc2l6ZXIueSgpKTsKICAgICAgICAgSW50UmVjdCB0cmFuc2Zvcm1lZENs aXAgPSBjbGlwOwogICAgICAgICB0cmFuc2Zvcm1lZENsaXAubW92ZShzY3JvbGxDb3JuZXJBbmRS ZXNpemVyLmxvY2F0aW9uKCkpOwotICAgICAgICBtX293bmluZ0xheWVyLT5wYWludFNjcm9sbENv cm5lcigmY29udGV4dCwgMCwgMCwgdHJhbnNmb3JtZWRDbGlwKTsKKyAgICAgICAgbV9vd25pbmdM YXllci0+cGFpbnRTY3JvbGxDb3JuZXIoJmNvbnRleHQsIEludFBvaW50KCksIHRyYW5zZm9ybWVk Q2xpcCk7CiAgICAgICAgIG1fb3duaW5nTGF5ZXItPnBhaW50UmVzaXplcigmY29udGV4dCwgMCwg MCwgdHJhbnNmb3JtZWRDbGlwKTsKICAgICAgICAgY29udGV4dC5yZXN0b3JlKCk7CiAgICAgfQo=