61846 2011-06-01 01:41:52 -0700 [EFL] Add null checking condition to EditorClientEfl.cpp 2011-06-01 04:41:13 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim commit-queue eric kenneth lucas.de.marchi tkent tonikitoo oldest_to_newest 413227 0 gyuyoung.kim 2011-06-01 01:41:52 -0700 In EditorClientEfl::handleEditingKeyboardEvent(), it uses caretBrowsingEnabled() of settings(). However, it doesn't check if settings() is null. settgins() of frame can be null. Frame.h Settings* settings() const; // can be NULL 413230 1 95566 gyuyoung.kim 2011-06-01 01:44:55 -0700 Created attachment 95566 Patch 413234 2 95566 tkent 2011-06-01 01:52:41 -0700 Comment on attachment 95566 Patch ok 413293 3 95566 commit-queue 2011-06-01 04:41:08 -0700 Comment on attachment 95566 Patch Clearing flags on attachment: 95566 Committed r87794: <http://trac.webkit.org/changeset/87794> 413294 4 commit-queue 2011-06-01 04:41:13 -0700 All reviewed patches have been landed. Closing bug. 95566 2011-06-01 01:44:55 -0700 2011-06-01 04:41:07 -0700 Patch patch-nullcheck.patch text/plain 1285 gyuyoung.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBkYjFjYmI5Li40NWExYTQxIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMDEgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbRUZMXSBBZGQgbnVsbCBjaGVja2luZyBjb25kaXRpb24gdG8gRWRpdG9yQ2xpZW50RWZs LmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjE4 NDYKKworICAgICAgICBBZGQgbnVsbCBjaGVja2luZyBjb25kaXRpb24gZm9yIHVzaW5nIHNldHRp bmdzKCkgb2YgZnJhbWUuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRF ZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9yQ2xpZW50RWZsOjpoYW5kbGVFZGl0aW5n S2V5Ym9hcmRFdmVudCk6CisKIDIwMTEtMDUtMjggIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0 Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50RWZsLmNw cCBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEVmbC5jcHAK aW5kZXggNGYxMDVlYS4uOTI0NzJmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvV2Vi Q29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50RWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9X ZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRFZmwuY3BwCkBAIC0zNDIsNiArMzQyLDkgQEAgYm9v bCBFZGl0b3JDbGllbnRFZmw6OmhhbmRsZUVkaXRpbmdLZXlib2FyZEV2ZW50KEtleWJvYXJkRXZl bnQqIGV2ZW50KQogICAgIGlmICgha2V5RXZlbnQpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAor ICAgIGlmICghZnJhbWUtPnNldHRpbmdzKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAg IGJvb2wgY2FyZXRCcm93c2luZyA9IGZyYW1lLT5zZXR0aW5ncygpLT5jYXJldEJyb3dzaW5nRW5h YmxlZCgpOwogICAgIGlmIChjYXJldEJyb3dzaW5nKSB7CiAgICAgICAgIHN3aXRjaCAoa2V5RXZl bnQtPndpbmRvd3NWaXJ0dWFsS2V5Q29kZSgpKSB7Cg==